Re: Next steps

2018-06-24 Thread Ricardo Wurmus


Hi Sahithi,

I checked out the “wip-sahithi” branch and ran this command in a
terminal (urxvt):

./pre-inst-env guix build --check --no-grafts hello

I do see colours for phase start and end notices, so the code is fine.

What terminal are you using?  Did this not work for you before?  What
has changed since?

--
Ricardo




Re: Next steps

2018-06-24 Thread Sahithi Yarlagadda
Hi


On Monday 25 June 2018 01:52 AM, Ricardo Wurmus wrote:
> Hi Sahithi,
>
> I checked out the “wip-sahithi” branch and ran this command in a
> terminal (urxvt):
>
> ./pre-inst-env guix build --check --no-grafts hello
>
> I do see colours for phase start and end notices, so the code is fine.
It worked for me now, when i tested it by checking out to wip-sahithi
branch.
> What terminal are you using?  Did this not work for you before?  What
> has changed since?
Gnome terminal
It worked for me earlier as well, i tested the code by building the
hello package before sending the patch.

Unsure why it dint work, i did couple of changes and reverted back
thought. Seems i missed something out.
>
> --
> Ricardo
>
>

-- 
Regards
Sahithi




Re: Next steps

2018-06-24 Thread Sahithi Yarlagadda
Hi all,

The following are the changes that I made earlier and changes worked
fine...

This patch is pushed to my branch wip-sahithi

But when I try executing it now I don't find its results not even
soft-port is getting called...

May I know the reason behind this


---
Thanks!!
Sahithi

From 99526f5624633e5fdc72fe8fb280b1279bea0636 Mon Sep 17 00:00:00 2001
From: Sahithi Yarlagadda 
Date: Sat, 16 Jun 2018 13:21:42 +0530
Subject: [PATCH] guix: Add coloring soft port.

* guix/ui.scm (handle-string): New procedures.
(colorful-build-output-port): New variable.

guix: Added colorful-build-output-port to build.scm instead of default
---
 guix/scripts/build.scm |  4 +---
 guix/ui.scm| 49 -
 2 files changed, 49 insertions(+), 4 deletions(-)

diff --git a/guix/scripts/build.scm b/guix/scripts/build.scm
index 4dd4fbccd..81ad255d8 100644
--- a/guix/scripts/build.scm
+++ b/guix/scripts/build.scm
@@ -733,9 +733,7 @@ needed."
 ;; Set the build options before we do anything else.
 (set-build-options-from-command-line store opts)
 
-(parameterize ((current-build-output-port (if quiet?
-  (%make-void-port "w")
-  (current-error-port
+ (parameterize ((current-build-output-port  colorful-build-output-port))
   (let* ((mode  (assoc-ref opts 'build-mode))
  (drv   (options->derivations store opts))
  (urls  (map (cut string-append <> "/log")
diff --git a/guix/ui.scm b/guix/ui.scm
index 80f1a4d77..88e5fa6b7 100644
--- a/guix/ui.scm
+++ b/guix/ui.scm
@@ -109,7 +109,7 @@
 warning
 info
 guix-main
-colorize-string))
+colorful-build-output-port))
 
 ;;; Commentary:
 ;;;
@@ -1631,4 +1631,51 @@ be reset such that subsequent output will not have any colors in effect."
str
(color 'RESET)))
 
+(define (handle-string str)
+ "Accepts input string(str) as argument and checks whether it matches with one 
+of the regular expressions specified. Upon matching, each substring is colorized 
+with corresponding colors and the modified colored string is returned. If the 
+input string fails match with the following conditionals it returns back the 
+unmodified input string."
+(let ((message  (or (and=> (string-match "^(starting phase)(.*)" str)
+   (lambda (m)
+ (string-append
+   (colorize-string (match:substring m 1) 'BLUE)
+   (colorize-string (match:substring m 2) 'GREEN
+
+   (and=> (string-match "^(phase)(.*)(succeeded after)(.*)(seconds)" str)
+  (lambda (m)
+(string-append
+  (colorize-string (match:substring m 1) 'BLUE)
+  (colorize-string (match:substring m 2) 'GREEN)
+  (colorize-string (match:substring m 3) 'BLUE)
+  (colorize-string (match:substring m 4) 'GREEN)
+  (colorize-string (match:substring m 5) 'BLUE
+
+   (and=> (string-match "^(phase)(.*)(failed after)(.*)(seconds)" str)
+  (lambda (m)
+(string-append
+  (colorize-string (match:substring m 1) 'RED)
+  (colorize-string (match:substring m 2) 'GREEN)
+  (colorize-string (match:substring m 3) 'RED)
+  (colorize-string (match:substring m 4) 'GREEN)
+  (colorize-string (match:substring m 5) 'RED
+
+ ;; Didn’t match with any expression, returns back unmodified string.
+   str)))
+(display message (current-error-port
+
+(define colorful-build-output-port
+  (make-soft-port
+   (vector
+ ;; procedure accepting one character for output
+(lambda (c) (write c (current-error-port)))
+ ;; procedure accepting a string for handle-string procedure
+handle-string
+(lambda () (force-output (current-error-port)))
+(const #t)
+(lambda () (display "@" (current-error-port
+   "rw"))
+
+
 ;;; ui.scm ends here
-- 
2.11.0



Re: MTP & Guix

2018-06-24 Thread Marius Bakke
Ricardo Wurmus  writes:

> Ricardo Wurmus  writes:
>
>> Pierre Neidhardt  writes:
>>
>>> Both Gentoo and Guix packages are outdated.
>>> 1.37 is out.
>>> GVFS has switched to Meson in the mean time.
>>> Arch is a little bit more up to date:
>>>
>>> https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/gvfs
>>>
>>> I guess the above definition could help.
>>> Anyone giving the update a shot?
>>
>> I’m already working on the upgrades to all of GNOME, including the gvfs
>> upgrade to 1.36.2.
>
> This happens on the “core-updates” branch.

Could you create a 'gnome-updates' branch for this?  That makes it
easier to track the changes, and allows for building it without
rebuilding the entire world.

We might want to merge it to core-updates rather than build it on its
own regardless, but at least we have the option.  What do you think?


signature.asc
Description: PGP signature


Re: MTP & Guix

2018-06-24 Thread Ricardo Wurmus


Pierre Neidhardt  writes:

> Both Gentoo and Guix packages are outdated.
> 1.37 is out.
> GVFS has switched to Meson in the mean time.
> Arch is a little bit more up to date:
>
> https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/gvfs
>
> I guess the above definition could help.
> Anyone giving the update a shot?

I’m already working on the upgrades to all of GNOME, including the gvfs
upgrade to 1.36.2.

-- 
Ricardo




Re: MTP & Guix

2018-06-24 Thread Ricardo Wurmus


Ricardo Wurmus  writes:

> Pierre Neidhardt  writes:
>
>> Both Gentoo and Guix packages are outdated.
>> 1.37 is out.
>> GVFS has switched to Meson in the mean time.
>> Arch is a little bit more up to date:
>>
>> https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/gvfs
>>
>> I guess the above definition could help.
>> Anyone giving the update a shot?
>
> I’m already working on the upgrades to all of GNOME, including the gvfs
> upgrade to 1.36.2.

This happens on the “core-updates” branch.

-- 
Ricardo