[hibernate-dev] Failing Analysis

[Alvaro Pedraza]

Hi, I'm wondering if there is something wrong with LGTM Java analysis, because 
it has failed in my 2 open PR’s.
https://github.com/hibernate/hibernate-orm/pull/2357 

https://github.com/hibernate/hibernate-orm/pull/2433 

Seeing the log in the first I got the message:
[2018-07-15 15:50:19] [autobuild] [2018-07-15 15:50:19] [ERROR] Parsing error 
in file 
/opt/src/hibernate-core/src/test/java/org/hibernate/test/mappingexception/InvalidMapping.hbm.xml
It seems to be a file to test mapping, so I assume there is something wrong 
with the analysis configuration as this file should not be analyzed at all, am 
I right?
Besides, my changes don’t affect that code.
Thanks in advance for your answers.

Best regards: Alvaro E. Pedraza
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] Failing test for issue HHH-12688

[Alvaro Pedraza]

I ran it again and seems to be failing consistently. This is the info I can get:

Stacktrace:
java.lang.AssertionError: expected:<1> but was:<0>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:631)
at 
org.hibernate.test.annotations.uniqueconstraint.UniqueConstraintBatchingTest.testBatching(UniqueConstraintBatchingTest.java:91)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at 
org.hibernate.testing.junit4.ExtendedFrameworkMethod.invokeExplosively(ExtendedFrameworkMethod.java:45)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
at 
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
at 
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.lang.Thread.run(Thread.java:745)

Std Output:
11:04:52,916  INFO Version:46 - HHH000412: Hibernate Core {[WORKING]}
11:04:52,968  INFO Environment:198 - HHH000205: Loaded properties from resource 
hibernate.properties: {hibernate.connection.driver_class=org.h2.Driver, 
javax.persistence.validation.mode=NONE, hibernate.service.allow_crawling=false, 
hibernate.max_fetch_depth=5, hibernate.dialect=org.hibernate.dialect.H2Dialect, 
hibernate.format_sql=true, 
hibernate.cache.region.factory_class=org.hibernate.testing.cache.CachingRegionFactory,
 hibernate.hql.bulk_id_strategy.global_temporary.drop_tables=true, 
hibernate.connection.username=sa, hibernate.cache.region_prefix=hibernate.test, 
hibernate.connection.url=jdbc:h2:mem:db1;DB_CLOSE_DELAY=-1;LOCK_TIMEOUT=1, 
hibernate.bytecode.use_reflection_optimizer=false, hibernate.show_sql=false, 
hibernate.connection.password=, hibernate.session.events.log=true, 
hibernate.connection.pool_size=5}
11:04:53,543  INFO Dialect:157 - HHH000400: Using dialect: 
org.hibernate.dialect.H2Dialect
11:04:56,792  INFO CustomRunner:116 - BeforeClass: 
org.hibernate.test.annotations.uniqueconstraint.UniqueConstraintBatchingTest
11:04:56,794  INFO Dialect:157 - HHH000400: Using dialect: 
org.hibernate.dialect.H2Dialect
11:04:56,899  INFO CustomRunner:123 - Test: testBatching
11:04:57,277  INFO LogHelper:31 - HHH000204: Processing PersistenceUnitInfo [
name: UniqueConstraintBatchingTest
...]
11:05:00,085  WARN CachingRegionFactory:48 - 
org.hibernate.testing.cache.CachingRegionFactory should be only used for 
testing.
11:05:00,085 DEBUG RegionFactoryInitiator:49 - Cache region factory : 
org.hibernate.testing.cache.CachingRegionFactory
11:05:00,260  INFO Version:49 - HCANN01: Hibernate Commons Annotations 
{5.0.4.Final}
11:05:01,801  WARN pooling:73 - HHH10001002: Using Hibernate built-in 
connection pool (not for production use!)
11:05:02,541  INFO pooling:129 - HHH10001005: using driver [org.h2.Driver] at 
URL [jdbc:h2:mem:db1;DB_CLOSE_DELAY=-1;LOCK_TIMEOUT=1]
11:05:02,542  INFO pooling:138 - HHH10001001: Connection properties: {user=sa, 
password=}
11:05:02,542  INFO pooling:143 - HHH10001003: Autocommit mode: false
11:05:02,566  INFO DriverManagerConnectionProviderImpl:281 - HHH000115: 
Hibernate connection pool size: 5 (min=1)
11:05:03,436  INFO Dialect:157 - HHH000400: Using dialect: 
org.hibernate.dialect.H2Dialect
11:05:08,568  INFO beans:73 - HHH10005002: No explicit CDI BeanManager 
reference was passed to Hibernate, but CDI is available on the Hibernate 
ClassLoader.
11:05:12,424 DEBUG SQL:94 - 

drop table House if exists
11:05:12,457  INFO access:47 - HHH10001501: Connection obtained from 
JdbcConnectionAccess 
[org.hibernate.engine.jdbc.env.internal.JdbcEnvironmentInitiator$ConnectionProviderJdbcConnectionAccess@33284695]
 for (non-JTA) DDL execution was not in auto-commit mode; the Connection 'local 
transaction' will be committed and the Connection will be set into auto-commit 
mode.
11:05:12,458 DEBUG SQL:94 - 

drop table Room if exists
11:05:12,475 DEBUG 

[hibernate-dev] NoORM IRC meeting minutes

[Guillaume Smet]

Hi!

Here are the minutes of our NoORM IRC meeting:

15:26 < jbott> Meeting ended Tue Jul 17 13:26:02 2018 UTC.  Information
about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
15:26 < jbott> Minutes:
http://transcripts.jboss.org/meeting/irc.freenode.org/hibernate-dev/2018/hibernate-dev.2018-07-17-13.01.html
15:26 < jbott> Minutes (text):
http://transcripts.jboss.org/meeting/irc.freenode.org/hibernate-dev/2018/hibernate-dev.2018-07-17-13.01.txt
15:26 < jbott> Log:
http://transcripts.jboss.org/meeting/irc.freenode.org/hibernate-dev/2018/hibernate-dev.2018-07-17-13.01.log.html

-- 
Guillaume
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] HHH-3138 - make constructor of DynamicMapEntityTuplizer public

[Steve Ebersole]

Sorry for the late reply.  As Sanne indicated, we are all very busy with
our own work.  Reaching out here and "championing" a particular issue that
you are interested in working on is a great way to make sure it is not
missed.

Anyway, I replied on the Jira.

On Tue, Jul 17, 2018 at 8:11 AM Sanne Grinovero  wrote:

> Hi Alvaro,
>
> welcome :-)
>
> The ticket descriptions can be debated; we can all be wrong, or you
> might have a better idea.
>
> Regarding feedback times: I'm sorry we're a bit slow. There are many
> things which are urgent - or we're more interested in - and since it's
> summer so many are on holidays. It might take a week - this was a bit
> too long so you did well to raise the mail here.
>
> Feel free to join the chat on IRC or HipChat? See the "contribute"
> section on [1] for links and instructions.
>
> In the specific example of HHH-3138, I guess people didn't comment as
> there is no clear problem to be solved. It might help to explain why
> you want to subclass a DynamicMapEntityTuplizer - but I'm just
> guessing as I'm not familiar with that area of the code so I hope you
> get the attention of someone more familiar with that code.
>
> Thanks,
> Sanne
>
> 1 - http://hibernate.org/community/
> On Tue, 17 Jul 2018 at 01:42, Alvaro Pedraza 
> wrote:
> >
> > Hi, I asigned myself this ticket and left a comment but unfortunately no
> feedback yet.
> > https://hibernate.atlassian.net/browse/HHH-3138
> > This leads me to 2 questions:
> > The first is the very same in the comment, which is if subclassing in
> DynamicMapEntityTuplizer is desirable? Please refer to the ticket for
> discussion
> > The second is about what can I assume as a contributor. I mean, Is
> always the ticket a holy word (i.e. what the ticket says, should be done)
> or it is always debatable? I understand that I’m taking low priority
> tickets (because I’m almost a newbie contributor and I don’t feel like
> taking some more important ones) but how long should I wait to get some
> feedback in the comments?
> > Thanks in advance for your answers.
> >
> > Best regards: Alvaro Pedraza
> > ___
> > hibernate-dev mailing list
> > hibernate-dev@lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/hibernate-dev
>
> ___
> hibernate-dev mailing list
> hibernate-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] HHH-3138 - make constructor of DynamicMapEntityTuplizer public

[Sanne Grinovero]

On Tue, 17 Jul 2018 at 13:45, Guillaume Smet  wrote:
>
> Hi,
>
> On Tue, Jul 17, 2018 at 11:33 AM Sanne Grinovero  wrote:
>>
>> In the specific example of HHH-3138, I guess people didn't comment as
>> there is no clear problem to be solved. It might help to explain why
>> you want to subclass a DynamicMapEntityTuplizer - but I'm just
>> guessing as I'm not familiar with that area of the code so I hope you
>> get the attention of someone more familiar with that code
>
>
> What I can suppose is that the OP customized the tuplizer with @Tuplizer and 
> would have liked to use DynamicMapEntityTuplizer as a base for his custom one.

My point was that people who can better explain what and why they need
changes are more likely to get a quick answer.

>
> We can ask in the issue but it's a very old one so I'm not sure we'll get an 
> answer.
>
> --
> Guillaume
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] HHH-3138 - make constructor of DynamicMapEntityTuplizer public

[Guillaume Smet]

Hi,

On Tue, Jul 17, 2018 at 11:33 AM Sanne Grinovero 
wrote:

> In the specific example of HHH-3138, I guess people didn't comment as
> there is no clear problem to be solved. It might help to explain why
> you want to subclass a DynamicMapEntityTuplizer - but I'm just
> guessing as I'm not familiar with that area of the code so I hope you
> get the attention of someone more familiar with that code


What I can suppose is that the OP customized the tuplizer with @Tuplizer
and would have liked to use DynamicMapEntityTuplizer as a base for his
custom one.

We can ask in the issue but it's a very old one so I'm not sure we'll get
an answer.

-- 
Guillaume
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev

[hibernate-dev] JDK 11 Early Access build 22 & JDK 12 Early Access b02 are available.

[Rory O'Donnell]

Hi Sanne,

*JDK 11 is in Rampdown Phase one*

  * *The overall feature set is frozen. No further JEPs will be targeted
to this release.*
  * *Rampdown Phase two is scheduled to start * *26th of July*


**JDK 11 EA build 22 , *under both the GPL and Oracle EA licenses, 
is now available at **http://jdk.java.net/11**. ***

  * Schedule, status & features
  o http://openjdk.java.net/projects/jdk/11/
  * Release Notes:
  o http://jdk.java.net/11/release-notes

*FOSS fixes in recent builds.*

  * JBoss Netty (b17) - JDK-8203937 (b17)
  * JUnit5 & other Foss Projects (b22)  -JDK-8206355

**Notable changes in JDK 11 EA *build 22*

  * New Collection.toArray(IntFunction) Default Method (JDK-8060192
)
  * Make some system properties effectively readonly (JDK-8066709
)
  * Obsolete Support for Commercial Features (JDK-8202331
)
  * JFR start failure after AppCDS archive created with JFR
StartFlightRecording (JDK-8203664
)
  * Change to policy for the default set of modules resolved when
compiling or running code on the class path (JDK-8197532
)

*JDK 12 Early Access  Build 02 is available at **http://jdk.java.net/12/*

  * OpenJDK builds
  o These early-access, open-source builds are provided under the
GNU General Public License, version 2, with the Classpath
Exception .
  * Changes in this build are listed here



*The Quality Report for July 2018 is published **here 
*

  * With the new six months release , we now publish the Quality report
every three months.
  * Thanks to all the FOSS Projects for logging bugs against the JDK 11
EA Builds!


Rgds,Rory

[1] http://openjdk.java.net/projects/jdk/11/

___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] HHH-3138 - make constructor of DynamicMapEntityTuplizer public

[Sanne Grinovero]

Hi Alvaro,

welcome :-)

The ticket descriptions can be debated; we can all be wrong, or you
might have a better idea.

Regarding feedback times: I'm sorry we're a bit slow. There are many
things which are urgent - or we're more interested in - and since it's
summer so many are on holidays. It might take a week - this was a bit
too long so you did well to raise the mail here.

Feel free to join the chat on IRC or HipChat? See the "contribute"
section on [1] for links and instructions.

In the specific example of HHH-3138, I guess people didn't comment as
there is no clear problem to be solved. It might help to explain why
you want to subclass a DynamicMapEntityTuplizer - but I'm just
guessing as I'm not familiar with that area of the code so I hope you
get the attention of someone more familiar with that code.

Thanks,
Sanne

1 - http://hibernate.org/community/
On Tue, 17 Jul 2018 at 01:42, Alvaro Pedraza  wrote:
>
> Hi, I asigned myself this ticket and left a comment but unfortunately no 
> feedback yet.
> https://hibernate.atlassian.net/browse/HHH-3138
> This leads me to 2 questions:
> The first is the very same in the comment, which is if subclassing in 
> DynamicMapEntityTuplizer is desirable? Please refer to the ticket for 
> discussion
> The second is about what can I assume as a contributor. I mean, Is always the 
> ticket a holy word (i.e. what the ticket says, should be done) or it is 
> always debatable? I understand that I’m taking low priority tickets (because 
> I’m almost a newbie contributor and I don’t feel like taking some more 
> important ones) but how long should I wait to get some feedback in the 
> comments?
> Thanks in advance for your answers.
>
> Best regards: Alvaro Pedraza
> ___
> hibernate-dev mailing list
> hibernate-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev

___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev

Re: [hibernate-dev] Failing test for issue HHH-12688

[Guillaume Smet]

Does it fail every time you run the build or is it a transient failure?

If it's consistent, please check the result of the test (the Gradle log
points you to a HTML file containing all the info) and paste the full error
message and stracktrace here.

Information about your environment might also be useful: OS, JDK version...

Thanks!

On Tue, Jul 17, 2018 at 6:04 AM Alvaro Pedraza 
wrote:

> Hi, working in something else I ran ./gradlew tests and exited with one
> failing test at
> org.hibernate.test.annotations.uniqueconstraint.UniqueConstraintBatchingTest
> I’ve been seeing https://hibernate.atlassian.net/browse/HHH-12688 <
> https://hibernate.atlassian.net/browse/HHH-12688> and it’s been closed
> and pushed, but the test is failing for me and just wanted to raise a flag
> just in case.
> Hope this helps.
>
> Best regards: Alvaro E. Pedraza
> ___
> hibernate-dev mailing list
> hibernate-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev