Re: [hibernate-dev] Any external uses for ORM's StatisticsImpl ?
Cool, thanks! I think we're good now, we'll just go with it. Worst case it's easy to revert. On Wed, 7 Aug 2019 at 14:44, Scott Marlow wrote: > > Hi Sanne, > > WildFly doesn't reference StatisticsImpl, WildFly does use Statistics. > > Scott ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Any external uses for ORM's StatisticsImpl ?
Hi Sanne, WildFly doesn't reference StatisticsImpl, WildFly does use Statistics. Scott ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Any external uses for ORM's StatisticsImpl ?
Thanks! done :) On Wed, 7 Aug 2019 at 13:39, Steve Ebersole wrote: > > I do not remember the history for it. > > +1 for removing that no-arg form. > > On Wed, Aug 7, 2019 at 4:08 AM Sanne Grinovero wrote: >> >> Hi all, >> >> while working on HHH-13527 I noticed that there's quite some >> complexity in StatisticsImpl to deal with the fact that the final >> field `sessionFactory` could be null in some cases. >> >> This field can only be null if its public no-argument constructor is >> invoked, yet there is no code in whole of ORM invoking this. >> >> I'm therefore tempted to remove this constructor and cleanup all those >> checks for null; anybody knows why that constructor was explicitly >> marked to stay with @SuppressWarnings({ "UnusedDeclaration" }) ? >> - >> https://github.com/hibernate/hibernate-orm/blob/a26b971d434453be482e7675fc8e9884c8f791e0/hibernate-core/src/main/java/org/hibernate/stat/internal/StatisticsImpl.java#L108-L111 >> >> Suggesting this change for 5.4 (and beyond) only. >> >> Thanks, >> Sanne >> ___ >> hibernate-dev mailing list >> hibernate-dev@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Any external uses for ORM's StatisticsImpl ?
I do not remember the history for it. +1 for removing that no-arg form. On Wed, Aug 7, 2019 at 4:08 AM Sanne Grinovero wrote: > Hi all, > > while working on HHH-13527 I noticed that there's quite some > complexity in StatisticsImpl to deal with the fact that the final > field `sessionFactory` could be null in some cases. > > This field can only be null if its public no-argument constructor is > invoked, yet there is no code in whole of ORM invoking this. > > I'm therefore tempted to remove this constructor and cleanup all those > checks for null; anybody knows why that constructor was explicitly > marked to stay with @SuppressWarnings({ "UnusedDeclaration" }) ? > - > https://github.com/hibernate/hibernate-orm/blob/a26b971d434453be482e7675fc8e9884c8f791e0/hibernate-core/src/main/java/org/hibernate/stat/internal/StatisticsImpl.java#L108-L111 > > Suggesting this change for 5.4 (and beyond) only. > > Thanks, > Sanne > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Any external uses for ORM's StatisticsImpl ?
Thanks, I applied the cleanup. If it was a mistake, I guess I'll hear about it :) On Wed, 7 Aug 2019 at 12:50, Yoann Rodiere wrote: > > Hi, > > I had a quick look at Hibernate Search's source code, and couldn't find any > use of this class. > So +1 for me. > > > Yoann Rodière > Hibernate NoORM Team > yo...@hibernate.org > > > On Wed, 7 Aug 2019 at 11:08, Sanne Grinovero wrote: >> >> Hi all, >> >> while working on HHH-13527 I noticed that there's quite some >> complexity in StatisticsImpl to deal with the fact that the final >> field `sessionFactory` could be null in some cases. >> >> This field can only be null if its public no-argument constructor is >> invoked, yet there is no code in whole of ORM invoking this. >> >> I'm therefore tempted to remove this constructor and cleanup all those >> checks for null; anybody knows why that constructor was explicitly >> marked to stay with @SuppressWarnings({ "UnusedDeclaration" }) ? >> - >> https://github.com/hibernate/hibernate-orm/blob/a26b971d434453be482e7675fc8e9884c8f791e0/hibernate-core/src/main/java/org/hibernate/stat/internal/StatisticsImpl.java#L108-L111 >> >> Suggesting this change for 5.4 (and beyond) only. >> >> Thanks, >> Sanne >> ___ >> hibernate-dev mailing list >> hibernate-dev@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Any external uses for ORM's StatisticsImpl ?
Hi, I had a quick look at Hibernate Search's source code, and couldn't find any use of this class. So +1 for me. Yoann Rodière Hibernate NoORM Team yo...@hibernate.org On Wed, 7 Aug 2019 at 11:08, Sanne Grinovero wrote: > Hi all, > > while working on HHH-13527 I noticed that there's quite some > complexity in StatisticsImpl to deal with the fact that the final > field `sessionFactory` could be null in some cases. > > This field can only be null if its public no-argument constructor is > invoked, yet there is no code in whole of ORM invoking this. > > I'm therefore tempted to remove this constructor and cleanup all those > checks for null; anybody knows why that constructor was explicitly > marked to stay with @SuppressWarnings({ "UnusedDeclaration" }) ? > - > https://github.com/hibernate/hibernate-orm/blob/a26b971d434453be482e7675fc8e9884c8f791e0/hibernate-core/src/main/java/org/hibernate/stat/internal/StatisticsImpl.java#L108-L111 > > Suggesting this change for 5.4 (and beyond) only. > > Thanks, > Sanne > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev