Re: [hibernate-dev] Boolean with null values and SAP SQL Anywhere
+1 to fix + note in the migration guide. On Fri, Nov 2, 2018 at 8:29 AM Guillaume Smet wrote: > Yeah, personally, I think it's a bug, e.g. this type shouldn't have been > used in the first place. > > But as it works when not storing nulls in the column, YMMV depending if you > use null or not. > > My vote goes to fix + note in the migration guide. > > Gail, what's your take on this one? > > Thanks! > > > On Fri, Nov 2, 2018 at 4:14 PM Steve Ebersole wrote: > > > In the general sense, it ultimately comes down to how one views the > > situation. Is it a bug? Then I think it is reasonable to just change it > > and mention it in the migration guide. If it is an enhancement, then I > > think a setting makes sense to control this. > > > > Honestly though, not sure this has a big compatibility impact. > > > > On Fri, Nov 2, 2018 at 10:00 AM Guillaume Smet > > > wrote: > > > >> Hi, > >> > >> Quite some time ago, someone opened > >> https://hibernate.atlassian.net/browse/HHH-12850 stating that null > values > >> were not supported for Booleans with SAP SQL Anywhere. > >> > >> This is due to the fact that null values are not supported for bits and > we > >> should use a tinyint. Interestingly enough, it was fixed for Sybase > here: > >> https://hibernate.atlassian.net/browse/HHH-5413 . > >> > >> Changing this will probably lead to compatibility issues but I think a > >> note > >> in the migration guide requiring a migration from bit to tinyint would > be > >> sufficient and 5.4.0 would be a good opportunity to do it. > >> > >> Thoughts? > >> > >> -- > >> Guillaume > >> ___ > >> hibernate-dev mailing list > >> hibernate-dev@lists.jboss.org > >> https://lists.jboss.org/mailman/listinfo/hibernate-dev > >> > > > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Boolean with null values and SAP SQL Anywhere
Yeah, personally, I think it's a bug, e.g. this type shouldn't have been used in the first place. But as it works when not storing nulls in the column, YMMV depending if you use null or not. My vote goes to fix + note in the migration guide. Gail, what's your take on this one? Thanks! On Fri, Nov 2, 2018 at 4:14 PM Steve Ebersole wrote: > In the general sense, it ultimately comes down to how one views the > situation. Is it a bug? Then I think it is reasonable to just change it > and mention it in the migration guide. If it is an enhancement, then I > think a setting makes sense to control this. > > Honestly though, not sure this has a big compatibility impact. > > On Fri, Nov 2, 2018 at 10:00 AM Guillaume Smet > wrote: > >> Hi, >> >> Quite some time ago, someone opened >> https://hibernate.atlassian.net/browse/HHH-12850 stating that null values >> were not supported for Booleans with SAP SQL Anywhere. >> >> This is due to the fact that null values are not supported for bits and we >> should use a tinyint. Interestingly enough, it was fixed for Sybase here: >> https://hibernate.atlassian.net/browse/HHH-5413 . >> >> Changing this will probably lead to compatibility issues but I think a >> note >> in the migration guide requiring a migration from bit to tinyint would be >> sufficient and 5.4.0 would be a good opportunity to do it. >> >> Thoughts? >> >> -- >> Guillaume >> ___ >> hibernate-dev mailing list >> hibernate-dev@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev >> > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Boolean with null values and SAP SQL Anywhere
In the general sense, it ultimately comes down to how one views the situation. Is it a bug? Then I think it is reasonable to just change it and mention it in the migration guide. If it is an enhancement, then I think a setting makes sense to control this. Honestly though, not sure this has a big compatibility impact. On Fri, Nov 2, 2018 at 10:00 AM Guillaume Smet wrote: > Hi, > > Quite some time ago, someone opened > https://hibernate.atlassian.net/browse/HHH-12850 stating that null values > were not supported for Booleans with SAP SQL Anywhere. > > This is due to the fact that null values are not supported for bits and we > should use a tinyint. Interestingly enough, it was fixed for Sybase here: > https://hibernate.atlassian.net/browse/HHH-5413 . > > Changing this will probably lead to compatibility issues but I think a note > in the migration guide requiring a migration from bit to tinyint would be > sufficient and 5.4.0 would be a good opportunity to do it. > > Thoughts? > > -- > Guillaume > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
[hibernate-dev] Boolean with null values and SAP SQL Anywhere
Hi, Quite some time ago, someone opened https://hibernate.atlassian.net/browse/HHH-12850 stating that null values were not supported for Booleans with SAP SQL Anywhere. This is due to the fact that null values are not supported for bits and we should use a tinyint. Interestingly enough, it was fixed for Sybase here: https://hibernate.atlassian.net/browse/HHH-5413 . Changing this will probably lead to compatibility issues but I think a note in the migration guide requiring a migration from bit to tinyint would be sufficient and 5.4.0 would be a good opportunity to do it. Thoughts? -- Guillaume ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
