Re: [hibernate-dev] Property#isLazy

2019-09-03 Thread Steve Ebersole
Do you have an example where this is actually a problem?

On Mon, Sep 2, 2019 at 8:01 PM Gail Badner  wrote:

> HHH-11147 changed Property#isLazy as shown in [1].
>
> The part that concerns me is:
>
> + // For a many-to-one, this is always false.  Whether the
> + // association is EAGER, PROXY or NO-PROXY we want the fk
> + // selected
> + return false;
>
> I don't think this is correct when enhancement-as-proxy is disabled.
>
> Join#isLazy relies on Property#isLazy for the properties included in the
> Join.
>
> If Join#isLazy is returning the wrong value,
> then SingleTableEntityPersister#isSubclassTableLazy
> and JoinedSubclassEntityPersister#isSubclassTableLazy will return the wrong
> value.
>
> Steve, WDYT?
>
> Thanks,
> Gail
>
> [1]
> https://github.com/hibernate/hibernate-orm/commit/cc01f2561dbca95bd58048f85e283ba1719ee588#diff-f564326e8dae92695cdffe6509fb8f0b
>
>
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev


[hibernate-dev] Property#isLazy

2019-09-02 Thread Gail Badner
HHH-11147 changed Property#isLazy as shown in [1].

The part that concerns me is:

+ // For a many-to-one, this is always false.  Whether the
+ // association is EAGER, PROXY or NO-PROXY we want the fk
+ // selected
+ return false;

I don't think this is correct when enhancement-as-proxy is disabled.

Join#isLazy relies on Property#isLazy for the properties included in the
Join.

If Join#isLazy is returning the wrong value,
then SingleTableEntityPersister#isSubclassTableLazy
and JoinedSubclassEntityPersister#isSubclassTableLazy will return the wrong
value.

Steve, WDYT?

Thanks,
Gail

[1]
https://github.com/hibernate/hibernate-orm/commit/cc01f2561dbca95bd58048f85e283ba1719ee588#diff-f564326e8dae92695cdffe6509fb8f0b
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev