[Hugin-bug-hunters] [Bug 2053287] Re: sometimes there are black patches/corners in blended images
@Bruno Since last autumn (~September) main line vigra should support c++17, but any distribution release is of course likely to not have included that yet. But I guess it will fix itself in Fedora some time. (wrt msvc, I was referring to what Thomas wrote.) -- You received this bug notification because you are a member of Hugin Bug Hunters, which is subscribed to Enblend. https://bugs.launchpad.net/bugs/2053287 Title: sometimes there are black patches/corners in blended images Status in Enblend: Fix Committed Bug description: As has been known for a long time, enblend sometimes produces black patches in the corners of subimages. As we have discussed by email, I'd like to suggest a patch for that: -- patch1 contains the pyramid type to make the following simpler -- patch2 contains the actual change where the mask is corrected using both alpha layers prior to the actual blending step -- patch3 are two small functional changes that are unrelated to the main issue -- patch4 are modernisation and style improvements, that I just had to do while working on the code. If you think some of them don't add enough (or any) value, feel free to drop some. cheers, lukas wirz To manage notifications about this bug go to: https://bugs.launchpad.net/enblend/+bug/2053287/+subscriptions ___ Mailing list: https://launchpad.net/~hugin-bug-hunters Post to : hugin-bug-hunters@lists.launchpad.net Unsubscribe : https://launchpad.net/~hugin-bug-hunters More help : https://help.launchpad.net/ListHelp
[Hugin-bug-hunters] [Bug 2053287] Re: sometimes there are black patches/corners in blended images
I'm not using msvc. This error is with fedora, but it looks like vigra in Ubuntu has already been patched to support c++17. The fedora vigra maintainer needs to copy some Ubuntu patches. -- You received this bug notification because you are a member of Hugin Bug Hunters, which is subscribed to Enblend. https://bugs.launchpad.net/bugs/2053287 Title: sometimes there are black patches/corners in blended images Status in Enblend: Fix Committed Bug description: As has been known for a long time, enblend sometimes produces black patches in the corners of subimages. As we have discussed by email, I'd like to suggest a patch for that: -- patch1 contains the pyramid type to make the following simpler -- patch2 contains the actual change where the mask is corrected using both alpha layers prior to the actual blending step -- patch3 are two small functional changes that are unrelated to the main issue -- patch4 are modernisation and style improvements, that I just had to do while working on the code. If you think some of them don't add enough (or any) value, feel free to drop some. cheers, lukas wirz To manage notifications about this bug go to: https://bugs.launchpad.net/enblend/+bug/2053287/+subscriptions ___ Mailing list: https://launchpad.net/~hugin-bug-hunters Post to : hugin-bug-hunters@lists.launchpad.net Unsubscribe : https://launchpad.net/~hugin-bug-hunters More help : https://help.launchpad.net/ListHelp
[Hugin-bug-hunters] [Bug 2053287] Re: sometimes there are black patches/corners in blended images
Thank you for merging and testing! The part that you omitted wasn't very important, but I am surprised that it causes issues with msvc (I had not tested that). I am not surprised, but slightly relieved that not only my but also your test cases pass! -- You received this bug notification because you are a member of Hugin Bug Hunters, which is subscribed to Enblend. https://bugs.launchpad.net/bugs/2053287 Title: sometimes there are black patches/corners in blended images Status in Enblend: Fix Committed Bug description: As has been known for a long time, enblend sometimes produces black patches in the corners of subimages. As we have discussed by email, I'd like to suggest a patch for that: -- patch1 contains the pyramid type to make the following simpler -- patch2 contains the actual change where the mask is corrected using both alpha layers prior to the actual blending step -- patch3 are two small functional changes that are unrelated to the main issue -- patch4 are modernisation and style improvements, that I just had to do while working on the code. If you think some of them don't add enough (or any) value, feel free to drop some. cheers, lukas wirz To manage notifications about this bug go to: https://bugs.launchpad.net/enblend/+bug/2053287/+subscriptions ___ Mailing list: https://launchpad.net/~hugin-bug-hunters Post to : hugin-bug-hunters@lists.launchpad.net Unsubscribe : https://launchpad.net/~hugin-bug-hunters More help : https://help.launchpad.net/ListHelp
[Hugin-bug-hunters] [Bug 2053287] Re: sometimes there are black patches/corners in blended images
Thanks for testing. I also closed the mentioned tickets. -- You received this bug notification because you are a member of Hugin Bug Hunters, which is subscribed to Enblend. https://bugs.launchpad.net/bugs/2053287 Title: sometimes there are black patches/corners in blended images Status in Enblend: Fix Committed Bug description: As has been known for a long time, enblend sometimes produces black patches in the corners of subimages. As we have discussed by email, I'd like to suggest a patch for that: -- patch1 contains the pyramid type to make the following simpler -- patch2 contains the actual change where the mask is corrected using both alpha layers prior to the actual blending step -- patch3 are two small functional changes that are unrelated to the main issue -- patch4 are modernisation and style improvements, that I just had to do while working on the code. If you think some of them don't add enough (or any) value, feel free to drop some. cheers, lukas wirz To manage notifications about this bug go to: https://bugs.launchpad.net/enblend/+bug/2053287/+subscriptions ___ Mailing list: https://launchpad.net/~hugin-bug-hunters Post to : hugin-bug-hunters@lists.launchpad.net Unsubscribe : https://launchpad.net/~hugin-bug-hunters More help : https://help.launchpad.net/ListHelp
[Hugin-bug-hunters] [Bug 2053287] Re: sometimes there are black patches/corners in blended images
It also passes the test case I uploaded here: https://bugs.launchpad.net/enblend/+bug/785803/comments/8 -- You received this bug notification because you are a member of Hugin Bug Hunters, which is subscribed to Enblend. https://bugs.launchpad.net/bugs/2053287 Title: sometimes there are black patches/corners in blended images Status in Enblend: Fix Committed Bug description: As has been known for a long time, enblend sometimes produces black patches in the corners of subimages. As we have discussed by email, I'd like to suggest a patch for that: -- patch1 contains the pyramid type to make the following simpler -- patch2 contains the actual change where the mask is corrected using both alpha layers prior to the actual blending step -- patch3 are two small functional changes that are unrelated to the main issue -- patch4 are modernisation and style improvements, that I just had to do while working on the code. If you think some of them don't add enough (or any) value, feel free to drop some. cheers, lukas wirz To manage notifications about this bug go to: https://bugs.launchpad.net/enblend/+bug/2053287/+subscriptions ___ Mailing list: https://launchpad.net/~hugin-bug-hunters Post to : hugin-bug-hunters@lists.launchpad.net Unsubscribe : https://launchpad.net/~hugin-bug-hunters More help : https://help.launchpad.net/ListHelp
[Hugin-bug-hunters] [Bug 2053287] Re: sometimes there are black patches/corners in blended images
Can confirm that the patched enblend passes all the tests that I uploaded here: https://bugs.launchpad.net/enblend/+bug/721136/comments/18 -- You received this bug notification because you are a member of Hugin Bug Hunters, which is subscribed to Enblend. https://bugs.launchpad.net/bugs/2053287 Title: sometimes there are black patches/corners in blended images Status in Enblend: Fix Committed Bug description: As has been known for a long time, enblend sometimes produces black patches in the corners of subimages. As we have discussed by email, I'd like to suggest a patch for that: -- patch1 contains the pyramid type to make the following simpler -- patch2 contains the actual change where the mask is corrected using both alpha layers prior to the actual blending step -- patch3 are two small functional changes that are unrelated to the main issue -- patch4 are modernisation and style improvements, that I just had to do while working on the code. If you think some of them don't add enough (or any) value, feel free to drop some. cheers, lukas wirz To manage notifications about this bug go to: https://bugs.launchpad.net/enblend/+bug/2053287/+subscriptions ___ Mailing list: https://launchpad.net/~hugin-bug-hunters Post to : hugin-bug-hunters@lists.launchpad.net Unsubscribe : https://launchpad.net/~hugin-bug-hunters More help : https://help.launchpad.net/ListHelp
[Hugin-bug-hunters] [Bug 2053287] Re: sometimes there are black patches/corners in blended images
Yes, I replaced the `throw(PreconditionViolation)` with `noexcept(false)` in both vigra locations and now enblend builds. I'm using enblend cmake, as the autoconf stuff needed bootstrapping and I couldn't remember how to do it. Haven't tested the bugfix yet, I seem to remember I created test cases with several examples that all failed at some time. -- You received this bug notification because you are a member of Hugin Bug Hunters, which is subscribed to Enblend. https://bugs.launchpad.net/bugs/2053287 Title: sometimes there are black patches/corners in blended images Status in Enblend: Fix Committed Bug description: As has been known for a long time, enblend sometimes produces black patches in the corners of subimages. As we have discussed by email, I'd like to suggest a patch for that: -- patch1 contains the pyramid type to make the following simpler -- patch2 contains the actual change where the mask is corrected using both alpha layers prior to the actual blending step -- patch3 are two small functional changes that are unrelated to the main issue -- patch4 are modernisation and style improvements, that I just had to do while working on the code. If you think some of them don't add enough (or any) value, feel free to drop some. cheers, lukas wirz To manage notifications about this bug go to: https://bugs.launchpad.net/enblend/+bug/2053287/+subscriptions ___ Mailing list: https://launchpad.net/~hugin-bug-hunters Post to : hugin-bug-hunters@lists.launchpad.net Unsubscribe : https://launchpad.net/~hugin-bug-hunters More help : https://help.launchpad.net/ListHelp
[Hugin-bug-hunters] [Bug 2053287] Re: sometimes there are black patches/corners in blended images
@Bruno: Are you building with automake or with CMake? (On Ubuntu with CMake it works. But it seems they are providing a patched vigra library, where this offending line is missing.) @Lukas: I applied now most of your patches and pushed the changes to the repository. Thank you again for the patches. Some parts I skipped because of cosmetic issues or some part results in compile error with MSVC. ** Changed in: enblend Status: New => Fix Committed -- You received this bug notification because you are a member of Hugin Bug Hunters, which is subscribed to Enblend. https://bugs.launchpad.net/bugs/2053287 Title: sometimes there are black patches/corners in blended images Status in Enblend: Fix Committed Bug description: As has been known for a long time, enblend sometimes produces black patches in the corners of subimages. As we have discussed by email, I'd like to suggest a patch for that: -- patch1 contains the pyramid type to make the following simpler -- patch2 contains the actual change where the mask is corrected using both alpha layers prior to the actual blending step -- patch3 are two small functional changes that are unrelated to the main issue -- patch4 are modernisation and style improvements, that I just had to do while working on the code. If you think some of them don't add enough (or any) value, feel free to drop some. cheers, lukas wirz To manage notifications about this bug go to: https://bugs.launchpad.net/enblend/+bug/2053287/+subscriptions ___ Mailing list: https://launchpad.net/~hugin-bug-hunters Post to : hugin-bug-hunters@lists.launchpad.net Unsubscribe : https://launchpad.net/~hugin-bug-hunters More help : https://help.launchpad.net/ListHelp
[Hugin-bug-hunters] [Bug 2053287] Re: sometimes there are black patches/corners in blended images
Yes, that is weird. You're quoting vigra code, ... #if _MSC_VER >= 1900 || __cplusplus >= 201103L noexcept(false) #else throw(PreconditionViolation) #endif ... and given that enblend uses c++17, the offending line shouldn't be used. Does that problem not occur without my patches? Do you run some modified version of vigra? -- You received this bug notification because you are a member of Hugin Bug Hunters, which is subscribed to Enblend. https://bugs.launchpad.net/bugs/2053287 Title: sometimes there are black patches/corners in blended images Status in Enblend: New Bug description: As has been known for a long time, enblend sometimes produces black patches in the corners of subimages. As we have discussed by email, I'd like to suggest a patch for that: -- patch1 contains the pyramid type to make the following simpler -- patch2 contains the actual change where the mask is corrected using both alpha layers prior to the actual blending step -- patch3 are two small functional changes that are unrelated to the main issue -- patch4 are modernisation and style improvements, that I just had to do while working on the code. If you think some of them don't add enough (or any) value, feel free to drop some. cheers, lukas wirz To manage notifications about this bug go to: https://bugs.launchpad.net/enblend/+bug/2053287/+subscriptions ___ Mailing list: https://launchpad.net/~hugin-bug-hunters Post to : hugin-bug-hunters@lists.launchpad.net Unsubscribe : https://launchpad.net/~hugin-bug-hunters More help : https://help.launchpad.net/ListHelp
[Hugin-bug-hunters] [Bug 2053287] Re: sometimes there are black patches/corners in blended images
I can't get the latest mercurial with patches to build, this doesn't really make sense to me as enblend requires c++17: ``` /usr/include/vigra/separableconvolution.hxx:1413:13: error: ISO C++17 does not allow dynamic exception specifications 1413 | throw(PreconditionViolation) | ^ /usr/include/vigra/stdconvolution.hxx:796:13: error: ISO C++17 does not allow dynamic exception specifications 796 | throw(PreconditionViolation) | ^ ``` -- You received this bug notification because you are a member of Hugin Bug Hunters, which is subscribed to Enblend. https://bugs.launchpad.net/bugs/2053287 Title: sometimes there are black patches/corners in blended images Status in Enblend: New Bug description: As has been known for a long time, enblend sometimes produces black patches in the corners of subimages. As we have discussed by email, I'd like to suggest a patch for that: -- patch1 contains the pyramid type to make the following simpler -- patch2 contains the actual change where the mask is corrected using both alpha layers prior to the actual blending step -- patch3 are two small functional changes that are unrelated to the main issue -- patch4 are modernisation and style improvements, that I just had to do while working on the code. If you think some of them don't add enough (or any) value, feel free to drop some. cheers, lukas wirz To manage notifications about this bug go to: https://bugs.launchpad.net/enblend/+bug/2053287/+subscriptions ___ Mailing list: https://launchpad.net/~hugin-bug-hunters Post to : hugin-bug-hunters@lists.launchpad.net Unsubscribe : https://launchpad.net/~hugin-bug-hunters More help : https://help.launchpad.net/ListHelp
[Hugin-bug-hunters] [Bug 2053287] Re: sometimes there are black patches/corners in blended images
p3 ** Patch added: "patch3.diff" https://bugs.launchpad.net/enblend/+bug/2053287/+attachment/5746516/+files/patch3.diff -- You received this bug notification because you are a member of Hugin Bug Hunters, which is subscribed to Enblend. https://bugs.launchpad.net/bugs/2053287 Title: sometimes there are black patches/corners in blended images Status in Enblend: New Bug description: As has been known for a long time, enblend sometimes produces black patches in the corners of subimages. As we have discussed by email, I'd like to suggest a patch for that: -- patch1 contains the pyramid type to make the following simpler -- patch2 contains the actual change where the mask is corrected using both alpha layers prior to the actual blending step -- patch3 are two small functional changes that are unrelated to the main issue -- patch4 are modernisation and style improvements, that I just had to do while working on the code. If you think some of them don't add enough (or any) value, feel free to drop some. cheers, lukas wirz To manage notifications about this bug go to: https://bugs.launchpad.net/enblend/+bug/2053287/+subscriptions ___ Mailing list: https://launchpad.net/~hugin-bug-hunters Post to : hugin-bug-hunters@lists.launchpad.net Unsubscribe : https://launchpad.net/~hugin-bug-hunters More help : https://help.launchpad.net/ListHelp
[Hugin-bug-hunters] [Bug 2053287] Re: sometimes there are black patches/corners in blended images
p2 ** Patch added: "patch2.diff" https://bugs.launchpad.net/enblend/+bug/2053287/+attachment/5746515/+files/patch2.diff -- You received this bug notification because you are a member of Hugin Bug Hunters, which is subscribed to Enblend. https://bugs.launchpad.net/bugs/2053287 Title: sometimes there are black patches/corners in blended images Status in Enblend: New Bug description: As has been known for a long time, enblend sometimes produces black patches in the corners of subimages. As we have discussed by email, I'd like to suggest a patch for that: -- patch1 contains the pyramid type to make the following simpler -- patch2 contains the actual change where the mask is corrected using both alpha layers prior to the actual blending step -- patch3 are two small functional changes that are unrelated to the main issue -- patch4 are modernisation and style improvements, that I just had to do while working on the code. If you think some of them don't add enough (or any) value, feel free to drop some. cheers, lukas wirz To manage notifications about this bug go to: https://bugs.launchpad.net/enblend/+bug/2053287/+subscriptions ___ Mailing list: https://launchpad.net/~hugin-bug-hunters Post to : hugin-bug-hunters@lists.launchpad.net Unsubscribe : https://launchpad.net/~hugin-bug-hunters More help : https://help.launchpad.net/ListHelp
[Hugin-bug-hunters] [Bug 2053287] Re: sometimes there are black patches/corners in blended images
p4 ** Patch added: "patch4.diff" https://bugs.launchpad.net/enblend/+bug/2053287/+attachment/5746517/+files/patch4.diff -- You received this bug notification because you are a member of Hugin Bug Hunters, which is subscribed to Enblend. https://bugs.launchpad.net/bugs/2053287 Title: sometimes there are black patches/corners in blended images Status in Enblend: New Bug description: As has been known for a long time, enblend sometimes produces black patches in the corners of subimages. As we have discussed by email, I'd like to suggest a patch for that: -- patch1 contains the pyramid type to make the following simpler -- patch2 contains the actual change where the mask is corrected using both alpha layers prior to the actual blending step -- patch3 are two small functional changes that are unrelated to the main issue -- patch4 are modernisation and style improvements, that I just had to do while working on the code. If you think some of them don't add enough (or any) value, feel free to drop some. cheers, lukas wirz To manage notifications about this bug go to: https://bugs.launchpad.net/enblend/+bug/2053287/+subscriptions ___ Mailing list: https://launchpad.net/~hugin-bug-hunters Post to : hugin-bug-hunters@lists.launchpad.net Unsubscribe : https://launchpad.net/~hugin-bug-hunters More help : https://help.launchpad.net/ListHelp
