[Hugin-devs] [Bug 679164] Re: hugin invokation of make failure on MAKEFLAGS=-j2
It seems to be a matter personal preference which of the (combination) of proposed fixes is the best one: * pass -j1 Commited in rev. 76f04d672b03 * Don't run make in a -j2 incompatible way, use make all make clean instead of make all clean This would require some more changes to be compatible with the progress dialog. So I decided for the easier way ;-) ** Changed in: hugin Status: Confirmed = Fix Committed -- You received this bug notification because you are a member of Hugin Developers, which is subscribed to Hugin. https://bugs.launchpad.net/bugs/679164 Title: hugin invokation of make failure on MAKEFLAGS=-j2 Status in Hugin - Panorama Tools GUI: Fix Committed Bug description: Hello, this has originally been reported by Helmut Grohne in http://bugs.debian.org/525494. -- nona -z PACKBITS -r ldr -m TIFF_m -o blah -i 0 /tmp/huginpto_deFg2s nona -z PACKBITS -r ldr -m TIFF_m -o blah -i 1 /tmp/huginpto_deFg2s nona -z PACKBITS -r ldr -m TIFF_m -o blah -i 2 /tmp/huginpto_deFg2s rm blah.tif blah0001.tif blah0002.tif enblend --compression LZW -m 1500 -f2277x4564 -o blah.tif blah.tif blah0001.tif blah0002.tif enblend: error opening input file blah.tif: Precondition violation! Unable to open file 'blah.tif'. make: *** [blah.tif] Fehler 1 -- Hugin stitiching breaks if MAKEFLAGS=-j2 is set. The reason is a rather simple one, during stitching hugin invokes make all clean. With parallelisation clean is run before all is finished and this happens with three images and -j2 (xa and xb are run in parallel): 1a nona for image 1 1b nona for image 2 -- 2a nona for image 3 2b rm temporary files, including the output the first nona invocations -- 3a run enblend, which fails due to missing files. The correct fix is to only run clean after all has finished (make all make clean). Removing MAKEFLAGS from the environment might not hurt but should be configurable. See also https://sourceforge.net/tracker/?func=detailaid=2781240group_id=77506atid=550441. This is verified for 0.7.0, but afaict this should also apply to SVN HEAD (0.8.0 prerelease r3801), which invokes make test all clean. thanks, cu andreas To manage notifications about this bug go to: https://bugs.launchpad.net/hugin/+bug/679164/+subscriptions ___ Mailing list: https://launchpad.net/~hugin-devs Post to : hugin-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~hugin-devs More help : https://help.launchpad.net/ListHelp
[Hugin-devs] [Bug 679164] Re: hugin invokation of make failure on MAKEFLAGS=-j2
On 2012-03-06 tmodes 679...@bugs.launchpad.net wrote: Previously Andreas wrote: [...] The correct fix is to only run clean after all has finished (make all make clean). Removing MAKEFLAGS from the environment might not hurt but should be configurable. See also https://sourceforge.net/tracker/?func=detailaid=2781240group_id=77506atid=550441. [...] I'm not sure if running several instances of nona or enblend parallel is a good idea. Both program can use several threads/core parallel. So running several instance of nona parallel can result in unwanted blocking behavior of the different threads. Also the programs needs often a lot of free memory. So when running several threads parallel this is amplified. This can be to relieved to some amount by restricting the number of threads in the preferences. Some idea: Would it help to call make with the -j1 switch, also make -f makefile -j1 info test all clean? Or do you think, that's a wrong way? [...] Hello, Afaict using the -j1 switch would work, at least with my version of make commandline arguments supercede MAKEFLAGS: ametzler@argenau:/tmp$ env MAKEFLAGS=j2 make foo bar foobarfoo done bar done ametzler@argenau:/tmp$ env MAKEFLAGS=j2 make -j1 foo bar foofoo done barbar done It seems to be a matter personal preference which of the (combination) of proposed fixes is the best one: * pass -j1 * Don't run make in a -j2 incompatible way, use make all make clean instead of make all clean * Drop MAKEFLAGS from make's environment. cu andreas ** Bug watch added: SourceForge.net Tracker #2781240 http://sourceforge.net/support/tracker.php?aid=2781240 -- You received this bug notification because you are a member of Hugin Developers, which is subscribed to Hugin. https://bugs.launchpad.net/bugs/679164 Title: hugin invokation of make failure on MAKEFLAGS=-j2 Status in Hugin - Panorama Tools GUI: Confirmed Bug description: Hello, this has originally been reported by Helmut Grohne in http://bugs.debian.org/525494. -- nona -z PACKBITS -r ldr -m TIFF_m -o blah -i 0 /tmp/huginpto_deFg2s nona -z PACKBITS -r ldr -m TIFF_m -o blah -i 1 /tmp/huginpto_deFg2s nona -z PACKBITS -r ldr -m TIFF_m -o blah -i 2 /tmp/huginpto_deFg2s rm blah.tif blah0001.tif blah0002.tif enblend --compression LZW -m 1500 -f2277x4564 -o blah.tif blah.tif blah0001.tif blah0002.tif enblend: error opening input file blah.tif: Precondition violation! Unable to open file 'blah.tif'. make: *** [blah.tif] Fehler 1 -- Hugin stitiching breaks if MAKEFLAGS=-j2 is set. The reason is a rather simple one, during stitching hugin invokes make all clean. With parallelisation clean is run before all is finished and this happens with three images and -j2 (xa and xb are run in parallel): 1a nona for image 1 1b nona for image 2 -- 2a nona for image 3 2b rm temporary files, including the output the first nona invocations -- 3a run enblend, which fails due to missing files. The correct fix is to only run clean after all has finished (make all make clean). Removing MAKEFLAGS from the environment might not hurt but should be configurable. See also https://sourceforge.net/tracker/?func=detailaid=2781240group_id=77506atid=550441. This is verified for 0.7.0, but afaict this should also apply to SVN HEAD (0.8.0 prerelease r3801), which invokes make test all clean. thanks, cu andreas To manage notifications about this bug go to: https://bugs.launchpad.net/hugin/+bug/679164/+subscriptions ___ Mailing list: https://launchpad.net/~hugin-devs Post to : hugin-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~hugin-devs More help : https://help.launchpad.net/ListHelp
[Hugin-devs] [Bug 679164] Re: hugin invokation of make failure on MAKEFLAGS=-j2
I'm not sure if running several instances of nona or enblend parallel is a good idea. Both program can use several threads/core parallel. So running several instance of nona parallel can result in unwanted blocking behavior of the different threads. Also the programs needs often a lot of free memory. So when running several threads parallel this is amplified. This can be to relieved to some amount by restricting the number of threads in the preferences. Some idea: Would it help to call make with the -j1 switch, also make -f makefile -j1 info test all clean? Or do you think, that's a wrong way? -- You received this bug notification because you are a member of Hugin Developers, which is subscribed to Hugin. https://bugs.launchpad.net/bugs/679164 Title: hugin invokation of make failure on MAKEFLAGS=-j2 Status in Hugin - Panorama Tools GUI: Confirmed Bug description: Hello, this has originally been reported by Helmut Grohne in http://bugs.debian.org/525494. -- nona -z PACKBITS -r ldr -m TIFF_m -o blah -i 0 /tmp/huginpto_deFg2s nona -z PACKBITS -r ldr -m TIFF_m -o blah -i 1 /tmp/huginpto_deFg2s nona -z PACKBITS -r ldr -m TIFF_m -o blah -i 2 /tmp/huginpto_deFg2s rm blah.tif blah0001.tif blah0002.tif enblend --compression LZW -m 1500 -f2277x4564 -o blah.tif blah.tif blah0001.tif blah0002.tif enblend: error opening input file blah.tif: Precondition violation! Unable to open file 'blah.tif'. make: *** [blah.tif] Fehler 1 -- Hugin stitiching breaks if MAKEFLAGS=-j2 is set. The reason is a rather simple one, during stitching hugin invokes make all clean. With parallelisation clean is run before all is finished and this happens with three images and -j2 (xa and xb are run in parallel): 1a nona for image 1 1b nona for image 2 -- 2a nona for image 3 2b rm temporary files, including the output the first nona invocations -- 3a run enblend, which fails due to missing files. The correct fix is to only run clean after all has finished (make all make clean). Removing MAKEFLAGS from the environment might not hurt but should be configurable. See also https://sourceforge.net/tracker/?func=detailaid=2781240group_id=77506atid=550441. This is verified for 0.7.0, but afaict this should also apply to SVN HEAD (0.8.0 prerelease r3801), which invokes make test all clean. thanks, cu andreas To manage notifications about this bug go to: https://bugs.launchpad.net/hugin/+bug/679164/+subscriptions ___ Mailing list: https://launchpad.net/~hugin-devs Post to : hugin-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~hugin-devs More help : https://help.launchpad.net/ListHelp
[Hugin-devs] [Bug 679164] Re: hugin invokation of make failure on MAKEFLAGS=-j2
Still present in 2011.0.0 beta3. It invokes make -f /tmp/huginmk_pViQ5m info test all clean ** Changed in: hugin Status: Expired = Confirmed -- You received this bug notification because you are a member of Hugin Developers, which is subscribed to Hugin. https://bugs.launchpad.net/bugs/679164 Title: hugin invokation of make failure on MAKEFLAGS=-j2 Status in Hugin - Panorama Tools GUI: Confirmed Bug description: Hello, this has originally been reported by Helmut Grohne in http://bugs.debian.org/525494. -- nona -z PACKBITS -r ldr -m TIFF_m -o blah -i 0 /tmp/huginpto_deFg2s nona -z PACKBITS -r ldr -m TIFF_m -o blah -i 1 /tmp/huginpto_deFg2s nona -z PACKBITS -r ldr -m TIFF_m -o blah -i 2 /tmp/huginpto_deFg2s rm blah.tif blah0001.tif blah0002.tif enblend --compression LZW -m 1500 -f2277x4564 -o blah.tif blah.tif blah0001.tif blah0002.tif enblend: error opening input file blah.tif: Precondition violation! Unable to open file 'blah.tif'. make: *** [blah.tif] Fehler 1 -- Hugin stitiching breaks if MAKEFLAGS=-j2 is set. The reason is a rather simple one, during stitching hugin invokes make all clean. With parallelisation clean is run before all is finished and this happens with three images and -j2 (xa and xb are run in parallel): 1a nona for image 1 1b nona for image 2 -- 2a nona for image 3 2b rm temporary files, including the output the first nona invocations -- 3a run enblend, which fails due to missing files. The correct fix is to only run clean after all has finished (make all make clean). Removing MAKEFLAGS from the environment might not hurt but should be configurable. See also https://sourceforge.net/tracker/?func=detailaid=2781240group_id=77506atid=550441. This is verified for 0.7.0, but afaict this should also apply to SVN HEAD (0.8.0 prerelease r3801), which invokes make test all clean. thanks, cu andreas ___ Mailing list: https://launchpad.net/~hugin-devs Post to : hugin-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~hugin-devs More help : https://help.launchpad.net/ListHelp
[Hugin-devs] [Bug 679164] Re: hugin invokation of make failure on MAKEFLAGS=-j2
[Expired for Hugin because there has been no activity for 60 days.] ** Changed in: hugin Status: Incomplete = Expired -- You received this bug notification because you are a member of Hugin Developers, which is subscribed to Hugin. https://bugs.launchpad.net/bugs/679164 Title: hugin invokation of make failure on MAKEFLAGS=-j2 Status in Hugin - Panorama Tools GUI: Expired Bug description: Hello, this has originally been reported by Helmut Grohne in http://bugs.debian.org/525494. -- nona -z PACKBITS -r ldr -m TIFF_m -o blah -i 0 /tmp/huginpto_deFg2s nona -z PACKBITS -r ldr -m TIFF_m -o blah -i 1 /tmp/huginpto_deFg2s nona -z PACKBITS -r ldr -m TIFF_m -o blah -i 2 /tmp/huginpto_deFg2s rm blah.tif blah0001.tif blah0002.tif enblend --compression LZW -m 1500 -f2277x4564 -o blah.tif blah.tif blah0001.tif blah0002.tif enblend: error opening input file blah.tif: Precondition violation! Unable to open file 'blah.tif'. make: *** [blah.tif] Fehler 1 -- Hugin stitiching breaks if MAKEFLAGS=-j2 is set. The reason is a rather simple one, during stitching hugin invokes make all clean. With parallelisation clean is run before all is finished and this happens with three images and -j2 (xa and xb are run in parallel): 1a nona for image 1 1b nona for image 2 -- 2a nona for image 3 2b rm temporary files, including the output the first nona invocations -- 3a run enblend, which fails due to missing files. The correct fix is to only run clean after all has finished (make all make clean). Removing MAKEFLAGS from the environment might not hurt but should be configurable. See also https://sourceforge.net/tracker/?func=detailaid=2781240group_id=77506atid=550441. This is verified for 0.7.0, but afaict this should also apply to SVN HEAD (0.8.0 prerelease r3801), which invokes make test all clean. thanks, cu andreas ___ Mailing list: https://launchpad.net/~hugin-devs Post to : hugin-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~hugin-devs More help : https://help.launchpad.net/ListHelp
[Hugin-devs] [Bug 679164] Re: hugin invokation of make failure on MAKEFLAGS=-j2
Verified in 2010.4.0. Hugin nowadays invokes make -f ... info test all clean, but this does not make a difference, clean and all still run in parallell. -- You received this bug notification because you are a member of Hugin Developers, which is subscribed to Hugin. https://bugs.launchpad.net/bugs/679164 Title: hugin invokation of make failure on MAKEFLAGS=-j2 Status in Hugin - Panorama Tools GUI: Incomplete Bug description: Hello, this has originally been reported by Helmut Grohne in http://bugs.debian.org/525494. -- nona -z PACKBITS -r ldr -m TIFF_m -o blah -i 0 /tmp/huginpto_deFg2s nona -z PACKBITS -r ldr -m TIFF_m -o blah -i 1 /tmp/huginpto_deFg2s nona -z PACKBITS -r ldr -m TIFF_m -o blah -i 2 /tmp/huginpto_deFg2s rm blah.tif blah0001.tif blah0002.tif enblend --compression LZW -m 1500 -f2277x4564 -o blah.tif blah.tif blah0001.tif blah0002.tif enblend: error opening input file blah.tif: Precondition violation! Unable to open file 'blah.tif'. make: *** [blah.tif] Fehler 1 -- Hugin stitiching breaks if MAKEFLAGS=-j2 is set. The reason is a rather simple one, during stitching hugin invokes make all clean. With parallelisation clean is run before all is finished and this happens with three images and -j2 (xa and xb are run in parallel): 1a nona for image 1 1b nona for image 2 -- 2a nona for image 3 2b rm temporary files, including the output the first nona invocations -- 3a run enblend, which fails due to missing files. The correct fix is to only run clean after all has finished (make all make clean). Removing MAKEFLAGS from the environment might not hurt but should be configurable. See also https://sourceforge.net/tracker/?func=detailaid=2781240group_id=77506atid=550441. This is verified for 0.7.0, but afaict this should also apply to SVN HEAD (0.8.0 prerelease r3801), which invokes make test all clean. thanks, cu andreas ___ Mailing list: https://launchpad.net/~hugin-devs Post to : hugin-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~hugin-devs More help : https://help.launchpad.net/ListHelp
