Re: [hugin-ptx] Mac builds of Hugin

[dudek53]

Any suggestions and refinements are most welcome. Still the better starting
point than what we had before.
I hope I get some time to tinker next week .
Have a nice evening.
/D

Den fre 16 juni 2023 16:44T. Modes  skrev:

> dud...@gmail.com schrieb am Donnerstag, 15. Juni 2023 um 20:34:54 UTC+2:
>
> Might have a fix for the button issue when in darkmode. Feel free to
> refine it.
>
> In splitbutton.cpp:
>
>
> *void SplitButton::OnPaint(wxPaintEvent& WXUNUSED(event))*
>
>
> Please don't copy the full code into the mail. First the software/mail
> client can reformat the code lines - this can introduce a lot of
> unnecessary trouble.
> Second it is not so obviously what you changed exactly.
> Please attached instead a unified diff (from hg diff). This makes the
> handling of such changes more easily.
>
> The changes affect only the caption (text) of the button, but not the
> drawing of the buttons itself. These are still wrongly drawn.
>
> Second, I don't like the fixed coded colours. What if the users theme is
> using other colours? Then it looks wrong again.
>
>
> --
> A list of frequently asked questions is available at:
> http://wiki.panotools.org/Hugin_FAQ
> ---
> You received this message because you are subscribed to the Google Groups
> "hugin and other free panoramic software" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to hugin-ptx+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/hugin-ptx/3ae298e7-1f3a-429a-b395-3d6e2ea1abb3n%40googlegroups.com
> 
> .
>

-- 
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
--- 
You received this message because you are subscribed to the Google Groups 
"hugin and other free panoramic software" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to hugin-ptx+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/hugin-ptx/CAHk3tqi95L1EQ5_QjGTrcSmCRDqfXbK7pcgPMFPt6Co6xCdYwg%40mail.gmail.com.

Re: [hugin-ptx] Mac builds of Hugin

[T. Modes]

dud...@gmail.com schrieb am Donnerstag, 15. Juni 2023 um 20:34:54 UTC+2:

Might have a fix for the button issue when in darkmode. Feel free to refine 
it.

In splitbutton.cpp:


*void SplitButton::OnPaint(wxPaintEvent& WXUNUSED(event))*


Please don't copy the full code into the mail. First the software/mail 
client can reformat the code lines - this can introduce a lot of 
unnecessary trouble. 
Second it is not so obviously what you changed exactly. 
Please attached instead a unified diff (from hg diff). This makes the 
handling of such changes more easily.

The changes affect only the caption (text) of the button, but not the 
drawing of the buttons itself. These are still wrongly drawn.

Second, I don't like the fixed coded colours. What if the users theme is 
using other colours? Then it looks wrong again.


-- 
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
--- 
You received this message because you are subscribed to the Google Groups 
"hugin and other free panoramic software" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to hugin-ptx+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/hugin-ptx/3ae298e7-1f3a-429a-b395-3d6e2ea1abb3n%40googlegroups.com.