On Mar 25, 2015, at 4:14 PM, Brice Goglin <brice.gog...@inria.fr> wrote:
> 
> Looks like I missed something in the OMPI discussion:
> When you say symbol, do you mean asm label?
> include/private/cpuid-x86.h: Assembler messages:
> include/private/cpuid-x86.h:40: Error: symbol `Lhwloc1' is already defined
> Like in the mail included at the end of
> http://www.open-mpi.org/community/lists/hwloc-users/2014/11/1119.php

(sorry it took me a few days to get back to this)

Yes, exactly like this.

> This is fixed by
> https://github.com/open-mpi/hwloc/commit/790aa2e1e62be6b4f37622959de9ce3766ebc57e
> (applied to all stable branches 4 month ago)

Got it.  Looks like we didn't grab it in OMPI because there was never an hwloc 
1.9.2.

> This is actually one of the reason why OMPI upgraded to hwloc v1.9. But
> I thought they were going to upgrade to hwloc v1.9 git HEAD, while they
> only went to v1.9.1, which does not contain this fix.

Makes sense.

> There's a stable release/branch issue here. hwloc updates stable
> *branches* up to what OMPI uses (hwloc v1.8), but usually we only
> publish stable *releases* on the last stable branch (v1.10). We need to
> clarify if OMPI wants official hwloc releases only, or if applying
> (possibly many) hwloc patches is OK.

Here's what I just did -- I grabbed all (relevant) hwloc 1.9 commits (including 
the dup symbol fix):

    https://github.com/open-mpi/ompi/pull/498

We usually only grab actual releases, but the OMPI v1.8 series is coming to a 
close, so I think that this is ok.

This PR is actually for OMPI master; once it shakes out ok on master, we'll PR 
it over to OMPI v1.8.  Once that has all completed, we'll likely want to 
upgrade OMPI master to hwloc v1.10.1 (which includes this Lhwloc1 fix).

Howzat?

-- 
Jeff Squyres
jsquy...@cisco.com
For corporate legal information go to: 
http://www.cisco.com/web/about/doing_business/legal/cri/

Reply via email to