Re: [i3] Call for testing for the 4.8 release
Hi Marcus, Marcus Crestani writes: > I've attached a patch that moves the __APPLE__ specific include of > sysctl.h below the include of i3.h. This way, the compiler considers > the redefinitions to come from a system header and does not show the > warnings. Also, types.h is no longer needed on OS X. Thanks. Next time, can you submit it to http://cr.i3wm.org/ directly please? -- Best regards, Michael
Re: [i3] Call for testing for the 4.8 release
>"MS" == Michael Stapelberg writes: MS> I want to release i3 v4.8 soon, so here is a call for testing. On OS X, I see a ton of "macro redefined" warnings when compiling src/log.c. The redefinitions are caused by include/queue.h that exists as a system header /usr/include/sys/queue.h on OS X. I've attached a patch that moves the __APPLE__ specific include of sysctl.h below the include of i3.h. This way, the compiler considers the redefinitions to come from a system header and does not show the warnings. Also, types.h is no longer needed on OS X. With this patch i3 builds cleanly and works fine for me. -- Marcus >From 349d7b2d1b603ce1ea54e275776505bd2a980e16 Mon Sep 17 00:00:00 2001 From: Marcus Crestani Date: Wed, 11 Jun 2014 20:53:22 +0200 Subject: [PATCH] Include sys/sysctl.h after i3.h to prevent redefinition warnings caused by queue.h on OS X. --- src/log.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/log.c b/src/log.c index ec44f3a..1014908 100644 --- a/src/log.c +++ b/src/log.c @@ -21,10 +21,6 @@ #include #include #include -#if defined(__APPLE__) -#include -#include -#endif #include "util.h" #include "log.h" @@ -32,6 +28,10 @@ #include "libi3.h" #include "shmlog.h" +#if defined(__APPLE__) +#include +#endif + static bool debug_logging = false; static bool verbose = false; static FILE *errorfile; -- 1.6.4.2
Re: [i3] Call for testing for the 4.8 release
Guess it isn't a regression then. A bit surprising for me, I've been using i3 for ages and I've never seen the issue before. Now it's popped up more than once in the last few days. On Wed, Jun 11, 2014 at 5:00 PM, Lewis Gunsch wrote: > On Wed, Jun 11, 2014 at 2:30 AM, wrote: >> >> >> >> Le 11.06.2014 09:29, Anders Aagaard a écrit : >> >>> Java focus issues isn't what I originally reported though. Me typing >>> stuff and it ending up in a different (non Java) window is definitely >>> a regression. >> >> >> I agree that this is not a Java problem, but I do not agree that it is a >> regression. I had the problem few days ago, with the version which can be >> found in Debian backports ( 4.7.2 ). I did not reported it because I am >> unable to reproduce it, and does not have internet at home (I'm currently at >> work). > > > I have had this problem on other programs then Intellij. I have regularly > encountered this issue in the Conkeror web browser. I focus a window, but > the typing ends up in some other window in the same workspace. Usually, this > means another Conkeror window since the workspace is devoted to it. No > amount of refocusing seems to solve it, but I've also never tried to switch > workspaces. However, I have had this problem for well over 6 months now. So, > I would agree that it is not a regression. > > Cheers, > ~Lewis > -- Mvh Anders Aagaard
Re: [i3] Call for testing for the 4.8 release
Can anyone tell me how to repeat this, I usually have windows popping in and out every now and then, and use IntelliJ idea for development work. So I'd like to look into this too. On Jun 11, 2014 8:31 PM, "Lewis Gunsch" wrote: > On Wed, Jun 11, 2014 at 2:30 AM, wrote: > >> >> >> Le 11.06.2014 09:29, Anders Aagaard a écrit : >> >> Java focus issues isn't what I originally reported though. Me typing >>> stuff and it ending up in a different (non Java) window is definitely >>> a regression. >>> >> >> I agree that this is not a Java problem, but I do not agree that it is a >> regression. I had the problem few days ago, with the version which can be >> found in Debian backports ( 4.7.2 ). I did not reported it because I am >> unable to reproduce it, and does not have internet at home (I'm currently >> at work). >> > > I have had this problem on other programs then Intellij. I have regularly > encountered this issue in the Conkeror web browser. I focus a window, but > the typing ends up in some other window in the same workspace. Usually, > this means another Conkeror window since the workspace is devoted to it. No > amount of refocusing seems to solve it, but I've also never tried to switch > workspaces. However, I have had this problem for well over 6 months now. > So, I would agree that it is not a regression. > > Cheers, > ~Lewis > >
Re: [i3] Call for testing for the 4.8 release
On Wed, Jun 11, 2014 at 2:30 AM, wrote: > > > Le 11.06.2014 09:29, Anders Aagaard a écrit : > > Java focus issues isn't what I originally reported though. Me typing >> stuff and it ending up in a different (non Java) window is definitely >> a regression. >> > > I agree that this is not a Java problem, but I do not agree that it is a > regression. I had the problem few days ago, with the version which can be > found in Debian backports ( 4.7.2 ). I did not reported it because I am > unable to reproduce it, and does not have internet at home (I'm currently > at work). > I have had this problem on other programs then Intellij. I have regularly encountered this issue in the Conkeror web browser. I focus a window, but the typing ends up in some other window in the same workspace. Usually, this means another Conkeror window since the workspace is devoted to it. No amount of refocusing seems to solve it, but I've also never tried to switch workspaces. However, I have had this problem for well over 6 months now. So, I would agree that it is not a regression. Cheers, ~Lewis
Re: [i3] Call for testing for the 4.8 release
Le 11.06.2014 09:29, Anders Aagaard a écrit : Java focus issues isn't what I originally reported though. Me typing stuff and it ending up in a different (non Java) window is definitely a regression. I agree that this is not a Java problem, but I do not agree that it is a regression. I had the problem few days ago, with the version which can be found in Debian backports ( 4.7.2 ). I did not reported it because I am unable to reproduce it, and does not have internet at home (I'm currently at work).
Re: [i3] Call for testing for the 4.8 release
Hi Anders, Anders Aagaard writes: > Java focus issues isn't what I originally reported though. Me typing stuff > and it ending up in a different (non Java) window is definitely a > regression. You were mentioning IntelliJ as one of the windows, and IntelliJ is written in Java. Not sure how this is not java-related. In any case, try upgrading to the latest commit (8ece9950012e0a2d20db9d4d15bc3a3e30b96121 at the time of writing), that may fix the issue(s). -- Best regards, Michael
Re: [i3] Call for testing for the 4.8 release
Java focus issues isn't what I originally reported though. Me typing stuff and it ending up in a different (non Java) window is definitely a regression. On Jun 11, 2014 9:22 AM, "Michael Stapelberg" wrote: > Hi, > > Marius Muja writes: > > I can confirm a focusing issue with intellij. I can reproduce it by doing > > Navigate -> Line and when the editor jumps to some line I cannot type in > > although the window has focus. If I move the focus out and back in the > > cursor appears and I can type. > We've been having issues with java for as long as the project > lives. These are not new problems and hence not blocking the upcoming > release. > > Thanks to everyone for testing, please update and continue testing so > that we can release (this weekend probably) :). > > -- > Best regards, > Michael >
Re: [i3] Call for testing for the 4.8 release
Hi, Marius Muja writes: > I can confirm a focusing issue with intellij. I can reproduce it by doing > Navigate -> Line and when the editor jumps to some line I cannot type in > although the window has focus. If I move the focus out and back in the > cursor appears and I can type. We’ve been having issues with java for as long as the project lives. These are not new problems and hence not blocking the upcoming release. Thanks to everyone for testing, please update and continue testing so that we can release (this weekend probably) :). -- Best regards, Michael
