Hi Ian,

Thank you for a very clear and well articulated bug report. It is much appreciated.

This was a simple one to fix. When I implemented the boxcar filter in Athena, I neglected to copy the energy shift value from the noisy group to the smoothed group. Oops! I just pushed a fix to github which will be included in the next windows installer.

If you would like to mend the copy of Athena on your computer, it's a small edit, as shown here:

https://github.com/bruceravel/demeter/commit/a84e5fb605cef26dd4be42bba46924264d941900

Thanks,
B


On 09/28/2016 11:33 AM, Godfrey, Ian wrote:
Dear All,


I have a bug to report when using the Athena data smoothing feature with
aligned data. Exemplar project and log files are attached, along with a
screenshot. I am running Windows 10 x64 with Athena 0.9.25 x64.


Summary:

When using the data smoothing feature in Athena with data that has
previously been aligned using the alignment feature, the smoothing is
performed on the non-aligned data, and the resulting, processed dataset
is shifted in E.


Recipe:


Open Athena

Import a dataset that has a reference channel

Import a second dataset with reference

Import a standard dataset, with a slightly off alignment wrt to the
first two datasets (I imported all three from Athena projects, rather
than raw datafiles)

Use the alignment tool to align the reference channel of one of the
datasets to the standard (I used the automatic alignment)

Go to the smoothing tool. You can immediately see that the smoothed
curve is in the wrong place for the aligned dataset.

The dataset that wasn't aligned will appear correctly


Many thanks,


Ian



----

Ian Godfrey



PhD Student,

UCL/JAIST Programme


Industrial Doctorate Centre in Molecular Modelling and Materials Science,

Department of Chemistry,

University College London



and



School of Materials Science,

Japan Advanced Institute of Science and Technology



i.godf...@ucl.ac.uk <mailto:i.godf...@ucl.ac.uk> i.godf...@jaist.ac.jp
<mailto:i.godf...@jaist.ac.jp>



_______________________________________________
Ifeffit mailing list
Ifeffit@millenia.cars.aps.anl.gov
http://millenia.cars.aps.anl.gov/mailman/listinfo/ifeffit
Unsubscribe: http://millenia.cars.aps.anl.gov/mailman/options/ifeffit



--
 Bruce Ravel  ------------------------------------ bra...@bnl.gov

 National Institute of Standards and Technology
 Synchrotron Science Group at NSLS-II
 Building 743, Room 114
 Upton NY, 11973

 Homepage:    http://bruceravel.github.io/home/
 Software:    https://github.com/bruceravel
 Demeter:     http://bruceravel.github.io/demeter/
_______________________________________________
Ifeffit mailing list
Ifeffit@millenia.cars.aps.anl.gov
http://millenia.cars.aps.anl.gov/mailman/listinfo/ifeffit
Unsubscribe: http://millenia.cars.aps.anl.gov/mailman/options/ifeffit

Reply via email to