Re: [infinispan-dev] Counters and their configurations in Infinispan server (DMR)

2017-11-07 Thread Vladimir Blagojevic 
Hi everyone,

Here is most of the implementation with example use outlined in
https://github.com/infinispan/infinispan/pull/5570

Would you please review it as I am not an expert in DMR and I need one now
:-)

Regards,
Vladimir

On Fri, Nov 3, 2017 at 8:58 AM, Vladimir Blagojevic 
wrote:

> Thanks Galder and Pedro. I'll implement them as you suggested!
> Cheers
> On 2017-11-03 6:02 AM, Galder Zamarreño wrote:
>
> At first glance, I'd agree with Pedro.
>
> On 2 Nov 2017, at 16:07, Pedro Ruivo 
>  wrote:
>
> Hi,
>
> IMO, I would separate the concept of counter and configuration.
>
> Even if an user doesn't create many counters, I think most of them will
> share the same configuration. As a bad example, if you want to counter
> oranges and apples, you're going to use the same configuration...
> probably :)
>
> In addition, it is symmetric to the cache DMR tree. This would reduce
> the learning curve if the user is already used to cli (i.e create caches).
>
> Cheers,
> Pedro
>
>
>
> On 02-11-2017 12:33, Vladimir Blagojevic wrote:
>
> Hey guys,
>
> How do you anticipate users are going to deal with counters? Are they
> going to be creating a lot of them in their applications, say dozens,
> hundreds, thousands?
>
> I am asking because I have a dilemma about their representation in DMR
> and therefore in the admin console and potentially wider. The dilemma is
> related to splitting the concepts and the mapping between counter
> configuration and counter instances. On one end of the possible spectrum
> use, if users are going to have many counters that have the same
> configuration then it makes sense to delineate the DMR concept of the
> counter configuration and its counter instance just like we do for
> caches and cache configuration templates. We deal with cache
> configurations as templates; one could create hundreds of caches from
> the same template. Similarly, we can do with counters. On the other end
> if users are going to create very few counters then it likely does not
> make much sense to separate counter configurations from its instance,
> they would have one to one mapping. For each new counter, users would
> just enter counter configuration and launch an instance of a
> corresponding counter.
>
> The first approach saves resources and makes large counter
> instantiations easier while the second approach is easier to understand
> conceptually but is inefficient if we are going to have many counter
> instance.
>
> Thoughts?
>
> Vladimir
>
> ___
> infinispan-dev mailing list
> infinispan-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
> ___
> infinispan-dev mailing list
> infinispan-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
>
> --
> Galder Zamarreño
> Infinispan, Red Hat
>
>
>
> ___
> infinispan-dev mailing 
> listinfinispan-dev@lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/infinispan-dev
>
>
>
> ___
> infinispan-dev mailing list
> infinispan-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
___
infinispan-dev mailing list
infinispan-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev

Re: [infinispan-dev] Counters and their configurations in Infinispan server (DMR)

2017-11-03 Thread Vladimir Blagojevic 

Thanks Galder and Pedro. I'll implement them as you suggested!
Cheers
On 2017-11-03 6:02 AM, Galder Zamarreño wrote:

At first glance, I'd agree with Pedro.


On 2 Nov 2017, at 16:07, Pedro Ruivo  wrote:

Hi,

IMO, I would separate the concept of counter and configuration.

Even if an user doesn't create many counters, I think most of them will
share the same configuration. As a bad example, if you want to counter
oranges and apples, you're going to use the same configuration...
probably :)

In addition, it is symmetric to the cache DMR tree. This would reduce
the learning curve if the user is already used to cli (i.e create 
caches).


Cheers,
Pedro



On 02-11-2017 12:33, Vladimir Blagojevic wrote:

Hey guys,

How do you anticipate users are going to deal with counters? Are they
going to be creating a lot of them in their applications, say dozens,
hundreds, thousands?

I am asking because I have a dilemma about their representation in DMR
and therefore in the admin console and potentially wider. The dilemma is
related to splitting the concepts and the mapping between counter
configuration and counter instances. On one end of the possible spectrum
use, if users are going to have many counters that have the same
configuration then it makes sense to delineate the DMR concept of the
counter configuration and its counter instance just like we do for
caches and cache configuration templates. We deal with cache
configurations as templates; one could create hundreds of caches from
the same template. Similarly, we can do with counters. On the other end
if users are going to create very few counters then it likely does not
make much sense to separate counter configurations from its instance,
they would have one to one mapping. For each new counter, users would
just enter counter configuration and launch an instance of a
corresponding counter.

The first approach saves resources and makes large counter
instantiations easier while the second approach is easier to understand
conceptually but is inefficient if we are going to have many counter
instance.

Thoughts?

Vladimir

___
infinispan-dev mailing list
infinispan-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev


___
infinispan-dev mailing list
infinispan-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev


--
Galder Zamarreño
Infinispan, Red Hat



___
infinispan-dev mailing list
infinispan-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev



___
infinispan-dev mailing list
infinispan-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev

Re: [infinispan-dev] Counters and their configurations in Infinispan server (DMR)

2017-11-03 Thread Galder Zamarreño 
At first glance, I'd agree with Pedro.On 2 Nov 2017, at 16:07, Pedro Ruivo  wrote:Hi,IMO, I would separate the concept of counter and configuration.Even if an user doesn't create many counters, I think most of them will share the same configuration. As a bad example, if you want to counter oranges and apples, you're going to use the same configuration... probably :)In addition, it is symmetric to the cache DMR tree. This would reduce the learning curve if the user is already used to cli (i.e create caches).Cheers,PedroOn 02-11-2017 12:33, Vladimir Blagojevic wrote:Hey guys,How do you anticipate users are going to deal with counters? Are theygoing to be creating a lot of them in their applications, say dozens,hundreds, thousands?I am asking because I have a dilemma about their representation in DMRand therefore in the admin console and potentially wider. The dilemma isrelated to splitting the concepts and the mapping between counterconfiguration and counter instances. On one end of the possible spectrumuse, if users are going to have many counters that have the sameconfiguration then it makes sense to delineate the DMR concept of thecounter configuration and its counter instance just like we do forcaches and cache configuration templates. We deal with cacheconfigurations as templates; one could create hundreds of caches fromthe same template. Similarly, we can do with counters. On the other endif users are going to create very few counters then it likely does notmake much sense to separate counter configurations from its instance,they would have one to one mapping. For each new counter, users wouldjust enter counter configuration and launch an instance of acorresponding counter.The first approach saves resources and makes large counterinstantiations easier while the second approach is easier to understandconceptually but is inefficient if we are going to have many counterinstance.Thoughts?Vladimir___infinispan-dev mailing listinfinispan-dev@lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/infinispan-dev___infinispan-dev mailing listinfinispan-dev@lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/infinispan-dev--Galder ZamarreñoInfinispan, Red Hat___
infinispan-dev mailing list
infinispan-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev