Hi David, Jesper,
Do you think it is OK that somebody checks in the changes without any
revision comments?
Well, I think that every checkin should have one. If your developers can not
come up with short description of what are the changes done to the file
doing, maybe he/she should not check it it at all, since they apparently
don't know what they doing...?
I also see that WinCvs is allowing the same 'solution' to the problem by
allowing the empty message to be entered on commit and replacing it with 'no
message' when issue the commit. Alex, sorry to say that but I don't like
it :( In the long run you will notice that is makes more troubles than it
solves. For example try to create change log from such a checkins...
Just my two cents :)
Take care.
Jerzy
Jesper,
During the move from my MKS/SI repository to
CVS I found this thing:
In src/rcs.c line 4068 (CVS-1.10.8) there is a
strncmp which fails, due to 'log' is NULL.
I added a check for log != NULL and the program
run fine again.
Is this a bug or has something in the conversion
gone wrong ?
Cheers,
Jesper Pedersen
This could be considered a bug, but I think it's really more of a
"functional characteristic" of RCS. RCS does not allow empty revision
comments in non-interactive check-ins. I discovered this also a few years
ago when writing a PVCS to RCS conversion script. This is the way I dealt
with in (in perl script form):
# If an empty comment is specified, RCS will not check in the file;
# check for this case. (but an empty -t- description is fine - go figure!)
# Since RCS will pause and ask for a comment if one is not given,
# substitute a dummy comment "no comment".
if ( $comment[$i] eq "\"\"" )
{
$ci_command =
"ci -f -r$rcs_rev_num[$i] -d$checked_in[$i] -w$author[$i]
-t-$description -m\"no comment\" $workfile";
}
else
{
$ci_command =
"ci -f -r$rcs_rev_num[$i] -d$checked_in[$i] -w$author[$i]
-t-$description -m$comment[$i] $workfile";
}
Regards,
David
BR,
Jerzy
The first thing they don't teach you at school: "Never say never".
All the issues not related to the list please send to me in private, thanks.
__
Get Your Private, Free Email at http://www.hotmail.com
