Re: Findbugs issues
merged - Original Message - From: Martin Perina mper...@redhat.com To: David Caro dcaro...@redhat.com Cc: Tomas Jelinek tjeli...@redhat.com, infra infra@ovirt.org Sent: Wednesday, April 23, 2014 6:34:55 PM Subject: Re: Findbugs issues - Original Message - From: David Caro dcaro...@redhat.com To: Tomas Jelinek tjeli...@redhat.com, Martin Perina mper...@redhat.com, infra infra@ovirt.org Sent: Wednesday, April 23, 2014 6:10:03 PM Subject: Findbugs issues Hi! There are still some findbugs issues merged on ovirt-engine master, and I've tracked them down to a couple commits of yours, can you please review them and if they were introduced there, fix them? Thanks!! Commit 4c2d171a701c04f5b3a82690826aa72b08f2f3e1 by Martin Perina HostGeneralModel.java:641, ES_COMPARING_PARAMETER_STRING_WITH_EQ, Priority: Low Comparison of String parameter using == or != in org.ovirt.engine.ui.uicommonweb.models.hosts.HostGeneralModel.setKdumpStatus(String) This code compares a java.lang.String parameter for reference equality using the == or != operators. Requiring callers to pass only String constants or interned strings to a method is unnecessarily fragile, and rarely leads to measurable performance gains. Consider using the equals(Object) method instead. Sorry, I missed this. Patch is ready: http://gerrit.ovirt.org/#/c/27022/ Martin Commit 749eba95219f36c0ad5ee8216b65a8efc8a1bae4 by Tomas Jelinek VmListModel.java:424, URF_UNREAD_FIELD, Priority: Low Unread field: org.ovirt.engine.ui.uicommonweb.models.vms.VmListModel.privateCustomPropertiesKeysList This field is never read. Consider removing it from the class. pd. We have improved infra enough and we are gonna enable back the per-patch checks to avoid this from happening in the future so we will not bother you anymore with these issues :) -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization RD Email: dc...@redhat.com Web: www.redhat.com RHT Global #: 82-62605 ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
[oVirt Jenkins] ovirt_engine_master_animal_sniffer_check - Build # 6472 - Fixed!
Project: http://jenkins.ovirt.org/job/ovirt_engine_master_animal_sniffer_check/ Build: http://jenkins.ovirt.org/job/ovirt_engine_master_animal_sniffer_check/6472/ Build Number: 6472 Build Status: Fixed Triggered By: Started by an SCM change - Changes Since Last Success: - Changes for Build #6471 [Lior Vernia] core: Add custom properties to VdsNetworkInterface [Lior Vernia] engine: Don't resurrect removed bonds for label Changes for Build #6472 [Martin Perina] webadmin: Fix findbugs issue in HostGeneralModel - Failed Tests: - No tests ran. ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
Logwatch for linode01.ovirt.org (Linux)
### Logwatch 7.3.6 (05/19/07) Processing Initiated: Thu Apr 24 04:16:05 2014 Date Range Processed: yesterday ( 2014-Apr-23 ) Period is day. Detail Level of Output: 0 Type of Output: unformatted Logfiles for Host: linode01.ovirt.org ## - httpd Begin Requests with error response codes 400 Bad Request /releases/stable/src/%%7Bname%7D-%%7Bversion%7D.tar.bz2: 1 Time(s) HTTP/1.1: 1 Time(s) 403 Forbidden /wordpress/wp-admin/: 12 Time(s) 404 Not Found //admin/categories.php/login.php?cPath=ac ... product_preview: 36 Time(s) //admin_area/charts/php-ofc-library/ofc_up ... p?name=vito.php: 1 Time(s) //admin_area/charts/tmp-upload-images/vito.php?rf: 1 Time(s) //administrator/components/com_acymailing/ ... /lobex21.php?rf: 17 Time(s) //administrator/components/com_acymailing/ ... ame=lobex21.php: 17 Time(s) //administrator/components/com_civicrm/civ ... /lobex21.php?rf: 17 Time(s) //administrator/components/com_civicrm/civ ... ame=lobex21.php: 17 Time(s) //administrator/components/com_civicrm/civ ... ges/vito.php?rf: 1 Time(s) //administrator/components/com_civicrm/civ ... p?name=vito.php: 1 Time(s) //administrator/components/com_jinc/classe ... /lobex21.php?rf: 17 Time(s) //administrator/components/com_jinc/classe ... ame=lobex21.php: 17 Time(s) //administrator/components/com_jinc/classe ... ges/vito.php?rf: 1 Time(s) //administrator/components/com_jinc/classe ... p?name=vito.php: 1 Time(s) //administrator/components/com_jinc/classe ... pload_image.php: 1 Time(s) //administrator/components/com_jnews/inclu ... /lobex21.php?rf: 17 Time(s) //administrator/components/com_jnews/inclu ... ame=lobex21.php: 17 Time(s) //administrator/components/com_jnews/inclu ... ges/vito.php?rf: 1 Time(s) //administrator/components/com_jnews/inclu ... p?name=vito.php: 1 Time(s) //administrator/components/com_jnewsletter ... /lobex21.php?rf: 17 Time(s) //administrator/components/com_jnewsletter ... ame=lobex21.php: 17 Time(s) //administrator/components/com_jnewsletter ... ges/vito.php?rf: 1 Time(s) //administrator/components/com_jnewsletter ... p?name=vito.php: 1 Time(s) //administrator/components/com_joomleague/ ... ges/vito.php?rf: 1 Time(s) //administrator/components/com_joomleague/ ... p?name=vito.php: 1 Time(s) //administrator/components/com_maian15/cha ... ges/vito.php?rf: 1 Time(s) //administrator/components/com_maian15/cha ... p?name=vito.php: 1 Time(s) //administrator/components/com_maianmedia/ ... /lobex21.php?rf: 17 Time(s) //administrator/components/com_maianmedia/ ... ame=lobex21.php: 17 Time(s) //administrator/components/com_maianmedia/ ... ges/vito.php?rf: 1 Time(s) //administrator/components/com_maianmedia/ ... p?name=vito.php: 1 Time(s) //administrator/components/com_redmystic/c ... ges/vito.php?rf: 1 Time(s) //administrator/components/com_redmystic/c ... p?name=vito.php: 1 Time(s) //components/com_jnews/includes/openflashc ... ges/guys.php?rf: 13 Time(s) //components/com_jnews/includes/openflashc ... p?name=guys.php: 14 Time(s) //openemr/library/openflashchart/php-ofc-l ... p?name=vito.php: 1 Time(s) //openemr/library/openflashchart/tmp-uploa ... ges/vito.php?rf: 1 Time(s) //wp-content/plugins/woopra/inc/php-ofc-li ... p?name=vito.php: 1 Time(s) //wp-content/plugins/woopra/inc/tmp-upload ... ges/vito.php?rf: 1 Time(s) //wp-content/plugins/wp-slimstat-ex/lib/of ... ges/vito.php?rf: 1 Time(s) //wp-content/plugins/wp-slimstat-ex/lib/of ... p?name=vito.php: 1 Time(s) //wp-content/themes/headlines/tools/thumb/ ... et3g.ro/gcc.php: 6 Time(s) /6.4/: 4 Time(s) /6/: 6 Time(s) /__: 1 Time(s) /admin.php: 8 Time(s) /admin/: 8 Time(s) /admin/banner_manager.php/login.php: 1 Time(s) /admin/board: 2 Time(s) /admin/categories.php/login.php: 1 Time(s) /admin/fckeditor/editor/filemanager/browse ... ctors/test.html: 1 Time(s) /admin/file_manager.php/login.php: 1 Time(s) /admin/login.php: 8 Time(s) /administrator/index.php: 29 Time(s) /bitrix/admin/index.php?lang=en: 8 Time(s) /blog/wp-admin/: 13 Time(s) /blog/wp-login.php: 1 Time(s) /board: 4 Time(s) /browserconfig.xml: 1 Time(s) /category/news/feed: 1 Time(s) /category/news/feed/: 41 Time(s) /components/com_oziogallery/imagin/scripts ... writeToFile.php: 1 Time(s) /components/com_oziogallery2/imagin/script ... writeToFile.php: 1 Time(s)
[oVirt Jenkins] ovirt_engine_master_animal_sniffer_check - Build # 6474 - Failure!
Project: http://jenkins.ovirt.org/job/ovirt_engine_master_animal_sniffer_check/ Build: http://jenkins.ovirt.org/job/ovirt_engine_master_animal_sniffer_check/6474/ Build Number: 6474 Build Status: Failure Triggered By: Started by an SCM change - Changes Since Last Success: - Changes for Build #6474 - Failed Tests: - No tests ran. ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
[oVirt Jenkins] ovirt-engine_master_animal-sniffer_merged - Build # 6477 - Fixed!
Project: http://jenkins.ovirt.org/job/ovirt-engine_master_animal-sniffer_merged/ Build: http://jenkins.ovirt.org/job/ovirt-engine_master_animal-sniffer_merged/6477/ Build Number: 6477 Build Status: Fixed Triggered By: Started by user David Caro - Changes Since Last Success: - Changes for Build #6474 Changes for Build #6475 [Vojtech Szocs] webadmin: UI plugins - SystemTreeSelectionChange Changes for Build #6476 [Vojtech Szocs] webadmin: UI plugins - SystemTreeSelectionChange Changes for Build #6477 [Vojtech Szocs] webadmin: UI plugins - SystemTreeSelectionChange - Failed Tests: - No tests ran. ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
cpopen missing again?
Didn't we resolved the issues with cpopen? nosetests tests.py E == ERROR: Failure: ImportError (No module named cpopen) -- Traceback (most recent call last): File /usr/lib/python2.7/site-packages/nose/loader.py, line 413, in loadTestsFromName addr.filename, addr.module) File /usr/lib/python2.7/site-packages/nose/importer.py, line 47, in importFromPath return self.importFromDir(dir_path, fqname) File /usr/lib/python2.7/site-packages/nose/importer.py, line 94, in importFromDir mod = load_module(part_fqname, fh, filename, desc) File /home/jenkins/workspace/vdsm_master_unit_tests_gerrit/vdsm/lib/zombiereaper/tests.py, line 24, in module from cpopen import CPopen ImportError: No module named cpopen See http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8419/console Can you please look into it? Thanks, Nir ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
Re: cpopen missing again?
- Original Message - From: Nir Soffer nsof...@redhat.com To: infra infra@ovirt.org Sent: Thursday, April 24, 2014 7:47:10 PM Subject: cpopen missing again? Didn't we resolved the issues with cpopen? nosetests tests.py E == ERROR: Failure: ImportError (No module named cpopen) -- Traceback (most recent call last): File /usr/lib/python2.7/site-packages/nose/loader.py, line 413, in loadTestsFromName addr.filename, addr.module) File /usr/lib/python2.7/site-packages/nose/importer.py, line 47, in importFromPath return self.importFromDir(dir_path, fqname) File /usr/lib/python2.7/site-packages/nose/importer.py, line 94, in importFromDir mod = load_module(part_fqname, fh, filename, desc) File /home/jenkins/workspace/vdsm_master_unit_tests_gerrit/vdsm/lib/zombiereaper/tests.py, line 24, in module from cpopen import CPopen ImportError: No module named cpopen See http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8419/console Note that triggering again was successful on the same host: http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8420/ Looks like there is a race in the test setup/teardown code, removing and installing cpopen. Nir ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
INFRA ISSUE: [oVirt Jenkins] ovirt-engine_3.4_upgrade-to-stable_merge - Build # 166 - Failure!
Project: http://jenkins.ovirt.org/job/ovirt-engine_3.4_upgrade-to-stable_merge/ Build: http://jenkins.ovirt.org/job/ovirt-engine_3.4_upgrade-to-stable_merge/166/ Build Number: 166 Build Status: Failure Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/26945 - Changes Since Last Success: - Changes for Build #166 - Failed Tests: - No tests ran. ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
INFRA ISSUE: [oVirt Jenkins] ovirt-engine_3.4_upgrade-to-stable_merge - Build # 167 - Still Failing!
Project: http://jenkins.ovirt.org/job/ovirt-engine_3.4_upgrade-to-stable_merge/ Build: http://jenkins.ovirt.org/job/ovirt-engine_3.4_upgrade-to-stable_merge/167/ Build Number: 167 Build Status: Still Failing Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/27020 - Changes Since Last Success: - Changes for Build #166 Changes for Build #167 - Failed Tests: - No tests ran. ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
INFRA ISSUE: [oVirt Jenkins] ovirt-engine_3.4_upgrade-to-stable_merge - Build # 168 - Still Failing!
Project: http://jenkins.ovirt.org/job/ovirt-engine_3.4_upgrade-to-stable_merge/ Build: http://jenkins.ovirt.org/job/ovirt-engine_3.4_upgrade-to-stable_merge/168/ Build Number: 168 Build Status: Still Failing Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/27006 - Changes Since Last Success: - Changes for Build #166 Changes for Build #167 Changes for Build #168 - Failed Tests: - No tests ran. ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
INFRA ISSUE: [oVirt Jenkins] ovirt-engine_3.4_upgrade-to-stable_merge - Build # 169 - Still Failing!
Project: http://jenkins.ovirt.org/job/ovirt-engine_3.4_upgrade-to-stable_merge/ Build: http://jenkins.ovirt.org/job/ovirt-engine_3.4_upgrade-to-stable_merge/169/ Build Number: 169 Build Status: Still Failing Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/27007 - Changes Since Last Success: - Changes for Build #166 Changes for Build #167 Changes for Build #168 Changes for Build #169 - Failed Tests: - No tests ran. ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
INFRA ISSUE: [oVirt Jenkins] ovirt-engine_3.4_upgrade-to-stable_merge - Build # 170 - Still Failing!
Project: http://jenkins.ovirt.org/job/ovirt-engine_3.4_upgrade-to-stable_merge/ Build: http://jenkins.ovirt.org/job/ovirt-engine_3.4_upgrade-to-stable_merge/170/ Build Number: 170 Build Status: Still Failing Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/27011 - Changes Since Last Success: - Changes for Build #166 Changes for Build #167 Changes for Build #168 Changes for Build #169 Changes for Build #170 - Failed Tests: - No tests ran. ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
