Re: [ovirt-devel] ovirt-system-tests hackathon report

2018-03-13 Thread Edward Haas
Hello there,

I indeed missed this event.
Nevertheless, I would like to add one remark:

The existing suites have differences in how they run the tests and how the
tests are written.
At the networking team, we found the original suites way of running things
and how tests are written problematic.
As a result, work has been done to make it more usable: control its run
flow, use advance capabilities from test frameworks (pytest) and make it as
simple as possible for a developer to add a test.
The result is seen in the network suite, which runs using pytest, has a lib
that wraps the SDK in a more "natural" manner, includes fixtures to handle
resources at different scopes and even has an ansible test.
Tests are NOT dependent on each other in any way, but they may require the
same resource (here fixtures play a role).

You are welcome to feedback on anything you see there, we are trying to
make it dead simple to write tests.

Thanks,
Edy.


On Tue, Mar 13, 2018 at 6:50 PM, Martin Sivak  wrote:

> Hi,
>
> just two or three notes from me:
>
> - I had to find a suitable hardware first
> - we spent quite some time to actually get OST up and running (missing CPU
> flags issue in my case)
> - he-basic-ansible-suite-4.2 failed because of package dependencies
> (imageio, but probably related to what Sandro already mentioned)
> - he-basic-suite-master fails for me because of the SDK version, but I
> have not way to check which version is required
>
> Just the last three issues cost me almost the whole day of playing with
> lago and OST instead of actually thinking about improvements.
>
> The contribution guide would help indeed as would better compatibility and
> some better way of dependency management.
>
> Btw, what would it take to allow ansible based tests? It should not be too
> hard to generate an inventory file for the deployment and launch all
> playbooks in the test directory. This would make contribution of simple
> tests even easier I think.
>
> Best regards
>
> Martin Sivak
>
>
>
>
> On Tue, Mar 13, 2018 at 5:26 PM, Sandro Bonazzola 
> wrote:
>
>> 4 people accepted calendar invite:
>> - Devin A. Bougie
>> - Francesco Romani
>> - Jiri Belka
>> - suporte, logicworks
>>
>> 4 people tentatively accepted calendar invite:
>> - Amnon Maimon
>> - Andreas Bleischwitz
>> - Arnaud Lauriou
>> - Stephen Pesini
>>
>> 2 mailing lists accepted calendar invite: us...@ovirt.org,
>> de...@ovirt.org (don't ask me how) so I may have missed someone in above
>> list
>>
>>
>> 4 patches got merged:
>> Add check for host update to the 1st host.
>>  Merged Yaniv Kaul
>> 
>> ovirt-system-tests
>>  
>> master
>> (add_upgrade_check)
>> 
>>  4:10
>> PM
>> basic-suite-master: add vnic_profile_mappings to register vm
>>  Merged Eitan Raviv
>> 
>> ovirt-system-tests
>>  
>> master
>> (register-template-vnic-mapping)
>> 
>>  2:50
>> PM
>> Revert "ovirt-4.2: Skipping 002_bootstrap.update_default_cluster"
>>  Merged Eyal Edri
>> 
>> ovirt-system-tests
>> 
>> master
>> 
>>  11:36
>> AM
>> seperate 4.2 tests and utils from master 
>> Merged Eyal Edri
>> 
>> ovirt-system-tests
>> 
>> master
>> 
>>  11:35
>> AM
>>
>> 13 patches has been pushed / reviewed / rebased
>>
>> Add gdeploy to ovirt-4.2.repo 
>> Daniel Belenky
>> 
>> ovirt-system-tests
>> 
>> master
>> 
>>  4:53
>> PM
>> Cleanup of test code - next() replaced with any()
>> 
>> Martin Sivák
>> 
>> ovirt-system-tests
>> 
>> master

Re: [ovirt-devel] ovirt-system-tests hackathon report

2018-03-13 Thread Martin Sivak
Hi,

just two or three notes from me:

- I had to find a suitable hardware first
- we spent quite some time to actually get OST up and running (missing CPU
flags issue in my case)
- he-basic-ansible-suite-4.2 failed because of package dependencies
(imageio, but probably related to what Sandro already mentioned)
- he-basic-suite-master fails for me because of the SDK version, but I have
not way to check which version is required

Just the last three issues cost me almost the whole day of playing with
lago and OST instead of actually thinking about improvements.

The contribution guide would help indeed as would better compatibility and
some better way of dependency management.

Btw, what would it take to allow ansible based tests? It should not be too
hard to generate an inventory file for the deployment and launch all
playbooks in the test directory. This would make contribution of simple
tests even easier I think.

Best regards

Martin Sivak




On Tue, Mar 13, 2018 at 5:26 PM, Sandro Bonazzola 
wrote:

> 4 people accepted calendar invite:
> - Devin A. Bougie
> - Francesco Romani
> - Jiri Belka
> - suporte, logicworks
>
> 4 people tentatively accepted calendar invite:
> - Amnon Maimon
> - Andreas Bleischwitz
> - Arnaud Lauriou
> - Stephen Pesini
>
> 2 mailing lists accepted calendar invite: us...@ovirt.org, de...@ovirt.org
> (don't ask me how) so I may have missed someone in above list
>
>
> 4 patches got merged:
> Add check for host update to the 1st host.
>  Merged Yaniv Kaul
> 
> ovirt-system-tests
>  
> master
> (add_upgrade_check)
> 
>  4:10
> PM
> basic-suite-master: add vnic_profile_mappings to register vm
>  Merged Eitan Raviv
> 
> ovirt-system-tests
>  
> master
> (register-template-vnic-mapping)
> 
>  2:50
> PM
> Revert "ovirt-4.2: Skipping 002_bootstrap.update_default_cluster"
>  Merged Eyal Edri
> 
> ovirt-system-tests
> 
> master
> 
>  11:36
> AM
> seperate 4.2 tests and utils from master 
> Merged Eyal Edri
> 
> ovirt-system-tests
> 
> master
> 
>  11:35
> AM
>
> 13 patches has been pushed / reviewed / rebased
>
> Add gdeploy to ovirt-4.2.repo 
> Daniel Belenky
> 
> ovirt-system-tests
> 
> master
> 
>  4:53
> PM
> Cleanup of test code - next() replaced with any()
> 
> Martin Sivák
> 
> ovirt-system-tests
> 
> master
> 
>  4:51
> PM
> Add network queues custom property and use it in the vnic profile for VM0
> 
> Yaniv Kaul
> 
> ovirt-system-tests
>  
> master
> (multi_queue_config)
> 
>  4:49
> PM
> new suite: he-basic-iscsi-suite-master 
> Yuval Turgeman
> 
> ovirt-system-tests
>  
> master
> (he-basic-iscsi-suite-master)
> 
>  4:47
> PM
> Collect host-deploy bundle from the engine
> 
> Yedidyah Bar David
>