Re: Freeze break request: teach nagios about noswap

[Stephen John Smoogen]

+1 from me

On 7 September 2017 at 19:41, Kevin Fenzi  wrote:
> Greetings.
>
> We currently have 7 hosts in nagios that are alerting about swap. 6 of them 
> are osbs* ones. The new OpenShift 3.6 actually disables swap on all nodes, so 
> these will alert forever, also more will as we roll 3.6 into production.
>
> Also, there's mailman01 that often gets low swap because it gets a bunch of 
> requests, swaps out things it isn't using and then frees the memory (but 
> never swaps back in).
>
> This patch sets a nagios.swap value which is defined in group_vars/all as 
> true, and set to false in all the places we don't want to check swap.
>
> Should be pretty easy to back out if it causes any issues.
>
> +1s?
>
> kevin
> --
> diff --git a/inventory/group_vars/all b/inventory/group_vars/all
> index e18af2f..18b9db5 100644
> --- a/inventory/group_vars/all
> +++ b/inventory/group_vars/all
> @@ -261,6 +261,7 @@ nagios_Check_Services:
>named: false
>dhcpd: false
>httpd: false
> +  swap: true
>
>  # Set variable if we want to use our global iptables defaults
>  # Some things need to set their own.
> diff --git a/inventory/group_vars/builders b/inventory/group_vars/builders
> index 8fea99e..c22c387 100644
> --- a/inventory/group_vars/builders
> +++ b/inventory/group_vars/builders
> @@ -1,5 +1,7 @@
>  ---
>  # nagios items
>  # We don't use nrpe to check any of the builders
> +# Nor do we check swap there.
>  nagios_Check_Services:
>nrpe: false
> +  swap: false
> diff --git a/inventory/group_vars/builders-stg 
> b/inventory/group_vars/builders-stg
> index 8fea99e..c22c387 100644
> --- a/inventory/group_vars/builders-stg
> +++ b/inventory/group_vars/builders-stg
> @@ -1,5 +1,7 @@
>  ---
>  # nagios items
>  # We don't use nrpe to check any of the builders
> +# Nor do we check swap there.
>  nagios_Check_Services:
>nrpe: false
> +  swap: false
> diff --git a/inventory/group_vars/cloud b/inventory/group_vars/cloud
> index abc2282..4af9dfb 100644
> --- a/inventory/group_vars/cloud
> +++ b/inventory/group_vars/cloud
> @@ -1,4 +1,5 @@
>  ---
>  nagios_Check_Services:
>nrpe: false
> +  swap: false
>  datacenter: cloud
> diff --git a/inventory/group_vars/mailman b/inventory/group_vars/mailman
> index 41dd8cd..f54b474 100644
> --- a/inventory/group_vars/mailman
> +++ b/inventory/group_vars/mailman
> @@ -63,3 +63,5 @@ nrpe_check_postfix_queue_crit: 200
>  nrpe_procs_warn: 300
>  nrpe_procs_crit: 500
>
> +nagios_Check_Services:
> +  swap: false
> diff --git a/inventory/host_vars/mirrorlist-host1plus.fedoraproject.org 
> b/inventory/host_vars/mirrorlist-host1plus.fedoraproject.org
> index ebd6151..c2e4532 100644
> --- a/inventory/host_vars/mirrorlist-host1plus.fedoraproject.org
> +++ b/inventory/host_vars/mirrorlist-host1plus.fedoraproject.org
> @@ -2,3 +2,11 @@
>  # This is now a cloud instance provided by host1plus
>  # vmhost: none
>  datacenter: host1plus
> +
> +nagios_Check_Services:
> +  nrpe: true
> +  sshd: true
> +  named: false
> +  dhcpd: false
> +  httpd: true
> +  swap: false
> diff --git a/inventory/host_vars/proxy05.fedoraproject.org 
> b/inventory/host_vars/proxy05.fedoraproject.org
> index 8efd950..fae19fd 100644
> --- a/inventory/host_vars/proxy05.fedoraproject.org
> +++ b/inventory/host_vars/proxy05.fedoraproject.org
> @@ -16,3 +16,11 @@ dns: 8.8.8.8
>  eth0_ip: 185.141.165.254
>  eth0_nm: 255.255.254.0
>  vpn: true
> +
> +nagios_Check_Services:
> +  nrpe: true
> +  sshd: true
> +  named: false
> +  dhcpd: false
> +  httpd: true
> +  swap: false
> diff --git a/roles/nagios_server/templates/nagios/hostgroups/checkswap.cfg.j2 
> b/roles/nagios_server/templates/nagios/hostgroups/checkswap.cfg.j2
> index 9f5bd8c..7da2328 100644
> --- a/roles/nagios_server/templates/nagios/hostgroups/checkswap.cfg.j2
> +++ b/roles/nagios_server/templates/nagios/hostgroups/checkswap.cfg.j2
> @@ -1,6 +1,5 @@
>  define hostgroup {
>  hostgroup_name  CheckSwap
>  alias   Swap-Is-Low
> -   members *, !status-fedora2, !registry-cdn, !phx2-gw, 
> !ibiblio-gw, !cloud-gw, !bodhost-gw, !coloamer-gw, !dedicated-gw, 
> !host1plus-gw, !internetx-gw, !osuosl-gw, !rdu-gw, !rdu-cc-gw, !tummy-gw, 
> !proxy05.fedoraproject.org, !mirrorlist-host1plus.fedoraproject.org, 
> !download-rdu01.fedoraproject.org, !virthost-rdu01.fedoraproject.org, 
> !fas3-01.stg.phx2.fedoraproject.org, !osbs-control01.phx2.fedoraproject.org, 
> {% for host in groups['builders'] %}!{{host}},{% endfor %} {% for host in 
> groups['builders-stg'] %}!{{host}},{% endfor %} {% for host in 
> groups['cloud'] %}!{{host}}, {% endfor %} {% for host in 
> vars['phx2_management_limited'] %}!{{host}},{% endfor %}  {% for host in 
> vars['phx2_management_hosts'] %}!{{host}}{% if not loop.last %},{% endif %} 
> {% endfor %}
> -
> +members {% for host in groups['all'] %}{% if 
> hostvars[host].nagios_Check_Services['swap'] == true %}{{host}}{% if not 
> loop.last %},{% endif %} {% endfor %}
>  }
>

Freeze break request: teach nagios about noswap

[Kevin Fenzi]

Greetings. 

We currently have 7 hosts in nagios that are alerting about swap. 6 of them are 
osbs* ones. The new OpenShift 3.6 actually disables swap on all nodes, so these 
will alert forever, also more will as we roll 3.6 into production. 

Also, there's mailman01 that often gets low swap because it gets a bunch of 
requests, swaps out things it isn't using and then frees the memory (but never 
swaps back in). 

This patch sets a nagios.swap value which is defined in group_vars/all as true, 
and set to false in all the places we don't want to check swap.

Should be pretty easy to back out if it causes any issues. 

+1s?

kevin
--
diff --git a/inventory/group_vars/all b/inventory/group_vars/all
index e18af2f..18b9db5 100644
--- a/inventory/group_vars/all
+++ b/inventory/group_vars/all
@@ -261,6 +261,7 @@ nagios_Check_Services:
   named: false
   dhcpd: false
   httpd: false
+  swap: true
 
 # Set variable if we want to use our global iptables defaults
 # Some things need to set their own.
diff --git a/inventory/group_vars/builders b/inventory/group_vars/builders
index 8fea99e..c22c387 100644
--- a/inventory/group_vars/builders
+++ b/inventory/group_vars/builders
@@ -1,5 +1,7 @@
 ---
 # nagios items
 # We don't use nrpe to check any of the builders
+# Nor do we check swap there.
 nagios_Check_Services:
   nrpe: false
+  swap: false
diff --git a/inventory/group_vars/builders-stg 
b/inventory/group_vars/builders-stg
index 8fea99e..c22c387 100644
--- a/inventory/group_vars/builders-stg
+++ b/inventory/group_vars/builders-stg
@@ -1,5 +1,7 @@
 ---
 # nagios items
 # We don't use nrpe to check any of the builders
+# Nor do we check swap there.
 nagios_Check_Services:
   nrpe: false
+  swap: false
diff --git a/inventory/group_vars/cloud b/inventory/group_vars/cloud
index abc2282..4af9dfb 100644
--- a/inventory/group_vars/cloud
+++ b/inventory/group_vars/cloud
@@ -1,4 +1,5 @@
 ---
 nagios_Check_Services: 
   nrpe: false
+  swap: false
 datacenter: cloud
diff --git a/inventory/group_vars/mailman b/inventory/group_vars/mailman
index 41dd8cd..f54b474 100644
--- a/inventory/group_vars/mailman
+++ b/inventory/group_vars/mailman
@@ -63,3 +63,5 @@ nrpe_check_postfix_queue_crit: 200
 nrpe_procs_warn: 300
 nrpe_procs_crit: 500
 
+nagios_Check_Services:
+  swap: false
diff --git a/inventory/host_vars/mirrorlist-host1plus.fedoraproject.org 
b/inventory/host_vars/mirrorlist-host1plus.fedoraproject.org
index ebd6151..c2e4532 100644
--- a/inventory/host_vars/mirrorlist-host1plus.fedoraproject.org
+++ b/inventory/host_vars/mirrorlist-host1plus.fedoraproject.org
@@ -2,3 +2,11 @@
 # This is now a cloud instance provided by host1plus
 # vmhost: none
 datacenter: host1plus
+
+nagios_Check_Services:
+  nrpe: true
+  sshd: true
+  named: false
+  dhcpd: false
+  httpd: true
+  swap: false
diff --git a/inventory/host_vars/proxy05.fedoraproject.org 
b/inventory/host_vars/proxy05.fedoraproject.org
index 8efd950..fae19fd 100644
--- a/inventory/host_vars/proxy05.fedoraproject.org
+++ b/inventory/host_vars/proxy05.fedoraproject.org
@@ -16,3 +16,11 @@ dns: 8.8.8.8
 eth0_ip: 185.141.165.254
 eth0_nm: 255.255.254.0
 vpn: true
+
+nagios_Check_Services:
+  nrpe: true
+  sshd: true
+  named: false
+  dhcpd: false
+  httpd: true
+  swap: false
diff --git a/roles/nagios_server/templates/nagios/hostgroups/checkswap.cfg.j2 
b/roles/nagios_server/templates/nagios/hostgroups/checkswap.cfg.j2
index 9f5bd8c..7da2328 100644
--- a/roles/nagios_server/templates/nagios/hostgroups/checkswap.cfg.j2
+++ b/roles/nagios_server/templates/nagios/hostgroups/checkswap.cfg.j2
@@ -1,6 +1,5 @@
 define hostgroup {
 hostgroup_name  CheckSwap
 alias   Swap-Is-Low
-   members *, !status-fedora2, !registry-cdn, !phx2-gw, 
!ibiblio-gw, !cloud-gw, !bodhost-gw, !coloamer-gw, !dedicated-gw, 
!host1plus-gw, !internetx-gw, !osuosl-gw, !rdu-gw, !rdu-cc-gw, !tummy-gw, 
!proxy05.fedoraproject.org, !mirrorlist-host1plus.fedoraproject.org, 
!download-rdu01.fedoraproject.org, !virthost-rdu01.fedoraproject.org, 
!fas3-01.stg.phx2.fedoraproject.org, !osbs-control01.phx2.fedoraproject.org, {% 
for host in groups['builders'] %}!{{host}},{% endfor %} {% for host in 
groups['builders-stg'] %}!{{host}},{% endfor %} {% for host in groups['cloud'] 
%}!{{host}}, {% endfor %} {% for host in vars['phx2_management_limited'] 
%}!{{host}},{% endfor %}  {% for host in vars['phx2_management_hosts'] 
%}!{{host}}{% if not loop.last %},{% endif %} {% endfor %} 
-
+members {% for host in groups['all'] %}{% if 
hostvars[host].nagios_Check_Services['swap'] == true %}{{host}}{% if not 
loop.last %},{% endif %} {% endfor %}
 }



signature.asc
Description: OpenPGP digital signature
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org

Re: Intro

[Patrick Kuny]

Hi Laura! Welcome to the Fedora Project's Infrastructure team. 
Feel free to drop into #fedora-admin and #fedora-noc on Freenode and get started
interacting with the admin team.

If you'd like to contribute and haven't already, I suggest you read the Getting
Started page on the Infrastructure Wiki:
https://fedoraproject.org/wiki/Infrastructure/GettingStarted

Thanks,
Patrick
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org

Re: intro email

[Patrick Kuny]

Hi Saif! Welcome to the Fedora Project's Infrastructure team. 
Feel free to drop into #fedora-admin and #fedora-noc on Freenode and get 
started interacting with the admin team.

If you'd like to contribute and haven't already, I suggest you read the Getting 
Started page on the Infrastructure Wiki:
https://fedoraproject.org/wiki/Infrastructure/GettingStarted

We definitely use a lot of Ansible automation here on the team and any help 
with it is welcome! Check out the Ansible SOP guide here:
https://fedora-infra-docs.readthedocs.io/en/latest/sysadmin-guide/sops/ansible.html

Thanks,
Patrick
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org

Re: Introduction

[Patrick Kuny]

Hi Dominic! Welcome to the Fedora Project's Infrastructure team. 
Feel free to drop into #fedora-admin and #fedora-noc on Freenode and get 
started interacting with the admin team.

If you'd like to contribute and haven't already, I suggest you read the Getting 
Started page on the Infrastructure Wiki:
https://fedoraproject.org/wiki/Infrastructure/GettingStarted

Thanks,
Patrick
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org

Intro

[Laura Tait]

Hello, my name is Laura and I have been using Fedora off/on for a few years now 
and I am interested in system admin things. I would be interested in helping 
out in the Fedora Project

Kind Regards,

Laura
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org

Introduction

[Dominic P Geevarghese]

Fellow admins/community,

I am Dominic Geevarghese (  4096R/43EACB09 ) , using various distros
including RHEL/CentOS/Fedora/Suse in professional life and Fedora on
personal hardware. I would like to be part of Fedora Infra team with System
Administration focus.

My irc nick is dominicpg and you will find me on most of the #fedora-*
channels. Appreciate any help to kickstart exciting journey with Infra team.

-- 
Regards,
Dominic P Geevarghese
https://fedoraproject.org/wiki/User:Dominicpg
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org

intro email

[saif al-shantir]

Hi  , 
my name is Saif  , i would be glad to join this group  . i am mainly interested 
in system admin & ansible  part .


regards Saif ___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org

Re: Restructuring hooks in dist-git

[Kevin Fenzi]

On 09/07/2017 07:12 AM, Pierre-Yves Chibon wrote:
> Good Morning Everyone,
> ...snip...

> What do you think? I know we are in freeze but this shouldn't impact directly
> anything release-related. Worth trying now or should it wait some more?

I like it and it should hopefully make it easy for me to add grokmirror
hooks. ;)

Can you do it in stg and test and confirm all works ok?

Also, should we renable check perms cron? I don't see that in this
patchset.

I'm somewhat leary of doing this in freeze, but if it looks ok in stg I
suppose it would be ok.

kevin




signature.asc
Description: OpenPGP digital signature
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org

Re: [PATCH] pagure: allow to delete forks

[Kevin Fenzi]

+1 here.

kevin



signature.asc
Description: OpenPGP digital signature
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org

Re: Plans for Thursday 2017-09-07 Fedora Infrastructure Meeting

[Kevin Fenzi]

On 09/07/2017 01:05 AM, Pierre-Yves Chibon wrote:
> On Wed, Sep 06, 2017 at 05:44:41PM -0400, Stephen John Smoogen wrote:
>> Thursday 2017-09-07 the Fedora Infrastructure team will have a meeting
>> in #fedora-meeting at 18:00 UTC. The agenda currently looks as follows
>> on the gobby page. Please add or update as needed.
>>
>> = Introduction =
>> We will use it over the week before the meeting to gather status and info and
>> discussion items and so forth, then use it in the irc meeting to transfer
>> information to the meetbot logs.
>>
>> = Meeting start stuff =
>>
>> #startmeeting Infrastructure (2017-09-07)
>> #meetingname infrastructure
>> #topic aloha
>> #chair smooge relrod nirik abadger1999 dgilmore threebean pingou
>> puiterwijk pbrobinson
> 
> I think we need to add maxamillion to this list now :)
> 
>> = Let new people say hello =
>>
>> #topic New folks introductions
>>
>> = Status / Information / Trivia / Announcements =
>>
>> (We put things here we want others on the team to know, but don't need
>> to discuss)
>> (Please use #info  - your name)
>>
>> #topic announcements and information
>> #info PHX2 Colo Trip, Dec 4th - 9th
>> #info beta freeze started 2017-09-05 - everyone
>> #info Moving .stg. ips ongoing
>> #info DNS breakage happened earlier this week
>> #info NFS slowdowns moved to high IO problem.
> 
> Hm, not sure I understand this last statement on its own.

We are no longer seeing nfs/netapp storage be slow, instead there is
something taking up tons and tons of read BW on it.
(something like 900MB/sec since the 31st). While that isn't being slow
for us, the storage folks want it to stop so we don't mess up
performance for other groups using the same head units. :)

I am not sure whats causing it... smooge and I looked and I found one
problem on bodhi-backend01 (it was mounting /pub twice, once with
NFS4.1). Fixing that didn't change anything. Smooge saw that the
kojipkgs machines were using a fair bit of BW, but thats somewhat
"normal" for them and varnish should be caching it away from nfs.

kevin




signature.asc
Description: OpenPGP digital signature
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org

Re: proxy01 logs

[Stephen John Smoogen]

On 6 September 2017 at 12:30, Kevin Fenzi  wrote:
> On 08/31/2017 04:54 PM, Stephen John Smoogen wrote:
>> Proxy01 paged on a disk space issue this evening. Half of the disk
>> space usage was journal logs. I vacuumed them down to 30 days which
>> gave us about 2GB free. The other disk usage is koji.fedoraproject.org
>> and kojipackages.fedoraproject.org which are using 1.8GB of disk space
>> in the last 24 hours.
>>
>> The lion share of this log is
>>
>> 10.5.125.62 - - [31/Aug/2017:04:02:16 +] "POST /kojihub HTTP/1.1"
>> 200 4118 "-" "koji/1"
>>
>> (with the POST being the size of whatever
>> koji02.phx2.fedoraproject.org. is pushing to koji.fedoraproject.org
>> (which somehow sounds weird).)
>
> Yeah, I am not sure how to fix this, but we have several scripts running
> on koji02 (from koji-gc) that do a lot of queries and remove signed
> copies and old builds that aren't refrenced anymore. In the past, it
> just used localhost so the traffic was local, but now it uses
> proxies->koji01 like everyone else. :(
>
> I think it might be worth making a pair of proxies:
> proxy100 and proxy101 that handle only internal phx2 traffic. This would
> allow us to not mess up internal stuff when there is heavy load on
> proxy01/10.
>
> Thoughts?
>

This sounds like a good idea. proxy01/10 load can get really bogged
with builds while also trying to pull stuff for external customers.


> kevin
>
>
>
>
> ___
> infrastructure mailing list -- infrastructure@lists.fedoraproject.org
> To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
>



-- 
Stephen J Smoogen.
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org

[PATCH 2/2] Fix the check-perms.py script/cron

[Pierre-Yves Chibon]

---
 roles/git/checks/files/check-perms.py | 41 ---
 1 file changed, 24 insertions(+), 17 deletions(-)

diff --git a/roles/git/checks/files/check-perms.py 
b/roles/git/checks/files/check-perms.py
index 7e6501f..8fd8516 100755
--- a/roles/git/checks/files/check-perms.py
+++ b/roles/git/checks/files/check-perms.py
@@ -226,19 +226,25 @@ def set_post_receive_hook_version3(gitdir, fix=False):
 error('%s:  %s is not a directory.' % (gitdir, dest_prefix))
 return False
 
+# Remove the old hooks
+hooks = [
+os.path.join(dest_prefix, 'post-receive-email'),
+os.path.join(dest_prefix, 'post-receive-fedmsg'),
+os.path.join(dest_prefix, 'post-receive-alternativearch'),
+]
+
+for hook in hooks:
+if os.path.exists(hook):
+if not fix:
+error('%s should be removed' % hook)
+else:
+os.unlink(hook)
+
 # Symlink mail notification and fedmsg scripts to post-receive hook
 scripts = {
-'/usr/share/git-core/mail-hooks/gnome-post-receive-email':
-os.path.join(dest_prefix, 'post-receive-email'),
-'/usr/share/git-core/post-receive-fedmsg':
-os.path.join(dest_prefix, 'post-receive-fedmsg'),
-'/usr/share/git-core/post-receive-alternativearch':
-os.path.join(dest_prefix, 'post-receive-alternativearch'),
-
 # This one kicks off all the others.
 '/usr/share/git-core/post-receive-chained':
 os.path.join(gitdir, 'hooks', 'post-receive'),
-
 }
 
 for script, hook in scripts.items():
@@ -250,19 +256,20 @@ def set_post_receive_hook_version3(gitdir, fix=False):
 error('%s: Hook (%s) not installed.' % (gitdir, hook))
 return False
 
-if os.path.exists(hook):
+if not os.path.islink(hook):
+if os.path.exists(hook):
+try:
+os.remove(hook)
+except Exception, e:
+errstr = hasattr(e, 'strerror') and e.strerror or e
+error('%s: Error removing %s: %s' % (gitdir, hook, errstr))
+return False
 try:
-os.remove(hook)
+os.symlink(script, hook)
 except Exception, e:
 errstr = hasattr(e, 'strerror') and e.strerror or e
-error('%s: Error removing %s: %s' % (gitdir, hook, errstr))
+error('%s: Error creating %s symlink: %s' % (gitdir, hook, 
errstr))
 return False
-try:
-os.symlink(script, hook)
-except Exception, e:
-errstr = hasattr(e, 'strerror') and e.strerror or e
-error('%s: Error creating %s symlink: %s' % (gitdir, hook, errstr))
-return False
 
 # We ran the gauntlet.
 return True
-- 
2.9.5
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org

[PATCH 1/2] Add pagure's hook to the post-receive hook and point to the main hooks

[Pierre-Yves Chibon]

---
 roles/git/hooks/files/post-receive-chained | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/roles/git/hooks/files/post-receive-chained 
b/roles/git/hooks/files/post-receive-chained
index 4718f57..e61cb72 100755
--- a/roles/git/hooks/files/post-receive-chained
+++ b/roles/git/hooks/files/post-receive-chained
@@ -4,8 +4,10 @@
 # You need to explicitly add your hook to the following list
 # for it to be invoked.
 pee \
-$GIT_DIR/hooks/post-receive-chained.d/post-receive-fedmsg \
-$GIT_DIR/hooks/post-receive-chained.d/post-receive-alternativearch
+/usr/share/git-core/post-receive-fedmsg \
+/usr/share/git-core/post-receive-alternativearch \
+/usr/lib/python2.7/site-packages/pagure/hooks/files/default_hook.py \
+/usr/lib/python2.7/site-packages/pagure/hooks/files/pagure_hook.py
 
 # We used to send emails directly from the git hook here, but now we send to
 # fedmsg which routes to FMN which routes to packagers and the mailing list.
-- 
2.9.5
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org

Restructuring hooks in dist-git

[Pierre-Yves Chibon]

Good Morning Everyone,

Looking into fixing the current git hook situation on dist-git I came accross
the following architecture and I would like to discuss it with you.

Each repo contains:
- post-receive pointing to /usr/share/git-core/post-receive-chained
- a folder post-receive-chained.d containing:
  - post-receive-alternativearch -> 
/usr/share/git-core/post-receive-alternativearch
  - post-receive-email -> 
/usr/share/git-core/mail-hooks/gnome-post-receive-email
  - post-receive-fedmsg -> /usr/share/git-core/post-receive-fedmsg

And /usr/share/git-core/post-receive-chained contains:

pee \
$GIT_DIR/hooks/post-receive-chained.d/post-receive-fedmsg \
$GIT_DIR/hooks/post-receive-chained.d/post-receive-alternativearch

So each git repo contains symlinks to the different git hooks, but there is no
need for them.

I would propose the following changes:

- Drop post-receive-chained.d entirely from each and every dist-git repo
- Replace /usr/share/git-core/post-receive-chained to be:

pee \
/usr/share/git-core/post-receive-fedmsg \
/usr/share/git-core/post-receive-alternativearch

Adjust the script in ansible in roles/git/checks/files/check-perms.py to
implement these changes.

Bonus, adding/removing hooks would then just become a matter of updating
roles/git/hooks/files/post-receive-chained in ansible.
So we could just add the pagure hooks:
/usr/lib/python2.7/site-packages/pagure/hooks/files/default_hook.py
/usr/lib/python2.7/site-packages/pagure/hooks/files/pagure_hook.py
to it to solve both the lack of logging of commits activity and to add support
for Merges/Fixes/Relates keywords in commit messages.


Finally it looks like the check-perms.py script isn't being run, that may be my
fault (I might have remove the script/cron when cleaning up after deploying
pagure).

What do you think? I know we are in freeze but this shouldn't impact directly
anything release-related. Worth trying now or should it wait some more?


Thanks,
Pierre


signature.asc
Description: PGP signature
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org

Re: Plans for Thursday 2017-09-07 Fedora Infrastructure Meeting

[Pierre-Yves Chibon]

On Wed, Sep 06, 2017 at 05:44:41PM -0400, Stephen John Smoogen wrote:
> Thursday 2017-09-07 the Fedora Infrastructure team will have a meeting
> in #fedora-meeting at 18:00 UTC. The agenda currently looks as follows
> on the gobby page. Please add or update as needed.
> 
> = Introduction =
> We will use it over the week before the meeting to gather status and info and
> discussion items and so forth, then use it in the irc meeting to transfer
> information to the meetbot logs.
> 
> = Meeting start stuff =
> 
> #startmeeting Infrastructure (2017-09-07)
> #meetingname infrastructure
> #topic aloha
> #chair smooge relrod nirik abadger1999 dgilmore threebean pingou
> puiterwijk pbrobinson

I think we need to add maxamillion to this list now :)

> = Let new people say hello =
> 
> #topic New folks introductions
> 
> = Status / Information / Trivia / Announcements =
> 
> (We put things here we want others on the team to know, but don't need
> to discuss)
> (Please use #info  - your name)
> 
> #topic announcements and information
> #info PHX2 Colo Trip, Dec 4th - 9th
> #info beta freeze started 2017-09-05 - everyone
> #info Moving .stg. ips ongoing
> #info DNS breakage happened earlier this week
> #info NFS slowdowns moved to high IO problem.

Hm, not sure I understand this last statement on its own.


Thanks,
Pierre
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org