Re: FBR: Set up docs.teamsilverblue.org

[Mohan Boddu]

LGTM +1

On Tue, Aug 28, 2018 at 7:10 PM Mikolaj Izdebski 
wrote:

> +1
>
> On 08/29/2018 01:06 AM, Patrick Uiterwijk wrote:
> > -BEGIN PGP SIGNED MESSAGE-
> > Hash: SHA512
> >
> > Hi all,
> >
> > So, teamsilverblue pointed their DNS to us without informing us, can I
> get +1s to add a redirect to docs.fp.o?
> >
> > Patrick
> >
> >
> > commit b0f37902db5d46b9aac5af8ebaa92639e9d43f8f
> > Author: Patrick Uiterwijk 
> > Date:   Tue Aug 28 23:03:28 2018 +
> >
> > Add docs.teamsilverblue.org and redirect to docs.fp.o/silverblue
> >
> > Signed-off-by: Patrick Uiterwijk 
> >
> > diff --git a/playbooks/include/proxies-redirects.yml
> b/playbooks/include/proxies-redirects.yml
> > index 91c167b..21b1583 100644
> > - --- a/playbooks/include/proxies-redirects.yml
> > +++ b/playbooks/include/proxies-redirects.yml
> > @@ -762,3 +762,12 @@
> >  website: cloud.fedoraproject.org
> >  path: /fedora-atomic-latest.x86_64.qcow2
> >  target:
> https://download.fedoraproject.org/pub/fedora/linux/releases/22/Cloud/x86_64/Images/Fedora-Cloud-Atomic-22-20150521.x86_64.qcow2
> > +
> > +  # Team Silverblue
> > +  - role: httpd/redirect
> > +shortname: docsteamsilverblue
> > +website: docs.teamsilverblue.org
> > +path: /
> > +target: https://docs.fedoraproject.org/en-US/fedora-silverblue/
> > +tags:
> > +- docs.teamsilverblue.org
> > diff --git a/playbooks/include/proxies-websites.yml
> b/playbooks/include/proxies-websites.yml
> > index 25ca1e4..8013c53 100644
> > - --- a/playbooks/include/proxies-websites.yml
> > +++ b/playbooks/include/proxies-websites.yml
> > @@ -418,6 +418,14 @@
> >  - whatcanidoforfedora.org
> >
> >- role: httpd/website
> > +site_name: docs.teamsilverblue.org
> > +ssl: true
> > +sslonly: true
> > +certbot: true
> > +tags:
> > +- docs.teamsilverblue.org
> > +
> > +  - role: httpd/website
> >  site_name: fedoramagazine.org
> >  server_aliases: [www.fedoramagazine.org stg.fedoramagazine.org]
> >  cert_name: fedoramagazine.org
> >
> > -BEGIN PGP SIGNATURE-
> >
> > iQIcBAEBCgAGBQJbhdVoAAoJEIZXmA2atR5QZTUP/RkmcVpQ4a0wbu3rFe/PC5P/
> > egb/tttT0KP0S3TXwUsNkLxaaZK/Une/l1rZU9a+8Y8TOw86THKWMlEp+15l+R9c
> > /+yShpSdJm6C+/fKlG+ajYOtq0pnrDVwyCEiTEz0CVXaXxoMToc/VXgtid7ORO0t
> > XRA6YWCjxs/eN5BkQmlcap0E5Oq2peGvuD3faxNNj8L1eoEDADTAy4AtvRTxOXay
> > PiXWg1bNTauIOEqXv57XZ51snFnf6qjqeok8uxKDKmpjp3ZOOYxvubdMRW8bJ+vh
> > MARovgRnUlAc6paeVdNrNi/FCfstT7W9Ht6Ep5zAZofFuEYZ4yLYbM16RAQQSmp7
> > p8m0zqRVXVtMnzRtzyq+V140bqZOJHgA4kyzuFW07IKLmaAGwqKswX0YXKCnyx7G
> > yTY57Q/P/NtcOQeeTDzBH63/Idi/ba2Ysq0zRRQ40E+ItYEeOGCuS+B5SWN+PEhf
> > qDo7Rxdv0SFI6H2vK8ePuTT41/I+MIq6QuKWxC4cC5oBAphyKn9oeNtH0FyvY+Sc
> > WV36yBQJWl2dHtTBslcTL+MdhZbRIDApZH5iPsLTMHRMXtksMI/ZVVRHQh4T7iuK
> > AmwQbaPH+Y9y/SPW4/9c+Fcya81vhDXxqtoYVwJtpEG9pA8f7L2dx2WWpewOSv1W
> > +rCW/b1S6CRZNxVLxt7x
> > =R99I
> > -END PGP SIGNATURE-
> > ___
> > infrastructure mailing list -- infrastructure@lists.fedoraproject.org
> > To unsubscribe send an email to
> infrastructure-le...@lists.fedoraproject.org
> > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
> > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > List Archives:
> https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org
> >
>
> --
> Mikolaj Izdebski
> Senior Software Engineer, Red Hat
> IRC: mizdebsk
> ___
> infrastructure mailing list -- infrastructure@lists.fedoraproject.org
> To unsubscribe send an email to
> infrastructure-le...@lists.fedoraproject.org
> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org
>
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org

Re: FBR: Set up docs.teamsilverblue.org

[Mikolaj Izdebski]

+1

On 08/29/2018 01:06 AM, Patrick Uiterwijk wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
> 
> Hi all,
> 
> So, teamsilverblue pointed their DNS to us without informing us, can I get 
> +1s to add a redirect to docs.fp.o?
> 
> Patrick
> 
> 
> commit b0f37902db5d46b9aac5af8ebaa92639e9d43f8f
> Author: Patrick Uiterwijk 
> Date:   Tue Aug 28 23:03:28 2018 +
> 
> Add docs.teamsilverblue.org and redirect to docs.fp.o/silverblue
> 
> Signed-off-by: Patrick Uiterwijk 
> 
> diff --git a/playbooks/include/proxies-redirects.yml 
> b/playbooks/include/proxies-redirects.yml
> index 91c167b..21b1583 100644
> - --- a/playbooks/include/proxies-redirects.yml
> +++ b/playbooks/include/proxies-redirects.yml
> @@ -762,3 +762,12 @@
>  website: cloud.fedoraproject.org
>  path: /fedora-atomic-latest.x86_64.qcow2
>  target: 
> https://download.fedoraproject.org/pub/fedora/linux/releases/22/Cloud/x86_64/Images/Fedora-Cloud-Atomic-22-20150521.x86_64.qcow2
> +
> +  # Team Silverblue
> +  - role: httpd/redirect
> +shortname: docsteamsilverblue
> +website: docs.teamsilverblue.org
> +path: /
> +target: https://docs.fedoraproject.org/en-US/fedora-silverblue/
> +tags:
> +- docs.teamsilverblue.org
> diff --git a/playbooks/include/proxies-websites.yml 
> b/playbooks/include/proxies-websites.yml
> index 25ca1e4..8013c53 100644
> - --- a/playbooks/include/proxies-websites.yml
> +++ b/playbooks/include/proxies-websites.yml
> @@ -418,6 +418,14 @@
>  - whatcanidoforfedora.org
>  
>- role: httpd/website
> +site_name: docs.teamsilverblue.org
> +ssl: true
> +sslonly: true
> +certbot: true
> +tags:
> +- docs.teamsilverblue.org
> +
> +  - role: httpd/website
>  site_name: fedoramagazine.org
>  server_aliases: [www.fedoramagazine.org stg.fedoramagazine.org]
>  cert_name: fedoramagazine.org
> 
> -BEGIN PGP SIGNATURE-
> 
> iQIcBAEBCgAGBQJbhdVoAAoJEIZXmA2atR5QZTUP/RkmcVpQ4a0wbu3rFe/PC5P/
> egb/tttT0KP0S3TXwUsNkLxaaZK/Une/l1rZU9a+8Y8TOw86THKWMlEp+15l+R9c
> /+yShpSdJm6C+/fKlG+ajYOtq0pnrDVwyCEiTEz0CVXaXxoMToc/VXgtid7ORO0t
> XRA6YWCjxs/eN5BkQmlcap0E5Oq2peGvuD3faxNNj8L1eoEDADTAy4AtvRTxOXay
> PiXWg1bNTauIOEqXv57XZ51snFnf6qjqeok8uxKDKmpjp3ZOOYxvubdMRW8bJ+vh
> MARovgRnUlAc6paeVdNrNi/FCfstT7W9Ht6Ep5zAZofFuEYZ4yLYbM16RAQQSmp7
> p8m0zqRVXVtMnzRtzyq+V140bqZOJHgA4kyzuFW07IKLmaAGwqKswX0YXKCnyx7G
> yTY57Q/P/NtcOQeeTDzBH63/Idi/ba2Ysq0zRRQ40E+ItYEeOGCuS+B5SWN+PEhf
> qDo7Rxdv0SFI6H2vK8ePuTT41/I+MIq6QuKWxC4cC5oBAphyKn9oeNtH0FyvY+Sc
> WV36yBQJWl2dHtTBslcTL+MdhZbRIDApZH5iPsLTMHRMXtksMI/ZVVRHQh4T7iuK
> AmwQbaPH+Y9y/SPW4/9c+Fcya81vhDXxqtoYVwJtpEG9pA8f7L2dx2WWpewOSv1W
> +rCW/b1S6CRZNxVLxt7x
> =R99I
> -END PGP SIGNATURE-
> ___
> infrastructure mailing list -- infrastructure@lists.fedoraproject.org
> To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: 
> https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org
> 

-- 
Mikolaj Izdebski
Senior Software Engineer, Red Hat
IRC: mizdebsk
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org

Re: FBR: Set up docs.teamsilverblue.org

[Kevin Fenzi]

+1 seems fine to me.

kevin



signature.asc
Description: OpenPGP digital signature
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org

FBR: Set up docs.teamsilverblue.org

[Patrick Uiterwijk]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Hi all,

So, teamsilverblue pointed their DNS to us without informing us, can I get +1s 
to add a redirect to docs.fp.o?

Patrick


commit b0f37902db5d46b9aac5af8ebaa92639e9d43f8f
Author: Patrick Uiterwijk 
Date:   Tue Aug 28 23:03:28 2018 +

Add docs.teamsilverblue.org and redirect to docs.fp.o/silverblue

Signed-off-by: Patrick Uiterwijk 

diff --git a/playbooks/include/proxies-redirects.yml 
b/playbooks/include/proxies-redirects.yml
index 91c167b..21b1583 100644
- --- a/playbooks/include/proxies-redirects.yml
+++ b/playbooks/include/proxies-redirects.yml
@@ -762,3 +762,12 @@
 website: cloud.fedoraproject.org
 path: /fedora-atomic-latest.x86_64.qcow2
 target: 
https://download.fedoraproject.org/pub/fedora/linux/releases/22/Cloud/x86_64/Images/Fedora-Cloud-Atomic-22-20150521.x86_64.qcow2
+
+  # Team Silverblue
+  - role: httpd/redirect
+shortname: docsteamsilverblue
+website: docs.teamsilverblue.org
+path: /
+target: https://docs.fedoraproject.org/en-US/fedora-silverblue/
+tags:
+- docs.teamsilverblue.org
diff --git a/playbooks/include/proxies-websites.yml 
b/playbooks/include/proxies-websites.yml
index 25ca1e4..8013c53 100644
- --- a/playbooks/include/proxies-websites.yml
+++ b/playbooks/include/proxies-websites.yml
@@ -418,6 +418,14 @@
 - whatcanidoforfedora.org
 
   - role: httpd/website
+site_name: docs.teamsilverblue.org
+ssl: true
+sslonly: true
+certbot: true
+tags:
+- docs.teamsilverblue.org
+
+  - role: httpd/website
 site_name: fedoramagazine.org
 server_aliases: [www.fedoramagazine.org stg.fedoramagazine.org]
 cert_name: fedoramagazine.org

-BEGIN PGP SIGNATURE-

iQIcBAEBCgAGBQJbhdVoAAoJEIZXmA2atR5QZTUP/RkmcVpQ4a0wbu3rFe/PC5P/
egb/tttT0KP0S3TXwUsNkLxaaZK/Une/l1rZU9a+8Y8TOw86THKWMlEp+15l+R9c
/+yShpSdJm6C+/fKlG+ajYOtq0pnrDVwyCEiTEz0CVXaXxoMToc/VXgtid7ORO0t
XRA6YWCjxs/eN5BkQmlcap0E5Oq2peGvuD3faxNNj8L1eoEDADTAy4AtvRTxOXay
PiXWg1bNTauIOEqXv57XZ51snFnf6qjqeok8uxKDKmpjp3ZOOYxvubdMRW8bJ+vh
MARovgRnUlAc6paeVdNrNi/FCfstT7W9Ht6Ep5zAZofFuEYZ4yLYbM16RAQQSmp7
p8m0zqRVXVtMnzRtzyq+V140bqZOJHgA4kyzuFW07IKLmaAGwqKswX0YXKCnyx7G
yTY57Q/P/NtcOQeeTDzBH63/Idi/ba2Ysq0zRRQ40E+ItYEeOGCuS+B5SWN+PEhf
qDo7Rxdv0SFI6H2vK8ePuTT41/I+MIq6QuKWxC4cC5oBAphyKn9oeNtH0FyvY+Sc
WV36yBQJWl2dHtTBslcTL+MdhZbRIDApZH5iPsLTMHRMXtksMI/ZVVRHQh4T7iuK
AmwQbaPH+Y9y/SPW4/9c+Fcya81vhDXxqtoYVwJtpEG9pA8f7L2dx2WWpewOSv1W
+rCW/b1S6CRZNxVLxt7x
=R99I
-END PGP SIGNATURE-
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org

Re: FBR: Autosigning for post bodhi activation of F29

[Kevin Fenzi]

+1

kevin



signature.asc
Description: OpenPGP digital signature
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org

FBR: Autosigning for post bodhi activation of F29

[Mohan Boddu]

--- a/roles/robosignatory/files/robosignatory.production.py
+++ b/roles/robosignatory/files/robosignatory.production.py
@@ -132,28 +132,21 @@ config = {
 "keyid": "cfc659b9",
 "type": "modular"
 },
-{
-"from": "f29-pending",
-"to": "f29",
-"key": "fedora-29",
-"keyid": "429476b4"
-},
+
+# Gated bodhi updates
 {
 "from": "f29-modular-signing-pending",
-"to": "f29-modular",
+"to": "f29-modular-updates-testing-pending",
 "key": "fedora-29",
 "keyid": "429476b4",
 "type": "modular"
 },
 {
-"from": "f29-modular-updates-candidate",
-"to": "f29-modular",
+"from": "f29-signing-pending",
+"to": "f29-updates-testing-pending",
 "key": "fedora-29",
-"keyid": "429476b4",
-"type": "modular"
+"keyid": "429476b4"
 },
-
-# Gated bodhi updates
 {
 "from": "f28-modular-signing-pending",
 "to": "f28-modular-updates-testing-pending",
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org

Re: FBR: Fix for new-updates-sync

[Dusty Mabe]

On 08/28/2018 01:14 PM, Mohan Boddu wrote:
> @dustymabe, Yes (throwing it under else part), since we want it to calculate 
> the path
> using os.path.realpath(source_path) only if its rawhide,
> or else use os.readlink(source_path).
> 
> Just for understanding purposes:
> $ ls -la /mnt/koji/compose/updates/f28-updates
> lrwxrwxrwx. 1 apache apache 54 Aug 27 00:54 
> /mnt/koji/compose/updates/f28-updates -> 
> /mnt/koji/compose/updates/Fedora-28-updates-20180826.0

wow. I actually think that is a bug. we should probably be using a relative 
symlink here
because if the filesystem was mounted anywhere else then the symlink would be 
broken.

Copying randy/lubos in case they have opinons


> 
> $ls -la /mnt/koji/compose/rawhide/latest-Fedora-Rawhide
> lrwxrwxrwx. 1 root root 27 Aug 27 17:09 
> /mnt/koji/compose/rawhide/latest-Fedora-Rawhide -> Fedora-Rawhide-20180827.n.0

___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org

Re: FBR: Fix for new-updates-sync

[Stephen John Smoogen]

Thanks for the explanation. I am +1 as it can be backed out
On Tue, 28 Aug 2018 at 13:14, Mohan Boddu  wrote:
>
> @dustymabe, Yes (throwing it under else part), since we want it to calculate 
> the path
> using os.path.realpath(source_path) only if its rawhide,
> or else use os.readlink(source_path).
>
> Just for understanding purposes:
> $ ls -la /mnt/koji/compose/updates/f28-updates
> lrwxrwxrwx. 1 apache apache 54 Aug 27 00:54 
> /mnt/koji/compose/updates/f28-updates -> 
> /mnt/koji/compose/updates/Fedora-28-updates-20180826.0
>
> $ls -la /mnt/koji/compose/rawhide/latest-Fedora-Rawhide
> lrwxrwxrwx. 1 root root 27 Aug 27 17:09 
> /mnt/koji/compose/rawhide/latest-Fedora-Rawhide -> Fedora-Rawhide-20180827.n.0
>
> On Tue, Aug 28, 2018 at 1:10 PM Dusty Mabe  wrote:
>>
>> LGTM - one comment below
>>
>> On 08/28/2018 12:59 PM, Mohan Boddu wrote:
>> > Better wording of the comment:
>> >
>> > diff --git a/roles/bodhi2/backend/files/new-updates-sync 
>> > b/roles/bodhi2/backend/files/new-updates-sync
>> > index 3619e6c..ae78b45 100755
>> > --- a/roles/bodhi2/backend/files/new-updates-sync
>> > +++ b/roles/bodhi2/backend/files/new-updates-sync
>> > @@ -367,10 +367,14 @@ def determine_last_link(release, repo):
>> >  if repo == 'rawhide':
>> >  source_path = os.path.join(RAWHIDESOURCE,
>> > 
>> > RELEASES[release]['repos'][repo]['from'])
>> > +#Since latest-Fedora-Rawhide is a symlink pointing to just the
>> > +#compose dir rather than its full path, we need the absolute path
>> > +#of the compose rather than relative path
>> > +target = os.path.realpath(source_path)
>> >  else:
>> >  source_path = os.path.join(SOURCE,
>> > 
>> > RELEASES[release]['repos'][repo]['from'])
>> > -target = os.readlink(source_path)
>> > +target = os.readlink(source_path)
>>
>> ^^ this was a spacing change?
>>
>>
>> >  logger.info ('Release %s, repo %s, target %s', 
>> > release, repo, target)
>> >  RELEASES[release]['repos'][repo]['from'] = target
>> >  return target
>
> ___
> infrastructure mailing list -- infrastructure@lists.fedoraproject.org
> To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: 
> https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org



-- 
Stephen J Smoogen.
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org

Re: FBR: Fix for new-updates-sync

[Mohan Boddu]

@dustymabe, Yes (throwing it under else part), since we want it to
calculate the path
using os.path.realpath(source_path) only if its rawhide,
or else use os.readlink(source_path).

Just for understanding purposes:
$ ls -la /mnt/koji/compose/updates/f28-updates
lrwxrwxrwx. 1 apache apache 54 Aug 27 00:54
/mnt/koji/compose/updates/f28-updates ->
/mnt/koji/compose/updates/Fedora-28-updates-20180826.0

$ls -la /mnt/koji/compose/rawhide/latest-Fedora-Rawhide
lrwxrwxrwx. 1 root root 27 Aug 27 17:09
/mnt/koji/compose/rawhide/latest-Fedora-Rawhide ->
Fedora-Rawhide-20180827.n.0

On Tue, Aug 28, 2018 at 1:10 PM Dusty Mabe  wrote:

> LGTM - one comment below
>
> On 08/28/2018 12:59 PM, Mohan Boddu wrote:
> > Better wording of the comment:
> >
> > diff --git a/roles/bodhi2/backend/files/new-updates-sync
> b/roles/bodhi2/backend/files/new-updates-sync
> > index 3619e6c..ae78b45 100755
> > --- a/roles/bodhi2/backend/files/new-updates-sync
> > +++ b/roles/bodhi2/backend/files/new-updates-sync
> > @@ -367,10 +367,14 @@ def determine_last_link(release, repo):
> >  if repo == 'rawhide':
> >  source_path = os.path.join(RAWHIDESOURCE,
> >
> RELEASES[release]['repos'][repo]['from'])
> > +#Since latest-Fedora-Rawhide is a symlink pointing to just the
> > +#compose dir rather than its full path, we need the absolute
> path
> > +#of the compose rather than relative path
> > +target = os.path.realpath(source_path)
> >  else:
> >  source_path = os.path.join(SOURCE,
> >
> RELEASES[release]['repos'][repo]['from'])
> > -target = os.readlink(source_path)
> > +target = os.readlink(source_path)
>
> ^^ this was a spacing change?
>
>
> >  logger.info ('Release %s, repo %s, target %s',
> release, repo, target)
> >  RELEASES[release]['repos'][repo]['from'] = target
> >  return target
>
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org

Re: FBR: Fix for new-updates-sync

[Dusty Mabe]

LGTM - one comment below

On 08/28/2018 12:59 PM, Mohan Boddu wrote:
> Better wording of the comment:
> 
> diff --git a/roles/bodhi2/backend/files/new-updates-sync 
> b/roles/bodhi2/backend/files/new-updates-sync
> index 3619e6c..ae78b45 100755
> --- a/roles/bodhi2/backend/files/new-updates-sync
> +++ b/roles/bodhi2/backend/files/new-updates-sync
> @@ -367,10 +367,14 @@ def determine_last_link(release, repo):
>      if repo == 'rawhide':
>          source_path = os.path.join(RAWHIDESOURCE,
>                                     RELEASES[release]['repos'][repo]['from'])
> +        #Since latest-Fedora-Rawhide is a symlink pointing to just the
> +        #compose dir rather than its full path, we need the absolute path
> +        #of the compose rather than relative path
> +        target = os.path.realpath(source_path)
>      else:
>          source_path = os.path.join(SOURCE,
>                                     RELEASES[release]['repos'][repo]['from'])
> -    target = os.readlink(source_path)
> +        target = os.readlink(source_path)

^^ this was a spacing change? 


>      logger.info ('Release %s, repo %s, target %s', 
> release, repo, target)
>      RELEASES[release]['repos'][repo]['from'] = target
>      return target
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org

Re: FBR: Fix for new-updates-sync

[Mohan Boddu]

Better wording of the comment:

diff --git a/roles/bodhi2/backend/files/new-updates-sync
b/roles/bodhi2/backend/files/new-updates-sync
index 3619e6c..ae78b45 100755
--- a/roles/bodhi2/backend/files/new-updates-sync
+++ b/roles/bodhi2/backend/files/new-updates-sync
@@ -367,10 +367,14 @@ def determine_last_link(release, repo):
 if repo == 'rawhide':
 source_path = os.path.join(RAWHIDESOURCE,

RELEASES[release]['repos'][repo]['from'])
+#Since latest-Fedora-Rawhide is a symlink pointing to just the
+#compose dir rather than its full path, we need the absolute path
+#of the compose rather than relative path
+target = os.path.realpath(source_path)
 else:
 source_path = os.path.join(SOURCE,

RELEASES[release]['repos'][repo]['from'])
-target = os.readlink(source_path)
+target = os.readlink(source_path)
 logger.info('Release %s, repo %s, target %s', release, repo, target)
 RELEASES[release]['repos'][repo]['from'] = target
 return target


On Tue, Aug 28, 2018 at 12:51 PM Mohan Boddu  wrote:

> diff --git a/roles/bodhi2/backend/files/new-updates-sync
> b/roles/bodhi2/backend/files/new-updates-sync
> index 3619e6c..5f00b29 100755
> --- a/roles/bodhi2/backend/files/new-updates-sync
> +++ b/roles/bodhi2/backend/files/new-updates-sync
> @@ -367,10 +367,13 @@ def determine_last_link(release, repo):
>  if repo == 'rawhide':
>  source_path = os.path.join(RAWHIDESOURCE,
>
> RELEASES[release]['repos'][repo]['from'])
> +#Since latest-Fedora-Rawhide is not a symlink
> +#we need the absolute path
> +target = os.path.realpath(source_path)
>  else:
>  source_path = os.path.join(SOURCE,
>
> RELEASES[release]['repos'][repo]['from'])
> -target = os.readlink(source_path)
> +target = os.readlink(source_path)
>  logger.info('Release %s, repo %s, target %s', release, repo, target)
>  RELEASES[release]['repos'][repo]['from'] = target
>  return target
>
>
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org

FBR: Fix for new-updates-sync

[Mohan Boddu]

diff --git a/roles/bodhi2/backend/files/new-updates-sync
b/roles/bodhi2/backend/files/new-updates-sync
index 3619e6c..5f00b29 100755
--- a/roles/bodhi2/backend/files/new-updates-sync
+++ b/roles/bodhi2/backend/files/new-updates-sync
@@ -367,10 +367,13 @@ def determine_last_link(release, repo):
 if repo == 'rawhide':
 source_path = os.path.join(RAWHIDESOURCE,

RELEASES[release]['repos'][repo]['from'])
+#Since latest-Fedora-Rawhide is not a symlink
+#we need the absolute path
+target = os.path.realpath(source_path)
 else:
 source_path = os.path.join(SOURCE,

RELEASES[release]['repos'][repo]['from'])
-target = os.readlink(source_path)
+target = os.readlink(source_path)
 logger.info('Release %s, repo %s, target %s', release, repo, target)
 RELEASES[release]['repos'][repo]['from'] = target
 return target
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org

Re: FBR: Greenwave config update for F29

[Kevin Fenzi]

+1

kevin



signature.asc
Description: OpenPGP digital signature
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org

Re: FBR: Greenwave config update for F29

[Mohan Boddu]

Adding modular pieces as well:

diff --git a/roles/openshift-apps/greenwave/templates/configmap.yml
b/roles/openshift-apps/greenwave/templ
index dd297c4..05041da 100644
--- a/roles/openshift-apps/greenwave/templates/configmap.yml
+++ b/roles/openshift-apps/greenwave/templates/configmap.yml
@@ -97,6 +97,7 @@ data:
 --- !Policy
 id: "taskotron_release_critical_tasks_for_testing"
 product_versions:
+  - fedora-29
   - fedora-28
   - fedora-27
   - fedora-26
@@ -114,6 +115,7 @@ data:
 --- !Policy
 id: "taskotron_release_critical_tasks_for_stable"
 product_versions:
+  - fedora-29
   - fedora-28
   - fedora-27
   - fedora-26
@@ -131,6 +133,7 @@ data:
 --- !Policy
 id: "no_requirements_testing"
 product_versions:
+  - fedora-29-modular
   - fedora-28-modular
   - fedora-epel-7
   - fedora-epel-6
@@ -142,6 +145,7 @@ data:
 --- !Policy
 id: "no_requirements_for_stable"
 product_versions:
+  - fedora-29-modular
   - fedora-28-modular
   - fedora-epel-7
   - fedora-epel-6
@@ -155,6 +159,7 @@ data:
 # http://fedoraproject.org/wiki/CI
 id: "atomic_ci_pipeline_results"
 product_versions:
+  - fedora-29
   - fedora-28
   - fedora-27
   - fedora-26
@@ -174,6 +179,7 @@ data:
 # http://fedoraproject.org/wiki/CI
 id: "atomic_ci_pipeline_results_stable"
 product_versions:
+  - fedora-29
   - fedora-28
   - fedora-27
   - fedora-26


On Tue, Aug 28, 2018 at 10:10 AM Ralph Bean  wrote:

> LGTM.  Easy to roll back if it is incorrect.  +1
>
> On Tue, Aug 28, 2018 at 10:05:08AM -0400, Mohan Boddu wrote:
> > diff --git a/roles/openshift-apps/greenwave/templates/configmap.yml
> > b/roles/openshift-apps/greenwave/templ
> > index dd297c4..694ca3c 100644
> > --- a/roles/openshift-apps/greenwave/templates/configmap.yml
> > +++ b/roles/openshift-apps/greenwave/templates/configmap.yml
> > @@ -97,6 +97,7 @@ data:
> >  --- !Policy
> >  id: "taskotron_release_critical_tasks_for_testing"
> >  product_versions:
> > +  - fedora-29
> >- fedora-28
> >- fedora-27
> >- fedora-26
> > @@ -114,6 +115,7 @@ data:
> >  --- !Policy
> >  id: "taskotron_release_critical_tasks_for_stable"
> >  product_versions:
> > +  - fedora-29
> >- fedora-28
> >- fedora-27
> >- fedora-26
> > @@ -155,6 +157,7 @@ data:
> >  # http://fedoraproject.org/wiki/CI
> >  id: "atomic_ci_pipeline_results"
> >  product_versions:
> > +  - fedora-29
> >- fedora-28
> >- fedora-27
> >- fedora-26
> > @@ -174,6 +177,7 @@ data:
> >  # http://fedoraproject.org/wiki/CI
> >  id: "atomic_ci_pipeline_results_stable"
> >  product_versions:
> > +  - fedora-29
> >- fedora-28
> >- fedora-27
> >- fedora-26
>
> > ___
> > infrastructure mailing list -- infrastructure@lists.fedoraproject.org
> > To unsubscribe send an email to
> infrastructure-le...@lists.fedoraproject.org
> > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
> > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > List Archives:
> https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org
>
> ___
> infrastructure mailing list -- infrastructure@lists.fedoraproject.org
> To unsubscribe send an email to
> infrastructure-le...@lists.fedoraproject.org
> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org
>
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org

Re: FBR: Greenwave config update for F29

[Ralph Bean]

LGTM.  Easy to roll back if it is incorrect.  +1

On Tue, Aug 28, 2018 at 10:05:08AM -0400, Mohan Boddu wrote:
> diff --git a/roles/openshift-apps/greenwave/templates/configmap.yml
> b/roles/openshift-apps/greenwave/templ
> index dd297c4..694ca3c 100644
> --- a/roles/openshift-apps/greenwave/templates/configmap.yml
> +++ b/roles/openshift-apps/greenwave/templates/configmap.yml
> @@ -97,6 +97,7 @@ data:
>  --- !Policy
>  id: "taskotron_release_critical_tasks_for_testing"
>  product_versions:
> +  - fedora-29
>- fedora-28
>- fedora-27
>- fedora-26
> @@ -114,6 +115,7 @@ data:
>  --- !Policy
>  id: "taskotron_release_critical_tasks_for_stable"
>  product_versions:
> +  - fedora-29
>- fedora-28
>- fedora-27
>- fedora-26
> @@ -155,6 +157,7 @@ data:
>  # http://fedoraproject.org/wiki/CI
>  id: "atomic_ci_pipeline_results"
>  product_versions:
> +  - fedora-29
>- fedora-28
>- fedora-27
>- fedora-26
> @@ -174,6 +177,7 @@ data:
>  # http://fedoraproject.org/wiki/CI
>  id: "atomic_ci_pipeline_results_stable"
>  product_versions:
> +  - fedora-29
>- fedora-28
>- fedora-27
>- fedora-26

> ___
> infrastructure mailing list -- infrastructure@lists.fedoraproject.org
> To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: 
> https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org



signature.asc
Description: PGP signature
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org

FBR: Greenwave config update for F29

[Mohan Boddu]

diff --git a/roles/openshift-apps/greenwave/templates/configmap.yml
b/roles/openshift-apps/greenwave/templ
index dd297c4..694ca3c 100644
--- a/roles/openshift-apps/greenwave/templates/configmap.yml
+++ b/roles/openshift-apps/greenwave/templates/configmap.yml
@@ -97,6 +97,7 @@ data:
 --- !Policy
 id: "taskotron_release_critical_tasks_for_testing"
 product_versions:
+  - fedora-29
   - fedora-28
   - fedora-27
   - fedora-26
@@ -114,6 +115,7 @@ data:
 --- !Policy
 id: "taskotron_release_critical_tasks_for_stable"
 product_versions:
+  - fedora-29
   - fedora-28
   - fedora-27
   - fedora-26
@@ -155,6 +157,7 @@ data:
 # http://fedoraproject.org/wiki/CI
 id: "atomic_ci_pipeline_results"
 product_versions:
+  - fedora-29
   - fedora-28
   - fedora-27
   - fedora-26
@@ -174,6 +177,7 @@ data:
 # http://fedoraproject.org/wiki/CI
 id: "atomic_ci_pipeline_results_stable"
 product_versions:
+  - fedora-29
   - fedora-28
   - fedora-27
   - fedora-26
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org