Re: Freeze Break Request: koji update for all builders
On Thu, Aug 27, 2020 at 2:37 PM kevin wrote: > > The koji 1.22.0 update added handling for the '--extra-boot-args' > kickstart option. UNfortunately, this support wasn't working right and > causes all our images specifying such options to fail. > > The good news is that the fix is just a one-liner: > > -cmd.extend(['--extra-boot-args', > -'--append=\"%s\"' % b_append]) > +cmd.extend(['--extra-boot-args', '\"%s\"' % b_append]) > > I've built a new rpm with this patch applied and would like to do a > freeze break to apply it to the 'builders' ansible group. > (This applies to kojid). > > See: > https://pagure.io/koji/pull-request/2452 > https://pagure.io/fedora-infrastructure/issue/9271 > > +1s? > LGTM! +1 -- 真実はいつも一つ！/ Always, there's only one truth! ___ infrastructure mailing list -- infrastructure@lists.fedoraproject.org To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org
Re: Freeze Break Request: koji update for all builders
+1 On Thu, 27 Aug 2020 at 16:40, Mohan Boddu wrote: > On Thu, Aug 27, 2020 at 2:36 PM kevin wrote: > > > > The koji 1.22.0 update added handling for the '--extra-boot-args' > > kickstart option. UNfortunately, this support wasn't working right and > > causes all our images specifying such options to fail. > > > > The good news is that the fix is just a one-liner: > > > > -cmd.extend(['--extra-boot-args', > > -'--append=\"%s\"' % b_append]) > > +cmd.extend(['--extra-boot-args', '\"%s\"' % b_append]) > > LGTM +1 > > > > > I've built a new rpm with this patch applied and would like to do a > > freeze break to apply it to the 'builders' ansible group. > > (This applies to kojid). > > > > See: > > https://pagure.io/koji/pull-request/2452 > > https://pagure.io/fedora-infrastructure/issue/9271 > > > > +1s? > > > > kevin > > ___ > > infrastructure mailing list -- infrastructure@lists.fedoraproject.org > > To unsubscribe send an email to > infrastructure-le...@lists.fedoraproject.org > > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > > List Archives: > https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org > ___ > infrastructure mailing list -- infrastructure@lists.fedoraproject.org > To unsubscribe send an email to > infrastructure-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org > -- Stephen J Smoogen. ___ infrastructure mailing list -- infrastructure@lists.fedoraproject.org To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org
Re: Freeze Break Request: koji update for all builders
On Thu, Aug 27, 2020 at 2:36 PM kevin wrote: > > The koji 1.22.0 update added handling for the '--extra-boot-args' > kickstart option. UNfortunately, this support wasn't working right and > causes all our images specifying such options to fail. > > The good news is that the fix is just a one-liner: > > -cmd.extend(['--extra-boot-args', > -'--append=\"%s\"' % b_append]) > +cmd.extend(['--extra-boot-args', '\"%s\"' % b_append]) LGTM +1 > > I've built a new rpm with this patch applied and would like to do a > freeze break to apply it to the 'builders' ansible group. > (This applies to kojid). > > See: > https://pagure.io/koji/pull-request/2452 > https://pagure.io/fedora-infrastructure/issue/9271 > > +1s? > > kevin > ___ > infrastructure mailing list -- infrastructure@lists.fedoraproject.org > To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org ___ infrastructure mailing list -- infrastructure@lists.fedoraproject.org To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org
Re: Freeze Break Request: koji update for all builders
> The koji 1.22.0 update added handling for the '--extra-boot-args' > kickstart option. UNfortunately, this support wasn't working right and > causes all our images specifying such options to fail. > > The good news is that the fix is just a one-liner: > > -cmd.extend(['--extra-boot-args', > -'--append=\"%s\"' % b_append]) > +cmd.extend(['--extra-boot-args', '\"%s\"' % b_append]) > > I've built a new rpm with this patch applied and would like to do a > freeze break to apply it to the 'builders' ansible group. > (This applies to kojid). Seems fine +1 > See: > https://pagure.io/koji/pull-request/2452 > https://pagure.io/fedora-infrastructure/issue/9271 > > +1s? > > kevin > ___ > infrastructure mailing list -- infrastructure@lists.fedoraproject.org > To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org ___ infrastructure mailing list -- infrastructure@lists.fedoraproject.org To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org
Freeze Break Request: koji update for all builders
The koji 1.22.0 update added handling for the '--extra-boot-args' kickstart option. UNfortunately, this support wasn't working right and causes all our images specifying such options to fail. The good news is that the fix is just a one-liner: -cmd.extend(['--extra-boot-args', -'--append=\"%s\"' % b_append]) +cmd.extend(['--extra-boot-args', '\"%s\"' % b_append]) I've built a new rpm with this patch applied and would like to do a freeze break to apply it to the 'builders' ansible group. (This applies to kojid). See: https://pagure.io/koji/pull-request/2452 https://pagure.io/fedora-infrastructure/issue/9271 +1s? kevin signature.asc Description: PGP signature ___ infrastructure mailing list -- infrastructure@lists.fedoraproject.org To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org
