[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update
== Series Details == Series: drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update URL : https://patchwork.freedesktop.org/series/46104/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4449_full -> Patchwork_9580_full = == Summary - FAILURE == Serious unknown changes coming with Patchwork_9580_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_9580_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. == Possible new issues == Here are the unknown changes that may have been introduced in Patchwork_9580_full: === IGT changes === Possible regressions igt@kms_flip_tiling@flip-x-tiled: shard-glk: PASS -> FAIL igt@kms_universal_plane@cursor-fb-leak-pipe-c: shard-apl: PASS -> FAIL Warnings igt@gem_exec_schedule@deep-bsd2: shard-kbl: PASS -> SKIP +2 igt@perf_pmu@rc6: shard-kbl: SKIP -> PASS == Known issues == Here are the changes found in Patchwork_9580_full that come from known issues: === IGT changes === Issues hit igt@kms_busy@extended-pageflip-hang-oldfb-render-a: shard-snb: PASS -> INCOMPLETE (fdo#105411) igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic: shard-glk: PASS -> FAIL (fdo#105454, fdo#106509) igt@kms_flip@2x-plain-flip-ts-check-interruptible: shard-glk: PASS -> FAIL (fdo#100368) igt@kms_setmode@basic: shard-apl: PASS -> FAIL (fdo#99912) Possible fixes igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic: shard-glk: FAIL (fdo#106509) -> PASS igt@kms_flip@2x-plain-flip-fb-recreate: shard-glk: FAIL (fdo#100368) -> PASS igt@kms_flip_tiling@flip-to-y-tiled: shard-glk: FAIL -> PASS igt@kms_setmode@basic: shard-kbl: FAIL (fdo#99912) -> PASS fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368 fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411 fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454 fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509 fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912 == Participating hosts (5 -> 5) == No changes in participating hosts == Build changes == * Linux: CI_DRM_4449 -> Patchwork_9580 CI_DRM_4449: e470d2ee915b7c36d73d16da953cca8969d73906 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4543: 366eed37c7c71217e1cb1f3be5e26358a41f0001 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_9580: 27f7762e393dff489b66b9a470107ed65db24e48 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9580/shards.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Replace nested subclassing with explicit subclasses
== Series Details == Series: drm/i915: Replace nested subclassing with explicit subclasses URL : https://patchwork.freedesktop.org/series/46103/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4449_full -> Patchwork_9579_full = == Summary - WARNING == Minor unknown changes coming with Patchwork_9579_full need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_9579_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. == Possible new issues == Here are the unknown changes that may have been introduced in Patchwork_9579_full: === IGT changes === Warnings igt@gem_exec_schedule@deep-bsd1: shard-kbl: SKIP -> PASS +2 igt@gem_exec_schedule@deep-bsd2: shard-kbl: PASS -> SKIP +2 == Known issues == Here are the changes found in Patchwork_9579_full that come from known issues: === IGT changes === Issues hit igt@kms_busy@extended-pageflip-hang-oldfb-render-a: shard-snb: PASS -> INCOMPLETE (fdo#105411) igt@kms_flip@2x-flip-vs-expired-vblank-interruptible: shard-glk: PASS -> FAIL (fdo#105363) igt@kms_flip@2x-plain-flip-ts-check-interruptible: shard-glk: PASS -> FAIL (fdo#100368) igt@kms_flip_tiling@flip-y-tiled: shard-glk: PASS -> FAIL (fdo#103822) igt@kms_setmode@basic: shard-apl: PASS -> FAIL (fdo#99912) Possible fixes igt@gem_workarounds@suspend-resume-context: shard-kbl: INCOMPLETE (fdo#103665) -> PASS igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic: shard-glk: FAIL (fdo#106509) -> PASS fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368 fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665 fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822 fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363 fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411 fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509 fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912 == Participating hosts (5 -> 5) == No changes in participating hosts == Build changes == * Linux: CI_DRM_4449 -> Patchwork_9579 CI_DRM_4449: e470d2ee915b7c36d73d16da953cca8969d73906 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4543: 366eed37c7c71217e1cb1f3be5e26358a41f0001 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_9579: 2bbfbe296b3ddf9bc55691f77f063f7de7de3daf @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9579/shards.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Avoid warning if runtime pm is disabled
== Series Details == Series: drm/i915/selftests: Avoid warning if runtime pm is disabled URL : https://patchwork.freedesktop.org/series/46101/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4449_full -> Patchwork_9578_full = == Summary - WARNING == Minor unknown changes coming with Patchwork_9578_full need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_9578_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. == Possible new issues == Here are the unknown changes that may have been introduced in Patchwork_9578_full: === IGT changes === Warnings igt@perf_pmu@rc6: shard-kbl: SKIP -> PASS == Known issues == Here are the changes found in Patchwork_9578_full that come from known issues: === IGT changes === Issues hit igt@drv_suspend@shrink: shard-snb: PASS -> FAIL (fdo#106886) igt@kms_busy@extended-pageflip-hang-oldfb-render-a: shard-snb: PASS -> INCOMPLETE (fdo#105411) igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic: shard-glk: PASS -> FAIL (fdo#105454, fdo#106509) igt@kms_flip_tiling@flip-to-x-tiled: shard-glk: PASS -> FAIL (fdo#103822) igt@kms_setmode@basic: shard-apl: PASS -> FAIL (fdo#99912) Possible fixes igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic: shard-glk: FAIL (fdo#106509) -> PASS igt@kms_flip@2x-plain-flip-fb-recreate: shard-glk: FAIL (fdo#100368) -> PASS igt@kms_flip_tiling@flip-to-y-tiled: shard-glk: FAIL -> PASS fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368 fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822 fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411 fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454 fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509 fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886 fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912 == Participating hosts (5 -> 5) == No changes in participating hosts == Build changes == * Linux: CI_DRM_4449 -> Patchwork_9578 CI_DRM_4449: e470d2ee915b7c36d73d16da953cca8969d73906 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4543: 366eed37c7c71217e1cb1f3be5e26358a41f0001 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_9578: 61dea1fc1d95130ccd10e5cdbdd29219cc758adc @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9578/shards.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH i-g-t 2/2] Add support for forcing specific module
This commit adds a new option for forcing the use of a specific module
indicated via command line. The force command expects a module name
which will be used on the target test (changing the standard behavior).
Signed-off-by: Rodrigo Siqueira
---
lib/drmtest.c| 33 +++--
lib/igt_core.c | 23 +++
lib/igt_core.h | 4
scripts/run-tests.sh | 4 +++-
4 files changed, 57 insertions(+), 7 deletions(-)
diff --git a/lib/drmtest.c b/lib/drmtest.c
index eee733eb..a77e2231 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -247,6 +247,20 @@ static int __open_device(const char *base, int offset,
unsigned int chipset)
if (chipset & DRIVER_AMDGPU && is_amd_device(fd))
return fd;
+ // Force options
+ if (get_target_module() && chipset == DRIVER_ANY) {
+ if (__is_device(fd, get_target_module())) {
+ return fd;
+ }
+ else {
+ memset(name, 0, sizeof(name));
+ __get_drm_device_name(fd, name);
+ close(fd);
+ igt_kmod_unload(name, 0);
+ return -1;
+ }
+ }
+
/* Only VGEM-specific tests should be run on VGEM */
if (chipset == DRIVER_ANY && !is_vgem_device(fd))
return fd;
@@ -260,6 +274,7 @@ static int __open_device(const char *base, int offset,
unsigned int chipset)
static int __open_driver(const char *base, int offset, unsigned int chipset)
{
static pthread_mutex_t mutex = PTHREAD_MUTEX_INITIALIZER;
+ const char* target;
static const struct module {
unsigned int bit;
const char *module;
@@ -278,13 +293,19 @@ static int __open_driver(const char *base, int offset,
unsigned int chipset)
if (fd != -1)
return fd;
+ target = get_target_module();
+
pthread_mutex_lock();
- for (const struct module *m = modules; m->module; m++) {
- if (chipset & m->bit) {
- if (m->modprobe)
- m->modprobe(m->module);
- else
- modprobe(m->module);
+ if (target) {
+ modprobe(target);
+ } else {
+ for (const struct module *m = modules; m->module; m++) {
+ if (chipset & m->bit) {
+ if (m->modprobe)
+ m->modprobe(m->module);
+ else
+ modprobe(m->module);
+ }
}
}
pthread_mutex_unlock();
diff --git a/lib/igt_core.c b/lib/igt_core.c
index 5092a3f0..ee085e2a 100644
--- a/lib/igt_core.c
+++ b/lib/igt_core.c
@@ -286,6 +286,7 @@ enum {
OPT_DESCRIPTION,
OPT_DEBUG,
OPT_INTERACTIVE_DEBUG,
+ OPT_FORCE_MODULE,
OPT_HELP = 'h'
};
@@ -303,6 +304,23 @@ static pthread_mutex_t log_buffer_mutex =
PTHREAD_MUTEX_INITIALIZER;
GKeyFile *igt_key_file;
#endif
+char *target_module = NULL;
+
+void set_target_module(char *target)
+{
+ if (!target)
+ igt_warn("No module specified, keep default behaviour");
+
+ target_module = target;
+}
+
+const char *get_target_module(void)
+{
+ if (target_module)
+ return target_module;
+ return NULL;
+}
+
char *igt_frame_dump_path;
const char *igt_test_name(void)
@@ -555,6 +573,7 @@ static void print_usage(const char *help_str, bool
output_on_stderr)
" --debug[=log-domain]\n"
" --interactive-debug[=domain]\n"
" --help-description\n"
+ " --force-module \n"
" --help\n");
if (help_str)
fprintf(f, "%s\n", help_str);
@@ -666,6 +685,7 @@ static int common_init(int *argc, char **argv,
{"debug", optional_argument, 0, OPT_DEBUG},
{"interactive-debug", optional_argument, 0,
OPT_INTERACTIVE_DEBUG},
{"help", 0, 0, OPT_HELP},
+ {"force-module", required_argument, 0, OPT_FORCE_MODULE},
{0, 0, 0, 0}
};
char *short_opts;
@@ -763,6 +783,9 @@ static int common_init(int *argc, char **argv,
print_test_description();
ret = -1;
goto out;
+ case OPT_FORCE_MODULE:
+ set_target_module(strdup(optarg));
+ break;
case OPT_HELP:
print_usage(help_str, false);
ret = -1;
diff --git a/lib/igt_core.h b/lib/igt_core.h
index bf8cd66c..6d635ebd 100644
---
[Intel-gfx] [PATCH i-g-t 1/2] Increase the string size for a module name
Some modules name are larger than 5 characters, this can be a problem to
add support for other modules. This patch, increase the maximum size in
order to enable other modules to use IGT.
Signed-off-by: Rodrigo Siqueira
---
lib/drmtest.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/drmtest.c b/lib/drmtest.c
index fae6f86f..eee733eb 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -60,6 +60,8 @@
#include "ioctl_wrappers.h"
#include "igt_dummyload.h"
+#define NAME_LEN 32
+
/**
* SECTION:drmtest
* @short_description: Base library for drm tests and tools
@@ -82,7 +84,7 @@ static int __get_drm_device_name(int fd, char *name)
drm_version_t version;
memset(, 0, sizeof(version));
- version.name_len = 4;
+ version.name_len = NAME_LEN;
version.name = name;
if (!drmIoctl(fd, DRM_IOCTL_VERSION, )){
@@ -94,7 +96,7 @@ static int __get_drm_device_name(int fd, char *name)
static bool __is_device(int fd, const char *expect)
{
- char name[5] = "";
+ char name[NAME_LEN] = "";
if (__get_drm_device_name(fd, name))
return false;
--
2.18.0
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH i-g-t 0/2] Add support to force specific module load
This patchset adds support for forcing a specific module to be loaded via command line. This feature can bring benefits for developers that need to create a new module since they can use IGT as a base test to guide their development (Test-driven development - TDD ). The first patch, expand the size of the module name accepted by IGT to make possible that modules with larger names can be loaded. The second patch has the force option implementation. The discussion about this feature started with an RFC named "[PATCH i-g-t] [RFC] Add support to force specific module load", link: https://www.spinics.net/lists/intel-gfx/msg166764.html Rodrigo Siqueira (2): Increase the string size for a module name Add support for forcing specific module lib/drmtest.c| 39 +++ lib/igt_core.c | 23 +++ lib/igt_core.h | 4 scripts/run-tests.sh | 4 +++- 4 files changed, 61 insertions(+), 9 deletions(-) -- 2.18.0 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH i-g-t 7/7] Avoid truncate string in __igt_lsof_fds
Note that 'proc_path' parameter in __igt_lsof_fds receives a string
which was initialized with the size of PATH_MAX and the local variable
'path' has the same size, but it also have to append: '/', '\0', and the
directory name. This situation caused the warning described below.
warning: ‘%s’ directive output may be truncated writing up to 255 bytes
into a region of size between 0 and 4095 [-Wformat-truncation=]
snprintf(path, sizeof(path), "%s/%s", proc_path, d->d_name);
note: ‘snprintf’ output between 2 and 4352 bytes into a destination of
size 4096 [..]
This commit fixes this problem by changing the string size passed by
__igt_lsoft to __igt_lsof_fds. The max size for the string is
strlen("/proc/%d/cwd")+1 where "%d" can be estimated with
CEILING(LOG_10(INT_MAX)), in this sense, it is safe to define a path
size of 30 characters.
Signed-off-by: Rodrigo Siqueira
---
lib/igt_aux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/igt_aux.c b/lib/igt_aux.c
index ca8ccfbd..d9dbf7ce 100644
--- a/lib/igt_aux.c
+++ b/lib/igt_aux.c
@@ -1485,7 +1485,7 @@ __igt_lsof(const char *dir)
PROCTAB *proc;
proc_t *proc_info;
- char path[PATH_MAX];
+ char path[30];
char *name_lnk;
struct stat st;
int state = 0;
--
2.18.0
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH i-g-t 6/7] Fix truncate string in the strncpy
This patch fix the following GCC Warnings: warning: ‘strncpy’ output truncated before terminating nul copying 36 bytes from a string of the same length [-Wstringop-truncation] [..] Signed-off-by: Rodrigo Siqueira --- tests/perf.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index 95048bfa..031bcee8 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -3693,7 +3693,7 @@ test_invalid_create_userspace_config(void) igt_assert_eq(__i915_perf_add_config(drm_fd, ), -EINVAL); /* invalid mux_regs */ - strncpy(config.uuid, uuid, sizeof(config.uuid)); + strncpy(config.uuid, uuid, strlen(config.uuid)); config.n_mux_regs = 1; config.mux_regs_ptr = to_user_pointer(invalid_mux_regs); config.n_boolean_regs = 0; @@ -3702,7 +3702,7 @@ test_invalid_create_userspace_config(void) igt_assert_eq(__i915_perf_add_config(drm_fd, ), -EINVAL); /* empty config */ - strncpy(config.uuid, uuid, sizeof(config.uuid)); + strncpy(config.uuid, uuid, strlen(config.uuid)); config.n_mux_regs = 0; config.mux_regs_ptr = to_user_pointer(mux_regs); config.n_boolean_regs = 0; @@ -3711,7 +3711,7 @@ test_invalid_create_userspace_config(void) igt_assert_eq(__i915_perf_add_config(drm_fd, ), -EINVAL); /* empty config with null pointers */ - strncpy(config.uuid, uuid, sizeof(config.uuid)); + strncpy(config.uuid, uuid, strlen(config.uuid)); config.n_mux_regs = 1; config.mux_regs_ptr = to_user_pointer(NULL); config.n_boolean_regs = 2; @@ -3722,7 +3722,7 @@ test_invalid_create_userspace_config(void) igt_assert_eq(__i915_perf_add_config(drm_fd, ), -EINVAL); /* invalid pointers */ - strncpy(config.uuid, uuid, sizeof(config.uuid)); + strncpy(config.uuid, uuid, strlen(config.uuid)); config.n_mux_regs = 42; config.mux_regs_ptr = to_user_pointer((void *) 0xDEADBEEF); config.n_boolean_regs = 0; @@ -3809,7 +3809,7 @@ test_create_destroy_userspace_config(void) i915_perf_remove_config(drm_fd, config_id); memset(, 0, sizeof(config)); - strncpy(config.uuid, uuid, sizeof(config.uuid)); + strncpy(config.uuid, uuid, strlen(config.uuid)); config.n_mux_regs = 1; config.mux_regs_ptr = to_user_pointer(mux_regs); -- 2.18.0 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH i-g-t 5/7] Make string commands dynamic allocate
This patch fix the following GCC warning:
intel_gvtg_test.c: In function ‘create_guest’:
intel_gvtg_test.c:127:50: warning: ‘%s’ directive writing up to 4095
bytes into a region of size 4077 [-Wformat-overflow=]
[..]
intel_gvtg_test.c:127:5: note: ‘sprintf’ output between 36 and 8226
bytes into a destination of size 4096
[..]
This patch changes the approach for allocating memory to handle QEMU
commands by dynamically allocate space to save the whole command.
Signed-off-by: Rodrigo Siqueira
---
tools/intel_gvtg_test.c | 27 ++-
1 file changed, 18 insertions(+), 9 deletions(-)
diff --git a/tools/intel_gvtg_test.c b/tools/intel_gvtg_test.c
index 659b7956..93c05e37 100644
--- a/tools/intel_gvtg_test.c
+++ b/tools/intel_gvtg_test.c
@@ -120,16 +120,25 @@ static int check_tools(void)
static void create_guest(void)
{
-char create_qcow_cmd[PATH_MAX] = {0};
-char create_vgpu_cmd[PATH_MAX] = {0};
-char create_instance_cmd[PATH_MAX] = {0};
+unsigned int max_size_cmd = sysconf(_SC_ARG_MAX);
+char *command;
-sprintf(create_qcow_cmd, "qemu-img create -b %s -f qcow2 %s.qcow2",
+command = malloc(max_size_cmd);
+if (!command)
+return;
+
+sprintf(command, "qemu-img create -b %s -f qcow2 %s.qcow2",
hda_path, hda_path);
-sprintf(create_vgpu_cmd, "echo \"%s\" > /sys/bus/pci/devices/:00:02.0/"
+igt_assert_eq(system(command), 0);
+memset(command, 0, max_size_cmd);
+
+sprintf(command, "echo \"%s\" > /sys/bus/pci/devices/:00:02.0/"
"mdev_supported_types/$(ls /sys/bus/pci/devices/:00:02.0/"
"mdev_supported_types |awk {'print $1'}|tail -1)/create", uuid);
-sprintf(create_instance_cmd, "%s -m 2048 -smp 2 -M pc -name gvtg_guest"
+igt_assert_eq(system(command), 0);
+memset(command, 0, max_size_cmd);
+
+sprintf(command, "%s -m 2048 -smp 2 -M pc -name gvtg_guest"
" -hda %s.qcow2 -bios %s -enable-kvm --net nic,macaddr=%s -net"
" tap,script=/etc/qemu-ifup -vga cirrus -k en-us"
" -serial stdio -vnc :1 -machine kernel_irqchip=on -global"
@@ -137,9 +146,9 @@ static void create_guest(void)
" -usb -usbdevice tablet -device vfio-pci,sysfsdev="
"/sys/bus/pci/devices/:00:02.0/%s &",
qemu_path, hda_path, bios_path, mac_addr, uuid);
-igt_assert_eq(system(create_qcow_cmd), 0);
-igt_assert_eq(system(create_vgpu_cmd), 0);
-igt_assert_eq(system(create_instance_cmd), 0);
+igt_assert_eq(system(command), 0);
+
+free(command);
}
static void destroy_all_guest(void)
--
2.18.0
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH i-g-t 3/7] Fix comparison that always evaluates to false
This commit fix the GCC warning:
warning: bitwise comparison always evaluates to false
[-Wtautological-compare]
} else if ((val & DPLLB_MODE_LVDS) == DPLLB_MODE_DAC_SERIAL) {
The first comparison already checks DPLLB_MODE_LVDS, in this sense, the
second 'if' condition always will be false. This commit changes the
comparison to DPLLB_MODE_DAC_SERIAL.
Signed-off-by: Rodrigo Siqueira
---
tools/intel_reg_decode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/intel_reg_decode.c b/tools/intel_reg_decode.c
index f3c7d74a..5a632e09 100644
--- a/tools/intel_reg_decode.c
+++ b/tools/intel_reg_decode.c
@@ -1277,7 +1277,7 @@ DEBUGSTRING(ironlake_debug_pch_dpll)
p2 = "Div 7";
else
p2 = "Div 14";
- } else if ((val & DPLLB_MODE_LVDS) == DPLLB_MODE_DAC_SERIAL) {
+ } else if ((val & DPLLB_MODE_DAC_SERIAL) == DPLLB_MODE_DAC_SERIAL) {
mode = "Non-LVDS";
if (val & DPLL_DAC_SERIAL_P2_CLOCK_DIV_5)
p2 = "Div 5";
--
2.18.0
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH i-g-t 4/7] Fix truncate string in the snprintf
This patch fix the following GCC warning:
intel_reg.c: In function ‘dump_decode’:
warning: ‘snprintf’ output may be truncated before the last format character
[-Wformat-truncation=]
snprintf(decode, sizeof(decode), "\n%s", bin);
intel_reg.c:203:3: note: ‘snprintf’ output between 2 and 1025 bytes into a
destination of size 1024
[..]
Signed-off-by: Rodrigo Siqueira
---
tools/intel_reg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/intel_reg.c b/tools/intel_reg.c
index ddff2794..15ebb86a 100644
--- a/tools/intel_reg.c
+++ b/tools/intel_reg.c
@@ -180,7 +180,7 @@ static void to_binary(char *buf, size_t buflen, uint32_t
val)
static void dump_decode(struct config *config, struct reg *reg, uint32_t val)
{
- char decode[1024];
+ char decode[2060];
char tmp[1024];
char bin[1024];
--
2.18.0
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH i-g-t 1/7] Remove parameter aliases with another argument
This commit fixes the following GCC warning:
warning: passing argument 2 to restrict-qualified parameter aliases with
argument 1 [-Wrestrict]
return (readlink (buf, buf, sizeof (buf)) != -1 &&
This commit fixes the GCC warning by creating a second buffer only to
keep the path.
Signed-off-by: Rodrigo Siqueira
---
lib/igt_core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/igt_core.c b/lib/igt_core.c
index 3313050c..fa22f12d 100644
--- a/lib/igt_core.c
+++ b/lib/igt_core.c
@@ -1169,10 +1169,10 @@ bool igt_can_fail(void)
static bool run_under_gdb(void)
{
- char buf[1024];
+ char pathname[1024], buf[1024];
- sprintf(buf, "/proc/%d/exe", getppid());
- return (readlink (buf, buf, sizeof (buf)) != -1 &&
+ sprintf(pathname, "/proc/%d/exe", getppid());
+ return (readlink (pathname, buf, sizeof (buf)) != -1 &&
strncmp(basename(buf), "gdb", 3) == 0);
}
--
2.18.0
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH i-g-t 2/7] Cast void * pointer used in arithmetic to uint32_t*
This commit fixes the GCC warning:
warning: pointer of type ‘void *’ used in arithmetic [-Wpointer-arith]
memset(ptr + offsets[0], full_range ? 0x00 : 0x10,
^
warning: pointer of type ‘void *’ used in arithmetic [-Wpointer-arith]
memset(ptr + offsets[1], 0x80,
This commit cast the ptr pointer, which is a void *, to uint32_t * in
the pointer arithmetic operation.
Signed-off-by: Rodrigo Siqueira
---
lib/igt_fb.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index ae71d967..ca905038 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -410,9 +410,11 @@ static int create_bo_for_fb(int fd, int width, int height,
switch (format->drm_id) {
case DRM_FORMAT_NV12:
- memset(ptr + offsets[0], full_range ? 0x00 :
0x10,
+ memset(((uint32_t *)ptr) + offsets[0],
+ full_range ? 0x00 : 0x10,
calculated_stride * height);
- memset(ptr + offsets[1], 0x80,
+ memset(((uint32_t *)ptr) + offsets[1],
+ 0x80,
calculated_stride * height/2);
break;
case DRM_FORMAT_YUYV:
--
2.18.0
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH i-g-t 0/7] GCC warning cleanup
This patchset fixes all the current GCC 8.1.1 warnings found in the IGT. Rodrigo Siqueira (7): Remove parameter aliases with another argument Cast void * pointer used in arithmetic to uint32_t* Fix comparison that always evaluates to false Fix truncate string in the snprintf Make string commands dynamic allocate Fix truncate string in the strncpy Avoid truncate string in __igt_lsof_fds lib/igt_aux.c| 2 +- lib/igt_core.c | 6 +++--- lib/igt_fb.c | 6 -- tests/perf.c | 10 +- tools/intel_gvtg_test.c | 27 ++- tools/intel_reg.c| 2 +- tools/intel_reg_decode.c | 2 +- 7 files changed, 33 insertions(+), 22 deletions(-) -- 2.18.0 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✓ Fi.CI.IGT: success for Make the "Reducing compressed framebufer size" message be DRM_INFO_ONCE()
== Series Details == Series: Make the "Reducing compressed framebufer size" message be DRM_INFO_ONCE() URL : https://patchwork.freedesktop.org/series/46092/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4448_full -> Patchwork_9577_full = == Summary - WARNING == Minor unknown changes coming with Patchwork_9577_full need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_9577_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. == Possible new issues == Here are the unknown changes that may have been introduced in Patchwork_9577_full: === IGT changes === Warnings igt@gem_exec_schedule@deep-bsd2: shard-kbl: SKIP -> PASS +1 igt@gem_exec_schedule@deep-vebox: shard-kbl: PASS -> SKIP +1 == Known issues == Here are the changes found in Patchwork_9577_full that come from known issues: === IGT changes === Issues hit igt@gem_workarounds@suspend-resume-context: shard-kbl: PASS -> INCOMPLETE (fdo#103665) igt@kms_cursor_legacy@cursor-vs-flip-toggle: shard-hsw: PASS -> FAIL (fdo#103355) igt@kms_flip_tiling@flip-x-tiled: shard-glk: PASS -> FAIL (fdo#103822) +1 Possible fixes igt@kms_busy@extended-pageflip-hang-oldfb-render-a: shard-snb: INCOMPLETE (fdo#105411) -> PASS igt@kms_flip@2x-blocking-wf_vblank: shard-glk: FAIL (fdo#100368) -> PASS igt@kms_flip_tiling@flip-to-y-tiled: shard-glk: FAIL -> PASS fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368 fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355 fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665 fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822 fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411 == Participating hosts (5 -> 5) == No changes in participating hosts == Build changes == * Linux: CI_DRM_4448 -> Patchwork_9577 CI_DRM_4448: e094950bd5b5767bab1d2a5c259635dc6091f8cc @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4543: 366eed37c7c71217e1cb1f3be5e26358a41f0001 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_9577: db1271a678bb745e2471c020f79a0a38a7a24f91 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9577/shards.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix assert_plane() warning on bootup with external display (rev8)
== Series Details == Series: drm/i915: Fix assert_plane() warning on bootup with external display (rev8) URL : https://patchwork.freedesktop.org/series/44909/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4448_full -> Patchwork_9576_full = == Summary - WARNING == Minor unknown changes coming with Patchwork_9576_full need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_9576_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. == Possible new issues == Here are the unknown changes that may have been introduced in Patchwork_9576_full: === IGT changes === Warnings igt@gem_exec_schedule@deep-bsd1: shard-kbl: PASS -> SKIP igt@gem_exec_schedule@deep-bsd2: shard-kbl: SKIP -> PASS +3 == Known issues == Here are the changes found in Patchwork_9576_full that come from known issues: === IGT changes === Issues hit igt@gem_render_linear_blits@basic: shard-kbl: PASS -> INCOMPLETE (fdo#103665) igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic: shard-glk: PASS -> FAIL (fdo#106509, fdo#105454) igt@kms_draw_crc@draw-method-rgb565-mmap-wc-ytiled: shard-glk: PASS -> FAIL (fdo#103184) igt@kms_setmode@basic: shard-apl: PASS -> FAIL (fdo#99912) Possible fixes igt@gem_render_copy_redux@normal: shard-kbl: INCOMPLETE (fdo#103665, fdo#106650) -> PASS igt@kms_flip@2x-blocking-wf_vblank: shard-glk: FAIL (fdo#100368) -> PASS fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368 fdo#103184 https://bugs.freedesktop.org/show_bug.cgi?id=103184 fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665 fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454 fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509 fdo#106650 https://bugs.freedesktop.org/show_bug.cgi?id=106650 fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912 == Participating hosts (5 -> 5) == No changes in participating hosts == Build changes == * Linux: CI_DRM_4448 -> Patchwork_9576 CI_DRM_4448: e094950bd5b5767bab1d2a5c259635dc6091f8cc @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4543: 366eed37c7c71217e1cb1f3be5e26358a41f0001 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_9576: 7b57b62848f96c2c2e92917e603c4bf1ee1909f5 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9576/shards.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Provide full mb() around clflush
== Series Details == Series: drm/i915/selftests: Provide full mb() around clflush URL : https://patchwork.freedesktop.org/series/46085/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4448_full -> Patchwork_9574_full = == Summary - WARNING == Minor unknown changes coming with Patchwork_9574_full need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_9574_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. == Possible new issues == Here are the unknown changes that may have been introduced in Patchwork_9574_full: === IGT changes === Warnings igt@gem_exec_schedule@deep-blt: shard-kbl: SKIP -> PASS +1 == Known issues == Here are the changes found in Patchwork_9574_full that come from known issues: === IGT changes === Issues hit igt@drv_suspend@shrink: shard-apl: PASS -> FAIL (fdo#106886) igt@gem_workarounds@suspend-resume-context: shard-kbl: PASS -> INCOMPLETE (fdo#103665) igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing: shard-glk: PASS -> FAIL (fdo#105703) igt@kms_cursor_legacy@cursor-vs-flip-toggle: shard-hsw: PASS -> FAIL (fdo#103355) igt@kms_flip@2x-flip-vs-expired-vblank-interruptible: shard-glk: PASS -> FAIL (fdo#105363) Possible fixes igt@gem_render_copy_redux@normal: shard-kbl: INCOMPLETE (fdo#106650, fdo#103665) -> PASS igt@kms_flip@2x-blocking-wf_vblank: shard-glk: FAIL (fdo#100368) -> PASS +1 igt@kms_flip_tiling@flip-to-y-tiled: shard-glk: FAIL -> PASS igt@kms_setmode@basic: shard-kbl: FAIL (fdo#99912) -> PASS fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368 fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355 fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665 fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363 fdo#105703 https://bugs.freedesktop.org/show_bug.cgi?id=105703 fdo#106650 https://bugs.freedesktop.org/show_bug.cgi?id=106650 fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886 fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912 == Participating hosts (5 -> 5) == No changes in participating hosts == Build changes == * Linux: CI_DRM_4448 -> Patchwork_9574 CI_DRM_4448: e094950bd5b5767bab1d2a5c259635dc6091f8cc @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4543: 366eed37c7c71217e1cb1f3be5e26358a41f0001 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_9574: cdfe0eb01ba9e72cddeb359438167509754b2403 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9574/shards.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Adjust y-tiling height for older machines
== Series Details == Series: drm/i915/selftests: Adjust y-tiling height for older machines URL : https://patchwork.freedesktop.org/series/46084/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4448_full -> Patchwork_9573_full = == Summary - FAILURE == Serious unknown changes coming with Patchwork_9573_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_9573_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. == Possible new issues == Here are the unknown changes that may have been introduced in Patchwork_9573_full: === IGT changes === Possible regressions igt@kms_universal_plane@cursor-fb-leak-pipe-b: shard-apl: PASS -> FAIL Warnings igt@gem_exec_schedule@deep-bsd1: shard-kbl: PASS -> SKIP +1 igt@gem_exec_schedule@deep-bsd2: shard-kbl: SKIP -> PASS +3 == Known issues == Here are the changes found in Patchwork_9573_full that come from known issues: === IGT changes === Issues hit igt@gem_exec_big: shard-hsw: PASS -> INCOMPLETE (fdo#103540) igt@gem_workarounds@suspend-resume-context: shard-kbl: PASS -> INCOMPLETE (fdo#103665) igt@kms_flip@2x-flip-vs-expired-vblank: shard-glk: PASS -> FAIL (fdo#105363) igt@kms_flip@2x-plain-flip-ts-check-interruptible: shard-glk: PASS -> FAIL (fdo#100368) igt@kms_flip@flip-vs-expired-vblank-interruptible: shard-hsw: PASS -> FAIL (fdo#105363, fdo#102887) igt@kms_setmode@basic: shard-apl: PASS -> FAIL (fdo#99912) Possible fixes igt@gem_render_copy_redux@normal: shard-kbl: INCOMPLETE (fdo#103665, fdo#106650) -> PASS igt@kms_flip@2x-blocking-wf_vblank: shard-glk: FAIL (fdo#100368) -> PASS +1 igt@kms_setmode@basic: shard-hsw: FAIL (fdo#99912) -> PASS fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368 fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887 fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540 fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665 fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363 fdo#106650 https://bugs.freedesktop.org/show_bug.cgi?id=106650 fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912 == Participating hosts (5 -> 5) == No changes in participating hosts == Build changes == * Linux: CI_DRM_4448 -> Patchwork_9573 CI_DRM_4448: e094950bd5b5767bab1d2a5c259635dc6091f8cc @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4543: 366eed37c7c71217e1cb1f3be5e26358a41f0001 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_9573: f10fe0a76a017d916a200eab03aa5a18c46cde4c @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9573/shards.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gen11: Preempt-to-idle support in execlists. (rev5)
== Series Details == Series: drm/i915/gen11: Preempt-to-idle support in execlists. (rev5) URL : https://patchwork.freedesktop.org/series/40747/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4446_full -> Patchwork_9572_full = == Summary - WARNING == Minor unknown changes coming with Patchwork_9572_full need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_9572_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. == Possible new issues == Here are the unknown changes that may have been introduced in Patchwork_9572_full: === IGT changes === Warnings igt@gem_exec_schedule@deep-blt: shard-kbl: PASS -> SKIP igt@gem_exec_schedule@deep-vebox: shard-kbl: SKIP -> PASS == Known issues == Here are the changes found in Patchwork_9572_full that come from known issues: === IGT changes === Issues hit igt@drv_suspend@shrink: shard-hsw: PASS -> INCOMPLETE (fdo#103540, fdo#106886) igt@kms_atomic_transition@1x-modeset-transitions-nonblocking: shard-glk: PASS -> FAIL (fdo#105703) igt@kms_draw_crc@draw-method-rgb565-mmap-wc-ytiled: shard-glk: PASS -> FAIL (fdo#103184) igt@kms_flip@2x-flip-vs-blocking-wf-vblank: shard-glk: PASS -> FAIL (fdo#100368) +1 igt@kms_flip@modeset-vs-vblank-race-interruptible: shard-hsw: PASS -> FAIL (fdo#103060) igt@kms_flip_tiling@flip-x-tiled: shard-glk: PASS -> FAIL (fdo#103822) igt@kms_rotation_crc@sprite-rotation-270: shard-apl: PASS -> FAIL (fdo#103925) igt@kms_setmode@basic: shard-apl: PASS -> FAIL (fdo#99912) Possible fixes igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic: shard-glk: FAIL (fdo#106509) -> PASS igt@kms_flip@2x-plain-flip-fb-recreate: shard-glk: FAIL (fdo#100368) -> PASS igt@kms_universal_plane@cursor-fb-leak-pipe-c: shard-apl: FAIL -> PASS fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368 fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060 fdo#103184 https://bugs.freedesktop.org/show_bug.cgi?id=103184 fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540 fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822 fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925 fdo#105703 https://bugs.freedesktop.org/show_bug.cgi?id=105703 fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509 fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886 fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912 == Participating hosts (5 -> 5) == No changes in participating hosts == Build changes == * Linux: CI_DRM_4446 -> Patchwork_9572 CI_DRM_4446: 95944426a9ffda186843c78f2f925494e1bc53c5 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4543: 366eed37c7c71217e1cb1f3be5e26358a41f0001 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_9572: 90f487fed124443c7a8d557fa0e54dcbbcbb046e @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9572/shards.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/selftests: Replace magic 1<<22 with MI_USE_GGTT/MI_MEM_VIRTUAL
== Series Details == Series: series starting with [1/2] drm/i915/selftests: Replace magic 1<<22 with MI_USE_GGTT/MI_MEM_VIRTUAL URL : https://patchwork.freedesktop.org/series/46078/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4446_full -> Patchwork_9570_full = == Summary - FAILURE == Serious unknown changes coming with Patchwork_9570_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_9570_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. == Possible new issues == Here are the unknown changes that may have been introduced in Patchwork_9570_full: === IGT changes === Possible regressions igt@kms_universal_plane@cursor-fb-leak-pipe-b: shard-apl: PASS -> FAIL Warnings igt@gem_exec_schedule@deep-bsd1: shard-kbl: SKIP -> PASS +1 igt@gem_exec_schedule@deep-bsd2: shard-kbl: PASS -> SKIP == Known issues == Here are the changes found in Patchwork_9570_full that come from known issues: === IGT changes === Issues hit igt@kms_rotation_crc@primary-rotation-270: shard-apl: PASS -> FAIL (fdo#103925) igt@kms_setmode@basic: shard-apl: PASS -> FAIL (fdo#99912) Possible fixes igt@gem_workarounds@suspend-resume-context: shard-kbl: INCOMPLETE (fdo#103665) -> PASS igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic: shard-glk: FAIL (fdo#106509) -> PASS igt@kms_universal_plane@cursor-fb-leak-pipe-c: shard-apl: FAIL -> PASS fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665 fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925 fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509 fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912 == Participating hosts (5 -> 5) == No changes in participating hosts == Build changes == * Linux: CI_DRM_4446 -> Patchwork_9570 CI_DRM_4446: 95944426a9ffda186843c78f2f925494e1bc53c5 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4543: 366eed37c7c71217e1cb1f3be5e26358a41f0001 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_9570: 4ece3280cdc43e239759fe44f8e94ab5b1dba570 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9570/shards.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Limit live_gtt allocation test to fit within RAM
== Series Details == Series: drm/i915/selftests: Limit live_gtt allocation test to fit within RAM URL : https://patchwork.freedesktop.org/series/46075/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4446_full -> Patchwork_9569_full = == Summary - WARNING == Minor unknown changes coming with Patchwork_9569_full need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_9569_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. == Possible new issues == Here are the unknown changes that may have been introduced in Patchwork_9569_full: === IGT changes === Warnings igt@gem_exec_schedule@deep-bsd1: shard-kbl: SKIP -> PASS +1 == Known issues == Here are the changes found in Patchwork_9569_full that come from known issues: === IGT changes === Issues hit igt@drv_selftest@live_hangcheck: shard-kbl: PASS -> DMESG-FAIL (fdo#106560, fdo#106947) igt@kms_cursor_legacy@cursor-vs-flip-toggle: shard-hsw: PASS -> FAIL (fdo#103355) igt@kms_flip_tiling@flip-x-tiled: shard-glk: PASS -> FAIL (fdo#103822) +1 igt@kms_setmode@basic: shard-apl: PASS -> FAIL (fdo#99912) Possible fixes igt@drv_selftest@live_gtt: shard-kbl: FAIL (fdo#105347, fdo#107127) -> PASS shard-apl: FAIL (fdo#105347, fdo#107127) -> PASS igt@kms_busy@extended-pageflip-hang-oldfb-render-a: shard-snb: INCOMPLETE (fdo#105411) -> PASS igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic: shard-glk: FAIL (fdo#106509) -> PASS igt@kms_flip_tiling@flip-to-y-tiled: shard-glk: FAIL (fdo#103822) -> PASS igt@kms_flip_tiling@flip-y-tiled: shard-glk: FAIL -> PASS igt@kms_universal_plane@cursor-fb-leak-pipe-c: shard-apl: FAIL -> PASS fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355 fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822 fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347 fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411 fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509 fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560 fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947 fdo#107127 https://bugs.freedesktop.org/show_bug.cgi?id=107127 fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912 == Participating hosts (5 -> 5) == No changes in participating hosts == Build changes == * Linux: CI_DRM_4446 -> Patchwork_9569 CI_DRM_4446: 95944426a9ffda186843c78f2f925494e1bc53c5 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4543: 366eed37c7c71217e1cb1f3be5e26358a41f0001 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_9569: 951ac5597a9bb633b7b1b9cca98c874b550c3e5e @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9569/shards.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/6] drm/i915: Refactor export_fence() after i915_vma_move_to_active() (rev2)
== Series Details == Series: series starting with [1/6] drm/i915: Refactor export_fence() after i915_vma_move_to_active() (rev2) URL : https://patchwork.freedesktop.org/series/46067/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4446_full -> Patchwork_9568_full = == Summary - WARNING == Minor unknown changes coming with Patchwork_9568_full need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_9568_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. == Possible new issues == Here are the unknown changes that may have been introduced in Patchwork_9568_full: === IGT changes === Warnings igt@gem_exec_schedule@deep-bsd1: shard-kbl: SKIP -> PASS igt@kms_vblank@pipe-b-query-busy-hang: shard-snb: PASS -> SKIP == Known issues == Here are the changes found in Patchwork_9568_full that come from known issues: === IGT changes === Issues hit igt@drv_selftest@live_gtt: shard-glk: PASS -> INCOMPLETE (fdo#103359, k.org#198133, fdo#107127) igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic: shard-glk: PASS -> FAIL (fdo#106509, fdo#105454) igt@kms_rotation_crc@primary-rotation-180: shard-hsw: PASS -> FAIL (fdo#103925) igt@kms_setmode@basic: shard-apl: PASS -> FAIL (fdo#99912) Possible fixes igt@gem_workarounds@suspend-resume-context: shard-kbl: INCOMPLETE (fdo#103665) -> PASS igt@kms_busy@extended-pageflip-hang-oldfb-render-a: shard-snb: INCOMPLETE (fdo#105411) -> PASS igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic: shard-glk: FAIL (fdo#106509) -> PASS igt@kms_flip_tiling@flip-to-y-tiled: shard-glk: FAIL (fdo#103822) -> PASS igt@kms_flip_tiling@flip-y-tiled: shard-glk: FAIL -> PASS igt@kms_universal_plane@cursor-fb-leak-pipe-c: shard-apl: FAIL -> PASS fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359 fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665 fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822 fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925 fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411 fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454 fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509 fdo#107127 https://bugs.freedesktop.org/show_bug.cgi?id=107127 fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912 k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133 == Participating hosts (5 -> 5) == No changes in participating hosts == Build changes == * Linux: CI_DRM_4446 -> Patchwork_9568 CI_DRM_4446: 95944426a9ffda186843c78f2f925494e1bc53c5 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4543: 366eed37c7c71217e1cb1f3be5e26358a41f0001 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_9568: a65a91a8871c69c8a80db2a1da700aaa4eb113b4 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9568/shards.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/gtt: Suppress warnings for dma_map_page
== Series Details == Series: series starting with [1/2] drm/i915/gtt: Suppress warnings for dma_map_page URL : https://patchwork.freedesktop.org/series/46072/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4446_full -> Patchwork_9567_full = == Summary - WARNING == Minor unknown changes coming with Patchwork_9567_full need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_9567_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. == Possible new issues == Here are the unknown changes that may have been introduced in Patchwork_9567_full: === IGT changes === Warnings igt@gem_exec_schedule@deep-bsd1: shard-kbl: SKIP -> PASS == Known issues == Here are the changes found in Patchwork_9567_full that come from known issues: === IGT changes === Issues hit igt@drv_selftest@live_gtt: shard-glk: PASS -> FAIL (fdo#107127, fdo#105347) igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic: shard-glk: PASS -> FAIL (fdo#106509) igt@kms_flip@2x-modeset-vs-vblank-race-interruptible: shard-glk: PASS -> FAIL (fdo#103060) igt@kms_flip_tiling@flip-x-tiled: shard-glk: PASS -> FAIL (fdo#103822) Possible fixes igt@drv_selftest@live_gtt: shard-kbl: FAIL (fdo#107127, fdo#105347) -> PASS igt@gem_workarounds@suspend-resume-context: shard-kbl: INCOMPLETE (fdo#103665) -> PASS igt@kms_flip_tiling@flip-to-y-tiled: shard-glk: FAIL (fdo#103822) -> PASS igt@kms_flip_tiling@flip-y-tiled: shard-glk: FAIL -> PASS igt@kms_setmode@basic: shard-kbl: FAIL (fdo#99912) -> PASS igt@kms_universal_plane@cursor-fb-leak-pipe-c: shard-apl: FAIL -> PASS fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060 fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665 fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822 fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347 fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509 fdo#107127 https://bugs.freedesktop.org/show_bug.cgi?id=107127 fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912 == Participating hosts (5 -> 5) == No changes in participating hosts == Build changes == * Linux: CI_DRM_4446 -> Patchwork_9567 CI_DRM_4446: 95944426a9ffda186843c78f2f925494e1bc53c5 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4543: 366eed37c7c71217e1cb1f3be5e26358a41f0001 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_9567: c8a26b94b94b3e9077ee998a8bd9085e79b75cb6 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9567/shards.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Magic numbers for old Y-tiling
== Series Details == Series: drm/i915/selftests: Magic numbers for old Y-tiling URL : https://patchwork.freedesktop.org/series/46114/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4451 -> Patchwork_9582 = == Summary - SUCCESS == No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/46114/revisions/1/mbox/ == Known issues == Here are the changes found in Patchwork_9582 that come from known issues: === IGT changes === Issues hit igt@prime_vgem@basic-fence-flip: fi-ilk-650: PASS -> FAIL (fdo#104008) Possible fixes igt@drv_module_reload@basic-reload: fi-kbl-7560u: INCOMPLETE -> PASS fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008 == Participating hosts (46 -> 41) == Missing(5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u == Build changes == * Linux: CI_DRM_4451 -> Patchwork_9582 CI_DRM_4451: 7ae7763aa2be33d723ed891f0803f08a11f85633 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4543: 366eed37c7c71217e1cb1f3be5e26358a41f0001 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_9582: f23ff15282b42dae2f1cfe4d6ad4f6a419acbd2a @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == f23ff15282b4 drm/i915/selftests: Magic numbers for old Y-tiling == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9582/issues.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH] drm/i915/selftests: Magic numbers for old Y-tiling
i915g has a slightly different tiling layout, and so requires a
different reference swizzle pattern.
Testcase: igt/drv_selftests/live_objects #gdg
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/selftests/i915_gem_object.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_object.c
b/drivers/gpu/drm/i915/selftests/i915_gem_object.c
index 25c2b2d433bd..f4a5099c75b5 100644
--- a/drivers/gpu/drm/i915/selftests/i915_gem_object.c
+++ b/drivers/gpu/drm/i915/selftests/i915_gem_object.c
@@ -169,9 +169,16 @@ static u64 tiled_offset(const struct tile *tile, u64 v)
v += y * tile->width;
v += div64_u64_rem(x, tile->width, ) << tile->size;
v += x;
- } else {
+ } else if (tile->width == 128) {
const unsigned int ytile_span = 16;
- const unsigned int ytile_height = 32 * ytile_span;
+ const unsigned int ytile_height = 512;
+
+ v += y * ytile_span;
+ v += div64_u64_rem(x, ytile_span, ) * ytile_height;
+ v += x;
+ } else {
+ const unsigned int ytile_span = 32;
+ const unsigned int ytile_height = 256;
v += y * ytile_span;
v += div64_u64_rem(x, ytile_span, ) * ytile_height;
--
2.18.0
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 4/4] drm/i915/intel_dsi: Read back pclk set by GOP and use that as pclk
Hi,
On 07/06/2018 04:16 PM, Ville Syrjälä wrote:
On Tue, Jun 19, 2018 at 10:18:27PM +0200, Hans de Goede wrote:
On BYT and CHT the GOP sometimes initializes the pclk at a (slightly)
different frequency then the pclk which we've calculated.
This commit makes the DSI code read-back the pclk set by the GOP and
if that is within a reasonable margin of the calculated pclk, uses
that instead.
This fixes the first modeset being a full modeset instead of a
fast modeset on systems where the GOP pclk is different.
Signed-off-by: Hans de Goede
---
drivers/gpu/drm/i915/intel_dsi_vbt.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_dsi_vbt.c
b/drivers/gpu/drm/i915/intel_dsi_vbt.c
index 4d6ffa7b3e7b..d4cc6099012c 100644
--- a/drivers/gpu/drm/i915/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/intel_dsi_vbt.c
@@ -517,6 +517,7 @@ bool intel_dsi_vbt_init(struct intel_dsi *intel_dsi, u16
panel_id)
u32 mul;
u16 burst_mode_ratio;
enum port port;
+ enum pipe pipe;
DRM_DEBUG_KMS("\n");
@@ -583,6 +584,19 @@ bool intel_dsi_vbt_init(struct intel_dsi *intel_dsi, u16 panel_id)
} else
burst_mode_ratio = 100;
+ /*
+* On BYT / CRC the GOP sometimes picks a slightly different pclk,
+* read back the GOP configured pclk and prefer it over ours.
+*/
+ if ((IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) &&
+ intel_dsi_get_hw_state(_dsi->base, )) {
+ u32 gop = intel_dsi_get_pclk(_dsi->base, bpp, NULL);
+
+ DRM_DEBUG_KMS("Calculated pclk %d GOP %d\n", pclk, gop);
+ if (gop >= (pclk * 9 / 10) && gop <= (pclk * 11 / 10))
+ pclk = gop;
+ }
Is the gop acually picking a different clock that what we pick in the
end, or is it just that the value in the vbt doesn't quite match what we
(and the gop) end up using on account of limitations of the pll?
I *think* the GOP is picking a different clock, IIRC (*) it is something like
90Mhz for the GOP and the VBT says 87Mhz (and our calculations leave it
unmodified. With this patch which puts pclk at 90Mhz on the specific
tablet I developed this on, the PLL settings calculated by our PLL code
end up being exactly the same as the once chosen by the GOP once we have
the pclk set to 90MHz.
Note I've seen these small (and sometimes somewhat bigger) differences
between GOP and VBT pclk on a lot of devices, not just the one tablet
I developed it on. Since submitting this I've run this on at least
5 different CHT/BYT devices and it works as advertised so far.
For that particular problem I think I had patches long ago to go through
the pll computation during init so that we basically fix up the slightly
bogus clock from the vbt.
We do end up with a slightly different clock then the 87MHhz when going
though the PLL calculations, something like 86.33MHz or some such from
the top of my head, but the problem is not the pclk not matching the
intel_pipe_config_compare() function does not look at it, it looks at
dsi_pll.ctrl dsi_pll.div and those don't match, where as they do match
if we fixup the VBT clock to be the one confgured by the GOP.
Any kind of hack that involves reading out the hardware state should go
into something like intel_sanitize_encoder(). Actually by that time we
have already read out the hw state, so it shouldn't require any
modifications to the existing dsi code itself.
I do not think that intel_sanitize encoder is the right place to do this:
* I don't want to modify the read-back state, I want to modify our
calculated "new/ideal" state to match the read-back state
* I don't want to directly modify our calculated new/ideal state,
instead I want to cleanup / sanitize the values we got from the VBT
so that the initial-modeset *and* any future modesets will use the
GOP pclk. I believe it is important that if we're going to use the
GOP pclk we use it for all modesets consistently.
* I only want to do this once, at boot when we are sure the mode was
set by the GOP and not after suspend/resume when we don't know if the
GOP will have touched things or not.
* It is DSI specific, whereas sofar intel_sanitize_encoder seems to
not contain any output specific code.
Regards,
Hans
+
intel_dsi->burst_mode_ratio = burst_mode_ratio;
intel_dsi->pclk = pclk;
--
2.17.1
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 0/4] drm/i915/intel_dsi: Read back and use pclk set by the GOP
Hi, On 07/06/2018 03:14 PM, Jani Nikula wrote: On Fri, 29 Jun 2018, Hans de Goede wrote: Hi, On 19-06-18 22:18, Hans de Goede wrote: Hi All, This patch-set is the result of the work I've been doing recently to give people a smooth "flickerfree" boot experience where the display keeps displaying the logo put there by the firmware until it smoothly fades into the Linux GUI (e.g. gdm). While testing this on some BYT/CHT devices I noticed the screen going black for 1 second or so, because the first modeset was not a fast modeset despite passing i915.fastboot=1 on the kernel commandline. This is caused by the GOP and the i915 code differing in what they think the DSI pclk should be. This patch-set fixes this by reading back the pclk set by the GOP and if it is reasonably close to the clk calculated by the i915 code, using the GOP set pclk. Ping? A review of this series would be appreciated. Sorry, swamped, and I was hoping Ville would chime in. ;) The first two patches are trivial, ack. But I'd really like to know what the GOP is doing, and why we're different. Not sure if that's possible. I'm afraid after much bikeshedding there were some file and function renames, and no matter what this series needs a rebase. See [1]. Sorry about the extra effort this causes; I truly appreciate your efforts with the DSI code, and I regret I haven't given this series the love it needs. No problem. I'll pick up those patches and do a rebase, I'm currently travelling so I don't have access to hardware to test this for a couple of days. I will post a rebased version when I'm back. Regards, Hans ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
