[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix includes and local vars order (rev2)
== Series Details ==
Series: drm/i915: Fix includes and local vars order (rev2)
URL : https://patchwork.freedesktop.org/series/77555/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8525_full -> Patchwork_17759_full
Summary
---
**FAILURE**
Serious unknown changes coming with Patchwork_17759_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_17759_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
---
Here are the unknown changes that may have been introduced in
Patchwork_17759_full:
### IGT changes ###
Possible regressions
* igt@kms_plane_cursor@pipe-c-viewport-size-128:
- shard-iclb: [PASS][1] -> [FAIL][2]
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-iclb7/igt@kms_plane_cur...@pipe-c-viewport-size-128.html
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-iclb4/igt@kms_plane_cur...@pipe-c-viewport-size-128.html
Warnings
* igt@kms_cursor_legacy@cursora-vs-flipb-toggle:
- shard-glk: [DMESG-FAIL][3] -> [DMESG-WARN][4]
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-glk1/igt@kms_cursor_leg...@cursora-vs-flipb-toggle.html
[4]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-glk2/igt@kms_cursor_leg...@cursora-vs-flipb-toggle.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-toggle:
- shard-glk: [DMESG-FAIL][5] ([i915#1186]) -> [DMESG-WARN][6]
[5]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-glk5/igt@kms_cursor_leg...@cursorb-vs-flipa-toggle.html
[6]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-glk8/igt@kms_cursor_leg...@cursorb-vs-flipa-toggle.html
Known issues
Here are the changes found in Patchwork_17759_full that come from known
issues:
### IGT changes ###
Issues hit
* igt@i915_suspend@forcewake:
- shard-skl: [PASS][7] -> [INCOMPLETE][8] ([i915#69])
[7]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-skl10/igt@i915_susp...@forcewake.html
[8]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-skl8/igt@i915_susp...@forcewake.html
* igt@kms_draw_crc@draw-method-xrgb2101010-render-untiled:
- shard-iclb: [PASS][9] -> [FAIL][10] ([i915#52] / [i915#54])
[9]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-iclb7/igt@kms_draw_...@draw-method-xrgb2101010-render-untiled.html
[10]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-iclb4/igt@kms_draw_...@draw-method-xrgb2101010-render-untiled.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [PASS][11] -> [DMESG-WARN][12] ([i915#180]) +1
similar issue
[11]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-kbl1/igt@kms_...@bpc-switch-suspend.html
[12]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-kbl1/igt@kms_...@bpc-switch-suspend.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-kbl: [PASS][13] -> [INCOMPLETE][14] ([i915#155])
[13]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-kbl6/igt@kms_pipe_crc_ba...@suspend-read-crc-pipe-c.html
[14]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-kbl2/igt@kms_pipe_crc_ba...@suspend-read-crc-pipe-c.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [PASS][15] -> [DMESG-WARN][16] ([i915#180]) +1
similar issue
[15]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-apl1/igt@kms_pl...@plane-panning-bottom-right-suspend-pipe-b-planes.html
[16]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-apl4/igt@kms_pl...@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][17] -> [FAIL][18] ([fdo#108145] / [i915#265])
[17]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-skl9/igt@kms_plane_alpha_bl...@pipe-c-coverage-7efc.html
[18]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-skl8/igt@kms_plane_alpha_bl...@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109441]) +1 similar
issue
[19]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[20]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/shard-iclb5/igt@kms_psr@psr2_primary_mmap_cpu.html
Possible fixes
* {igt@gem_ctx_isolation@preservation-s3@rcs0}:
- shard-apl: [DMESG-WARN][21] ([i915#180]) -> [PASS][22] +2
similar issues
[21]:
[Intel-gfx] ✓ Fi.CI.IGT: success for agp/intel: Fix a memory leak on module initialisation failure
== Series Details ==
Series: agp/intel: Fix a memory leak on module initialisation failure
URL : https://patchwork.freedesktop.org/series/77550/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8524_full -> Patchwork_17756_full
Summary
---
**SUCCESS**
No regressions found.
Known issues
Here are the changes found in Patchwork_17756_full that come from known
issues:
### IGT changes ###
Issues hit
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [PASS][1] -> [DMESG-WARN][2] ([i915#180])
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8524/shard-apl3/igt@gem_workarou...@suspend-resume-context.html
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17756/shard-apl4/igt@gem_workarou...@suspend-resume-context.html
* igt@gen9_exec_parse@allowed-all:
- shard-skl: [PASS][3] -> [DMESG-WARN][4] ([i915#1436] /
[i915#716])
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8524/shard-skl4/igt@gen9_exec_pa...@allowed-all.html
[4]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17756/shard-skl9/igt@gen9_exec_pa...@allowed-all.html
* igt@i915_suspend@forcewake:
- shard-skl: [PASS][5] -> [INCOMPLETE][6] ([i915#69])
[5]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8524/shard-skl7/igt@i915_susp...@forcewake.html
[6]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17756/shard-skl2/igt@i915_susp...@forcewake.html
* igt@kms_big_fb@y-tiled-64bpp-rotate-0:
- shard-glk: [PASS][7] -> [FAIL][8] ([i915#1119] / [i915#118] /
[i915#95])
[7]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8524/shard-glk4/igt@kms_big...@y-tiled-64bpp-rotate-0.html
[8]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17756/shard-glk8/igt@kms_big...@y-tiled-64bpp-rotate-0.html
* igt@kms_flip_tiling@flip-changes-tiling-yf:
- shard-apl: [PASS][9] -> [FAIL][10] ([i915#95])
[9]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8524/shard-apl2/igt@kms_flip_til...@flip-changes-tiling-yf.html
[10]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17756/shard-apl3/igt@kms_flip_til...@flip-changes-tiling-yf.html
* igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
- shard-skl: [PASS][11] -> [FAIL][12] ([i915#53])
[11]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8524/shard-skl4/igt@kms_pipe_crc_ba...@read-crc-pipe-b-frame-sequence.html
[12]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17756/shard-skl4/igt@kms_pipe_crc_ba...@read-crc-pipe-b-frame-sequence.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-kbl: [PASS][13] -> [DMESG-WARN][14] ([i915#180]) +2
similar issues
[13]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8524/shard-kbl3/igt@kms_pl...@plane-panning-bottom-right-suspend-pipe-b-planes.html
[14]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17756/shard-kbl6/igt@kms_pl...@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][15] -> [FAIL][16] ([fdo#108145] / [i915#265])
+1 similar issue
[15]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8524/shard-skl1/igt@kms_plane_alpha_bl...@pipe-c-constant-alpha-min.html
[16]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17756/shard-skl2/igt@kms_plane_alpha_bl...@pipe-c-constant-alpha-min.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109441]) +1 similar
issue
[17]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8524/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[18]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17756/shard-iclb4/igt@kms_psr@psr2_cursor_render.html
Possible fixes
* {igt@gem_exec_balancer@bonded-true-hang}:
- shard-tglb: [TIMEOUT][19] -> [PASS][20]
[19]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8524/shard-tglb5/igt@gem_exec_balan...@bonded-true-hang.html
[20]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17756/shard-tglb7/igt@gem_exec_balan...@bonded-true-hang.html
* igt@gem_tiled_swapping@non-threaded:
- shard-apl: [DMESG-WARN][21] ([i915#183]) -> [PASS][22]
[21]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8524/shard-apl3/igt@gem_tiled_swapp...@non-threaded.html
[22]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17756/shard-apl2/igt@gem_tiled_swapp...@non-threaded.html
* igt@gen9_exec_parse@allowed-all:
- shard-apl: [DMESG-WARN][23] ([i915#1436] / [i915#716]) ->
[PASS][24]
[23]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8524/shard-apl7/igt@gen9_exec_pa...@allowed-all.html
[24]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17756/shard-apl7/igt@gen9_exec_pa...@allowed-all.html
* igt@i915_suspend@fence-restore-untiled:
-
Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Consider DBuf bandwidth when calculating CDCLK (rev18)
Quoting Chris Wilson (2020-05-22 23:00:10) > Quoting Lisovskiy, Stanislav (2020-05-21 10:35:42) > > Seems to be unrelated issue. There seems to be some list corruption > > happening in drm fb manipulation code. > > if those patches would be causing that (like some severe mem corruption)- > > it would happen much more broadly than single test and single platform. > > Moreover there is no direct connection to the changes. > > The fi-glk-dsi failure in module reload is a result of this series. > Somehow you have angered the i915 pm around snd_hda_intel. > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17733/fi-glk-dsi/igt@i915_pm_...@module-reload.html CI says "drm/i915: Adjust CDCLK accordingly to our DBuf bw needs" is the culprit. -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gem: Avoid waiting inside mmu_notifier_invalidate_range
== Series Details == Series: drm/i915/gem: Avoid waiting inside mmu_notifier_invalidate_range URL : https://patchwork.freedesktop.org/series/77529/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8523_full -> Patchwork_17755_full Summary --- **FAILURE** Serious unknown changes coming with Patchwork_17755_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_17755_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues --- Here are the unknown changes that may have been introduced in Patchwork_17755_full: ### IGT changes ### Possible regressions * igt@gem_userptr_blits@map-fixed-invalidate-busy-gup@uc: - shard-kbl: [PASS][1] -> [INCOMPLETE][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8523/shard-kbl3/igt@gem_userptr_blits@map-fixed-invalidate-busy-...@uc.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17755/shard-kbl1/igt@gem_userptr_blits@map-fixed-invalidate-busy-...@uc.html * igt@gem_userptr_blits@map-fixed-invalidate-busy@wb: - shard-skl: [PASS][3] -> [INCOMPLETE][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8523/shard-skl10/igt@gem_userptr_blits@map-fixed-invalidate-b...@wb.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17755/shard-skl8/igt@gem_userptr_blits@map-fixed-invalidate-b...@wb.html * igt@gem_userptr_blits@sync-unmap-cycles: - shard-skl: [PASS][5] -> [DMESG-FAIL][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8523/shard-skl9/igt@gem_userptr_bl...@sync-unmap-cycles.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17755/shard-skl5/igt@gem_userptr_bl...@sync-unmap-cycles.html Known issues Here are the changes found in Patchwork_17755_full that come from known issues: ### IGT changes ### Issues hit * igt@i915_suspend@debugfs-reader: - shard-apl: [PASS][7] -> [DMESG-WARN][8] ([i915#180]) +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8523/shard-apl6/igt@i915_susp...@debugfs-reader.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17755/shard-apl1/igt@i915_susp...@debugfs-reader.html * igt@kms_cursor_crc@pipe-a-cursor-256x85-offscreen: - shard-skl: [PASS][9] -> [FAIL][10] ([i915#54]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8523/shard-skl7/igt@kms_cursor_...@pipe-a-cursor-256x85-offscreen.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17755/shard-skl2/igt@kms_cursor_...@pipe-a-cursor-256x85-offscreen.html * igt@kms_cursor_crc@pipe-b-cursor-suspend: - shard-kbl: [PASS][11] -> [DMESG-WARN][12] ([i915#180]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8523/shard-kbl6/igt@kms_cursor_...@pipe-b-cursor-suspend.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17755/shard-kbl2/igt@kms_cursor_...@pipe-b-cursor-suspend.html * igt@kms_cursor_legacy@all-pipes-torture-bo: - shard-kbl: [PASS][13] -> [DMESG-WARN][14] ([i915#128]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8523/shard-kbl6/igt@kms_cursor_leg...@all-pipes-torture-bo.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17755/shard-kbl1/igt@kms_cursor_leg...@all-pipes-torture-bo.html * igt@kms_cursor_legacy@cursorb-vs-flipa-toggle: - shard-glk: [PASS][15] -> [DMESG-FAIL][16] ([i915#1186]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8523/shard-glk5/igt@kms_cursor_leg...@cursorb-vs-flipa-toggle.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17755/shard-glk7/igt@kms_cursor_leg...@cursorb-vs-flipa-toggle.html * igt@kms_flip_tiling@flip-changes-tiling: - shard-apl: [PASS][17] -> [FAIL][18] ([i915#95]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8523/shard-apl2/igt@kms_flip_til...@flip-changes-tiling.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17755/shard-apl7/igt@kms_flip_til...@flip-changes-tiling.html - shard-kbl: [PASS][19] -> [FAIL][20] ([i915#699] / [i915#93] / [i915#95]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8523/shard-kbl1/igt@kms_flip_til...@flip-changes-tiling.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17755/shard-kbl2/igt@kms_flip_til...@flip-changes-tiling.html * igt@kms_frontbuffer_tracking@psr-rgb101010-draw-render: - shard-skl: [PASS][21] -> [FAIL][22] ([i915#49]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8523/shard-skl7/igt@kms_frontbuffer_track...@psr-rgb101010-draw-render.html [22]:
Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Consider DBuf bandwidth when calculating CDCLK (rev18)
Quoting Lisovskiy, Stanislav (2020-05-21 10:35:42) > Seems to be unrelated issue. There seems to be some list corruption happening > in drm fb manipulation code. > if those patches would be causing that (like some severe mem corruption)- it > would happen much more broadly than single test and single platform. Moreover > there is no direct connection to the changes. The fi-glk-dsi failure in module reload is a result of this series. Somehow you have angered the i915 pm around snd_hda_intel. https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17733/fi-glk-dsi/igt@i915_pm_...@module-reload.html -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsi: Dont forget to clean up the connector on error (rev2)
== Series Details == Series: drm/i915/dsi: Dont forget to clean up the connector on error (rev2) URL : https://patchwork.freedesktop.org/series/77011/ State : success == Summary == CI Bug Log - changes from CI_DRM_8527 -> Patchwork_17763 Summary --- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17763/index.html Changes --- No changes found Participating hosts (45 -> 41) -- Additional (1): fi-kbl-7560u Missing(5): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus Build changes - * Linux: CI_DRM_8527 -> Patchwork_17763 CI-20190529: 20190529 CI_DRM_8527: 5931295af1b8254640f0defa759a7363f6c896f0 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5675: 74f7488fe4f8acf901b18fc9c6c4d45a972dcad5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_17763: 1f70c324c426077d0583c0397886ffc5d02588e3 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 1f70c324c426 drm/i915/dsi: Dont forget to clean up the connector on error (v2) == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17763/index.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH] drm/i915/dsi: Dont forget to clean up the connector on error (v2)
If an error is encountered during the DSI initialization setup, the drm connector object also needs to be cleaned up along with the encoder. The error can happen due to a missing mode in the VBT or for other reasons. v2: Rephrase the commit message to make it more clear. Cc: Jani Nikula Cc: Vandita Kulkarni Signed-off-by: Vivek Kasireddy --- drivers/gpu/drm/i915/display/icl_dsi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c index 4fec5bd64920..f93f72463df5 100644 --- a/drivers/gpu/drm/i915/display/icl_dsi.c +++ b/drivers/gpu/drm/i915/display/icl_dsi.c @@ -1954,6 +1954,7 @@ void icl_dsi_init(struct drm_i915_private *dev_priv) return; err: + drm_connector_cleanup(connector); drm_encoder_cleanup(>base); kfree(intel_dsi); kfree(intel_connector); -- 2.21.1 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c (rev2)
== Series Details == Series: series starting with [CI,1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c (rev2) URL : https://patchwork.freedesktop.org/series/77566/ State : success == Summary == CI Bug Log - changes from CI_DRM_8527 -> Patchwork_17762 Summary --- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17762/index.html Changes --- No changes found Participating hosts (45 -> 40) -- Missing(5): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus Build changes - * Linux: CI_DRM_8527 -> Patchwork_17762 CI-20190529: 20190529 CI_DRM_8527: 5931295af1b8254640f0defa759a7363f6c896f0 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5675: 74f7488fe4f8acf901b18fc9c6c4d45a972dcad5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_17762: dbcf6ddb68af341343e3bad85d876ce8aa22a15e @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == dbcf6ddb68af drm/i915: convert get_user_pages() --> pin_user_pages() cd6f28206a07 mm/gup: introduce pin_user_pages_fast_only() 315ca35393cd mm/gup: refactor and de-duplicate gup_fast() code eeb23485305d mm/gup: move __get_user_pages_fast() down a few lines in gup.c == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17762/index.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c (rev2)
== Series Details == Series: series starting with [CI,1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c (rev2) URL : https://patchwork.freedesktop.org/series/77566/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1019:47:expected unsigned int [addressable] [usertype] ulClockParams +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1019:47:got restricted __le32 [usertype] +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1019:47: warning: incorrect type in assignment (different base types) +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1028:50: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1029:49: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1037:47: warning: too many warnings +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:184:44: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:283:14: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:320:14: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:323:14: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:326:14: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:329:18: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:330:26: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:338:30: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:340:38: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:342:30: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:346:30: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:348:30: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:353:33: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:367:43: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:369:38: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:374:67: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:375:53: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:378:66: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:389:80: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:395:57: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:402:69: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:403:53: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:406:66: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:414:66: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:423:69: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:424:69: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:473:30: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:476:45: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:477:45: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:484:54: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:52:28: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:531:35: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:53:29: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:533:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:54:26: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:55:27: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:56:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:57:26: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:577:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:581:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:58:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:583:21: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:586:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:590:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:59:26: warning: cast to restricted __le16
[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c (rev2)
== Series Details == Series: series starting with [CI,1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c (rev2) URL : https://patchwork.freedesktop.org/series/77566/ State : warning == Summary == $ dim checkpatch origin/drm-tip eeb23485305d mm/gup: move __get_user_pages_fast() down a few lines in gup.c -:111: CHECK:SPACING: No space is necessary after a cast #111: FILE: mm/gup.c:2766: + len = (unsigned long) nr_pages << PAGE_SHIFT; total: 0 errors, 0 warnings, 1 checks, 124 lines checked 315ca35393cd mm/gup: refactor and de-duplicate gup_fast() code cd6f28206a07 mm/gup: introduce pin_user_pages_fast_only() dbcf6ddb68af drm/i915: convert get_user_pages() --> pin_user_pages() ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v3] drm/i915/mst: filter out the display mode exceed sink's capability
On Fri, 2020-05-22 at 14:35 -0400, Lyude Paul wrote:
>
> On Tue, 2020-05-19 at 11:56 +0800, Lee Shawn C wrote:
> > So far, max dot clock rate for MST mode rely on physcial
> > bandwidth limitation. It would caused compatibility issue
> > if source display resolution exceed MST hub output ability.
> >
> > For example, source DUT had DP 1.2 output capability.
> > And MST docking just support HDMI 1.4 spec. When a HDMI 2.0
> > monitor connected. Source would retrieve EDID from external
> > and get max resolution 4k@60fps. DP 1.2 can support 4K@60fps
> > because it did not surpass DP physical bandwidth limitation.
> > Do modeset to 4k@60fps, source output display data but MST
> > docking can't output HDMI properly due to this resolution
> > already over HDMI 1.4 spec.
> >
> > Refer to commit ("drm/dp_mst: Use full_pbn
> > instead of available_pbn for bandwidth checks").
> > Source driver should refer to full_pbn to evaluate sink
> > output capability. And filter out the resolution surpass
> > sink output limitation.
> >
> > v2: Using mgr->base.lock to protect full_pbn.
> > v3: Add ctx lock.
> >
> > Cc: Manasi Navare
> > Cc: Jani Nikula
> > Cc: Ville Syrjala
> > Cc: Cooper Chiou
> > Cc: Lyude Paul
> > Signed-off-by: Lee Shawn C
> > ---
> > drivers/gpu/drm/i915/display/intel_dp_mst.c | 30 -
> > 1 file changed, 29 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > index 74559379384a..6b6f7eef5b68 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> > @@ -611,6 +611,32 @@ static int intel_dp_mst_get_modes(struct drm_connector
> > *connector)
> > return intel_dp_mst_get_ddc_modes(connector);
> > }
> >
> > +static bool
> > +intel_dp_mst_mode_clock_exceed_pbn_bandwidth(struct drm_connector
> > *connector,
> > int clock, int bpp)
> > +{
> > + struct intel_connector *intel_connector = to_intel_connector(connector);
> > + struct intel_dp *intel_dp = intel_connector->mst_port;
> > + struct drm_dp_mst_topology_mgr *mgr = _dp->mst_mgr;
> > + struct drm_dp_mst_port *port = (to_intel_connector(connector))->port;
> > + struct drm_modeset_acquire_ctx ctx;
> > + bool ret = false;
> > +
> > + if (!mgr)
> > + return ret;
> > +
> > + drm_modeset_acquire_init(, 0);
> > +
> > + drm_modeset_lock(>base.lock, );
> > + if (port->full_pbn)
> > + ret = (drm_dp_calc_pbn_mode(clock, bpp, false) > port-
> > > full_pbn);
> > + drm_modeset_unlock(>base.lock);
> > +
> > + drm_modeset_drop_locks();
> > + drm_modeset_acquire_fini();
> > +
> > + return ret;
> > +}
>
> Sorry to do this, but this still isn't right :s, and will likely end up
> deadlocking. I'm going to write up a fixed version of this patch and add you
> in
> the Co-developed-by: tag, shouldn't take too long for me to do so I can send
> it
> out today
Completely forgot to actually explain what was wrong here - this creates an
acquisition context that would be separate from the caller's lock acquisition
context. So, drm_helper_probe_single_connector_modes() would grab
connection_mutex before calling the hook, and since it's not using an
acquisition context we could potentially deadlock when locking >base.lock
if another thread locked >base.lock before connection_mutex. If we add a
lock acquisition context to drm_helper_probe_single_connector_modes and use that
to grab >base.lock, the ww-mutex code can detect the deadlock and give us a
chance to back off and try again.
anyway-i'll send out the new version of the patch asap
> > +
> > static enum drm_mode_status
> > intel_dp_mst_mode_valid(struct drm_connector *connector,
> > struct drm_display_mode *mode)
> > @@ -633,7 +659,9 @@ intel_dp_mst_mode_valid(struct drm_connector *connector,
> > max_rate = intel_dp_max_data_rate(max_link_clock, max_lanes);
> > mode_rate = intel_dp_link_required(mode->clock, 18);
> >
> > - /* TODO - validate mode against available PBN for link */
> > + if (intel_dp_mst_mode_clock_exceed_pbn_bandwidth(connector, mode-
> > >clock,
> > 24))
> > + return MODE_CLOCK_HIGH;
> > +
> > if (mode->clock < 1)
> > return MODE_CLOCK_LOW;
> >
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v3] drm/i915/mst: filter out the display mode exceed sink's capability
On Tue, 2020-05-19 at 11:56 +0800, Lee Shawn C wrote:
> So far, max dot clock rate for MST mode rely on physcial
> bandwidth limitation. It would caused compatibility issue
> if source display resolution exceed MST hub output ability.
>
> For example, source DUT had DP 1.2 output capability.
> And MST docking just support HDMI 1.4 spec. When a HDMI 2.0
> monitor connected. Source would retrieve EDID from external
> and get max resolution 4k@60fps. DP 1.2 can support 4K@60fps
> because it did not surpass DP physical bandwidth limitation.
> Do modeset to 4k@60fps, source output display data but MST
> docking can't output HDMI properly due to this resolution
> already over HDMI 1.4 spec.
>
> Refer to commit ("drm/dp_mst: Use full_pbn
> instead of available_pbn for bandwidth checks").
> Source driver should refer to full_pbn to evaluate sink
> output capability. And filter out the resolution surpass
> sink output limitation.
>
> v2: Using mgr->base.lock to protect full_pbn.
> v3: Add ctx lock.
>
> Cc: Manasi Navare
> Cc: Jani Nikula
> Cc: Ville Syrjala
> Cc: Cooper Chiou
> Cc: Lyude Paul
> Signed-off-by: Lee Shawn C
> ---
> drivers/gpu/drm/i915/display/intel_dp_mst.c | 30 -
> 1 file changed, 29 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> index 74559379384a..6b6f7eef5b68 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> @@ -611,6 +611,32 @@ static int intel_dp_mst_get_modes(struct drm_connector
> *connector)
> return intel_dp_mst_get_ddc_modes(connector);
> }
>
> +static bool
> +intel_dp_mst_mode_clock_exceed_pbn_bandwidth(struct drm_connector *connector,
> int clock, int bpp)
> +{
> + struct intel_connector *intel_connector = to_intel_connector(connector);
> + struct intel_dp *intel_dp = intel_connector->mst_port;
> + struct drm_dp_mst_topology_mgr *mgr = _dp->mst_mgr;
> + struct drm_dp_mst_port *port = (to_intel_connector(connector))->port;
> + struct drm_modeset_acquire_ctx ctx;
> + bool ret = false;
> +
> + if (!mgr)
> + return ret;
> +
> + drm_modeset_acquire_init(, 0);
> +
> + drm_modeset_lock(>base.lock, );
> + if (port->full_pbn)
> + ret = (drm_dp_calc_pbn_mode(clock, bpp, false) > port-
> >full_pbn);
> + drm_modeset_unlock(>base.lock);
> +
> + drm_modeset_drop_locks();
> + drm_modeset_acquire_fini();
> +
> + return ret;
> +}
Sorry to do this, but this still isn't right :s, and will likely end up
deadlocking. I'm going to write up a fixed version of this patch and add you in
the Co-developed-by: tag, shouldn't take too long for me to do so I can send it
out today
> +
> static enum drm_mode_status
> intel_dp_mst_mode_valid(struct drm_connector *connector,
> struct drm_display_mode *mode)
> @@ -633,7 +659,9 @@ intel_dp_mst_mode_valid(struct drm_connector *connector,
> max_rate = intel_dp_max_data_rate(max_link_clock, max_lanes);
> mode_rate = intel_dp_link_required(mode->clock, 18);
>
> - /* TODO - validate mode against available PBN for link */
> + if (intel_dp_mst_mode_clock_exceed_pbn_bandwidth(connector,
> mode->clock,
> 24))
> + return MODE_CLOCK_HIGH;
> +
> if (mode->clock < 1)
> return MODE_CLOCK_LOW;
>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c
== Series Details ==
Series: series starting with [CI,1/4] mm/gup: move __get_user_pages_fast() down
a few lines in gup.c
URL : https://patchwork.freedesktop.org/series/77566/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8526 -> Patchwork_17761
Summary
---
**FAILURE**
Serious unknown changes coming with Patchwork_17761 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_17761, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17761/index.html
Possible new issues
---
Here are the unknown changes that may have been introduced in Patchwork_17761:
### IGT changes ###
Possible regressions
* igt@i915_selftest@live@hangcheck:
- fi-cml-s: [PASS][1] -> [DMESG-FAIL][2]
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8526/fi-cml-s/igt@i915_selftest@l...@hangcheck.html
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17761/fi-cml-s/igt@i915_selftest@l...@hangcheck.html
Suppressed
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@kms_flip@basic-flip-vs-wf_vblank@a-hdmi-a1}:
- fi-elk-e7500: [PASS][3] -> [FAIL][4]
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8526/fi-elk-e7500/igt@kms_flip@basic-flip-vs-wf_vbl...@a-hdmi-a1.html
[4]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17761/fi-elk-e7500/igt@kms_flip@basic-flip-vs-wf_vbl...@a-hdmi-a1.html
Known issues
Here are the changes found in Patchwork_17761 that come from known issues:
### IGT changes ###
Issues hit
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [PASS][5] -> [FAIL][6] ([i915#262])
[5]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8526/fi-kbl-7500u/igt@kms_chamel...@dp-crc-fast.html
[6]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17761/fi-kbl-7500u/igt@kms_chamel...@dp-crc-fast.html
Possible fixes
* igt@i915_selftest@live@sanitycheck:
- fi-bwr-2160:[INCOMPLETE][7] ([i915#489]) -> [PASS][8]
[7]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8526/fi-bwr-2160/igt@i915_selftest@l...@sanitycheck.html
[8]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17761/fi-bwr-2160/igt@i915_selftest@l...@sanitycheck.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
[i915#489]: https://gitlab.freedesktop.org/drm/intel/issues/489
Participating hosts (45 -> 40)
--
Missing(5): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper
fi-bdw-samus
Build changes
-
* Linux: CI_DRM_8526 -> Patchwork_17761
CI-20190529: 20190529
CI_DRM_8526: 9592ac944021f6ace6a96f17001c0531fb538d7f @
git://anongit.freedesktop.org/gfx-ci/linux
IGT_5675: 74f7488fe4f8acf901b18fc9c6c4d45a972dcad5 @
git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17761: 2324b68859350bafca08bab5980a48d2185b90b6 @
git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
2324b6885935 drm/i915: convert get_user_pages() --> pin_user_pages()
25611799150b mm/gup: introduce pin_user_pages_fast_only()
8f94b0b105bb mm/gup: refactor and de-duplicate gup_fast() code
48c15b755cba mm/gup: move __get_user_pages_fast() down a few lines in gup.c
== Logs ==
For more details see:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17761/index.html
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c
== Series Details == Series: series starting with [CI,1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c URL : https://patchwork.freedesktop.org/series/77566/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1019:47:expected unsigned int [addressable] [usertype] ulClockParams +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1019:47:got restricted __le32 [usertype] +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1019:47: warning: incorrect type in assignment (different base types) +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1028:50: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1029:49: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:1037:47: warning: too many warnings +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:184:44: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:283:14: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:320:14: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:323:14: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:326:14: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:329:18: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:330:26: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:338:30: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:340:38: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:342:30: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:346:30: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:348:30: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:353:33: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:367:43: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:369:38: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:374:67: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:375:53: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:378:66: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:389:80: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:395:57: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:402:69: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:403:53: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:406:66: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:414:66: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:423:69: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:424:69: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:473:30: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:476:45: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:477:45: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:484:54: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:52:28: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:531:35: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:53:29: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:533:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:54:26: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:55:27: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:56:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:57:26: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:577:21: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:581:25: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:58:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:583:21: warning: cast to restricted __le32 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:586:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:590:25: warning: cast to restricted __le16 +drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c:59:26: warning: cast to restricted __le16
[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c
== Series Details == Series: series starting with [CI,1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c URL : https://patchwork.freedesktop.org/series/77566/ State : warning == Summary == $ dim checkpatch origin/drm-tip 48c15b755cba mm/gup: move __get_user_pages_fast() down a few lines in gup.c -:111: CHECK:SPACING: No space is necessary after a cast #111: FILE: mm/gup.c:2766: + len = (unsigned long) nr_pages << PAGE_SHIFT; total: 0 errors, 0 warnings, 1 checks, 124 lines checked 8f94b0b105bb mm/gup: refactor and de-duplicate gup_fast() code 25611799150b mm/gup: introduce pin_user_pages_fast_only() 2324b6885935 drm/i915: convert get_user_pages() --> pin_user_pages() ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [CI 3/4] mm/gup: introduce pin_user_pages_fast_only()
From: John Hubbard
This is the FOLL_PIN equivalent of __get_user_pages_fast(),
except with a more descriptive name, and gup_flags instead of
a boolean "write" in the argument list.
Signed-off-by: John Hubbard
---
include/linux/mm.h | 2 ++
mm/gup.c | 36
2 files changed, 38 insertions(+)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index bf1c6258198a..95761246d255 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -1818,6 +1818,8 @@ extern int mprotect_fixup(struct vm_area_struct *vma,
*/
int __get_user_pages_fast(unsigned long start, int nr_pages, int write,
struct page **pages);
+int pin_user_pages_fast_only(unsigned long start, int nr_pages,
+unsigned int gup_flags, struct page **pages);
/*
* per-process(per-mm_struct) statistics.
*/
diff --git a/mm/gup.c b/mm/gup.c
index dd2fe8f72b4b..e381b550cbd8 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -2859,6 +2859,42 @@ int pin_user_pages_fast(unsigned long start, int
nr_pages,
}
EXPORT_SYMBOL_GPL(pin_user_pages_fast);
+/*
+ * This is the FOLL_PIN equivalent of __get_user_pages_fast(). Behavior is the
+ * same, except that this one sets FOLL_PIN instead of FOLL_GET.
+ *
+ * The API rules are the same, too: no negative values may be returned.
+ */
+int pin_user_pages_fast_only(unsigned long start, int nr_pages,
+unsigned int gup_flags, struct page **pages)
+{
+ int nr_pinned;
+
+ /*
+* FOLL_GET and FOLL_PIN are mutually exclusive. Note that the API
+* rules require returning 0, rather than -errno:
+*/
+ if (WARN_ON_ONCE(gup_flags & FOLL_GET))
+ return 0;
+ /*
+* FOLL_FAST_ONLY is required in order to match the API description of
+* this routine: no fall back to regular ("slow") GUP.
+*/
+ gup_flags |= (FOLL_PIN | FOLL_FAST_ONLY);
+ nr_pinned = internal_get_user_pages_fast(start, nr_pages, gup_flags,
+pages);
+ /*
+* This routine is not allowed to return negative values. However,
+* internal_get_user_pages_fast() *can* return -errno. Therefore,
+* correct for that here:
+*/
+ if (nr_pinned < 0)
+ nr_pinned = 0;
+
+ return nr_pinned;
+}
+EXPORT_SYMBOL_GPL(pin_user_pages_fast_only);
+
/**
* pin_user_pages_remote() - pin pages of a remote process (task != current)
*
--
2.20.1
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [CI 1/4] mm/gup: move __get_user_pages_fast() down a few lines in gup.c
From: John Hubbard
This is in order to avoid a forward declaration of
internal_get_user_pages_fast(), in the next patch.
This is code movement only--all generated code should
be identical.
Signed-off-by: John Hubbard
---
mm/gup.c | 112 +++
1 file changed, 56 insertions(+), 56 deletions(-)
diff --git a/mm/gup.c b/mm/gup.c
index 87a6a59fe667..a9a7e305bd46 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -2666,62 +2666,6 @@ static bool gup_fast_permitted(unsigned long start,
unsigned long end)
}
#endif
-/*
- * Like get_user_pages_fast() except it's IRQ-safe in that it won't fall back
to
- * the regular GUP.
- * Note a difference with get_user_pages_fast: this always returns the
- * number of pages pinned, 0 if no pages were pinned.
- *
- * If the architecture does not support this function, simply return with no
- * pages pinned.
- */
-int __get_user_pages_fast(unsigned long start, int nr_pages, int write,
- struct page **pages)
-{
- unsigned long len, end;
- unsigned long flags;
- int nr_pinned = 0;
- /*
-* Internally (within mm/gup.c), gup fast variants must set FOLL_GET,
-* because gup fast is always a "pin with a +1 page refcount" request.
-*/
- unsigned int gup_flags = FOLL_GET;
-
- if (write)
- gup_flags |= FOLL_WRITE;
-
- start = untagged_addr(start) & PAGE_MASK;
- len = (unsigned long) nr_pages << PAGE_SHIFT;
- end = start + len;
-
- if (end <= start)
- return 0;
- if (unlikely(!access_ok((void __user *)start, len)))
- return 0;
-
- /*
-* Disable interrupts. We use the nested form as we can already have
-* interrupts disabled by get_futex_key.
-*
-* With interrupts disabled, we block page table pages from being
-* freed from under us. See struct mmu_table_batch comments in
-* include/asm-generic/tlb.h for more details.
-*
-* We do not adopt an rcu_read_lock(.) here as we also want to
-* block IPIs that come from THPs splitting.
-*/
-
- if (IS_ENABLED(CONFIG_HAVE_FAST_GUP) &&
- gup_fast_permitted(start, end)) {
- local_irq_save(flags);
- gup_pgd_range(start, end, gup_flags, pages, _pinned);
- local_irq_restore(flags);
- }
-
- return nr_pinned;
-}
-EXPORT_SYMBOL_GPL(__get_user_pages_fast);
-
static int __gup_longterm_unlocked(unsigned long start, int nr_pages,
unsigned int gup_flags, struct page **pages)
{
@@ -2794,6 +2738,62 @@ static int internal_get_user_pages_fast(unsigned long
start, int nr_pages,
return ret;
}
+/*
+ * Like get_user_pages_fast() except it's IRQ-safe in that it won't fall back
to
+ * the regular GUP.
+ * Note a difference with get_user_pages_fast: this always returns the
+ * number of pages pinned, 0 if no pages were pinned.
+ *
+ * If the architecture does not support this function, simply return with no
+ * pages pinned.
+ */
+int __get_user_pages_fast(unsigned long start, int nr_pages, int write,
+ struct page **pages)
+{
+ unsigned long len, end;
+ unsigned long flags;
+ int nr_pinned = 0;
+ /*
+* Internally (within mm/gup.c), gup fast variants must set FOLL_GET,
+* because gup fast is always a "pin with a +1 page refcount" request.
+*/
+ unsigned int gup_flags = FOLL_GET;
+
+ if (write)
+ gup_flags |= FOLL_WRITE;
+
+ start = untagged_addr(start) & PAGE_MASK;
+ len = (unsigned long) nr_pages << PAGE_SHIFT;
+ end = start + len;
+
+ if (end <= start)
+ return 0;
+ if (unlikely(!access_ok((void __user *)start, len)))
+ return 0;
+
+ /*
+* Disable interrupts. We use the nested form as we can already have
+* interrupts disabled by get_futex_key.
+*
+* With interrupts disabled, we block page table pages from being
+* freed from under us. See struct mmu_table_batch comments in
+* include/asm-generic/tlb.h for more details.
+*
+* We do not adopt an rcu_read_lock(.) here as we also want to
+* block IPIs that come from THPs splitting.
+*/
+
+ if (IS_ENABLED(CONFIG_HAVE_FAST_GUP) &&
+ gup_fast_permitted(start, end)) {
+ local_irq_save(flags);
+ gup_pgd_range(start, end, gup_flags, pages, _pinned);
+ local_irq_restore(flags);
+ }
+
+ return nr_pinned;
+}
+EXPORT_SYMBOL_GPL(__get_user_pages_fast);
+
/**
* get_user_pages_fast() - pin user pages in memory
* @start: starting user address
--
2.20.1
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [CI 2/4] mm/gup: refactor and de-duplicate gup_fast() code
From: John Hubbard
There were two nearly identical sets of code for gup_fast()
style of walking the page tables with interrupts disabled.
This has lead to the usual maintenance problems that arise from
having duplicated code.
There is already a core internal routine in gup.c for gup_fast(),
so just enhance it very slightly: allow skipping the fall-back
to "slow" (regular) get_user_pages(), via the new FOLL_FAST_ONLY
flag. Then, just call internal_get_user_pages_fast() from
__get_user_pages_fast(), and adjust the API to match pre-existing
API behavior.
There is a change in behavior from this refactoring: the nested
form of interrupt disabling is used in all gup_fast() variants
now. That's because there is only one place that interrupt disabling
for page walking is done, and so the safer form is required. This
should, if anything, eliminate possible (rare) bugs, because the
non-nested form of enabling interrupts was fragile at best.
Signed-off-by: John Hubbard
---
include/linux/mm.h | 1 +
mm/gup.c | 63 ++
2 files changed, 31 insertions(+), 33 deletions(-)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 5a323422d783..bf1c6258198a 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -2780,6 +2780,7 @@ struct page *follow_page(struct vm_area_struct *vma,
unsigned long address,
#define FOLL_LONGTERM 0x1 /* mapping lifetime is indefinite: see below */
#define FOLL_SPLIT_PMD 0x2 /* split huge pmd before returning */
#define FOLL_PIN 0x4 /* pages must be released via unpin_user_page */
+#define FOLL_FAST_ONLY 0x8 /* gup_fast: prevent fall-back to slow gup */
/*
* FOLL_PIN and FOLL_LONGTERM may be used in various combinations with each
diff --git a/mm/gup.c b/mm/gup.c
index a9a7e305bd46..dd2fe8f72b4b 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -2694,10 +2694,12 @@ static int internal_get_user_pages_fast(unsigned long
start, int nr_pages,
struct page **pages)
{
unsigned long addr, len, end;
+ unsigned long flags;
int nr_pinned = 0, ret = 0;
if (WARN_ON_ONCE(gup_flags & ~(FOLL_WRITE | FOLL_LONGTERM |
- FOLL_FORCE | FOLL_PIN | FOLL_GET)))
+ FOLL_FORCE | FOLL_PIN | FOLL_GET |
+ FOLL_FAST_ONLY)))
return -EINVAL;
start = untagged_addr(start) & PAGE_MASK;
@@ -2710,15 +2712,26 @@ static int internal_get_user_pages_fast(unsigned long
start, int nr_pages,
if (unlikely(!access_ok((void __user *)start, len)))
return -EFAULT;
+ /*
+* Disable interrupts. The nested form is used, in order to allow full,
+* general purpose use of this routine.
+*
+* With interrupts disabled, we block page table pages from being
+* freed from under us. See struct mmu_table_batch comments in
+* include/asm-generic/tlb.h for more details.
+*
+* We do not adopt an rcu_read_lock(.) here as we also want to
+* block IPIs that come from THPs splitting.
+*/
if (IS_ENABLED(CONFIG_HAVE_FAST_GUP) &&
gup_fast_permitted(start, end)) {
- local_irq_disable();
+ local_irq_save(flags);
gup_pgd_range(addr, end, gup_flags, pages, _pinned);
- local_irq_enable();
+ local_irq_restore(flags);
ret = nr_pinned;
}
- if (nr_pinned < nr_pages) {
+ if (nr_pinned < nr_pages && !(gup_flags & FOLL_FAST_ONLY)) {
/* Try to get the remaining pages with get_user_pages */
start += nr_pinned << PAGE_SHIFT;
pages += nr_pinned;
@@ -2750,45 +2763,29 @@ static int internal_get_user_pages_fast(unsigned long
start, int nr_pages,
int __get_user_pages_fast(unsigned long start, int nr_pages, int write,
struct page **pages)
{
- unsigned long len, end;
- unsigned long flags;
- int nr_pinned = 0;
+ int nr_pinned;
/*
* Internally (within mm/gup.c), gup fast variants must set FOLL_GET,
* because gup fast is always a "pin with a +1 page refcount" request.
+*
+* FOLL_FAST_ONLY is required in order to match the API description of
+* this routine: no fall back to regular ("slow") GUP.
*/
- unsigned int gup_flags = FOLL_GET;
+ unsigned int gup_flags = FOLL_GET | FOLL_FAST_ONLY;
if (write)
gup_flags |= FOLL_WRITE;
- start = untagged_addr(start) & PAGE_MASK;
- len = (unsigned long) nr_pages << PAGE_SHIFT;
- end = start + len;
-
- if (end <= start)
- return 0;
- if (unlikely(!access_ok((void __user *)start, len)))
- return 0;
-
+ nr_pinned = internal_get_user_pages_fast(start, nr_pages,
[Intel-gfx] [CI 4/4] drm/i915: convert get_user_pages() --> pin_user_pages()
From: John Hubbard
This code was using get_user_pages*(), in a "Case 2" scenario
(DMA/RDMA), using the categorization from [1]. That means that it's
time to convert the get_user_pages*() + put_page() calls to
pin_user_pages*() + unpin_user_pages() calls.
There is some helpful background in [2]: basically, this is a small
part of fixing a long-standing disconnect between pinning pages, and
file systems' use of those pages.
[1] Documentation/core-api/pin_user_pages.rst
[2] "Explicit pinning of user-space pages":
https://lwn.net/Articles/807108/
Signed-off-by: John Hubbard
---
drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 22 -
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
index 8b0708708671..4d3c0c2fdbb0 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
@@ -471,7 +471,7 @@ __i915_gem_userptr_get_pages_worker(struct work_struct
*_work)
down_read(>mmap_sem);
locked = 1;
}
- ret = get_user_pages_remote
+ ret = pin_user_pages_remote
(work->task, mm,
obj->userptr.ptr + pinned * PAGE_SIZE,
npages - pinned,
@@ -507,7 +507,7 @@ __i915_gem_userptr_get_pages_worker(struct work_struct
*_work)
}
mutex_unlock(>mm.lock);
- release_pages(pvec, pinned);
+ unpin_user_pages(pvec, pinned);
kvfree(pvec);
i915_gem_object_put(obj);
@@ -564,6 +564,7 @@ static int i915_gem_userptr_get_pages(struct
drm_i915_gem_object *obj)
struct sg_table *pages;
bool active;
int pinned;
+ unsigned int gup_flags = 0;
/* If userspace should engineer that these pages are replaced in
* the vma between us binding this page into the GTT and completion
@@ -598,11 +599,14 @@ static int i915_gem_userptr_get_pages(struct
drm_i915_gem_object *obj)
GFP_KERNEL |
__GFP_NORETRY |
__GFP_NOWARN);
- if (pvec) /* defer to worker if malloc fails */
- pinned = __get_user_pages_fast(obj->userptr.ptr,
- num_pages,
-
!i915_gem_object_is_readonly(obj),
- pvec);
+ /* defer to worker if malloc fails */
+ if (pvec) {
+ if (!i915_gem_object_is_readonly(obj))
+ gup_flags |= FOLL_WRITE;
+ pinned = pin_user_pages_fast_only(obj->userptr.ptr,
+ num_pages, gup_flags,
+ pvec);
+ }
}
active = false;
@@ -620,7 +624,7 @@ static int i915_gem_userptr_get_pages(struct
drm_i915_gem_object *obj)
__i915_gem_userptr_set_active(obj, true);
if (IS_ERR(pages))
- release_pages(pvec, pinned);
+ unpin_user_pages(pvec, pinned);
kvfree(pvec);
return PTR_ERR_OR_ZERO(pages);
@@ -675,7 +679,7 @@ i915_gem_userptr_put_pages(struct drm_i915_gem_object *obj,
}
mark_page_accessed(page);
- put_page(page);
+ unpin_user_page(page);
}
obj->mm.dirty = false;
--
2.20.1
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/execlists: Shortcircuit queue_prio() for no internal levels
== Series Details ==
Series: series starting with [1/2] drm/i915/execlists: Shortcircuit
queue_prio() for no internal levels
URL : https://patchwork.freedesktop.org/series/77518/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8520_full -> Patchwork_17754_full
Summary
---
**SUCCESS**
No regressions found.
Possible new issues
---
Here are the unknown changes that may have been introduced in
Patchwork_17754_full:
### IGT changes ###
Suppressed
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@gem_exec_balancer@bonded-true-hang}:
- shard-kbl: [PASS][1] -> [TIMEOUT][2]
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8520/shard-kbl4/igt@gem_exec_balan...@bonded-true-hang.html
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17754/shard-kbl6/igt@gem_exec_balan...@bonded-true-hang.html
New tests
-
New tests have been introduced between CI_DRM_8520_full and
Patchwork_17754_full:
### New IGT tests (2) ###
* igt@i915_query@engine-info:
- Statuses : 7 pass(s)
- Exec time: [0.0] s
* igt@i915_query@engine-info-invalid:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s
Known issues
Here are the changes found in Patchwork_17754_full that come from known
issues:
### IGT changes ###
Issues hit
* igt@gem_exec_suspend@basic-s3:
- shard-kbl: [PASS][3] -> [DMESG-WARN][4] ([i915#180] / [i915#93]
/ [i915#95])
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8520/shard-kbl6/igt@gem_exec_susp...@basic-s3.html
[4]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17754/shard-kbl1/igt@gem_exec_susp...@basic-s3.html
* igt@gem_fenced_exec_thrash@2-spare-fences:
- shard-snb: [PASS][5] -> [INCOMPLETE][6] ([i915#82])
[5]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8520/shard-snb5/igt@gem_fenced_exec_thr...@2-spare-fences.html
[6]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17754/shard-snb1/igt@gem_fenced_exec_thr...@2-spare-fences.html
* igt@gen9_exec_parse@allowed-all:
- shard-skl: [PASS][7] -> [DMESG-WARN][8] ([i915#1436] /
[i915#716])
[7]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8520/shard-skl3/igt@gen9_exec_pa...@allowed-all.html
[8]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17754/shard-skl9/igt@gen9_exec_pa...@allowed-all.html
* igt@kms_cursor_crc@pipe-c-cursor-64x21-random:
- shard-skl: [PASS][9] -> [FAIL][10] ([i915#54])
[9]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8520/shard-skl6/igt@kms_cursor_...@pipe-c-cursor-64x21-random.html
[10]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17754/shard-skl5/igt@kms_cursor_...@pipe-c-cursor-64x21-random.html
- shard-kbl: [PASS][11] -> [FAIL][12] ([i915#54])
[11]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8520/shard-kbl1/igt@kms_cursor_...@pipe-c-cursor-64x21-random.html
[12]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17754/shard-kbl6/igt@kms_cursor_...@pipe-c-cursor-64x21-random.html
- shard-apl: [PASS][13] -> [FAIL][14] ([i915#54])
[13]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8520/shard-apl1/igt@kms_cursor_...@pipe-c-cursor-64x21-random.html
[14]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17754/shard-apl1/igt@kms_cursor_...@pipe-c-cursor-64x21-random.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-apl: [PASS][15] -> [DMESG-WARN][16] ([i915#180]) +1
similar issue
[15]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8520/shard-apl4/igt@kms_cursor_...@pipe-c-cursor-suspend.html
[16]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17754/shard-apl4/igt@kms_cursor_...@pipe-c-cursor-suspend.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [PASS][17] -> [FAIL][18] ([i915#72])
[17]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8520/shard-glk9/igt@kms_cursor_leg...@2x-long-flip-vs-cursor-atomic.html
[18]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17754/shard-glk6/igt@kms_cursor_leg...@2x-long-flip-vs-cursor-atomic.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][19] -> [FAIL][20] ([i915#1188]) +2 similar
issues
[19]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8520/shard-skl2/igt@kms_...@bpc-switch-dpms.html
[20]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17754/shard-skl4/igt@kms_...@bpc-switch-dpms.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-apl: [PASS][21] -> [DMESG-WARN][22] ([i915#180] /
[i915#95])
[21]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8520/shard-apl6/igt@kms_pipe_crc_ba...@suspend-read-crc-pipe-c.html
[22]:
[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Stop cross-poluting PIN_GLOBAL with PIN_USER with no-ppgtt
== Series Details ==
Series: drm/i915/gt: Stop cross-poluting PIN_GLOBAL with PIN_USER with no-ppgtt
URL : https://patchwork.freedesktop.org/series/77517/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8520_full -> Patchwork_17753_full
Summary
---
**FAILURE**
Serious unknown changes coming with Patchwork_17753_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_17753_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
---
Here are the unknown changes that may have been introduced in
Patchwork_17753_full:
### IGT changes ###
Possible regressions
* igt@runner@aborted:
- shard-iclb: NOTRUN -> [FAIL][1]
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17753/shard-iclb2/igt@run...@aborted.html
Suppressed
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@i915_selftest@perf@request}:
- shard-iclb: [PASS][2] -> [INCOMPLETE][3]
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8520/shard-iclb5/igt@i915_selftest@p...@request.html
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17753/shard-iclb2/igt@i915_selftest@p...@request.html
Known issues
Here are the changes found in Patchwork_17753_full that come from known
issues:
### IGT changes ###
Issues hit
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-kbl: [PASS][4] -> [DMESG-WARN][5] ([i915#180]) +2 similar
issues
[4]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8520/shard-kbl3/igt@i915_susp...@fence-restore-tiled2untiled.html
[5]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17753/shard-kbl7/igt@i915_susp...@fence-restore-tiled2untiled.html
* igt@kms_cursor_crc@pipe-c-cursor-64x21-random:
- shard-skl: [PASS][6] -> [FAIL][7] ([i915#54])
[6]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8520/shard-skl6/igt@kms_cursor_...@pipe-c-cursor-64x21-random.html
[7]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17753/shard-skl9/igt@kms_cursor_...@pipe-c-cursor-64x21-random.html
- shard-kbl: [PASS][8] -> [FAIL][9] ([i915#54])
[8]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8520/shard-kbl1/igt@kms_cursor_...@pipe-c-cursor-64x21-random.html
[9]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17753/shard-kbl1/igt@kms_cursor_...@pipe-c-cursor-64x21-random.html
- shard-apl: [PASS][10] -> [FAIL][11] ([i915#54])
[10]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8520/shard-apl1/igt@kms_cursor_...@pipe-c-cursor-64x21-random.html
[11]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17753/shard-apl2/igt@kms_cursor_...@pipe-c-cursor-64x21-random.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [PASS][12] -> [FAIL][13] ([i915#72])
[12]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8520/shard-glk9/igt@kms_cursor_leg...@2x-long-flip-vs-cursor-legacy.html
[13]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17753/shard-glk6/igt@kms_cursor_leg...@2x-long-flip-vs-cursor-legacy.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-untiled:
- shard-snb: [PASS][14] -> [INCOMPLETE][15] ([i915#82])
[14]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8520/shard-snb5/igt@kms_draw_...@draw-method-xrgb2101010-mmap-cpu-untiled.html
[15]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17753/shard-snb1/igt@kms_draw_...@draw-method-xrgb2101010-mmap-cpu-untiled.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][16] -> [DMESG-WARN][17] ([i915#165] /
[i915#93] / [i915#95])
[16]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8520/shard-kbl1/igt@kms_frontbuffer_track...@fbc-suspend.html
[17]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17753/shard-kbl1/igt@kms_frontbuffer_track...@fbc-suspend.html
* igt@kms_hdr@bpc-switch:
- shard-skl: [PASS][18] -> [FAIL][19] ([i915#1188])
[18]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8520/shard-skl3/igt@kms_...@bpc-switch.html
[19]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17753/shard-skl3/igt@kms_...@bpc-switch.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-apl: [PASS][20] -> [DMESG-WARN][21] ([i915#180])
[20]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8520/shard-apl7/igt@kms_pipe_crc_ba...@suspend-read-crc-pipe-b.html
[21]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17753/shard-apl8/igt@kms_pipe_crc_ba...@suspend-read-crc-pipe-b.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-kbl: [PASS][22] ->
[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gem: Avoid iterating an empty list (rev2)
== Series Details == Series: drm/i915/gem: Avoid iterating an empty list (rev2) URL : https://patchwork.freedesktop.org/series/77553/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8525 -> Patchwork_17760 Summary --- **FAILURE** Serious unknown changes coming with Patchwork_17760 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_17760, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17760/index.html Possible new issues --- Here are the unknown changes that may have been introduced in Patchwork_17760: ### CI changes ### Possible regressions * boot: - fi-kbl-8809g: [PASS][1] -> [FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/fi-kbl-8809g/boot.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17760/fi-kbl-8809g/boot.html - fi-icl-y: [PASS][3] -> [FAIL][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/fi-icl-y/boot.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17760/fi-icl-y/boot.html - fi-snb-2520m: [PASS][5] -> [FAIL][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/fi-snb-2520m/boot.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17760/fi-snb-2520m/boot.html - fi-icl-u2: [PASS][7] -> [FAIL][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/fi-icl-u2/boot.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17760/fi-icl-u2/boot.html - fi-cfl-8109u: [PASS][9] -> [FAIL][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/fi-cfl-8109u/boot.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17760/fi-cfl-8109u/boot.html - fi-skl-6600u: [PASS][11] -> [FAIL][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/fi-skl-6600u/boot.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17760/fi-skl-6600u/boot.html - fi-byt-j1900: [PASS][13] -> [FAIL][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/fi-byt-j1900/boot.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17760/fi-byt-j1900/boot.html - fi-cfl-8700k: [PASS][15] -> [FAIL][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/fi-cfl-8700k/boot.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17760/fi-cfl-8700k/boot.html - fi-icl-dsi: [PASS][17] -> [FAIL][18] [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/fi-icl-dsi/boot.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17760/fi-icl-dsi/boot.html - fi-whl-u: [PASS][19] -> [FAIL][20] [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/fi-whl-u/boot.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17760/fi-whl-u/boot.html - fi-ilk-650: [PASS][21] -> [FAIL][22] [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/fi-ilk-650/boot.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17760/fi-ilk-650/boot.html - fi-skl-6700k2: [PASS][23] -> [FAIL][24] [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/fi-skl-6700k2/boot.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17760/fi-skl-6700k2/boot.html - fi-icl-guc: [PASS][25] -> [FAIL][26] [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/fi-icl-guc/boot.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17760/fi-icl-guc/boot.html - fi-cml-s: [PASS][27] -> [FAIL][28] [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/fi-cml-s/boot.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17760/fi-cml-s/boot.html - fi-byt-n2820: [PASS][29] -> [FAIL][30] [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/fi-byt-n2820/boot.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17760/fi-byt-n2820/boot.html - fi-elk-e7500: [PASS][31] -> [FAIL][32] [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/fi-elk-e7500/boot.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17760/fi-elk-e7500/boot.html - fi-skl-lmem:[PASS][33] -> [FAIL][34] [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/fi-skl-lmem/boot.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17760/fi-skl-lmem/boot.html - fi-glk-dsi: [PASS][35] -> [FAIL][36] [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8525/fi-glk-dsi/boot.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17760/fi-glk-dsi/boot.html - fi-ivb-3770:[PASS][37] -> [FAIL][38] [37]:
[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix includes and local vars order (rev2)
== Series Details == Series: drm/i915: Fix includes and local vars order (rev2) URL : https://patchwork.freedesktop.org/series/77555/ State : success == Summary == CI Bug Log - changes from CI_DRM_8525 -> Patchwork_17759 Summary --- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/index.html Changes --- No changes found Participating hosts (46 -> 41) -- Missing(5): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus Build changes - * Linux: CI_DRM_8525 -> Patchwork_17759 CI-20190529: 20190529 CI_DRM_8525: 56110c7afae3bbeb681960494b92b745c6802e1f @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5675: 74f7488fe4f8acf901b18fc9c6c4d45a972dcad5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_17759: cf01279ccf923a066f5fc2cab3bf2a0fab76c497 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == cf01279ccf92 drm/i915: Fix includes and local vars order == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17759/index.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix includes and local vars order
== Series Details == Series: drm/i915: Fix includes and local vars order URL : https://patchwork.freedesktop.org/series/77555/ State : success == Summary == CI Bug Log - changes from CI_DRM_8525 -> Patchwork_17758 Summary --- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17758/index.html Changes --- No changes found Participating hosts (46 -> 41) -- Missing(5): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus Build changes - * Linux: CI_DRM_8525 -> Patchwork_17758 CI-20190529: 20190529 CI_DRM_8525: 56110c7afae3bbeb681960494b92b745c6802e1f @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5675: 74f7488fe4f8acf901b18fc9c6c4d45a972dcad5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_17758: 87c2ef00d4d73bc4f578977e9d8017950d6ef268 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 87c2ef00d4d7 drm/i915: Fix includes and local vars order == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17758/index.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [CI] drm/i915/gem: Avoid iterating an empty list
Our __sgt_iter assumes that the scattergather list has at least one
element. But during construction we may fail in allocating the first
page, and so mark the first element as the terminator. This is
unexpected!
[22555.524752] RIP: 0010:shmem_get_pages+0x506/0x710 [i915]
[22555.524759] Code: 49 8b 2c 24 31 c0 66 89 44 24 40 48 85 ed 0f 84 62 01 00
00 4c 8b 75 00 8b 5d 08 44 8b 7d 0c 48 8b 0d 7e 34 07 e2 49 83 e6 fc <49> 8b 16
41 01 df 48 89 cf 48 89 d0 48 c1 e8 2d 48 85 c9 0f 84 c8
[22555.524765] RSP: 0018:c953f9d0 EFLAGS: 00010246
[22555.524770] RAX: RBX: RCX: 8881a000
[22555.524774] RDX: fff4 RSI: RDI: 821efe00
[22555.524778] RBP: 8881b099ab00 R08: R09: fff4
[22555.524782] R10: 0002 R11: ffec0a02 R12: 8881cd3c8d60
[22555.524786] R13: fff4 R14: R15:
[22555.524790] FS: 7f4fbeb9b9c0() GS:8881f858()
knlGS:
[22555.524795] CS: 0010 DS: ES: CR0: 80050033
[22555.524799] CR2: CR3: 0001ec7f0004 CR4: 001606e0
[22555.524803] Call Trace:
[22555.524919] __i915_gem_object_get_pages+0x4f/0x60 [i915]
Fixes: 85d1225ec066 ("drm/i915: Introduce & use new lightweight SGL iterators")
Signed-off-by: Chris Wilson
Cc: Matthew Auld
Cc: Tvrtko Ursulin
Cc: # v4.8+
Reviewed-by: Matthew Auld
Reviewed-by: Maciej Patelczyk
---
drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 15 +--
drivers/gpu/drm/i915/i915_scatterlist.h | 2 ++
2 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
index 5d5d7eef3f43..7aff3514d97a 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
@@ -39,7 +39,6 @@ static int shmem_get_pages(struct drm_i915_gem_object *obj)
unsigned long last_pfn = 0; /* suppress gcc warning */
unsigned int max_segment = i915_sg_segment_size();
unsigned int sg_page_sizes;
- struct pagevec pvec;
gfp_t noreclaim;
int ret;
@@ -192,13 +191,17 @@ static int shmem_get_pages(struct drm_i915_gem_object
*obj)
sg_mark_end(sg);
err_pages:
mapping_clear_unevictable(mapping);
- pagevec_init();
- for_each_sgt_page(page, sgt_iter, st) {
- if (!pagevec_add(, page))
+ if (sg != st->sgl) {
+ struct pagevec pvec;
+
+ pagevec_init();
+ for_each_sgt_page(page, sgt_iter, st) {
+ if (!pagevec_add(, page))
+ check_release_pagevec();
+ }
+ if (pagevec_count())
check_release_pagevec();
}
- if (pagevec_count())
- check_release_pagevec();
sg_free_table(st);
kfree(st);
diff --git a/drivers/gpu/drm/i915/i915_scatterlist.h
b/drivers/gpu/drm/i915/i915_scatterlist.h
index b7b59328cb76..5041c268f450 100644
--- a/drivers/gpu/drm/i915/i915_scatterlist.h
+++ b/drivers/gpu/drm/i915/i915_scatterlist.h
@@ -27,6 +27,8 @@ static __always_inline struct sgt_iter {
} __sgt_iter(struct scatterlist *sgl, bool dma) {
struct sgt_iter s = { .sgp = sgl };
+ GEM_BUG_ON(sg_is_chain(s.sgp) || sg_is_last(s.sgp));
+
if (s.sgp) {
s.max = s.curr = s.sgp->offset;
s.max += s.sgp->length;
--
2.20.1
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH v2] drm/i915: Fix includes and local vars order
Removed duplicate include and fixed comment > 80 chars.
v2: Added newline after system include and between functions
Reviewed-by: Chris Wilson
Signed-off-by: Stanislav Lisovskiy
---
drivers/gpu/drm/i915/display/intel_bw.c| 44 --
drivers/gpu/drm/i915/display/intel_bw.h| 2 +-
drivers/gpu/drm/i915/display/intel_cdclk.c | 3 +-
drivers/gpu/drm/i915/display/intel_cdclk.h | 1 +
drivers/gpu/drm/i915/intel_pm.c| 3 +-
drivers/gpu/drm/i915/intel_pm.h| 2 +-
6 files changed, 31 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bw.c
b/drivers/gpu/drm/i915/display/intel_bw.c
index 8d2f58e39595..a79bd7aeb03b 100644
--- a/drivers/gpu/drm/i915/display/intel_bw.c
+++ b/drivers/gpu/drm/i915/display/intel_bw.c
@@ -5,13 +5,12 @@
#include
+#include "intel_atomic.h"
#include "intel_bw.h"
-#include "intel_pm.h"
+#include "intel_cdclk.h"
#include "intel_display_types.h"
-#include "intel_sideband.h"
-#include "intel_atomic.h"
#include "intel_pm.h"
-#include "intel_cdclk.h"
+#include "intel_sideband.h"
/* Parameters for Qclk Geyserville (QGV) */
struct intel_qgv_point {
@@ -352,6 +351,7 @@ static unsigned int intel_bw_crtc_data_rate(const struct
intel_crtc_state *crtc_
return data_rate;
}
+
void intel_bw_crtc_update(struct intel_bw_state *bw_state,
const struct intel_crtc_state *crtc_state)
{
@@ -431,13 +431,13 @@ intel_atomic_get_bw_state(struct intel_atomic_state
*state)
int skl_bw_calc_min_cdclk(struct intel_atomic_state *state)
{
struct drm_i915_private *dev_priv = to_i915(state->base.dev);
- int i;
+ struct intel_bw_state *new_bw_state = NULL;
+ struct intel_bw_state *old_bw_state = NULL;
const struct intel_crtc_state *crtc_state;
struct intel_crtc *crtc;
int max_bw = 0;
int slice_id;
- struct intel_bw_state *new_bw_state = NULL;
- struct intel_bw_state *old_bw_state = NULL;
+ int i;
for_each_new_intel_crtc_in_state(state, crtc, crtc_state, i) {
enum plane_id plane_id;
@@ -463,14 +463,17 @@ int skl_bw_calc_min_cdclk(struct intel_atomic_state
*state)
dbuf_mask |= skl_ddb_dbuf_slice_mask(dev_priv,
uv_plane_alloc);
/*
-* FIXME: To calculate that more properly we probably
need to
-* to split per plane data_rate into data_rate_y and
data_rate_uv
-* for multiplanar formats in order not to get
accounted those twice
-* if they happen to reside on different slices.
-* However for pre-icl this would work anyway because
we have only single
-* slice and for icl+ uv plane has non-zero data rate.
-* So in worst case those calculation are a bit
pessimistic, which
-* shouldn't pose any significant problem anyway.
+* FIXME: To calculate that more properly we probably
+* need to to split per plane data_rate into data_rate_y
+* and data_rate_uv for multiplanar formats in order not
+* to get accounted those twice if they happen to reside
+* on different slices.
+* However for pre-icl this would work anyway because
+* we have only single slice and for icl+ uv plane has
+* non-zero data rate.
+* So in worst case those calculation are a bit
+* pessimistic, which shouldn't pose any significant
+* problem anyway.
*/
for_each_dbuf_slice_in_mask(slice_id, dbuf_mask)
crtc_bw->used_bw[slice_id] += data_rate;
@@ -478,11 +481,12 @@ int skl_bw_calc_min_cdclk(struct intel_atomic_state
*state)
for_each_dbuf_slice(slice_id) {
/*
-* Current experimental observations show that contrary
to BSpec
-* we get underruns once we exceed 64 * CDCLK for
slices in total.
-* As a temporary measure in order not to keep CDCLK
bumped up all the
-* time we calculate CDCLK according to this formula
for overall bw
-* consumed by slices.
+* Current experimental observations show that contrary
+* to BSpec we get underruns once we exceed 64 * CDCLK
+* for slices in total.
+* As a temporary measure in order not to keep CDCLK
+* bumped up all the time we calculate CDCLK according
+* to this formula for overall bw consumed by slices.
Re: [Intel-gfx] [PATCH v1] drm/i915: Fix includes and local vars order
On Fri, May 22, 2020 at 02:05:26PM +0100, Chris Wilson wrote: > Quoting Stanislav Lisovskiy (2020-05-22 13:55:34) > > Removed duplicate include and fixed comment > 80 chars. > > > > Signed-off-by: Stanislav Lisovskiy > > --- > > drivers/gpu/drm/i915/display/intel_bw.c| 43 -- > > drivers/gpu/drm/i915/display/intel_bw.h| 2 +- > > drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +- > > drivers/gpu/drm/i915/display/intel_cdclk.h | 1 + > > drivers/gpu/drm/i915/intel_pm.c| 3 +- > > drivers/gpu/drm/i915/intel_pm.h| 2 +- > > 6 files changed, 29 insertions(+), 24 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c > > b/drivers/gpu/drm/i915/display/intel_bw.c > > index 8d2f58e39595..db9ba8f922bd 100644 > > --- a/drivers/gpu/drm/i915/display/intel_bw.c > > +++ b/drivers/gpu/drm/i915/display/intel_bw.c > > @@ -5,13 +5,12 @@ > > > > #include > > > > +#include "intel_atomic.h" > > #include "intel_bw.h" > > -#include "intel_pm.h" > > +#include "intel_cdclk.h" > > #include "intel_display_types.h" > > -#include "intel_sideband.h" > > -#include "intel_atomic.h" > > #include "intel_pm.h" > > -#include "intel_cdclk.h" > > +#include "intel_sideband.h" > > There was also the accidental remove of a '\n' before > intel_bw_crtc_update() Weird..how didn't I spot this. > > > diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c > > b/drivers/gpu/drm/i915/display/intel_cdclk.c > > index dda9bae02a86..643701cca6ba 100644 > > --- a/drivers/gpu/drm/i915/display/intel_cdclk.c > > +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c > > @@ -23,10 +23,10 @@ > > > > #include > > \n between system and local includes > > > #include "intel_atomic.h" > > +#include "intel_bw.h" > > #include "intel_cdclk.h" > > #include "intel_display_types.h" > > #include "intel_sideband.h" > > -#include "intel_bw.h" > > 2 more nits then > Reviewed-by: Chris Wilson > s/Reviewed/Critiqued/ > -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v1] drm/i915: Fix includes and local vars order
Quoting Stanislav Lisovskiy (2020-05-22 13:55:34) > Removed duplicate include and fixed comment > 80 chars. > > Signed-off-by: Stanislav Lisovskiy > --- > drivers/gpu/drm/i915/display/intel_bw.c| 43 -- > drivers/gpu/drm/i915/display/intel_bw.h| 2 +- > drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +- > drivers/gpu/drm/i915/display/intel_cdclk.h | 1 + > drivers/gpu/drm/i915/intel_pm.c| 3 +- > drivers/gpu/drm/i915/intel_pm.h| 2 +- > 6 files changed, 29 insertions(+), 24 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c > b/drivers/gpu/drm/i915/display/intel_bw.c > index 8d2f58e39595..db9ba8f922bd 100644 > --- a/drivers/gpu/drm/i915/display/intel_bw.c > +++ b/drivers/gpu/drm/i915/display/intel_bw.c > @@ -5,13 +5,12 @@ > > #include > > +#include "intel_atomic.h" > #include "intel_bw.h" > -#include "intel_pm.h" > +#include "intel_cdclk.h" > #include "intel_display_types.h" > -#include "intel_sideband.h" > -#include "intel_atomic.h" > #include "intel_pm.h" > -#include "intel_cdclk.h" > +#include "intel_sideband.h" There was also the accidental remove of a '\n' before intel_bw_crtc_update() > diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c > b/drivers/gpu/drm/i915/display/intel_cdclk.c > index dda9bae02a86..643701cca6ba 100644 > --- a/drivers/gpu/drm/i915/display/intel_cdclk.c > +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c > @@ -23,10 +23,10 @@ > > #include \n between system and local includes > #include "intel_atomic.h" > +#include "intel_bw.h" > #include "intel_cdclk.h" > #include "intel_display_types.h" > #include "intel_sideband.h" > -#include "intel_bw.h" 2 more nits then Reviewed-by: Chris Wilson s/Reviewed/Critiqued/ -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH v1] drm/i915: Fix includes and local vars order
Removed duplicate include and fixed comment > 80 chars.
Signed-off-by: Stanislav Lisovskiy
---
drivers/gpu/drm/i915/display/intel_bw.c| 43 --
drivers/gpu/drm/i915/display/intel_bw.h| 2 +-
drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +-
drivers/gpu/drm/i915/display/intel_cdclk.h | 1 +
drivers/gpu/drm/i915/intel_pm.c| 3 +-
drivers/gpu/drm/i915/intel_pm.h| 2 +-
6 files changed, 29 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bw.c
b/drivers/gpu/drm/i915/display/intel_bw.c
index 8d2f58e39595..db9ba8f922bd 100644
--- a/drivers/gpu/drm/i915/display/intel_bw.c
+++ b/drivers/gpu/drm/i915/display/intel_bw.c
@@ -5,13 +5,12 @@
#include
+#include "intel_atomic.h"
#include "intel_bw.h"
-#include "intel_pm.h"
+#include "intel_cdclk.h"
#include "intel_display_types.h"
-#include "intel_sideband.h"
-#include "intel_atomic.h"
#include "intel_pm.h"
-#include "intel_cdclk.h"
+#include "intel_sideband.h"
/* Parameters for Qclk Geyserville (QGV) */
struct intel_qgv_point {
@@ -431,13 +430,13 @@ intel_atomic_get_bw_state(struct intel_atomic_state
*state)
int skl_bw_calc_min_cdclk(struct intel_atomic_state *state)
{
struct drm_i915_private *dev_priv = to_i915(state->base.dev);
- int i;
+ struct intel_bw_state *new_bw_state = NULL;
+ struct intel_bw_state *old_bw_state = NULL;
const struct intel_crtc_state *crtc_state;
struct intel_crtc *crtc;
int max_bw = 0;
int slice_id;
- struct intel_bw_state *new_bw_state = NULL;
- struct intel_bw_state *old_bw_state = NULL;
+ int i;
for_each_new_intel_crtc_in_state(state, crtc, crtc_state, i) {
enum plane_id plane_id;
@@ -463,14 +462,17 @@ int skl_bw_calc_min_cdclk(struct intel_atomic_state
*state)
dbuf_mask |= skl_ddb_dbuf_slice_mask(dev_priv,
uv_plane_alloc);
/*
-* FIXME: To calculate that more properly we probably
need to
-* to split per plane data_rate into data_rate_y and
data_rate_uv
-* for multiplanar formats in order not to get
accounted those twice
-* if they happen to reside on different slices.
-* However for pre-icl this would work anyway because
we have only single
-* slice and for icl+ uv plane has non-zero data rate.
-* So in worst case those calculation are a bit
pessimistic, which
-* shouldn't pose any significant problem anyway.
+* FIXME: To calculate that more properly we probably
+* need to to split per plane data_rate into data_rate_y
+* and data_rate_uv for multiplanar formats in order not
+* to get accounted those twice if they happen to reside
+* on different slices.
+* However for pre-icl this would work anyway because
+* we have only single slice and for icl+ uv plane has
+* non-zero data rate.
+* So in worst case those calculation are a bit
+* pessimistic, which shouldn't pose any significant
+* problem anyway.
*/
for_each_dbuf_slice_in_mask(slice_id, dbuf_mask)
crtc_bw->used_bw[slice_id] += data_rate;
@@ -478,11 +480,12 @@ int skl_bw_calc_min_cdclk(struct intel_atomic_state
*state)
for_each_dbuf_slice(slice_id) {
/*
-* Current experimental observations show that contrary
to BSpec
-* we get underruns once we exceed 64 * CDCLK for
slices in total.
-* As a temporary measure in order not to keep CDCLK
bumped up all the
-* time we calculate CDCLK according to this formula
for overall bw
-* consumed by slices.
+* Current experimental observations show that contrary
+* to BSpec we get underruns once we exceed 64 * CDCLK
+* for slices in total.
+* As a temporary measure in order not to keep CDCLK
+* bumped up all the time we calculate CDCLK according
+* to this formula for overall bw consumed by slices.
*/
max_bw += crtc_bw->used_bw[slice_id];
}
diff --git a/drivers/gpu/drm/i915/display/intel_bw.h
b/drivers/gpu/drm/i915/display/intel_bw.h
index af1a981dec84..46c6eecbd917 100644
--- a/drivers/gpu/drm/i915/display/intel_bw.h
+++ b/drivers/gpu/drm/i915/display/intel_bw.h
@@ -9,8 +9,8 @@
#include
Re: [Intel-gfx] [PATCH] drm/i915/gem: Avoid iterating an empty list
On Fri, 22 May 2020 at 13:02, Chris Wilson wrote:
>
> Quoting Chris Wilson (2020-05-22 11:42:07)
> > Our __sgt_iter assumes that the scattergather list has at least one
> > element. But during construction we may fail in allocating the first
> > page, and so mark the first element as the terminator. This is
> > unexpected!
> >
> > [22555.524752] RIP: 0010:shmem_get_pages+0x506/0x710 [i915]
> > [22555.524759] Code: 49 8b 2c 24 31 c0 66 89 44 24 40 48 85 ed 0f 84 62 01
> > 00 00 4c 8b 75 00 8b 5d 08 44 8b 7d 0c 48 8b 0d 7e 34 07 e2 49 83 e6 fc
> > <49> 8b 16 41 01 df 48 89 cf 48 89 d0 48 c1 e8 2d 48 85 c9 0f 84 c8
> > [22555.524765] RSP: 0018:c953f9d0 EFLAGS: 00010246
> > [22555.524770] RAX: RBX: RCX:
> > 8881a000
> > [22555.524774] RDX: fff4 RSI: RDI:
> > 821efe00
> > [22555.524778] RBP: 8881b099ab00 R08: R09:
> > fff4
> > [22555.524782] R10: 0002 R11: ffec0a02 R12:
> > 8881cd3c8d60
> > [22555.524786] R13: fff4 R14: R15:
> >
> > [22555.524790] FS: 7f4fbeb9b9c0() GS:8881f858()
> > knlGS:
> > [22555.524795] CS: 0010 DS: ES: CR0: 80050033
> > [22555.524799] CR2: CR3: 0001ec7f0004 CR4:
> > 001606e0
> > [22555.524803] Call Trace:
> > [22555.524919] __i915_gem_object_get_pages+0x4f/0x60 [i915]
> >
>
> Fixes: 85d1225ec066 ("drm/i915: Introduce & use new lightweight SGL
> iterators")
> > Signed-off-by: Chris Wilson
> > Cc: Matthew Auld
> > Cc: Tvrtko Ursulin
> Cc: # v4.8+
Reviewed-by: Matthew Auld
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm/i915/gem: Avoid iterating an empty list
Quoting Chris Wilson (2020-05-22 11:42:07)
> Our __sgt_iter assumes that the scattergather list has at least one
> element. But during construction we may fail in allocating the first
> page, and so mark the first element as the terminator. This is
> unexpected!
>
> [22555.524752] RIP: 0010:shmem_get_pages+0x506/0x710 [i915]
> [22555.524759] Code: 49 8b 2c 24 31 c0 66 89 44 24 40 48 85 ed 0f 84 62 01 00
> 00 4c 8b 75 00 8b 5d 08 44 8b 7d 0c 48 8b 0d 7e 34 07 e2 49 83 e6 fc <49> 8b
> 16 41 01 df 48 89 cf 48 89 d0 48 c1 e8 2d 48 85 c9 0f 84 c8
> [22555.524765] RSP: 0018:c953f9d0 EFLAGS: 00010246
> [22555.524770] RAX: RBX: RCX:
> 8881a000
> [22555.524774] RDX: fff4 RSI: RDI:
> 821efe00
> [22555.524778] RBP: 8881b099ab00 R08: R09:
> fff4
> [22555.524782] R10: 0002 R11: ffec0a02 R12:
> 8881cd3c8d60
> [22555.524786] R13: fff4 R14: R15:
>
> [22555.524790] FS: 7f4fbeb9b9c0() GS:8881f858()
> knlGS:
> [22555.524795] CS: 0010 DS: ES: CR0: 80050033
> [22555.524799] CR2: CR3: 0001ec7f0004 CR4:
> 001606e0
> [22555.524803] Call Trace:
> [22555.524919] __i915_gem_object_get_pages+0x4f/0x60 [i915]
>
Fixes: 85d1225ec066 ("drm/i915: Introduce & use new lightweight SGL iterators")
> Signed-off-by: Chris Wilson
> Cc: Matthew Auld
> Cc: Tvrtko Ursulin
Cc: # v4.8+
> ---
> drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 15 +--
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
> b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
> index 5d5d7eef3f43..7aff3514d97a 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
> @@ -39,7 +39,6 @@ static int shmem_get_pages(struct drm_i915_gem_object *obj)
> unsigned long last_pfn = 0; /* suppress gcc warning */
> unsigned int max_segment = i915_sg_segment_size();
> unsigned int sg_page_sizes;
> - struct pagevec pvec;
> gfp_t noreclaim;
> int ret;
>
> @@ -192,13 +191,17 @@ static int shmem_get_pages(struct drm_i915_gem_object
> *obj)
> sg_mark_end(sg);
> err_pages:
> mapping_clear_unevictable(mapping);
> - pagevec_init();
> - for_each_sgt_page(page, sgt_iter, st) {
> - if (!pagevec_add(, page))
> + if (sg != st->sgl) {
> + struct pagevec pvec;
> +
> + pagevec_init();
> + for_each_sgt_page(page, sgt_iter, st) {
> + if (!pagevec_add(, page))
> + check_release_pagevec();
> + }
> + if (pagevec_count())
> check_release_pagevec();
> }
> - if (pagevec_count())
> - check_release_pagevec();
> sg_free_table(st);
> kfree(st);
>
> --
> 2.20.1
>
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 0/4] mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()
Hi John, On Tue, May 19, 2020 at 5:51 AM John Hubbard wrote: > > This needs to go through Andrew's -mm tree, due to adding a new gup.c > routine. However, I would really love to have some testing from the > drm/i915 folks, because I haven't been able to run-time test that part > of it. > > Otherwise, though, the series has passed my basic run time testing: > some LTP tests, some xfs and etx4 non-destructive xfstests, and an > assortment of other smaller ones: vm selftests, io_uring_register, a > few more. But that's only on one particular machine. Also, cross-compile > tests for half a dozen arches all pass. > > Details: > > In order to convert the drm/i915 driver from get_user_pages() to > pin_user_pages(), a FOLL_PIN equivalent of __get_user_pages_fast() was > required. That led to refactoring __get_user_pages_fast(), with the > following goals: > > 1) As above: provide a pin_user_pages*() routine for drm/i915 to call, >in place of __get_user_pages_fast(), > > 2) Get rid of the gup.c duplicate code for walking page tables with >interrupts disabled. This duplicate code is a minor maintenance >problem anyway. > > 3) Make it easy for an upcoming patch from Souptick, which aims to >convert __get_user_pages_fast() to use a gup_flags argument, instead >of a bool writeable arg. Also, if this series looks good, we can >ask Souptick to change the name as well, to whatever the consensus >is. My initial recommendation is: get_user_pages_fast_only(), to >match the new pin_user_pages_only(). Shall I hold my changes till 5.8-rc1 , when this series will appear upstream ? > > John Hubbard (4): > mm/gup: move __get_user_pages_fast() down a few lines in gup.c > mm/gup: refactor and de-duplicate gup_fast() code > mm/gup: introduce pin_user_pages_fast_only() > drm/i915: convert get_user_pages() --> pin_user_pages() > > drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 22 +-- > include/linux/mm.h | 3 + > mm/gup.c| 150 > 3 files changed, 107 insertions(+), 68 deletions(-) > > > base-commit: 642b151f45dd54809ea00ecd3976a56c1ec9b53d > -- > 2.26.2 > ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Avoid iterating an empty list
== Series Details == Series: drm/i915/gem: Avoid iterating an empty list URL : https://patchwork.freedesktop.org/series/77553/ State : success == Summary == CI Bug Log - changes from CI_DRM_8524 -> Patchwork_17757 Summary --- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17757/index.html Known issues Here are the changes found in Patchwork_17757 that come from known issues: ### IGT changes ### Possible fixes * igt@kms_chamelium@hdmi-hpd-fast: - fi-kbl-7500u: [FAIL][1] ([i915#227]) -> [PASS][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8524/fi-kbl-7500u/igt@kms_chamel...@hdmi-hpd-fast.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17757/fi-kbl-7500u/igt@kms_chamel...@hdmi-hpd-fast.html Warnings * igt@i915_pm_rpm@module-reload: - fi-kbl-x1275: [FAIL][3] ([i915#62] / [i915#95]) -> [SKIP][4] ([fdo#109271]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8524/fi-kbl-x1275/igt@i915_pm_...@module-reload.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17757/fi-kbl-x1275/igt@i915_pm_...@module-reload.html [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [i915#227]: https://gitlab.freedesktop.org/drm/intel/issues/227 [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (45 -> 41) -- Additional (1): fi-kbl-7560u Missing(5): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-tgl-y fi-byt-clapper Build changes - * Linux: CI_DRM_8524 -> Patchwork_17757 CI-20190529: 20190529 CI_DRM_8524: 14a61eda3439d0655e4438f77310479a6da8c583 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5673: f37cd37470612616f65914bca35497ca13aeb11a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_17757: 40aca02e9196eb820853fdfd5a36513c48526dea @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 40aca02e9196 drm/i915/gem: Avoid iterating an empty list == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17757/index.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH] drm/i915/gem: Avoid iterating an empty list
Our __sgt_iter assumes that the scattergather list has at least one
element. But during construction we may fail in allocating the first
page, and so mark the first element as the terminator. This is
unexpected!
[22555.524752] RIP: 0010:shmem_get_pages+0x506/0x710 [i915]
[22555.524759] Code: 49 8b 2c 24 31 c0 66 89 44 24 40 48 85 ed 0f 84 62 01 00
00 4c 8b 75 00 8b 5d 08 44 8b 7d 0c 48 8b 0d 7e 34 07 e2 49 83 e6 fc <49> 8b 16
41 01 df 48 89 cf 48 89 d0 48 c1 e8 2d 48 85 c9 0f 84 c8
[22555.524765] RSP: 0018:c953f9d0 EFLAGS: 00010246
[22555.524770] RAX: RBX: RCX: 8881a000
[22555.524774] RDX: fff4 RSI: RDI: 821efe00
[22555.524778] RBP: 8881b099ab00 R08: R09: fff4
[22555.524782] R10: 0002 R11: ffec0a02 R12: 8881cd3c8d60
[22555.524786] R13: fff4 R14: R15:
[22555.524790] FS: 7f4fbeb9b9c0() GS:8881f858()
knlGS:
[22555.524795] CS: 0010 DS: ES: CR0: 80050033
[22555.524799] CR2: CR3: 0001ec7f0004 CR4: 001606e0
[22555.524803] Call Trace:
[22555.524919] __i915_gem_object_get_pages+0x4f/0x60 [i915]
Signed-off-by: Chris Wilson
Cc: Matthew Auld
Cc: Tvrtko Ursulin
---
drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
index 5d5d7eef3f43..7aff3514d97a 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
@@ -39,7 +39,6 @@ static int shmem_get_pages(struct drm_i915_gem_object *obj)
unsigned long last_pfn = 0; /* suppress gcc warning */
unsigned int max_segment = i915_sg_segment_size();
unsigned int sg_page_sizes;
- struct pagevec pvec;
gfp_t noreclaim;
int ret;
@@ -192,13 +191,17 @@ static int shmem_get_pages(struct drm_i915_gem_object
*obj)
sg_mark_end(sg);
err_pages:
mapping_clear_unevictable(mapping);
- pagevec_init();
- for_each_sgt_page(page, sgt_iter, st) {
- if (!pagevec_add(, page))
+ if (sg != st->sgl) {
+ struct pagevec pvec;
+
+ pagevec_init();
+ for_each_sgt_page(page, sgt_iter, st) {
+ if (!pagevec_add(, page))
+ check_release_pagevec();
+ }
+ if (pagevec_count())
check_release_pagevec();
}
- if (pagevec_count())
- check_release_pagevec();
sg_free_table(st);
kfree(st);
--
2.20.1
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Remove PIN_UPDATE for i915_vma_pin
== Series Details ==
Series: drm/i915: Remove PIN_UPDATE for i915_vma_pin
URL : https://patchwork.freedesktop.org/series/77515/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8518_full -> Patchwork_17752_full
Summary
---
**SUCCESS**
No regressions found.
Known issues
Here are the changes found in Patchwork_17752_full that come from known
issues:
### IGT changes ###
Issues hit
* igt@gem_ctx_persistence@engines-hostile@rcs0:
- shard-iclb: [PASS][1] -> [FAIL][2] ([i915#1622])
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8518/shard-iclb8/igt@gem_ctx_persistence@engines-host...@rcs0.html
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17752/shard-iclb4/igt@gem_ctx_persistence@engines-host...@rcs0.html
- shard-tglb: [PASS][3] -> [FAIL][4] ([i915#1622])
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8518/shard-tglb2/igt@gem_ctx_persistence@engines-host...@rcs0.html
[4]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17752/shard-tglb1/igt@gem_ctx_persistence@engines-host...@rcs0.html
* igt@gem_workarounds@suspend-resume:
- shard-skl: [PASS][5] -> [INCOMPLETE][6] ([i915#69])
[5]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8518/shard-skl6/igt@gem_workarou...@suspend-resume.html
[6]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17752/shard-skl9/igt@gem_workarou...@suspend-resume.html
* igt@i915_suspend@sysfs-reader:
- shard-kbl: [PASS][7] -> [DMESG-WARN][8] ([i915#180]) +4 similar
issues
[7]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8518/shard-kbl6/igt@i915_susp...@sysfs-reader.html
[8]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17752/shard-kbl1/igt@i915_susp...@sysfs-reader.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][9] -> [DMESG-WARN][10] ([i915#180] / [i915#93]
/ [i915#95])
[9]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8518/shard-kbl2/igt@kms_frontbuffer_track...@fbc-suspend.html
[10]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17752/shard-kbl2/igt@kms_frontbuffer_track...@fbc-suspend.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][11] -> [FAIL][12] ([i915#1188])
[11]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8518/shard-skl2/igt@kms_...@bpc-switch-suspend.html
[12]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17752/shard-skl4/igt@kms_...@bpc-switch-suspend.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][13] -> [FAIL][14] ([fdo#108145] / [i915#265])
+1 similar issue
[13]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8518/shard-skl1/igt@kms_plane_alpha_bl...@pipe-a-constant-alpha-min.html
[14]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17752/shard-skl1/igt@kms_plane_alpha_bl...@pipe-a-constant-alpha-min.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#109441]) +2 similar
issues
[15]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8518/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[16]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17752/shard-iclb1/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-apl: [PASS][17] -> [DMESG-WARN][18] ([i915#180])
[17]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8518/shard-apl8/igt@kms_vbl...@pipe-b-ts-continuation-suspend.html
[18]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17752/shard-apl4/igt@kms_vbl...@pipe-b-ts-continuation-suspend.html
Possible fixes
* {igt@gem_ctx_isolation@preservation-s3@vecs0}:
- shard-skl: [INCOMPLETE][19] ([i915#198]) -> [PASS][20]
[19]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8518/shard-skl10/igt@gem_ctx_isolation@preservation...@vecs0.html
[20]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17752/shard-skl7/igt@gem_ctx_isolation@preservation...@vecs0.html
* igt@gem_ctx_persistence@engines-hostile@vecs0:
- shard-iclb: [FAIL][21] ([i915#1622]) -> [PASS][22]
[21]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8518/shard-iclb8/igt@gem_ctx_persistence@engines-host...@vecs0.html
[22]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17752/shard-iclb4/igt@gem_ctx_persistence@engines-host...@vecs0.html
* igt@gem_softpin@noreloc-s3:
- shard-skl: [INCOMPLETE][23] ([i915#69]) -> [PASS][24]
[23]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8518/shard-skl6/igt@gem_soft...@noreloc-s3.html
[24]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17752/shard-skl10/igt@gem_soft...@noreloc-s3.html
* igt@i915_suspend@forcewake:
- shard-kbl: [DMESG-WARN][25] ([i915#180]) -> [PASS][26] +3
similar issues
[25]:
[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/2] drm/i915: Disable semaphore inter-engine sync without timeslicing
== Series Details == Series: series starting with [CI,1/2] drm/i915: Disable semaphore inter-engine sync without timeslicing URL : https://patchwork.freedesktop.org/series/77512/ State : failure == Summary == CI Bug Log - changes from CI_DRM_8518_full -> Patchwork_17751_full Summary --- **FAILURE** Serious unknown changes coming with Patchwork_17751_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_17751_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues --- Here are the unknown changes that may have been introduced in Patchwork_17751_full: ### IGT changes ### Possible regressions * igt@gem_eio@in-flight-suspend: - shard-apl: [PASS][1] -> [TIMEOUT][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8518/shard-apl6/igt@gem_...@in-flight-suspend.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17751/shard-apl2/igt@gem_...@in-flight-suspend.html * igt@kms_plane_scaling@pipe-b-scaler-with-pixel-format: - shard-apl: [PASS][3] -> [FAIL][4] +7 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8518/shard-apl6/igt@kms_plane_scal...@pipe-b-scaler-with-pixel-format.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17751/shard-apl2/igt@kms_plane_scal...@pipe-b-scaler-with-pixel-format.html Known issues Here are the changes found in Patchwork_17751_full that come from known issues: ### IGT changes ### Issues hit * igt@gem_ctx_persistence@engines-hostile@rcs0: - shard-iclb: [PASS][5] -> [FAIL][6] ([i915#1622]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8518/shard-iclb8/igt@gem_ctx_persistence@engines-host...@rcs0.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17751/shard-iclb7/igt@gem_ctx_persistence@engines-host...@rcs0.html - shard-kbl: [PASS][7] -> [FAIL][8] ([i915#1622]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8518/shard-kbl2/igt@gem_ctx_persistence@engines-host...@rcs0.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17751/shard-kbl4/igt@gem_ctx_persistence@engines-host...@rcs0.html * igt@kms_cursor_crc@pipe-a-cursor-64x64-random: - shard-skl: [PASS][9] -> [FAIL][10] ([i915#54]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8518/shard-skl4/igt@kms_cursor_...@pipe-a-cursor-64x64-random.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17751/shard-skl9/igt@kms_cursor_...@pipe-a-cursor-64x64-random.html * igt@kms_cursor_crc@pipe-b-cursor-suspend: - shard-apl: [PASS][11] -> [DMESG-WARN][12] ([i915#180]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8518/shard-apl6/igt@kms_cursor_...@pipe-b-cursor-suspend.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17751/shard-apl4/igt@kms_cursor_...@pipe-b-cursor-suspend.html * igt@kms_cursor_legacy@pipe-c-torture-move: - shard-tglb: [PASS][13] -> [DMESG-WARN][14] ([i915#128]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8518/shard-tglb1/igt@kms_cursor_leg...@pipe-c-torture-move.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17751/shard-tglb3/igt@kms_cursor_leg...@pipe-c-torture-move.html * igt@kms_hdr@bpc-switch-suspend: - shard-kbl: [PASS][15] -> [DMESG-WARN][16] ([i915#180]) +1 similar issue [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8518/shard-kbl6/igt@kms_...@bpc-switch-suspend.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17751/shard-kbl4/igt@kms_...@bpc-switch-suspend.html * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: - shard-skl: [PASS][17] -> [FAIL][18] ([fdo#108145] / [i915#265]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8518/shard-skl1/igt@kms_plane_alpha_bl...@pipe-a-constant-alpha-min.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17751/shard-skl10/igt@kms_plane_alpha_bl...@pipe-a-constant-alpha-min.html * igt@kms_psr@psr2_primary_mmap_cpu: - shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109441]) +1 similar issue [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8518/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17751/shard-iclb1/igt@kms_psr@psr2_primary_mmap_cpu.html * igt@kms_vblank@pipe-b-ts-continuation-idle-hang: - shard-apl: [PASS][21] -> [SKIP][22] ([fdo#109271]) +6 similar issues [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8518/shard-apl6/igt@kms_vbl...@pipe-b-ts-continuation-idle-hang.html [22]:
[Intel-gfx] ✓ Fi.CI.BAT: success for agp/intel: Fix a memory leak on module initialisation failure
== Series Details == Series: agp/intel: Fix a memory leak on module initialisation failure URL : https://patchwork.freedesktop.org/series/77550/ State : success == Summary == CI Bug Log - changes from CI_DRM_8524 -> Patchwork_17756 Summary --- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17756/index.html Known issues Here are the changes found in Patchwork_17756 that come from known issues: ### IGT changes ### Warnings * igt@i915_pm_rpm@module-reload: - fi-kbl-x1275: [FAIL][1] ([i915#62] / [i915#95]) -> [FAIL][2] ([i915#62]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8524/fi-kbl-x1275/igt@i915_pm_...@module-reload.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17756/fi-kbl-x1275/igt@i915_pm_...@module-reload.html [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (45 -> 40) -- Missing(5): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-bwr-2160 fi-byt-clapper Build changes - * Linux: CI_DRM_8524 -> Patchwork_17756 CI-20190529: 20190529 CI_DRM_8524: 14a61eda3439d0655e4438f77310479a6da8c583 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5673: f37cd37470612616f65914bca35497ca13aeb11a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_17756: 118686605b3f2e1282b5842c05c1afb086057936 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 118686605b3f agp/intel: Fix a memory leak on module initialisation failure == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17756/index.html ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for agp/intel: Fix a memory leak on module initialisation failure
== Series Details == Series: agp/intel: Fix a memory leak on module initialisation failure URL : https://patchwork.freedesktop.org/series/77550/ State : warning == Summary == $ dim checkpatch origin/drm-tip 118686605b3f agp/intel: Fix a memory leak on module initialisation failure -:8: WARNING:TYPO_SPELLING: 'intialisation' may be misspelled - perhaps 'initialisation'? #8: module intialisation failure. Simply fix this issue by freeing "page" total: 0 errors, 1 warnings, 0 checks, 11 lines checked ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [CI] agp/intel: Fix a memory leak on module initialisation failure
From: Qiushi Wu
In intel_gtt_setup_scratch_page(), pointer "page" is not released if
pci_dma_mapping_error() return an error, leading to a memory leak on
module intialisation failure. Simply fix this issue by freeing "page"
before return.
Fixes: 0e87d2b06cb46 ("intel-gtt: initialize our own scratch page")
Signed-off-by: Qiushi Wu
Reviewed-by: Chris Wilson
Signed-off-by: Chris Wilson
---
drivers/char/agp/intel-gtt.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/char/agp/intel-gtt.c b/drivers/char/agp/intel-gtt.c
index 4b34a5195c65..5bfdf222d5f9 100644
--- a/drivers/char/agp/intel-gtt.c
+++ b/drivers/char/agp/intel-gtt.c
@@ -304,8 +304,10 @@ static int intel_gtt_setup_scratch_page(void)
if (intel_private.needs_dmar) {
dma_addr = pci_map_page(intel_private.pcidev, page, 0,
PAGE_SIZE, PCI_DMA_BIDIRECTIONAL);
- if (pci_dma_mapping_error(intel_private.pcidev, dma_addr))
+ if (pci_dma_mapping_error(intel_private.pcidev, dma_addr)) {
+ __free_page(page);
return -EINVAL;
+ }
intel_private.scratch_page_dma = dma_addr;
} else
--
2.20.1
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Flush the submission, not cancel it!
== Series Details == Series: drm/i915/selftests: Flush the submission, not cancel it! URL : https://patchwork.freedesktop.org/series/77510/ State : success == Summary == CI Bug Log - changes from CI_DRM_8517_full -> Patchwork_17750_full Summary --- **WARNING** Minor unknown changes coming with Patchwork_17750_full need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_17750_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues --- Here are the unknown changes that may have been introduced in Patchwork_17750_full: ### IGT changes ### Warnings * igt@i915_selftest@live@gt_pm: - shard-tglb: [DMESG-FAIL][1] ([i915#1759]) -> [DMESG-FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8517/shard-tglb7/igt@i915_selftest@live@gt_pm.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17750/shard-tglb5/igt@i915_selftest@live@gt_pm.html Known issues Here are the changes found in Patchwork_17750_full that come from known issues: ### IGT changes ### Issues hit * igt@i915_suspend@sysfs-reader: - shard-apl: [PASS][3] -> [DMESG-WARN][4] ([i915#180]) +4 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8517/shard-apl6/igt@i915_susp...@sysfs-reader.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17750/shard-apl7/igt@i915_susp...@sysfs-reader.html * igt@kms_cursor_crc@pipe-a-cursor-128x42-onscreen: - shard-skl: [PASS][5] -> [FAIL][6] ([i915#54]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8517/shard-skl1/igt@kms_cursor_...@pipe-a-cursor-128x42-onscreen.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17750/shard-skl9/igt@kms_cursor_...@pipe-a-cursor-128x42-onscreen.html * igt@kms_cursor_edge_walk@pipe-a-128x128-bottom-edge: - shard-snb: [PASS][7] -> [SKIP][8] ([fdo#109271]) +2 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8517/shard-snb6/igt@kms_cursor_edge_w...@pipe-a-128x128-bottom-edge.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17750/shard-snb6/igt@kms_cursor_edge_w...@pipe-a-128x128-bottom-edge.html * igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy: - shard-glk: [PASS][9] -> [FAIL][10] ([i915#72]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8517/shard-glk1/igt@kms_cursor_leg...@2x-flip-vs-cursor-legacy.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17750/shard-glk2/igt@kms_cursor_leg...@2x-flip-vs-cursor-legacy.html * igt@kms_dp_dsc@basic-dsc-enable-edp: - shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#109349]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8517/shard-iclb2/igt@kms_dp_...@basic-dsc-enable-edp.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17750/shard-iclb8/igt@kms_dp_...@basic-dsc-enable-edp.html * igt@kms_draw_crc@draw-method-xrgb-mmap-gtt-untiled: - shard-kbl: [PASS][13] -> [FAIL][14] ([i915#177] / [i915#52] / [i915#54] / [i915#93] / [i915#95]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8517/shard-kbl4/igt@kms_draw_...@draw-method-xrgb-mmap-gtt-untiled.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17750/shard-kbl4/igt@kms_draw_...@draw-method-xrgb-mmap-gtt-untiled.html * igt@kms_pipe_crc_basic@hang-read-crc-pipe-a: - shard-kbl: [PASS][15] -> [FAIL][16] ([i915#53] / [i915#93] / [i915#95]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8517/shard-kbl2/igt@kms_pipe_crc_ba...@hang-read-crc-pipe-a.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17750/shard-kbl7/igt@kms_pipe_crc_ba...@hang-read-crc-pipe-a.html - shard-apl: [PASS][17] -> [FAIL][18] ([i915#53] / [i915#95]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8517/shard-apl1/igt@kms_pipe_crc_ba...@hang-read-crc-pipe-a.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17750/shard-apl3/igt@kms_pipe_crc_ba...@hang-read-crc-pipe-a.html * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: [PASS][19] -> [FAIL][20] ([fdo#108145] / [i915#265]) +2 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8517/shard-skl9/igt@kms_plane_alpha_bl...@pipe-b-coverage-7efc.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17750/shard-skl1/igt@kms_plane_alpha_bl...@pipe-b-coverage-7efc.html * igt@kms_psr2_su@frontbuffer: - shard-iclb: [PASS][21] -> [SKIP][22] ([fdo#109642] / [fdo#111068]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8517/shard-iclb2/igt@kms_psr2...@frontbuffer.html [22]:
[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Immediately check for ACK after submission
== Series Details == Series: drm/i915/gt: Immediately check for ACK after submission URL : https://patchwork.freedesktop.org/series/77509/ State : success == Summary == CI Bug Log - changes from CI_DRM_8517_full -> Patchwork_17749_full Summary --- **SUCCESS** No regressions found. Known issues Here are the changes found in Patchwork_17749_full that come from known issues: ### IGT changes ### Issues hit * igt@gem_ctx_persistence@legacy-engines-mixed-process@blt: - shard-skl: [PASS][1] -> [FAIL][2] ([i915#1528]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8517/shard-skl9/igt@gem_ctx_persistence@legacy-engines-mixed-proc...@blt.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17749/shard-skl9/igt@gem_ctx_persistence@legacy-engines-mixed-proc...@blt.html * igt@gem_softpin@noreloc-s3: - shard-kbl: [PASS][3] -> [DMESG-WARN][4] ([i915#165] / [i915#180]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8517/shard-kbl6/igt@gem_soft...@noreloc-s3.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17749/shard-kbl2/igt@gem_soft...@noreloc-s3.html * igt@gen9_exec_parse@allowed-all: - shard-apl: [PASS][5] -> [DMESG-WARN][6] ([i915#1436] / [i915#716]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8517/shard-apl8/igt@gen9_exec_pa...@allowed-all.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17749/shard-apl3/igt@gen9_exec_pa...@allowed-all.html * igt@i915_pm_dc@dc6-psr: - shard-iclb: [PASS][7] -> [FAIL][8] ([i915#454]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8517/shard-iclb6/igt@i915_pm...@dc6-psr.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17749/shard-iclb6/igt@i915_pm...@dc6-psr.html * igt@i915_suspend@debugfs-reader: - shard-kbl: [PASS][9] -> [DMESG-WARN][10] ([i915#180]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8517/shard-kbl7/igt@i915_susp...@debugfs-reader.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17749/shard-kbl4/igt@i915_susp...@debugfs-reader.html * igt@i915_suspend@fence-restore-tiled2untiled: - shard-apl: [PASS][11] -> [DMESG-WARN][12] ([i915#180]) +3 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8517/shard-apl8/igt@i915_susp...@fence-restore-tiled2untiled.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17749/shard-apl3/igt@i915_susp...@fence-restore-tiled2untiled.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-skl: [PASS][13] -> [FAIL][14] ([IGT#5]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8517/shard-skl8/igt@kms_cursor_leg...@flip-vs-cursor-atomic-transitions-varying-size.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17749/shard-skl2/igt@kms_cursor_leg...@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_dp_dsc@basic-dsc-enable-edp: - shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#109349]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8517/shard-iclb2/igt@kms_dp_...@basic-dsc-enable-edp.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17749/shard-iclb5/igt@kms_dp_...@basic-dsc-enable-edp.html * igt@kms_draw_crc@draw-method-xrgb-mmap-gtt-untiled: - shard-kbl: [PASS][17] -> [FAIL][18] ([i915#177] / [i915#52] / [i915#54] / [i915#93] / [i915#95]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8517/shard-kbl4/igt@kms_draw_...@draw-method-xrgb-mmap-gtt-untiled.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17749/shard-kbl1/igt@kms_draw_...@draw-method-xrgb-mmap-gtt-untiled.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-glk: [PASS][19] -> [FAIL][20] ([i915#64]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8517/shard-glk5/igt@kms_fbcon_...@fbc-suspend.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17749/shard-glk2/igt@kms_fbcon_...@fbc-suspend.html * igt@kms_pipe_crc_basic@hang-read-crc-pipe-a: - shard-kbl: [PASS][21] -> [FAIL][22] ([i915#53] / [i915#93] / [i915#95]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8517/shard-kbl2/igt@kms_pipe_crc_ba...@hang-read-crc-pipe-a.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17749/shard-kbl6/igt@kms_pipe_crc_ba...@hang-read-crc-pipe-a.html - shard-apl: [PASS][23] -> [FAIL][24] ([i915#53] / [i915#95]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8517/shard-apl1/igt@kms_pipe_crc_ba...@hang-read-crc-pipe-a.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17749/shard-apl2/igt@kms_pipe_crc_ba...@hang-read-crc-pipe-a.html * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: [PASS][25] -> [FAIL][26] ([fdo#108145] / [i915#265])
