Re: [Intel-gfx] [PATCH 14/15] drm/amd: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()
On 21/09/18 01:17AM, Fernando Ramos wrote: > > > +#include > > > > Top-level headers generally come above the driver headers. Also, now that I > > think > > about this a bit more, all of the new includes in this set should probably > > be > > for 'drm_modeset_lock.h' instead of 'drm_drv.h'. > > Ok. Let me try that. Turns out that the DRM_MODESET_LOCK_ALL_*() macros expansion includes a call to drm_drv_uses_atomic_modeset() which is defined in "drm_drv.h". Thus, #include'ing cannot be avoided. This makes me wonder... 1. "drm_drv.h" includes "drm_device.h", which includes "drm_mode_config.h", which includes "drm_modeset_lock.h" 2. "drm_modeset_lock.h" defines DRM_MODESET_LOCK_ALL_*() which expands into drm_drv_uses_atomic_modeset() 3. drm_drv_uses_atomic_modeset() is declared in "drm_drv.h" There seems to be a circular dependency here. We can try to fix this, but I suggest to do it in a different patch series.
[Intel-gfx] [PULL] gvt-fixes
Hi, Here's one ww lock fini fix from Zhi which resolved recent regression with i915 change. Thanks -- The following changes since commit 71de496cc489b6bae2f51f89da7f28849bf2836e: drm/i915/dp: Drop redundant debug print (2021-08-26 07:31:52 -0400) are available in the Git repository at: https://github.com/intel/gvt-linux tags/gvt-fixes-2021-09-18 for you to fetch changes up to d168cd797982db9db617113644c87b8f5f3cf27e: drm/i915/gvt: fix the usage of ww lock in gvt scheduler. (2021-09-13 21:59:31 +0800) gvt-fixes-2021-09-18 - ww locking fix from Zhi Zhi A Wang (1): drm/i915/gvt: fix the usage of ww lock in gvt scheduler. drivers/gpu/drm/i915/gvt/scheduler.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) signature.asc Description: PGP signature
[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Introduce Intel PXP (rev8)
== Series Details == Series: drm/i915: Introduce Intel PXP (rev8) URL : https://patchwork.freedesktop.org/series/90503/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10605_full -> Patchwork_21096_full Summary --- **FAILURE** Serious unknown changes coming with Patchwork_21096_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_21096_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues --- Here are the unknown changes that may have been introduced in Patchwork_21096_full: ### Piglit changes ### Possible regressions * spec@!opengl 3.2@layered-rendering@clear-color-all-types cube_map_array mipmapped (NEW): - pig-glk-j5005: NOTRUN -> [INCOMPLETE][1] +3 similar issues [1]: None * spec@glsl-1.20@execution@uniform-initializer@vs-structure (NEW): - pig-skl-6260u: NOTRUN -> [INCOMPLETE][2] +3 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21096/pig-skl-6260u/spec@glsl-1.20@execution@uniform-initiali...@vs-structure.html New tests - New tests have been introduced between CI_DRM_10605_full and Patchwork_21096_full: ### New Piglit tests (8) ### * spec@!opengl 3.2@layered-rendering@clear-color-all-types cube_map_array mipmapped: - Statuses : 1 incomplete(s) - Exec time: [0.0] s * spec@!opengl 3.3@minmax: - Statuses : 1 incomplete(s) - Exec time: [0.0] s * spec@!opengl 3.3@required-renderbuffer-attachment-formats: - Statuses : 1 incomplete(s) - Exec time: [0.0] s * spec@arb_sample_shading@builtin-gl-sample-mask 2: - Statuses : 1 incomplete(s) - Exec time: [0.0] s * spec@glsl-1.20@execution@clipping@fixed-clip-enables: - Statuses : 1 incomplete(s) - Exec time: [0.0] s * spec@glsl-1.20@execution@uniform-initializer@fs-structure: - Statuses : 1 incomplete(s) - Exec time: [0.0] s * spec@glsl-1.20@execution@uniform-initializer@fs-structure-array: - Statuses : 1 incomplete(s) - Exec time: [0.0] s * spec@glsl-1.20@execution@uniform-initializer@vs-structure: - Statuses : 1 incomplete(s) - Exec time: [0.0] s Known issues Here are the changes found in Patchwork_21096_full that come from known issues: ### IGT changes ### Issues hit * igt@gem_ctx_sseu@engines: - shard-skl: NOTRUN -> [SKIP][3] ([fdo#109271]) +3 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21096/shard-skl10/igt@gem_ctx_s...@engines.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-tglb: [PASS][4] -> [FAIL][5] ([i915#2842]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10605/shard-tglb1/igt@gem_exec_fair@basic-none-sh...@rcs0.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21096/shard-tglb2/igt@gem_exec_fair@basic-none-sh...@rcs0.html * igt@gem_exec_params@rsvd2-dirt: - shard-tglb: NOTRUN -> [SKIP][6] ([fdo#109283]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21096/shard-tglb8/igt@gem_exec_par...@rsvd2-dirt.html * igt@gem_media_vme: - shard-tglb: NOTRUN -> [SKIP][7] ([i915#284]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21096/shard-tglb8/igt@gem_media_vme.html * igt@gem_pread@exhaustion: - shard-skl: NOTRUN -> [WARN][8] ([i915#2658]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21096/shard-skl6/igt@gem_pr...@exhaustion.html * igt@gen9_exec_parse@valid-registers: - shard-tglb: NOTRUN -> [SKIP][9] ([i915#2856]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21096/shard-tglb8/igt@gen9_exec_pa...@valid-registers.html * igt@i915_module_load@reload-with-fault-injection: - shard-skl: [PASS][10] -> [DMESG-WARN][11] ([i915#1982]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10605/shard-skl8/igt@i915_module_l...@reload-with-fault-injection.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21096/shard-skl7/igt@i915_module_l...@reload-with-fault-injection.html * igt@i915_pm_rpm@pc8-residency: - shard-tglb: NOTRUN -> [SKIP][12] ([fdo#109506] / [i915#2411]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21096/shard-tglb8/igt@i915_pm_...@pc8-residency.html * igt@i915_pm_rpm@system-suspend: - shard-skl: [PASS][13] -> [INCOMPLETE][14] ([i915#151]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10605/shard-skl8/igt@i915_pm_...@system-suspend.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21096/shard-skl3/igt@i915_pm_...@system-suspend.html * igt@i915_pm_rpm@system-suspend-execbuf: - shard-tglb: [PASS][15] -> [INCOMPLETE][16] ([i915#2411] /
