Re: [Intel-gfx] [PATCH v5 2/6] drm/i915/pxp: add device link between i915 and mei_pxp
> > diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c
> b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c
> > index d50354bfb993..bef6d7f8ac55 100644
> > --- a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c
> > +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c
> > @@ -127,6 +127,10 @@ static int i915_pxp_tee_component_bind(struct
> device *i915_kdev,
> > intel_wakeref_t wakeref;
> > int ret = 0;
> >
> > + if (!HAS_HECI_PXP(i915) &&
> > + drm_WARN_ON(>drm, !device_link_add(i915_kdev,
> tee_kdev,
>
> I don't like the action here hidden behind the drm_WARN_ON.
> Please notice that almost every use of this and other helpers like
> this expect the param as a failure. Not an actual action. So,
> most of lazy readers like me might ignore that the main function
> is actually a param inside this warn condition.
>
Honestly, copy-pasted from drivers/gpu/drm/i915/display/intel_audio.c +1266
I don't have deep knowledge of drm macros, so thought this should be ok.
Can make it any other form that acceptable in drm tree...
> We should probably stash the link as well...
>
> pxp->dev_link = device_link_add(i915_kdev, tee_kdev,...);
>
> so in the end below, instead of checking the HAS_HECI_PXP again
> and use the remove version you check the dev_link and use the del
> function.
>
> something like:
>
> if (pxp->dev_link)
>device_link_del(pxp->dev_link);
>
Not sure that this simplification warrants additional clutter in struct.
> Also, do you really need the WARN to see the stack when this happens
> or you already know the callers?
> Why not a simple drm_error msg?
>
> if (!HAS_HECI_PXP(i915) {
> pxp->dev_link = device_link_add(i915_kdev, tee_kdev,...);
> if (!pxp->dev_link) {
> drm_error();
> return -ESOMETHING;
>
> > DL_FLAG_STATELESS)))
>
> do we need the RPM in sync as well?
> I mean:
>
> DL_FLAG_STATELESS | DL_FLAG_PM_RUNTIME)))
>
> ?
No, the mei device should not be active all the time when i915 is active, only
when pxp requires it.
>
> > + return -ENOMEM;
>
> why ENOMEM?
Copy-paste from i915 audio.
>
> > +
> > mutex_lock(>tee_mutex);
> > pxp->pxp_component = data;
> > pxp->pxp_component->tee_dev = tee_kdev;
> > @@ -169,6 +173,9 @@ static void i915_pxp_tee_component_unbind(struct
> device *i915_kdev,
> > mutex_lock(>tee_mutex);
> > pxp->pxp_component = NULL;
> > mutex_unlock(>tee_mutex);
> > +
> > + if (!HAS_HECI_PXP(i915))
> > + device_link_remove(i915_kdev, tee_kdev);
> > }
> >
> > static const struct component_ops i915_pxp_tee_component_ops = {
> > --
> > 2.39.0
> >
Re: [Intel-gfx] [PATCH v2 1/8] drm/i915: Add _PICK_EVEN_2RANGES()
On Fri, Jan 20, 2023 at 10:14:19PM -0800, Anusha Srivatsa wrote: -Original Message- From: Intel-gfx On Behalf Of Lucas De Marchi Sent: Friday, January 20, 2023 11:35 AM To: intel-gfx@lists.freedesktop.org Cc: De Marchi, Lucas ; dri- de...@lists.freedesktop.org Subject: [Intel-gfx] [PATCH v2 1/8] drm/i915: Add _PICK_EVEN_2RANGES() It's a constant pattern in the driver to need to use 2 ranges of MMIOs based on port, phy, pll, etc. When that happens, instead of using _PICK_EVEN(), _PICK() needs to be used. Using _PICK() is discouraged due to some reasons like: 1) It increases the code size since the array is declared in each call site 2) Developers need to be careful not to incur an out-of-bounds array access 3) Developers need to be careful that the indexes match the table. For that it may be that the table needs to contain holes, making (1) even worse. Add a variant of _PICK_EVEN() that works with 2 ranges and selects which one to use depending on the index value. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/i915_reg_defs.h | 28 1 file changed, 28 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg_defs.h b/drivers/gpu/drm/i915/i915_reg_defs.h index be43580a6979..b7ec87464d69 100644 --- a/drivers/gpu/drm/i915/i915_reg_defs.h +++ b/drivers/gpu/drm/i915/i915_reg_defs.h @@ -119,6 +119,34 @@ */ #define _PICK_EVEN(__index, __a, __b) ((__a) + (__index) * ((__b) - (__a))) +/* + * Like _PICK_EVEN(), but supports 2 ranges of evenly spaced address offsets. + * The first range is used for indexes below @__c_index, and the second + * range is used for anything above it. Example:: + * + * #define _FOO_A 0xf000 + * #define _FOO_B 0xf004 + * #define _FOO_C 0xf008 + * #define _SUPER_FOO_A0xa000 + * #define _SUPER_FOO_B0xa100 + * #define FOO(x) _MMIO(_PICK_EVEN_RANGES(x, 3, \ + * _FOO_A, _FOO_B, \ + * _SUPER_FOO_A, _SUPER_FOO_B)) + * + * This expands to: + * 0: 0xf000, + * 1: 0xf004, + * 2: 0xf008, + * 3: 0xa100, You mean 3:0xa000 doesn't really matter. This is an example of register addresses. They don't need to start from 0, it's whatever the hw gives us. Lucas De Marchi + * 4: 0xa200, 4:0xa100 + * 5: 0xa300, 5:0xa200 Anusha + * ... + */ +#define _PICK_EVEN_2RANGES(__index, __c_index, __a, __b, __c, __d) \ + (BUILD_BUG_ON_ZERO(!__is_constexpr(__c_index)) + \ +((__index) < (__c_index) ? _PICK_EVEN(__index, __a, __b) : \ + _PICK_EVEN((__index) - (__c_index), __c, __d))) + /* * Given the arbitrary numbers in varargs, pick the 0-based __index'th number. * -- 2.39.0
[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Fix sphinx warnings for workarounds documentation
== Series Details ==
Series: drm/i915/gt: Fix sphinx warnings for workarounds documentation
URL : https://patchwork.freedesktop.org/series/113193/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12619_full -> Patchwork_113193v1_full
Summary
---
**SUCCESS**
No regressions found.
External URL:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113193v1/index.html
Participating hosts (11 -> 9)
--
Missing(2): pig-skl-6260u pig-kbl-iris
Known issues
Here are the changes found in Patchwork_113193v1_full that come from known
issues:
### IGT changes ###
Issues hit
* igt@gem_exec_fair@basic-deadline:
- shard-glk: NOTRUN -> [FAIL][1] ([i915#2846])
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113193v1/shard-glk8/igt@gem_exec_f...@basic-deadline.html
* igt@gem_lmem_swapping@heavy-verify-random:
- shard-glk: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613])
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113193v1/shard-glk8/igt@gem_lmem_swapp...@heavy-verify-random.html
* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#3886]) +4
similar issues
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113193v1/shard-glk8/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-ccs-on-another-bo-yf_tiled_ccs:
- shard-glk: NOTRUN -> [SKIP][4] ([fdo#109271]) +41 similar issues
[4]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113193v1/shard-glk8/igt@kms_ccs@pipe-d-ccs-on-another-bo-yf_tiled_ccs.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-glk: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#658])
[5]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113193v1/shard-glk8/igt@kms_psr2...@overlay-plane-update-sf-dmg-area.html
* igt@kms_writeback@writeback-fb-id:
- shard-glk: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#2437])
[6]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113193v1/shard-glk8/igt@kms_writeb...@writeback-fb-id.html
* igt@sysfs_clients@fair-0:
- shard-glk: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#2994])
[7]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113193v1/shard-glk8/igt@sysfs_clie...@fair-0.html
Possible fixes
* igt@fbdev@info:
- {shard-rkl}:[SKIP][8] ([i915#2582]) -> [PASS][9]
[8]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12619/shard-rkl-5/igt@fb...@info.html
[9]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113193v1/shard-rkl-6/igt@fb...@info.html
* igt@feature_discovery@psr2:
- {shard-rkl}:[SKIP][10] ([i915#658]) -> [PASS][11]
[10]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12619/shard-rkl-5/igt@feature_discov...@psr2.html
[11]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113193v1/shard-rkl-6/igt@feature_discov...@psr2.html
* igt@gem_eio@in-flight-suspend:
- {shard-rkl}:[FAIL][12] ([fdo#103375]) -> [PASS][13]
[12]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12619/shard-rkl-3/igt@gem_...@in-flight-suspend.html
[13]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113193v1/shard-rkl-1/igt@gem_...@in-flight-suspend.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][14] ([i915#2842]) -> [PASS][15] +1 similar
issue
[14]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12619/shard-glk8/igt@gem_exec_fair@basic-pace-sh...@rcs0.html
[15]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113193v1/shard-glk9/igt@gem_exec_fair@basic-pace-sh...@rcs0.html
* igt@gem_exec_reloc@basic-gtt-wc:
- {shard-rkl}:[SKIP][16] ([i915#3281]) -> [PASS][17] +5 similar
issues
[16]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12619/shard-rkl-4/igt@gem_exec_re...@basic-gtt-wc.html
[17]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113193v1/shard-rkl-5/igt@gem_exec_re...@basic-gtt-wc.html
* igt@gem_mmap_wc@set-cache-level:
- {shard-rkl}:[SKIP][18] ([i915#1850]) -> [PASS][19]
[18]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12619/shard-rkl-2/igt@gem_mmap...@set-cache-level.html
[19]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113193v1/shard-rkl-6/igt@gem_mmap...@set-cache-level.html
* igt@gem_partial_pwrite_pread@writes-after-reads:
- {shard-rkl}:[SKIP][20] ([i915#3282]) -> [PASS][21] +1 similar
issue
[20]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12619/shard-rkl-2/igt@gem_partial_pwrite_pr...@writes-after-reads.html
[21]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113193v1/shard-rkl-5/igt@gem_partial_pwrite_pr...@writes-after-reads.html
* igt@gen9_exec_parse@allowed-all:
- {shard-rkl}:[SKIP][22] ([i915#2527]) -> [PASS][23] +1
[Intel-gfx] ✓ Fi.CI.IGT: success for Allow error capture without a request & fix locking issues (rev2)
== Series Details ==
Series: Allow error capture without a request & fix locking issues (rev2)
URL : https://patchwork.freedesktop.org/series/113078/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12619_full -> Patchwork_113078v2_full
Summary
---
**SUCCESS**
No regressions found.
External URL:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v2/index.html
Participating hosts (11 -> 10)
--
Additional (1): shard-rkl0
Missing(2): pig-skl-6260u pig-kbl-iris
Known issues
Here are the changes found in Patchwork_113078v2_full that come from known
issues:
### IGT changes ###
Issues hit
* igt@gem_exec_fair@basic-deadline:
- shard-glk: NOTRUN -> [FAIL][1] ([i915#2846])
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v2/shard-glk9/igt@gem_exec_f...@basic-deadline.html
* igt@gem_lmem_swapping@heavy-verify-random:
- shard-glk: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613])
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v2/shard-glk9/igt@gem_lmem_swapp...@heavy-verify-random.html
* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#3886]) +4
similar issues
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v2/shard-glk9/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-ccs-on-another-bo-yf_tiled_ccs:
- shard-glk: NOTRUN -> [SKIP][4] ([fdo#109271]) +41 similar issues
[4]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v2/shard-glk9/igt@kms_ccs@pipe-d-ccs-on-another-bo-yf_tiled_ccs.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [PASS][5] -> [FAIL][6] ([i915#2346])
[5]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12619/shard-glk1/igt@kms_cursor_legacy@flip-vs-cur...@atomic-transitions-varying-size.html
[6]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v2/shard-glk2/igt@kms_cursor_legacy@flip-vs-cur...@atomic-transitions-varying-size.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-glk: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#658])
[7]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v2/shard-glk9/igt@kms_psr2...@overlay-plane-update-sf-dmg-area.html
* igt@kms_writeback@writeback-fb-id:
- shard-glk: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#2437])
[8]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v2/shard-glk9/igt@kms_writeb...@writeback-fb-id.html
* igt@sysfs_clients@fair-0:
- shard-glk: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#2994])
[9]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v2/shard-glk9/igt@sysfs_clie...@fair-0.html
Possible fixes
* igt@fbdev@nullptr:
- {shard-rkl}:[SKIP][10] ([i915#2582]) -> [PASS][11] +1 similar
issue
[10]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12619/shard-rkl-1/igt@fb...@nullptr.html
[11]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v2/shard-rkl-6/igt@fb...@nullptr.html
* igt@gem_exec_reloc@basic-wc-read-noreloc:
- {shard-rkl}:[SKIP][12] ([i915#3281]) -> [PASS][13] +9 similar
issues
[12]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12619/shard-rkl-2/igt@gem_exec_re...@basic-wc-read-noreloc.html
[13]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v2/shard-rkl-5/igt@gem_exec_re...@basic-wc-read-noreloc.html
* igt@gem_partial_pwrite_pread@write:
- {shard-rkl}:[SKIP][14] ([i915#3282]) -> [PASS][15] +5 similar
issues
[14]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12619/shard-rkl-2/igt@gem_partial_pwrite_pr...@write.html
[15]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v2/shard-rkl-5/igt@gem_partial_pwrite_pr...@write.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [DMESG-WARN][16] ([i915#5566] / [i915#716]) ->
[PASS][17]
[16]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12619/shard-glk2/igt@gen9_exec_pa...@allowed-single.html
[17]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v2/shard-glk9/igt@gen9_exec_pa...@allowed-single.html
* igt@gen9_exec_parse@bb-start-far:
- {shard-rkl}:[SKIP][18] ([i915#2527]) -> [PASS][19] +1 similar
issue
[18]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12619/shard-rkl-2/igt@gen9_exec_pa...@bb-start-far.html
[19]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113078v2/shard-rkl-5/igt@gen9_exec_pa...@bb-start-far.html
* igt@i915_pm_dc@dc6-dpms:
- {shard-rkl}:[SKIP][20] ([i915#3361]) -> [PASS][21]
[20]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12619/shard-rkl-5/igt@i915_pm...@dc6-dpms.html
[21]:
[Intel-gfx] ✗ Fi.CI.IGT: failure for Add _PICK_EVEN_2RANGES
== Series Details == Series: Add _PICK_EVEN_2RANGES URL : https://patchwork.freedesktop.org/series/113177/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12618_full -> Patchwork_113177v1_full Summary --- **FAILURE** Serious unknown changes coming with Patchwork_113177v1_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_113177v1_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113177v1/index.html Participating hosts (12 -> 9) -- Missing(3): shard-rkl0 pig-kbl-iris pig-skl-6260u Possible new issues --- Here are the unknown changes that may have been introduced in Patchwork_113177v1_full: ### IGT changes ### Possible regressions * igt@gem_exec_schedule@wide@rcs0: - shard-glk: [PASS][1] -> [FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-glk9/igt@gem_exec_schedule@w...@rcs0.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113177v1/shard-glk9/igt@gem_exec_schedule@w...@rcs0.html Known issues Here are the changes found in Patchwork_113177v1_full that come from known issues: ### IGT changes ### Issues hit * igt@gem_exec_fair@basic-none@vcs0: - shard-glk: [PASS][3] -> [FAIL][4] ([i915#2842]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-glk2/igt@gem_exec_fair@basic-n...@vcs0.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113177v1/shard-glk4/igt@gem_exec_fair@basic-n...@vcs0.html * igt@gem_lmem_swapping@heavy-verify-multi: - shard-glk: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#4613]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113177v1/shard-glk1/igt@gem_lmem_swapp...@heavy-verify-multi.html * igt@gem_userptr_blits@vma-merge: - shard-glk: NOTRUN -> [FAIL][6] ([i915#3318]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113177v1/shard-glk1/igt@gem_userptr_bl...@vma-merge.html * igt@i915_pm_rc6_residency@rc6-idle@vecs0: - shard-glk: NOTRUN -> [FAIL][7] ([i915#3591]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113177v1/shard-glk1/igt@i915_pm_rc6_residency@rc6-i...@vecs0.html * igt@kms_async_flips@alternate-sync-async-flip@pipe-c-hdmi-a-1: - shard-glk: [PASS][8] -> [FAIL][9] ([i915#2521]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-glk6/igt@kms_async_flips@alternate-sync-async-f...@pipe-c-hdmi-a-1.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113177v1/shard-glk2/igt@kms_async_flips@alternate-sync-async-f...@pipe-c-hdmi-a-1.html * igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc: - shard-glk: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#3886]) +1 similar issue [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113177v1/shard-glk1/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html * igt@kms_cdclk@mode-transition: - shard-glk: NOTRUN -> [SKIP][11] ([fdo#109271]) +46 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113177v1/shard-glk1/igt@kms_cd...@mode-transition.html * igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions: - shard-glk: [PASS][12] -> [FAIL][13] ([i915#2346]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-glk6/igt@kms_cursor_legacy@flip-vs-cur...@atomic-transitions.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113177v1/shard-glk2/igt@kms_cursor_legacy@flip-vs-cur...@atomic-transitions.html * igt@kms_dsc@dsc-with-bpc-formats: - shard-glk: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#7205]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113177v1/shard-glk1/igt@kms_...@dsc-with-bpc-formats.html * igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf: - shard-glk: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#658]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113177v1/shard-glk1/igt@kms_psr2...@cursor-plane-move-continuous-exceed-fully-sf.html * igt@perf@stress-open-close: - shard-glk: [PASS][16] -> [INCOMPLETE][17] ([i915#5213]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-glk1/igt@p...@stress-open-close.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113177v1/shard-glk4/igt@p...@stress-open-close.html * igt@runner@aborted: - shard-glk: NOTRUN -> [FAIL][18] ([i915#4312]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113177v1/shard-glk4/igt@run...@aborted.html * igt@sysfs_clients@sema-50: - shard-glk:
[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Use uabi engines for the default engine map (rev2)
== Series Details ==
Series: drm/i915: Use uabi engines for the default engine map (rev2)
URL : https://patchwork.freedesktop.org/series/68395/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12618_full -> Patchwork_68395v2_full
Summary
---
**SUCCESS**
No regressions found.
External URL:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_68395v2/index.html
Participating hosts (12 -> 9)
--
Missing(3): shard-rkl0 pig-kbl-iris pig-skl-6260u
Known issues
Here are the changes found in Patchwork_68395v2_full that come from known
issues:
### IGT changes ###
Issues hit
* igt@gem_lmem_swapping@heavy-verify-multi:
- shard-glk: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#4613])
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_68395v2/shard-glk8/igt@gem_lmem_swapp...@heavy-verify-multi.html
* igt@gem_userptr_blits@vma-merge:
- shard-glk: NOTRUN -> [FAIL][2] ([i915#3318])
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_68395v2/shard-glk8/igt@gem_userptr_bl...@vma-merge.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#3886]) +1
similar issue
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_68395v2/shard-glk8/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_cdclk@mode-transition:
- shard-glk: NOTRUN -> [SKIP][4] ([fdo#109271]) +46 similar issues
[4]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_68395v2/shard-glk8/igt@kms_cd...@mode-transition.html
* igt@kms_dsc@dsc-with-bpc-formats:
- shard-glk: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#7205])
[5]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_68395v2/shard-glk8/igt@kms_...@dsc-with-bpc-formats.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][6] -> [FAIL][7] ([i915#79])
[6]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank-interrupti...@ac-hdmi-a1-hdmi-a2.html
[7]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_68395v2/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank-interrupti...@ac-hdmi-a1-hdmi-a2.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf:
- shard-glk: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#658])
[8]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_68395v2/shard-glk8/igt@kms_psr2...@cursor-plane-move-continuous-exceed-fully-sf.html
* igt@sysfs_clients@sema-50:
- shard-glk: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#2994])
[9]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_68395v2/shard-glk8/igt@sysfs_clie...@sema-50.html
Possible fixes
* igt@drm_fdinfo@idle@rcs0:
- {shard-rkl}:[FAIL][10] ([i915#7742]) -> [PASS][11] +1 similar
issue
[10]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-rkl-2/igt@drm_fdinfo@i...@rcs0.html
[11]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_68395v2/shard-rkl-2/igt@drm_fdinfo@i...@rcs0.html
* igt@gem_eio@suspend:
- {shard-rkl}:[FAIL][12] ([i915#7052]) -> [PASS][13]
[12]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-rkl-4/igt@gem_...@suspend.html
[13]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_68395v2/shard-rkl-5/igt@gem_...@suspend.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- {shard-rkl}:[FAIL][14] ([i915#2842]) -> [PASS][15]
[14]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-rkl-4/igt@gem_exec_fair@basic-none-s...@rcs0.html
[15]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_68395v2/shard-rkl-5/igt@gem_exec_fair@basic-none-s...@rcs0.html
* igt@gem_exec_reloc@basic-wc-read-noreloc:
- {shard-rkl}:[SKIP][16] ([i915#3281]) -> [PASS][17] +14 similar
issues
[16]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-rkl-2/igt@gem_exec_re...@basic-wc-read-noreloc.html
[17]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_68395v2/shard-rkl-5/igt@gem_exec_re...@basic-wc-read-noreloc.html
* igt@gem_mmap_wc@set-cache-level:
- {shard-tglu}: [SKIP][18] ([i915#1850]) -> [PASS][19]
[18]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-tglu-6/igt@gem_mmap...@set-cache-level.html
[19]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_68395v2/shard-tglu-2/igt@gem_mmap...@set-cache-level.html
* igt@gem_pread@bench:
- {shard-rkl}:[SKIP][20] ([i915#3282]) -> [PASS][21] +7 similar
issues
[20]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-rkl-4/igt@gem_pr...@bench.html
[21]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_68395v2/shard-rkl-5/igt@gem_pr...@bench.html
* igt@gen9_exec_parse@secure-batches:
-
[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Convert PSS_MODE2 to multicast register (rev2)
== Series Details ==
Series: drm/i915/gt: Convert PSS_MODE2 to multicast register (rev2)
URL : https://patchwork.freedesktop.org/series/113159/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12618_full -> Patchwork_113159v2_full
Summary
---
**SUCCESS**
No regressions found.
External URL:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113159v2/index.html
Participating hosts (12 -> 9)
--
Missing(3): shard-rkl0 pig-kbl-iris pig-skl-6260u
Known issues
Here are the changes found in Patchwork_113159v2_full that come from known
issues:
### IGT changes ###
Issues hit
* igt@gem_lmem_swapping@heavy-verify-multi:
- shard-glk: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#4613])
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113159v2/shard-glk7/igt@gem_lmem_swapp...@heavy-verify-multi.html
* igt@gem_userptr_blits@vma-merge:
- shard-glk: NOTRUN -> [FAIL][2] ([i915#3318])
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113159v2/shard-glk7/igt@gem_userptr_bl...@vma-merge.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#3886]) +1
similar issue
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113159v2/shard-glk7/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_cdclk@mode-transition:
- shard-glk: NOTRUN -> [SKIP][4] ([fdo#109271]) +46 similar issues
[4]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113159v2/shard-glk7/igt@kms_cd...@mode-transition.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: [PASS][5] -> [FAIL][6] ([i915#2346])
[5]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-glk6/igt@kms_cursor_legacy@flip-vs-cur...@atomic-transitions.html
[6]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113159v2/shard-glk3/igt@kms_cursor_legacy@flip-vs-cur...@atomic-transitions.html
* igt@kms_dsc@dsc-with-bpc-formats:
- shard-glk: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#7205])
[7]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113159v2/shard-glk7/igt@kms_...@dsc-with-bpc-formats.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf:
- shard-glk: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#658])
[8]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113159v2/shard-glk7/igt@kms_psr2...@cursor-plane-move-continuous-exceed-fully-sf.html
* igt@sysfs_clients@sema-50:
- shard-glk: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#2994])
[9]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113159v2/shard-glk7/igt@sysfs_clie...@sema-50.html
Possible fixes
* igt@drm_fdinfo@virtual-idle:
- {shard-rkl}:[FAIL][10] ([i915#7742]) -> [PASS][11] +1 similar
issue
[10]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-rkl-6/igt@drm_fdi...@virtual-idle.html
[11]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113159v2/shard-rkl-2/igt@drm_fdi...@virtual-idle.html
* igt@drm_read@empty-block:
- {shard-rkl}:[SKIP][12] ([i915#4098]) -> [PASS][13] +1 similar
issue
[12]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-rkl-3/igt@drm_r...@empty-block.html
[13]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113159v2/shard-rkl-6/igt@drm_r...@empty-block.html
* igt@fbdev@info:
- {shard-rkl}:[SKIP][14] ([i915#2582]) -> [PASS][15]
[14]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-rkl-3/igt@fb...@info.html
[15]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113159v2/shard-rkl-6/igt@fb...@info.html
* igt@gem_exec_fair@basic-pace@rcs0:
- {shard-rkl}:[FAIL][16] ([i915#2842]) -> [PASS][17] +2 similar
issues
[16]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-rkl-1/igt@gem_exec_fair@basic-p...@rcs0.html
[17]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113159v2/shard-rkl-5/igt@gem_exec_fair@basic-p...@rcs0.html
* igt@gem_exec_reloc@basic-write-read-active:
- {shard-rkl}:[SKIP][18] ([i915#3281]) -> [PASS][19] +5 similar
issues
[18]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-rkl-1/igt@gem_exec_re...@basic-write-read-active.html
[19]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113159v2/shard-rkl-5/igt@gem_exec_re...@basic-write-read-active.html
* igt@gem_exec_schedule@semaphore-power:
- {shard-rkl}:[SKIP][20] ([i915#7276]) -> [PASS][21]
[20]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-rkl-1/igt@gem_exec_sched...@semaphore-power.html
[21]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113159v2/shard-rkl-5/igt@gem_exec_sched...@semaphore-power.html
* igt@gem_mmap_gtt@coherency:
-
[Intel-gfx] ✓ Fi.CI.IGT: success for GuC oriented print macros
== Series Details ==
Series: GuC oriented print macros
URL : https://patchwork.freedesktop.org/series/113162/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12618_full -> Patchwork_113162v1_full
Summary
---
**SUCCESS**
No regressions found.
External URL:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v1/index.html
Participating hosts (12 -> 10)
--
Missing(2): pig-skl-6260u pig-kbl-iris
Known issues
Here are the changes found in Patchwork_113162v1_full that come from known
issues:
### IGT changes ###
Issues hit
* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [PASS][1] -> [FAIL][2] ([i915#2842])
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-glk2/igt@gem_exec_fair@basic-n...@vcs0.html
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v1/shard-glk6/igt@gem_exec_fair@basic-n...@vcs0.html
* igt@gem_lmem_swapping@heavy-verify-multi:
- shard-glk: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613])
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v1/shard-glk4/igt@gem_lmem_swapp...@heavy-verify-multi.html
* igt@gem_userptr_blits@vma-merge:
- shard-glk: NOTRUN -> [FAIL][4] ([i915#3318])
[4]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v1/shard-glk4/igt@gem_userptr_bl...@vma-merge.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#3886]) +1
similar issue
[5]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v1/shard-glk4/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_cdclk@mode-transition:
- shard-glk: NOTRUN -> [SKIP][6] ([fdo#109271]) +46 similar issues
[6]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v1/shard-glk4/igt@kms_cd...@mode-transition.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: [PASS][7] -> [FAIL][8] ([i915#2346])
[7]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-glk6/igt@kms_cursor_legacy@flip-vs-cur...@atomic-transitions.html
[8]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v1/shard-glk7/igt@kms_cursor_legacy@flip-vs-cur...@atomic-transitions.html
* igt@kms_dsc@dsc-with-bpc-formats:
- shard-glk: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#7205])
[9]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v1/shard-glk4/igt@kms_...@dsc-with-bpc-formats.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1:
- shard-glk: [PASS][10] -> [FAIL][11] ([i915#79]) +1 similar issue
[10]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-glk4/igt@kms_flip@flip-vs-expired-vblank-interrupti...@b-hdmi-a1.html
[11]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v1/shard-glk7/igt@kms_flip@flip-vs-expired-vblank-interrupti...@b-hdmi-a1.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf:
- shard-glk: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#658])
[12]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v1/shard-glk4/igt@kms_psr2...@cursor-plane-move-continuous-exceed-fully-sf.html
* igt@perf@stress-open-close:
- shard-glk: [PASS][13] -> [INCOMPLETE][14] ([i915#5213])
[13]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-glk1/igt@p...@stress-open-close.html
[14]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v1/shard-glk6/igt@p...@stress-open-close.html
* igt@runner@aborted:
- shard-glk: NOTRUN -> [FAIL][15] ([i915#4312])
[15]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v1/shard-glk6/igt@run...@aborted.html
* igt@sysfs_clients@sema-50:
- shard-glk: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#2994])
[16]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v1/shard-glk4/igt@sysfs_clie...@sema-50.html
Possible fixes
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][17] ([i915#2842]) -> [PASS][18]
[17]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-glk8/igt@gem_exec_fair@basic-pace-sh...@rcs0.html
[18]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v1/shard-glk3/igt@gem_exec_fair@basic-pace-sh...@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- {shard-rkl}:[FAIL][19] ([i915#2842]) -> [PASS][20] +2 similar
issues
[19]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-rkl-1/igt@gem_exec_fair@basic-p...@rcs0.html
[20]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113162v1/shard-rkl-5/igt@gem_exec_fair@basic-p...@rcs0.html
* igt@gem_exec_reloc@basic-write-read-active:
- {shard-rkl}:[SKIP][21] ([i915#3281]) -> [PASS][22] +5 similar
issues
[21]:
[Intel-gfx] ✓ Fi.CI.IGT: success for kvm/vfio: Fix potential deadlock on vfio group_lock
== Series Details ==
Series: kvm/vfio: Fix potential deadlock on vfio group_lock
URL : https://patchwork.freedesktop.org/series/113156/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12618_full -> Patchwork_113156v1_full
Summary
---
**SUCCESS**
No regressions found.
External URL:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113156v1/index.html
Participating hosts (12 -> 10)
--
Missing(2): pig-skl-6260u pig-kbl-iris
Known issues
Here are the changes found in Patchwork_113156v1_full that come from known
issues:
### IGT changes ###
Issues hit
* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [PASS][1] -> [FAIL][2] ([i915#2842])
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-glk2/igt@gem_exec_fair@basic-n...@vcs0.html
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113156v1/shard-glk9/igt@gem_exec_fair@basic-n...@vcs0.html
* igt@gem_lmem_swapping@heavy-verify-multi:
- shard-glk: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613])
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113156v1/shard-glk9/igt@gem_lmem_swapp...@heavy-verify-multi.html
* igt@gem_userptr_blits@vma-merge:
- shard-glk: NOTRUN -> [FAIL][4] ([i915#3318])
[4]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113156v1/shard-glk9/igt@gem_userptr_bl...@vma-merge.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#3886]) +1
similar issue
[5]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113156v1/shard-glk9/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_cdclk@mode-transition:
- shard-glk: NOTRUN -> [SKIP][6] ([fdo#109271]) +46 similar issues
[6]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113156v1/shard-glk9/igt@kms_cd...@mode-transition.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: [PASS][7] -> [FAIL][8] ([i915#2346])
[7]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-glk6/igt@kms_cursor_legacy@flip-vs-cur...@atomic-transitions.html
[8]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113156v1/shard-glk3/igt@kms_cursor_legacy@flip-vs-cur...@atomic-transitions.html
* igt@kms_dsc@dsc-with-bpc-formats:
- shard-glk: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#7205])
[9]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113156v1/shard-glk9/igt@kms_...@dsc-with-bpc-formats.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][10] -> [FAIL][11] ([i915#79])
[10]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank-interrupti...@ab-hdmi-a1-hdmi-a2.html
[11]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113156v1/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank-interrupti...@ab-hdmi-a1-hdmi-a2.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
- shard-glk: [PASS][12] -> [DMESG-FAIL][13] ([i915#118])
[12]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-glk7/igt@kms_frontbuffer_track...@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
[13]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113156v1/shard-glk2/igt@kms_frontbuffer_track...@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf:
- shard-glk: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#658])
[14]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113156v1/shard-glk9/igt@kms_psr2...@cursor-plane-move-continuous-exceed-fully-sf.html
* igt@sysfs_clients@sema-50:
- shard-glk: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#2994])
[15]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113156v1/shard-glk9/igt@sysfs_clie...@sema-50.html
Possible fixes
* igt@drm_fdinfo@virtual-idle:
- {shard-rkl}:[FAIL][16] ([i915#7742]) -> [PASS][17] +2 similar
issues
[16]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-rkl-6/igt@drm_fdi...@virtual-idle.html
[17]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113156v1/shard-rkl-2/igt@drm_fdi...@virtual-idle.html
* igt@gem_eio@suspend:
- {shard-rkl}:[FAIL][18] ([i915#7052]) -> [PASS][19]
[18]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-rkl-4/igt@gem_...@suspend.html
[19]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113156v1/shard-rkl-2/igt@gem_...@suspend.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][20] ([i915#2842]) -> [PASS][21]
[20]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12618/shard-glk8/igt@gem_exec_fair@basic-pace-sh...@rcs0.html
[21]:
[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Fix sphinx warnings for workarounds documentation
== Series Details ==
Series: drm/i915/gt: Fix sphinx warnings for workarounds documentation
URL : https://patchwork.freedesktop.org/series/113193/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12619 -> Patchwork_113193v1
Summary
---
**SUCCESS**
No regressions found.
External URL:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113193v1/index.html
Participating hosts (37 -> 35)
--
Missing(2): fi-kbl-soraka fi-snb-2520m
Known issues
Here are the changes found in Patchwork_113193v1 that come from known issues:
### IGT changes ###
Issues hit
* igt@i915_selftest@live@mman:
- fi-rkl-guc: NOTRUN -> [TIMEOUT][1] ([i915#6794])
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113193v1/fi-rkl-guc/igt@i915_selftest@l...@mman.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- fi-rkl-guc: NOTRUN -> [SKIP][2] ([i915#7828])
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113193v1/fi-rkl-guc/igt@kms_chamelium_...@common-hpd-after-suspend.html
Possible fixes
* igt@i915_pm_rpm@module-reload:
- {bat-adls-5}: [FAIL][3] -> [PASS][4]
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12619/bat-adls-5/igt@i915_pm_...@module-reload.html
[4]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113193v1/bat-adls-5/igt@i915_pm_...@module-reload.html
* igt@i915_selftest@live@gt_pm:
- {bat-rpls-2}: [DMESG-FAIL][5] ([i915#4258]) -> [PASS][6]
[5]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12619/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
[6]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113193v1/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@migrate:
- {bat-dg2-11}: [DMESG-WARN][7] ([i915#7699]) -> [PASS][8]
[7]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12619/bat-dg2-11/igt@i915_selftest@l...@migrate.html
[8]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113193v1/bat-dg2-11/igt@i915_selftest@l...@migrate.html
* igt@i915_selftest@live@reset:
- {bat-rpls-2}: [DMESG-FAIL][9] ([i915#4983]) -> [PASS][10]
[9]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12619/bat-rpls-2/igt@i915_selftest@l...@reset.html
[10]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113193v1/bat-rpls-2/igt@i915_selftest@l...@reset.html
- {bat-rpls-1}: [DMESG-FAIL][11] ([i915#4983]) -> [PASS][12]
[11]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12619/bat-rpls-1/igt@i915_selftest@l...@reset.html
[12]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113193v1/bat-rpls-1/igt@i915_selftest@l...@reset.html
* igt@i915_selftest@live@workarounds:
- fi-rkl-guc: [INCOMPLETE][13] ([i915#4983]) -> [PASS][14]
[13]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12619/fi-rkl-guc/igt@i915_selftest@l...@workarounds.html
[14]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113193v1/fi-rkl-guc/igt@i915_selftest@l...@workarounds.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-a-hdmi-a-3:
- {bat-dg2-11}: [INCOMPLETE][15] -> [PASS][16]
[15]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12619/bat-dg2-11/igt@kms_pipe_crc_basic@suspend-read-...@pipe-a-hdmi-a-3.html
[16]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113193v1/bat-dg2-11/igt@kms_pipe_crc_basic@suspend-read-...@pipe-a-hdmi-a-3.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6794]: https://gitlab.freedesktop.org/drm/intel/issues/6794
[i915#7359]: https://gitlab.freedesktop.org/drm/intel/issues/7359
[i915#7625]: https://gitlab.freedesktop.org/drm/intel/issues/7625
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
Build changes
-
* Linux: CI_DRM_12619 -> Patchwork_113193v1
CI-20190529: 20190529
CI_DRM_12619: 7d3e7f64a42d66ba8da6e7b66a8d85457ef84570 @
git://anongit.freedesktop.org/gfx-ci/linux
IGT_7129: 7816773163a1b0d248dd9dd34d14e632ad8903be @
https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113193v1: 7d3e7f64a42d66ba8da6e7b66a8d85457ef84570 @
git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
33e6a647e06e drm/i915/gt: Fix sphinx warnings for workarounds documentation
== Logs ==
For more details see:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113193v1/index.html
[Intel-gfx] [PATCH] drm/i915/gt: Fix sphinx warnings for workarounds documentation
The wildchar ("*") used in the function name patterns in the
documentation was taken as a start of an "emphasis" inline markup. Wrap
the patterns with the inline literal markup and, for consistency, do the
same for the other function names mentioned.
Fixes: 0c3064cf33fb ("drm/i915/doc: Document where to implement register
workarounds")
Reported-by: kernel test robot
Signed-off-by: Gustavo Sousa
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c
b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 918a271447e2..e849035d8dc5 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -30,8 +30,8 @@
* creation to have a "primed golden context", i.e. a context image that
* already contains the changes needed to all the registers.
*
- * Context workarounds should be implemented in the *_ctx_workarounds_init()
- * variants respective to the targeted platforms.
+ * Context workarounds should be implemented in the
+ * ``*_ctx_workarounds_init()`` variants respective to the targeted
platforms.
*
* - Engine workarounds: the list of these WAs is applied whenever the specific
* engine is reset. It's also possible that a set of engine classes share a
@@ -46,16 +46,16 @@
* ``drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c`` for reference.
*
* Workarounds for registers specific to RCS and CCS should be implemented in
- * rcs_engine_wa_init() and ccs_engine_wa_init(), respectively; those for
- * registers belonging to BCS, VCS or VECS should be implemented in
- * xcs_engine_wa_init(). Workarounds for registers not belonging to a
specific
- * engine's MMIO range but that are part of of the common RCS/CCS reset
domain
- * should be implemented in general_render_compute_wa_init().
+ * ``rcs_engine_wa_init()`` and ``ccs_engine_wa_init()``, respectively; those
+ * for registers belonging to BCS, VCS or VECS should be implemented in
+ * ``xcs_engine_wa_init()``. Workarounds for registers not belonging to a
+ * specific engine's MMIO range but that are part of of the common RCS/CCS
+ * reset domain should be implemented in
``general_render_compute_wa_init()``.
*
* - GT workarounds: the list of these WAs is applied whenever these registers
* revert to their default values: on GPU reset, suspend/resume [1]_, etc.
*
- * GT workarounds should be implemented in the *_gt_workarounds_init()
+ * GT workarounds should be implemented in the ``*_gt_workarounds_init()``
* variants respective to the targeted platforms.
*
* - Register whitelist: some workarounds need to be implemented in userspace,
@@ -64,8 +64,8 @@
* this is just a special case of a MMIO workaround (as we write the list of
* these to/be-whitelisted registers to some special HW registers).
*
- * Register whitelisting should be done in the *_whitelist_build() variants
- * respective to the targeted platforms.
+ * Register whitelisting should be done in the ``*_whitelist_build()``
+ * variants respective to the targeted platforms.
*
* - Workaround batchbuffers: buffers that get executed automatically by the
* hardware on every HW context restore. These buffers are created and
--
2.39.0
[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/debugfs: Get rid of single use macros.
== Series Details ==
Series: drm/i915/debugfs: Get rid of single use macros.
URL : https://patchwork.freedesktop.org/series/113147/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12617_full -> Patchwork_113147v1_full
Summary
---
**SUCCESS**
No regressions found.
External URL:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113147v1/index.html
Participating hosts (11 -> 9)
--
Missing(2): pig-skl-6260u pig-kbl-iris
Possible new issues
---
Here are the unknown changes that may have been introduced in
Patchwork_113147v1_full:
### IGT changes ###
Suppressed
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_cursor_crc@cursor-suspend@pipe-d-hdmi-a-1:
- {shard-tglu}: [PASS][1] -> [DMESG-WARN][2]
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-tglu-4/igt@kms_cursor_crc@cursor-susp...@pipe-d-hdmi-a-1.html
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113147v1/shard-tglu-8/igt@kms_cursor_crc@cursor-susp...@pipe-d-hdmi-a-1.html
Known issues
Here are the changes found in Patchwork_113147v1_full that come from known
issues:
### IGT changes ###
Issues hit
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][3] -> [FAIL][4] ([i915#2842])
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-glk8/igt@gem_exec_fair@basic-pace-sh...@rcs0.html
[4]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113147v1/shard-glk7/igt@gem_exec_fair@basic-pace-sh...@rcs0.html
Possible fixes
* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- {shard-rkl}:[FAIL][5] ([i915#7742]) -> [PASS][6]
[5]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-rkl-6/igt@drm_fdinfo@most-busy-idle-check-...@rcs0.html
[6]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113147v1/shard-rkl-1/igt@drm_fdinfo@most-busy-idle-check-...@rcs0.html
* igt@drm_read@fault-buffer:
- {shard-rkl}:[SKIP][7] ([i915#4098]) -> [PASS][8]
[7]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-rkl-3/igt@drm_r...@fault-buffer.html
[8]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113147v1/shard-rkl-6/igt@drm_r...@fault-buffer.html
* igt@drm_read@invalid-buffer:
- {shard-tglu}: [SKIP][9] ([i915#1845]) -> [PASS][10]
[9]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-tglu-6/igt@drm_r...@invalid-buffer.html
[10]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113147v1/shard-tglu-4/igt@drm_r...@invalid-buffer.html
* igt@fbdev@write:
- {shard-tglu}: [SKIP][11] ([i915#2582]) -> [PASS][12]
[11]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-tglu-6/igt@fb...@write.html
[12]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113147v1/shard-tglu-4/igt@fb...@write.html
- {shard-rkl}:[SKIP][13] ([i915#2582]) -> [PASS][14]
[13]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-rkl-2/igt@fb...@write.html
[14]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113147v1/shard-rkl-6/igt@fb...@write.html
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-rkl}:[FAIL][15] ([i915#6268]) -> [PASS][16]
[15]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-rkl-2/igt@gem_ctx_e...@basic-nohangcheck.html
[16]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113147v1/shard-rkl-3/igt@gem_ctx_e...@basic-nohangcheck.html
* igt@gem_ctx_persistence@engines-hang@bcs0:
- {shard-rkl}:[SKIP][17] ([i915#6252]) -> [PASS][18]
[17]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-rkl-5/igt@gem_ctx_persistence@engines-h...@bcs0.html
[18]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113147v1/shard-rkl-2/igt@gem_ctx_persistence@engines-h...@bcs0.html
* igt@gem_eio@suspend:
- {shard-rkl}:[FAIL][19] ([i915#7052]) -> [PASS][20]
[19]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-rkl-3/igt@gem_...@suspend.html
[20]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113147v1/shard-rkl-1/igt@gem_...@suspend.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [FAIL][21] ([i915#2846]) -> [PASS][22]
[21]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-glk6/igt@gem_exec_f...@basic-deadline.html
[22]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113147v1/shard-glk9/igt@gem_exec_f...@basic-deadline.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- {shard-rkl}:[FAIL][23] ([i915#2842]) -> [PASS][24]
[23]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12617/shard-rkl-2/igt@gem_exec_fair@basic-none-r...@rcs0.html
[24]:
[Intel-gfx] [drm-intel:drm-intel-gt-next 1/2] htmldocs: Documentation/gpu/i915:64: ./drivers/gpu/drm/i915/gt/intel_workarounds.c:32: WARNING: Inline emphasis start-string without end-string.
tree: git://anongit.freedesktop.org/drm-intel drm-intel-gt-next head: 8d7eb8ed3f83f248e01a4f548d9c500a950a2c2d commit: 0c3064cf33fbfa8a25871d847e715f33b64f323e [1/2] drm/i915/doc: Document where to implement register workarounds reproduce: git remote add drm-intel git://anongit.freedesktop.org/drm-intel git fetch --no-tags drm-intel drm-intel-gt-next git checkout 0c3064cf33fbfa8a25871d847e715f33b64f323e make menuconfig # enable CONFIG_COMPILE_TEST, CONFIG_WARN_MISSING_DOCUMENTS, CONFIG_WARN_ABI_ERRORS make htmldocs If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> Documentation/gpu/i915:64: ./drivers/gpu/drm/i915/gt/intel_workarounds.c:32: >> WARNING: Inline emphasis start-string without end-string. -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
[Intel-gfx] ✓ Fi.CI.IGT: success for drm: override detected status for connectors which are forced on
== Series Details ==
Series: drm: override detected status for connectors which are forced on
URL : https://patchwork.freedesktop.org/series/113142/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12616_full -> Patchwork_113142v1_full
Summary
---
**SUCCESS**
No regressions found.
External URL:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113142v1/index.html
Participating hosts (12 -> 9)
--
Missing(3): shard-rkl0 pig-kbl-iris pig-skl-6260u
Known issues
Here are the changes found in Patchwork_113142v1_full that come from known
issues:
### IGT changes ###
Issues hit
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][1] -> [FAIL][2] ([i915#2846])
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12616/shard-glk2/igt@gem_exec_f...@basic-deadline.html
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113142v1/shard-glk7/igt@gem_exec_f...@basic-deadline.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: [PASS][3] -> [FAIL][4] ([i915#2842])
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12616/shard-glk7/igt@gem_exec_fair@basic-pace-s...@rcs0.html
[4]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113142v1/shard-glk3/igt@gem_exec_fair@basic-pace-s...@rcs0.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-glk: NOTRUN -> [SKIP][5] ([fdo#109271]) +1 similar issue
[5]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113142v1/shard-glk1/igt@kms_frontbuffer_track...@psr-2p-primscrn-pri-shrfb-draw-mmap-wc.html
Possible fixes
* igt@api_intel_bb@object-reloc-keep-cache:
- {shard-rkl}:[SKIP][6] ([i915#3281]) -> [PASS][7] +11 similar
issues
[6]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12616/shard-rkl-1/igt@api_intel...@object-reloc-keep-cache.html
[7]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113142v1/shard-rkl-5/igt@api_intel...@object-reloc-keep-cache.html
* igt@drm_fdinfo@virtual-idle:
- {shard-rkl}:[FAIL][8] ([i915#7742]) -> [PASS][9]
[8]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12616/shard-rkl-1/igt@drm_fdi...@virtual-idle.html
[9]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113142v1/shard-rkl-6/igt@drm_fdi...@virtual-idle.html
* igt@fbdev@eof:
- {shard-rkl}:[SKIP][10] ([i915#2582]) -> [PASS][11] +1 similar
issue
[10]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12616/shard-rkl-4/igt@fb...@eof.html
[11]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113142v1/shard-rkl-6/igt@fb...@eof.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][12] ([i915#2842]) -> [PASS][13] +2 similar
issues
[12]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12616/shard-glk8/igt@gem_exec_fair@basic-pace-sh...@rcs0.html
[13]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113142v1/shard-glk6/igt@gem_exec_fair@basic-pace-sh...@rcs0.html
- {shard-rkl}:[FAIL][14] ([i915#2842]) -> [PASS][15] +1 similar
issue
[14]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12616/shard-rkl-4/igt@gem_exec_fair@basic-pace-sh...@rcs0.html
[15]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113142v1/shard-rkl-4/igt@gem_exec_fair@basic-pace-sh...@rcs0.html
* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- {shard-rkl}:[SKIP][16] ([fdo#109313]) -> [PASS][17]
[16]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12616/shard-rkl-1/igt@gem_exec_fl...@basic-batch-kernel-default-cmd.html
[17]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113142v1/shard-rkl-5/igt@gem_exec_fl...@basic-batch-kernel-default-cmd.html
* igt@gem_userptr_blits@forbidden-operations:
- {shard-rkl}:[SKIP][18] ([i915#3282]) -> [PASS][19] +1 similar
issue
[18]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12616/shard-rkl-2/igt@gem_userptr_bl...@forbidden-operations.html
[19]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113142v1/shard-rkl-5/igt@gem_userptr_bl...@forbidden-operations.html
* igt@gen9_exec_parse@unaligned-jump:
- {shard-rkl}:[SKIP][20] ([i915#2527]) -> [PASS][21] +2 similar
issues
[20]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12616/shard-rkl-2/igt@gen9_exec_pa...@unaligned-jump.html
[21]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113142v1/shard-rkl-5/igt@gen9_exec_pa...@unaligned-jump.html
* igt@i915_pm_dc@dc9-dpms:
- {shard-rkl}:[SKIP][22] ([i915#3361]) -> [PASS][23]
[22]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12616/shard-rkl-5/igt@i915_pm...@dc9-dpms.html
[23]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113142v1/shard-rkl-3/igt@i915_pm...@dc9-dpms.html
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- {shard-rkl}:[WARN][24] ([i915#2681])
Re: [Intel-gfx] [PATCH v3 1/6] drm/i915: Fix request locking during error capture & debugfs dump
On Fri, Jan 20, 2023 at 03:06:02PM -0800, John Harrison wrote:
> On 1/19/2023 07:16, Andy Shevchenko wrote:
> > On Wed, Jan 18, 2023 at 10:49:55PM -0800, john.c.harri...@intel.com wrote:
...
> > > + found = false;
> > > + spin_lock(>guc_state.lock);
> > > list_for_each_entry(rq, >guc_state.requests,
> > > sched.link) {
> > > if (i915_test_request_state(rq) !=
> > > I915_REQUEST_ACTIVE)
> > > continue;
> > > + found = true;
> > > + break;
> > > + }
> > This can be combined to (see also below)
> >
> > list_for_each_entry(rq, >guc_state.requests, sched.link) {
> > if (i915_test_request_state(rq) == I915_REQUEST_ACTIVE)
> > break;
> > }
> >
> > > + spin_unlock(>guc_state.lock);
> > Instead of 'found' you can check the current entry pointer
> >
> > if (!list_entry_is_head(...))
> >
> > And because requests can only be messed up with the guc_state itself, I
> > think
> > you don't need to perform the above check under spinlock, so it's safe.
> I'm not following the argument as to why it is safe to test a guc_state
> owned list outside of holding the guc_state spinlock.
The very same reasons why found is not checked inside the lock.
If something bad to the list head pointer happens, it would mean
that we have much bigger issues. And list_entry_is_head() is specifically
to test the loop exit condition.
> I also think that having an explicit 'found' flag makes the code more
> readable and immediately obvious as to what is going on.
It depends on the perception. With boolean I have to go somewhere to be sure
that found has false when loop is fully revolved. (Sometimes it may be the
inverted loops like
found = true;
for (...loop...) {
if (...cond...) {
found = false;
break;
}
}
while with the helper it's obvious)
> For the sake of one
> bool (which the compiler would optimise out anyway),
Is it really optimized away?
> I don't think it is worth the obfuscation of behaviour and the risk of "I
> think this will work".
Whatever, not big deal :)
> > > + if (found) {
> > > intel_engine_set_hung_context(engine, ce);
--
With Best Regards,
Andy Shevchenko
Re: [Intel-gfx] [PATCH v6 09/10] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller
On 20/01/2023 17:54, Sean Paul wrote: On Thu, Jan 19, 2023 at 11:35:32AM +0100, Krzysztof Kozlowski wrote: On 18/01/2023 20:30, Mark Yacoub wrote: From: Sean Paul This patch adds the register ranges required for HDCP key injection and Do not use "This commit/patch". https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 This applies to all your patches. Fix it everywhere. My goodness, this is peak bikeshedding. Surely we have better things to do with our time? While I would not enforce this rule if there were no other issues with the commits, Mark will have to cleanup/rework commits anyway, see other review comments. Thus removing/slightly rephrasing a commit message sounds like a minor issue to me. Signed-off-by: Sean Paul Signed-off-by: Mark Yacoub Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-15-s...@poorly.run #v1 Link: https://patchwork.freedesktop.org/patch/msgid/20210915203834.1439-14-s...@poorly.run #v2 Link: https://patchwork.freedesktop.org/patch/msgid/20211001151145.55916-14-s...@poorly.run #v3 Link: https://patchwork.freedesktop.org/patch/msgid/20211105030434.2828845-14-s...@poorly.run #v4 Link: https://patchwork.freedesktop.org/patch/msgid/20220411204741.1074308-10-s...@poorly.run #v5 Drop the links. Why? I've always done this, it seems helpful to me? I'd say, if you wish to include them, they belong to the cover letter, not to the per-commit message. Once landed, they will serve no purpose. -- With best wishes Dmitry
