[Intel-gfx] i915/kexec: warning at drivers/gpu/drm/i915/display/intel_psr.c:782 intel_psr_activate+0x3c6/0x440
Hi, This warning exists for long time, I did not find time to report, here is the latest kernel logs, can you please to have a look? hardware: Thinkpad T480s lspci: 00:02.0 VGA compatible controller: Intel Corporation UHD Graphics 620 (rev 07) -- [0.00] Linux version 5.8.0-rc1+ (dyo...@dhcp-128-65.nay.redhat.com) (gcc (GCC) 10.0.1 20200328 (Red Hat 10.0.1-0.11), GNU ld version 2.34-2.fc32) #179 SMP Wed Jun 17 14:12:27 CST 2020 [0.00] Command line: ramoops.mem_address=0x2000 ramoops.mem_size=0x40 hung_task_panic=1 softlockup_panic=1 panic=6 root=/dev/nvme0n1p9 ro rd.lvm.lv=rhel/swap LANG=zh_CN.UTF-8 audit=0 selinux=0 no_console_suspend crashkernel=160M printk.devkmsg=off usbcore.autosuspend=-1 [0.00] KERNEL supported cpus: [0.00] Intel GenuineIntel [0.00] AMD AuthenticAMD [0.00] x86/fpu: Supporting XSAVE feature 0x001: 'x87 floating point registers' [0.00] x86/fpu: Supporting XSAVE feature 0x002: 'SSE registers' [0.00] x86/fpu: Supporting XSAVE feature 0x004: 'AVX registers' [0.00] x86/fpu: Supporting XSAVE feature 0x008: 'MPX bounds registers' [0.00] x86/fpu: Supporting XSAVE feature 0x010: 'MPX CSR' [0.00] x86/fpu: xstate_offset[2]: 576, xstate_sizes[2]: 256 [0.00] x86/fpu: xstate_offset[3]: 832, xstate_sizes[3]: 64 [0.00] x86/fpu: xstate_offset[4]: 896, xstate_sizes[4]: 64 [0.00] x86/fpu: Enabled xstate features 0x1f, context size is 960 bytes, using 'compacted' format. [0.00] BIOS-provided physical RAM map: [0.00] BIOS-e820: [mem 0x-0x00057fff] usable [0.00] BIOS-e820: [mem 0x00058000-0x00058fff] reserved [0.00] BIOS-e820: [mem 0x00059000-0x0009cfff] usable [0.00] BIOS-e820: [mem 0x0009d000-0x000f] reserved [0.00] BIOS-e820: [mem 0x0010-0x3fff] usable [0.00] BIOS-e820: [mem 0x4000-0x403f] reserved [0.00] BIOS-e820: [mem 0x4040-0x7b4b2fff] usable [0.00] BIOS-e820: [mem 0x7b4b3000-0x7b4b4fff] reserved [0.00] BIOS-e820: [mem 0x7b4b5000-0x7b51cfff] usable [0.00] BIOS-e820: [mem 0x7b51d000-0x7b51dfff] reserved [0.00] BIOS-e820: [mem 0x7b51e000-0xad334fff] usable [0.00] BIOS-e820: [mem 0xad335000-0xad335fff] ACPI NVS [0.00] BIOS-e820: [mem 0xad336000-0xad336fff] reserved [0.00] BIOS-e820: [mem 0xad337000-0xba3e9fff] usable [0.00] BIOS-e820: [mem 0xba3ea000-0xbb535fff] reserved [0.00] BIOS-e820: [mem 0xbb536000-0xbb599fff] ACPI NVS [0.00] BIOS-e820: [mem 0xbb59a000-0xbb5fefff] ACPI data [0.00] BIOS-e820: [mem 0xbb5ff000-0xbb5f] usable [0.00] BIOS-e820: [mem 0xbb60-0xbf7f] reserved [0.00] BIOS-e820: [mem 0xf800-0xfbff] reserved [0.00] BIOS-e820: [mem 0xfe01-0xfe010fff] reserved [0.00] BIOS-e820: [mem 0x0001-0x00043e7f] usable [0.00] NX (Execute Disable) protection: active [0.00] e820: update [mem 0x00050270-0x000502df] usable ==> usable [0.00] extended physical RAM map: [0.00] reserve setup_data: [mem 0x-0x0005026f] usable [0.00] reserve setup_data: [mem 0x00050270-0x000502df] usable [0.00] reserve setup_data: [mem 0x000502e0-0x00057fff] usable [0.00] reserve setup_data: [mem 0x00058000-0x00058fff] reserved [0.00] reserve setup_data: [mem 0x00059000-0x0009cfff] usable [0.00] reserve setup_data: [mem 0x0009d000-0x000f] reserved [0.00] reserve setup_data: [mem 0x0010-0x3fff] usable [0.00] reserve setup_data: [mem 0x4000-0x403f] reserved [0.00] reserve setup_data: [mem 0x4040-0x7b4b2fff] usable [0.00] reserve setup_data: [mem 0x7b4b3000-0x7b4b4fff] reserved [0.00] reserve setup_data: [mem 0x7b4b5000-0x7b51cfff] usable [0.00] reserve setup_data: [mem 0x7b51d000-0x7b51dfff] reserved [0.00] reserve setup_data: [mem 0x7b51e000-0xad334fff] usable [0.00] reserve setup_data: [mem 0xad335000-0xad335fff] ACPI NVS [0.00] reserve setup_data: [mem 0xad336000-0xad336fff] reserved [0.00] reserve setup_data: [mem 0xad337000-0xba3e9fff] usable [0.00] reserve setup_data: [mem 0xba3ea000-0xbb535fff] reserved [0.00] reserve
Re: [Intel-gfx] [PATCH]i915: use WARN_ON_ONCE in intel_dp_aux_transfer
On 12/01/16 at 04:00pm, Dave Young wrote:
> On 11/30/16 at 03:25pm, Ville Syrjälä wrote:
> > On Thu, Nov 24, 2016 at 05:03:20PM +0800, Dave Young wrote:
> > > On 11/24/16 at 10:53am, Jani Nikula wrote:
> > > > On Thu, 24 Nov 2016, Dave Young <dyo...@redhat.com> wrote:
> > > > > I see a lot of below warning:
> > > >
> > > > No, we must not hide this under the carpet. There's a bug at fdo about
> > > > this, and we need to fix it.
> > >
> > > It is not hiding it, just not repeating the warnings. But anyway I do
> > > not have strong opinion. I'm building my kernel with this patch until
> > > there is a real fix in upstream.
> >
> > We already have a patch to reduce it a single WARN:
> > d4cb3fd9b548 ("drm/i915/dp: add lane_count check in
> > intel_dp_check_link_status")
>
> It works for me, thanks
>
> >
> > Do we need to get that backported to stable?
>
> Personally I think it should but I'm not sure the policy of stable for i915
> though.
>
Hmm, I can not recall when I had such issue in which version of kernel
because I just pull and rebuild very often, so I should say I have no
idea ..
> Thanks
> Dave
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH]i915: use WARN_ON_ONCE in intel_dp_aux_transfer
On 11/30/16 at 03:25pm, Ville Syrjälä wrote:
> On Thu, Nov 24, 2016 at 05:03:20PM +0800, Dave Young wrote:
> > On 11/24/16 at 10:53am, Jani Nikula wrote:
> > > On Thu, 24 Nov 2016, Dave Young <dyo...@redhat.com> wrote:
> > > > I see a lot of below warning:
> > >
> > > No, we must not hide this under the carpet. There's a bug at fdo about
> > > this, and we need to fix it.
> >
> > It is not hiding it, just not repeating the warnings. But anyway I do
> > not have strong opinion. I'm building my kernel with this patch until
> > there is a real fix in upstream.
>
> We already have a patch to reduce it a single WARN:
> d4cb3fd9b548 ("drm/i915/dp: add lane_count check in
> intel_dp_check_link_status")
It works for me, thanks
>
> Do we need to get that backported to stable?
Personally I think it should but I'm not sure the policy of stable for i915
though.
Thanks
Dave
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH]i915: use WARN_ON_ONCE in intel_dp_aux_transfer
On 11/24/16 at 10:53am, Jani Nikula wrote: > On Thu, 24 Nov 2016, Dave Young <dyo...@redhat.com> wrote: > > I see a lot of below warning: > > No, we must not hide this under the carpet. There's a bug at fdo about > this, and we need to fix it. It is not hiding it, just not repeating the warnings. But anyway I do not have strong opinion. I'm building my kernel with this patch until there is a real fix in upstream. > > BR, > Jani. > > > > [ 17.128256] WARNING: CPU: 1 PID: 95 at > > drivers/gpu/drm/i915/intel_dp.c:1062 intel_dp_aux_transfer+0x201/0x240 > > [i915] > > [ 17.128264] WARN_ON_ONCE(!msg->buffer != !msg->size) > > [ 17.128267] Modules linked in: > > [ 17.128273] kvm_intel kvm irqbypass i915 intel_gtt drm_kms_helper > > snd_hda_codec_realtek syscopyarea snd_hda_codec_generic sysfillrect > > sysimgblt fb_sys_fops drm arc4 rtsx_pci_sdmmc iwlmvm mac80211 snd_hda_intel > > btusb snd_hda_codec btrtl iwlwifi btbcm btintel snd_hwdep snd_hda_core > > snd_seq bluetooth e1000e i2c_i801 cfg80211 input_leds snd_seq_device > > i2c_smbus serio_raw pcspkr snd_pcm ptp rtsx_pci pps_core mfd_core snd_timer > > thinkpad_acpi snd soundcore rfkill video nfsd auth_rpcgss nfs_acl lockd > > grace sunrpc > > [ 17.128338] CPU: 1 PID: 95 Comm: kworker/u16:2 Not tainted 4.9.0-rc6+ > > #200 > > [ 17.128344] Hardware name: LENOVO 20ARS1BJ02/20ARS1BJ02, BIOS GJET91WW > > (2.41 ) 09/21/2016 > > [ 17.128355] Workqueue: events_unbound async_run_entry_fn > > [ 17.128361] 9db20105fa98 a9eeb8ed 9db20105fae8 > > > > [ 17.128370] 9db20105fad8 a9c5339b 0426907d27c8 > > 9db20105fbc0 > > [ 17.128379] 9474910510e0 0003 fffb > > > > [ 17.128388] Call Trace: > > [ 17.128396] [] dump_stack+0x63/0x86 > > [ 17.128404] [] __warn+0xcb/0xf0 > > [ 17.128410] [] warn_slowpath_fmt+0x5f/0x80 > > [ 17.128454] [] ? intel_dp_aux_transfer+0xde/0x240 > > [i915] > > [ 17.128492] [] intel_dp_aux_transfer+0x201/0x240 > > [i915] > > [ 17.128507] [] drm_dp_dpcd_access+0x72/0x110 > > [drm_kms_helper] > > [ 17.128519] [] drm_dp_dpcd_write+0x1b/0x20 > > [drm_kms_helper] > > [ 17.128557] [] intel_dp_start_link_train+0x2cb/0x4c0 > > [i915] > > [ 17.128594] [] intel_dp_check_link_status+0xd9/0x110 > > [i915] > > [ 17.128630] [] intel_dp_detect+0x79f/0xb90 [i915] > > [ 17.128641] [] > > drm_helper_probe_single_connector_modes+0x3ff/0x4f0 [drm_kms_helper] > > [ 17.128654] [] > > drm_fb_helper_initial_config+0xae/0x430 [drm_kms_helper] > > [ 17.128697] [] intel_fbdev_initial_config+0x18/0x30 > > [i915] > > [ 17.128705] [] async_run_entry_fn+0x37/0xe0 > > [ 17.128713] [] process_one_work+0x1e9/0x440 > > [ 17.128721] [] worker_thread+0x4b/0x4f0 > > [ 17.128728] [] ? process_one_work+0x440/0x440 > > [ 17.128721] [] worker_thread+0x4b/0x4f0 > > [ 17.128728] [] ? process_one_work+0x440/0x440 > > [ 17.128735] [] kthread+0xd9/0xf0 > > [ 17.128741] [] ? __switch_to+0x2ce/0x580 > > [ 17.128748] [] ? kthread_park+0x60/0x60 > > [ 17.128754] [] ? kthread_park+0x60/0x60 > > [ 17.128762] [] ret_from_fork+0x25/0x30 > > [ 17.128768] ---[ end trace 1c8614b2fcd03dac ]--- > > [ 17.151929] [drm:intel_dp_start_link_train [i915]] *ERROR* failed to > > update link training > > > > It seems a known issue below: > > https://bugs.freedesktop.org/show_bug.cgi?id=97344 > > > > This is not to fix the real problem just use WARN_ON_ONCE is better for > > this kind of warnings instead of warn again and again. > > > > Signed-off-by: Dave Young <dyo...@redhat.com> > > --- > > drivers/gpu/drm/i915/intel_dp.c |2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > --- linux-x86.orig/drivers/gpu/drm/i915/intel_dp.c > > +++ linux-x86/drivers/gpu/drm/i915/intel_dp.c > > @@ -1059,7 +1059,7 @@ intel_dp_aux_transfer(struct drm_dp_aux > > if (WARN_ON(txsize > 20)) > > return -E2BIG; > > > > - WARN_ON(!msg->buffer != !msg->size); > > + WARN_ON_ONCE(!msg->buffer != !msg->size); > > > > if (msg->buffer) > > memcpy(txbuf + HEADER_SIZE, msg->buffer, msg->size); > > -- > Jani Nikula, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH]i915: use WARN_ON_ONCE in intel_dp_aux_transfer
I see a lot of below warning: [ 17.128256] WARNING: CPU: 1 PID: 95 at drivers/gpu/drm/i915/intel_dp.c:1062 intel_dp_aux_transfer+0x201/0x240 [i915] [ 17.128264] WARN_ON_ONCE(!msg->buffer != !msg->size) [ 17.128267] Modules linked in: [ 17.128273] kvm_intel kvm irqbypass i915 intel_gtt drm_kms_helper snd_hda_codec_realtek syscopyarea snd_hda_codec_generic sysfillrect sysimgblt fb_sys_fops drm arc4 rtsx_pci_sdmmc iwlmvm mac80211 snd_hda_intel btusb snd_hda_codec btrtl iwlwifi btbcm btintel snd_hwdep snd_hda_core snd_seq bluetooth e1000e i2c_i801 cfg80211 input_leds snd_seq_device i2c_smbus serio_raw pcspkr snd_pcm ptp rtsx_pci pps_core mfd_core snd_timer thinkpad_acpi snd soundcore rfkill video nfsd auth_rpcgss nfs_acl lockd grace sunrpc [ 17.128338] CPU: 1 PID: 95 Comm: kworker/u16:2 Not tainted 4.9.0-rc6+ #200 [ 17.128344] Hardware name: LENOVO 20ARS1BJ02/20ARS1BJ02, BIOS GJET91WW (2.41 ) 09/21/2016 [ 17.128355] Workqueue: events_unbound async_run_entry_fn [ 17.128361] 9db20105fa98 a9eeb8ed 9db20105fae8 [ 17.128370] 9db20105fad8 a9c5339b 0426907d27c8 9db20105fbc0 [ 17.128379] 9474910510e0 0003 fffb [ 17.128388] Call Trace: [ 17.128396] [] dump_stack+0x63/0x86 [ 17.128404] [] __warn+0xcb/0xf0 [ 17.128410] [] warn_slowpath_fmt+0x5f/0x80 [ 17.128454] [] ? intel_dp_aux_transfer+0xde/0x240 [i915] [ 17.128492] [] intel_dp_aux_transfer+0x201/0x240 [i915] [ 17.128507] [] drm_dp_dpcd_access+0x72/0x110 [drm_kms_helper] [ 17.128519] [] drm_dp_dpcd_write+0x1b/0x20 [drm_kms_helper] [ 17.128557] [] intel_dp_start_link_train+0x2cb/0x4c0 [i915] [ 17.128594] [] intel_dp_check_link_status+0xd9/0x110 [i915] [ 17.128630] [] intel_dp_detect+0x79f/0xb90 [i915] [ 17.128641] [] drm_helper_probe_single_connector_modes+0x3ff/0x4f0 [drm_kms_helper] [ 17.128654] [] drm_fb_helper_initial_config+0xae/0x430 [drm_kms_helper] [ 17.128697] [] intel_fbdev_initial_config+0x18/0x30 [i915] [ 17.128705] [] async_run_entry_fn+0x37/0xe0 [ 17.128713] [] process_one_work+0x1e9/0x440 [ 17.128721] [] worker_thread+0x4b/0x4f0 [ 17.128728] [] ? process_one_work+0x440/0x440 [ 17.128721] [] worker_thread+0x4b/0x4f0 [ 17.128728] [] ? process_one_work+0x440/0x440 [ 17.128735] [] kthread+0xd9/0xf0 [ 17.128741] [] ? __switch_to+0x2ce/0x580 [ 17.128748] [] ? kthread_park+0x60/0x60 [ 17.128754] [] ? kthread_park+0x60/0x60 [ 17.128762] [] ret_from_fork+0x25/0x30 [ 17.128768] ---[ end trace 1c8614b2fcd03dac ]--- [ 17.151929] [drm:intel_dp_start_link_train [i915]] *ERROR* failed to update link training It seems a known issue below: https://bugs.freedesktop.org/show_bug.cgi?id=97344 This is not to fix the real problem just use WARN_ON_ONCE is better for this kind of warnings instead of warn again and again. Signed-off-by: Dave Young <dyo...@redhat.com> --- drivers/gpu/drm/i915/intel_dp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-x86.orig/drivers/gpu/drm/i915/intel_dp.c +++ linux-x86/drivers/gpu/drm/i915/intel_dp.c @@ -1059,7 +1059,7 @@ intel_dp_aux_transfer(struct drm_dp_aux if (WARN_ON(txsize > 20)) return -E2BIG; - WARN_ON(!msg->buffer != !msg->size); + WARN_ON_ONCE(!msg->buffer != !msg->size); if (msg->buffer) memcpy(txbuf + HEADER_SIZE, msg->buffer, msg->size); ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
