[Intel-gfx] 4.2.0+ warning in dmesg drm_atomic.c:491 drm_atomic_check_only+0x19e/0x401()
Hi Since this morning this warning is in my kernel log: [ 10.588770] [ cut here ] [ 10.593120] WARNING: CPU: 0 PID: 1477 at /usr/src/linux.git/drivers/gpu/drm/drm_atomic.c:491 drm_atomic_check_only+0x19e/0x401() [ 10.597589] Modules linked in: [ 10.601962] CPU: 0 PID: 1477 Comm: kworker/0:5 Tainted: GW 4.2.0+ #822 [ 10.606363] Hardware name: Dell Inc. Latitude D430 /0XW455, BIOS A02 10/11/2007 [ 10.610827] Workqueue: events output_poll_execute [ 10.615241] 02ba f5941c70 c14eeecb f5941c88 c105b158 c12740a2 f5ab [ 10.619761] f62c c17092f8 f5941c98 c105b1d3 0009 f5941cb8 c12740a2 [ 10.624296] 0001 f6222000 0002 f5ab f6222000 f6222000 f5941cc8 c1274313 [ 10.628817] Call Trace: [ 10.633175] [] dump_stack+0x16/0x18 [ 10.637525] [] warn_slowpath_common+0x72/0x89 [ 10.641866] [] ? drm_atomic_check_only+0x19e/0x401 [ 10.646134] [] warn_slowpath_null+0xf/0x13 [ 10.650324] [] drm_atomic_check_only+0x19e/0x401 [ 10.654473] [] drm_atomic_commit+0xe/0x44 [ 10.658668] [] intel_get_load_detect_pipe+0x40e/0x48b [ 10.662791] [] intel_tv_detect+0x10b/0x43a [ 10.666900] [] drm_helper_probe_single_connector_modes_merge_bits+0xaf/0x34a [ 10.671061] [] drm_helper_probe_single_connector_modes+0xa/0xc [ 10.675163] [] drm_fb_helper_probe_connector_modes+0x3b/0x49 [ 10.679269] [] drm_fb_helper_hotplug_event+0x61/0x94 [ 10.683298] [] intel_fbdev_output_poll_changed+0x15/0x17 [ 10.687373] [] drm_kms_helper_hotplug_event+0x1c/0x1f [ 10.691502] [] output_poll_execute+0x108/0x145 [ 10.695629] [] process_one_work+0x152/0x248 [ 10.699777] [] worker_thread+0x236/0x327 [ 10.703872] [] ? cancel_delayed_work_sync+0xf/0xf [ 10.707982] [] kthread+0xa3/0xa8 [ 10.712016] [] ret_from_kernel_thread+0x20/0x30 [ 10.716035] [] ? kthread_worker_fn+0x100/0x100 [ 10.720696] ---[ end trace b2652b27bfce9d22 ]--- -- Hans In case I need to bisect: good..bad : 51e771c..6c0f568 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] commit dec4f799d0a4c9edae20512fa60b0a36f3299ca2 laptop reboots or hangs at boot time
Daniel, commit dec4f799d0a4c9edae20512fa60b0a36f3299ca2 causes my laptop to hang or reboot at the moment the kernel swiches the vido mode at boot time. I also noticed a warning while compiling: CC drivers/gpu/drm/i915/i915_gem_gtt.o /usr/src/linux.bisect/drivers/gpu/drm/i915/i915_gem_gtt.c: In function 'gen8_ppgtt_init': /usr/src/linux.bisect/drivers/gpu/drm/i915/i915_gem_gtt.c:954:2: warning: large integer implicitly truncated to unsigned type [-Woverflow] ppgtt-base.total = 1ULL 32; ^ It might be related, or not. -- Hans commit dec4f799d0a4c9edae20512fa60b0a36f3299ca2 Author: Daniel Vetter daniel.vet...@ffwll.ch Date: Tue Jul 7 11:15:47 2015 +0200 drm/i915: Use crtc_state-active in primary check_plane func Since commit 8c7b5ccb729870e606321b3703e2c2e698c49a95 Author: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com Date: Tue Apr 21 17:13:19 2015 +0300 drm/i915: Use atomic helpers for computing changed flags we compute the plane state for a modeset before actually committing any changes, which means crtc-active won't be correct yet. Looking at future work in the modeset conversion targetting 4.3 the only places where crtc_state-active isn't accurate is when disabling other CRTCs than the one the modeset is for (when stealing connectors). Which isn't the case here. And that's also confirmed by an audit, we do unconditionally update crtc_state-active for the current pipe. We also don't need to update any other plane check functions since we only ever add the primary state to the modeset update right now. Cc: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com Cc: Maarten Lankhorst maarten.lankho...@linux.intel.com Cc: Jani Nikula jani.nik...@linux.intel.com Signed-off-by: Daniel Vetter daniel.vet...@intel.com Reviewed-by: Maarten Lankhorst maarten.lankho...@linux.intel.com Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] dmesg warnings by commit 51e31d49c89055299e34b8f44d13f70e19aaaad1
Daniel You commit, drm/i915: Use generic vblank wait, causes a warnings in my latops dmesg. The screen and al its possible resolutions look fine. I have not tried to attach a monitor to my laptop. Here is one of the warnings: [0.611074] [ cut here ] [0.611091] WARNING: CPU: 0 PID: 12 at /usr/src/linux.bisect/drivers/gpu/drm/drm_irq.c:1121 drm_wait_one_vblank+0x2c/0x12c() [0.611108] vblank not available on crtc 0, ret=-22 [0.67] Modules linked in: [0.611128] CPU: 0 PID: 12 Comm: kworker/u2:1 Not tainted 3.19.0-rc2bisect #49 [0.611141] Hardware name: Dell Inc. Latitude D430 /0XW455, BIOS A02 10/11/2007 [0.611159] Workqueue: events_unbound async_run_entry_fn [0.611169] 020a f606fbd0 f606fba8 c14b6793 f606fbc0 c10538bc c124b70c f613 [0.611188] f609a800 f606fbd8 c10538f9 0009 f606fbd0 c1606900 f606fbec [0.611206] f606fc1c c124b70c c160670a 0461 c1606900 ffea 8000 [0.611225] Call Trace: [0.611238] [c14b6793] dump_stack+0x16/0x18 [0.611250] [c10538bc] warn_slowpath_common+0x72/0x89 [0.611263] [c124b70c] ? drm_wait_one_vblank+0x2c/0x12c [0.611275] [c10538f9] warn_slowpath_fmt+0x26/0x2a [0.611288] [c124b70c] drm_wait_one_vblank+0x2c/0x12c [0.611302] [c129b7fc] ? intel_enable_pipe+0x12f/0x151 [0.611315] [c12c6da6] intel_enable_tv+0x1a/0x46 [0.611328] [c12a0539] i9xx_crtc_enable+0x2db/0x324 [0.611341] [c128e0e1] ? gen4_write64+0x42/0x42 [0.611353] [c129ff98] __intel_set_mode+0x705/0x7f6 [0.611366] [c12a3ee6] intel_set_mode+0x4a/0x64 [0.611378] [c12a4220] intel_get_load_detect_pipe+0x320/0x39f [0.611392] [c12c7589] intel_tv_detect+0x10b/0x42e [0.611410] [c123f2ed] drm_helper_probe_single_connector_modes_merge_bits+0xa8/0x2d3 [0.611427] [c123f522] drm_helper_probe_single_connector_modes+0xa/0xc [0.611441] [c1244d23] drm_fb_helper_probe_connector_modes+0x3b/0x49 [0.611455] [c12464f9] drm_fb_helper_initial_config+0x36/0x2dd [0.611468] [c14b87d8] ? __schedule+0x368/0x49d [0.611482] [c105e571] ? __call_usermodehelper+0x3c/0x3c [0.611495] [c12aeae9] intel_fbdev_initial_config+0x14/0x16 [0.611507] [c1064a14] async_run_entry_fn+0x2e/0xaf [0.611519] [c10603ca] process_one_work+0x152/0x245 [0.611531] [c1060a57] worker_thread+0x245/0x336 [0.611543] [c1060812] ? cancel_delayed_work_sync+0xf/0xf [0.611555] [c1063555] kthread+0xa3/0xa8 [0.611568] [c14ba7c0] ret_from_kernel_thread+0x20/0x30 [0.611580] [c10634b2] ? kthread_worker_fn+0x100/0x100 [0.611594] ---[ end trace 12873218311cf9cc ]--- -- Hans [0.00] Initializing cgroup subsys cpu [0.00] Linux version 3.19.0-rc2bisect (root@sol) (gcc version 4.8.2 (GCC) ) #49 PREEMPT Sun Jan 18 12:16:41 CET 2015 [0.00] Disabled fast string operations [0.00] e820: BIOS-provided physical RAM map: [0.00] BIOS-e820: [mem 0x-0x0009efff] usable [0.00] BIOS-e820: [mem 0x0009f000-0x0009] reserved [0.00] BIOS-e820: [mem 0x0010-0x7f6813ff] usable [0.00] BIOS-e820: [mem 0x7f681400-0x7fff] reserved [0.00] BIOS-e820: [mem 0xf000-0xf4006fff] reserved [0.00] BIOS-e820: [mem 0xf4008000-0xf400bfff] reserved [0.00] BIOS-e820: [mem 0xfec0-0xfec0] reserved [0.00] BIOS-e820: [mem 0xfed2-0xfed9] reserved [0.00] BIOS-e820: [mem 0xfee0-0xfee0] reserved [0.00] BIOS-e820: [mem 0xffb0-0x] reserved [0.00] Notice: NX (Execute Disable) protection cannot be enabled: non-PAE kernel! [0.00] SMBIOS 2.4 present. [0.00] DMI: Dell Inc. Latitude D430 /0XW455, BIOS A02 10/11/2007 [0.00] e820: update [mem 0x-0x0fff] usable == reserved [0.00] e820: remove [mem 0x000a-0x000f] usable [0.00] e820: last_pfn = 0x7f681 max_arch_pfn = 0x10 [0.00] MTRR default type: uncachable [0.00] MTRR fixed ranges enabled: [0.00] 0-9 write-back [0.00] A-B uncachable [0.00] C-D3FFF write-protect [0.00] D4000-E uncachable [0.00] F-F write-protect [0.00] MTRR variable ranges enabled: [0.00] 0 base 0 mask F8000 write-back [0.00] 1 base 07F80 mask FFF80 uncachable [0.00] 2 base 07F70 mask 0 uncachable [0.00] 3 disabled [0.00] 4 disabled [0.00] 5 disabled [0.00] 6 disabled [0.00] 7 disabled [0.00] PAT not supported by CPU. [0.00] initial memory mapped: [mem 0x-0x01bf] [0.00] Base memory trampoline at [c009a000] 9a000 size
Re: [Intel-gfx] [PATCH] Revert drm/i915: Don't set the 8to6 dither flag when not scaling
On 07/09/2014 10:35 PM, Daniel Vetter wrote: This reverts commit 773875bfb6737982903c42d1ee88cf60af80089c. It is very much needed and the lack of dithering has been reported by a large list of people with various gen2/3 hardware. Also, the original patch was complete non-sense since the WARNING backtraces in the references bugzilla are about gmch_pfit.lvds_border_bits mismatch, not at all about the dither bit. That one seems to work. Cc: Jiri Kosina jkos...@suse.cz Cc: Pavel Machek pa...@ucw.cz Cc: Hans de Bruin jmdebr...@xmsnet.nl Cc: sta...@vger.kernel.org Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch I have applied the patches and al looks well again. -- Hans ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] 3.16.0-rcx regression 945GM lower color depth
On 07/08/2014 09:39 AM, Chris Wilson wrote: On Mon, Jul 07, 2014 at 09:46:14PM +0200, Hans de Bruin wrote: Hi, Since the 3.16.0-rc my laptop displays a lower color depth. Gradient surfaces show a staircase effect where before the gradient was smooth. Daniel turned off dithering... Witch explains why I could not find a difference in bits per pixel. -- Hans ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] 3.11.0+ Laptop screen goes blank during kernelboot
On 09/13/2013 09:36 PM, Daniel Vetter wrote: On Fri, Sep 13, 2013 at 7:43 PM, Hans de Bruin jmdebr...@xmsnet.nl wrote: On 09/12/2013 10:49 PM, Daniel Vetter wrote: On Thu, Sep 12, 2013 at 10:45:10PM +0200, Hans de Bruin wrote: On 09/10/2013 01:00 PM, Jani Nikula wrote: Hi Hans - On Sat, 07 Sep 2013, Hans de Bruin jmdebr...@xmsnet.nl wrote: Since a day or two the screen of my laptop goes blank when the kernel switches resolution in the boot process. Happily the x-server turns it on again. Please try the drm-intel-nightly branch of git://people.freedesktop.org/~danvet/drm-intel Well the drm-intel-testing branch works fine but that was not the question. lets see if I am able to use gits -b option and clone drm-intel-nightly. -testing should be recent enough for the commit Jani mentioned. It's also already in Linus' git, so hopefully that works again for you. drm-intel-nightly Works fine to (the compile was already running when I read your mail). Today's Linus tree still has the defect. Time for a bisect? Hm, so either it's a different feature patch in -nightly which -fixes this, or much more likely a regression somewhere in Linus' git tree. I think a bisect is asked for here indeed. -Daniel This is the one: 137b944e100278d696826cf25c83014ac17473fe is the first bad commit commit 137b944e100278d696826cf25c83014ac17473fe Author: Daniel Lezcano daniel.lezc...@linaro.org Date: Wed Jun 12 15:08:48 2013 +0200 cpuidle: Make it clear that governors cannot be modules cpufreq governors are defined as modules in the code, but the Kconfig options do not allow them to be built as modules. This is not really a problem, but the cpuidle init ordering is: the cpuidle init functions (framework and driver) and then the governors. That leads to some weirdness in the cpuidle framework. Namely, cpuidle_register_device() calls cpuidle_enable_device() which fails at the first attempt, because governors have not been registered yet. When a governor is registered, the framework calls cpuidle_enable_device() again which runs __cpuidle_register_device() only then. Of course, for that to work, the cpuidle_enable_device() return value has to be ignored by cpuidle_register_device(). Instead of having this cyclic call graph and relying on a positive side effects of the hackish back and forth cpuidle_enable_device() calls it is better to fix the cpuidle init ordering. To that end, replace the module init code with postcore_initcall() so we have: * cpuidle framework : core_initcall * cpuidle governors : postcore_initcall * cpuidle drivers : device_initcall and remove the corresponding module exit code as it is dead anyway (governors can't be built as modules). [rjw: Changelog] Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Signed-off-by: Rafael J. Wysocki rafael.j.wyso...@intel.com :04 04 45e7cb28411864c00b62296a7ff239f9f139d5d9 86a36b01dee52a77cfbab41a973b7a2bfa44ce34 M drivers Reverting it makes the problem go away. The pull request from Rafael had cc's to linux-a...@vger.kernel.org linux-...@vger.kernel.org. -- Hans ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] 3.11.0+ Laptop screen goes blank during kernelboot
On 09/12/2013 10:49 PM, Daniel Vetter wrote: On Thu, Sep 12, 2013 at 10:45:10PM +0200, Hans de Bruin wrote: On 09/10/2013 01:00 PM, Jani Nikula wrote: Hi Hans - On Sat, 07 Sep 2013, Hans de Bruin jmdebr...@xmsnet.nl wrote: Since a day or two the screen of my laptop goes blank when the kernel switches resolution in the boot process. Happily the x-server turns it on again. Please try the drm-intel-nightly branch of git://people.freedesktop.org/~danvet/drm-intel Well the drm-intel-testing branch works fine but that was not the question. lets see if I am able to use gits -b option and clone drm-intel-nightly. -testing should be recent enough for the commit Jani mentioned. It's also already in Linus' git, so hopefully that works again for you. drm-intel-nightly Works fine to (the compile was already running when I read your mail). Today's Linus tree still has the defect. Time for a bisect? -- Hans ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] 3.11.0+ Laptop screen goes blank during kernelboot
On 09/10/2013 01:00 PM, Jani Nikula wrote: Hi Hans - On Sat, 07 Sep 2013, Hans de Bruin jmdebr...@xmsnet.nl wrote: Since a day or two the screen of my laptop goes blank when the kernel switches resolution in the boot process. Happily the x-server turns it on again. Please try the drm-intel-nightly branch of git://people.freedesktop.org/~danvet/drm-intel Well the drm-intel-testing branch works fine but that was not the question. lets see if I am able to use gits -b option and clone drm-intel-nightly. -- Hans ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] 3.10.0+ laptop resolution problem
somewhere before commit 496322b (yesterday's kernel) resolution switching on my laptop broke. The screen switches to the right resolution but the screen is not horizontally centered. The screen is aligned left and the last vertical line is repeated until the right side of the screen. Normally there would be black bars on left and right side. -- Hans lspci: ... 00:02.1 Display controller: Intel Corporation Mobile 945GM/GMS/GME, 943/940GML Express Integrated Graphics Controller (rev 03) ... Screen 0: minimum 320 x 200, current 800 x 600, maximum 4096 x 4096 LVDS1 connected 800x600+0+0 (0x47) normal (normal left inverted right x axis y axis) 261mm x 163mm Identifier: 0x41 Timestamp: 3327596 Subpixel: horizontal rgb Gamma: 1.0:1.0:1.0 Brightness: 1.0 Clones: CRTC: 1 CRTCs: 1 Transform: 1.00 0.00 0.00 0.00 1.00 0.00 0.00 0.00 1.00 filter: EDID: 00004ca34154 00110103801a10780a87f594574f8c27 2750540001010101010101010101 010101010101121b008b502010303020 360005a31019000f 0032d20232fe0050 593637350331323141540a2000fe 00263741496c88b0ff01010a20200084 BACKLIGHT: 0 (0x) range: (0,312) Backlight: 0 (0x) range: (0,312) scaling mode: Full aspect supported: None Full Center Full aspect 1280x800 (0x45) 69.3MHz -HSync -VSync +preferred h: width 1280 start 1328 end 1360 total 1419 skew0 clock 48.8KHz v: height 800 start 803 end 809 total 816 clock 59.8Hz 1024x768 (0x46) 65.0MHz -HSync -VSync h: width 1024 start 1048 end 1184 total 1344 skew0 clock 48.4KHz v: height 768 start 771 end 777 total 806 clock 60.0Hz 800x600 (0x47) 40.0MHz +HSync +VSync *current h: width 800 start 840 end 968 total 1056 skew0 clock 37.9KHz v: height 600 start 601 end 605 total 628 clock 60.3Hz 800x600 (0x48) 36.0MHz +HSync +VSync h: width 800 start 824 end 896 total 1024 skew0 clock 35.2KHz v: height 600 start 601 end 603 total 625 clock 56.2Hz 640x480 (0x49) 25.2MHz -HSync -VSync h: width 640 start 656 end 752 total 800 skew0 clock 31.5KHz v: height 480 start 490 end 492 total 525 clock 59.9Hz VGA1 disconnected (normal left inverted right x axis y axis) Identifier: 0x42 Timestamp: 3327596 Subpixel: unknown Clones: CRTCs: 0 1 Transform: 1.00 0.00 0.00 0.00 1.00 0.00 0.00 0.00 1.00 filter: DVI1 disconnected (normal left inverted right x axis y axis) Identifier: 0x43 Timestamp: 3327596 Subpixel: horizontal rgb Clones: CRTCs: 0 1 Transform: 1.00 0.00 0.00 0.00 1.00 0.00 0.00 0.00 1.00 filter: TV1 disconnected (normal left inverted right x axis y axis) Identifier: 0x44 Timestamp: 3327596 Subpixel: unknown Clones: CRTCs: 0 1 Transform: 1.00 0.00 0.00 0.00 1.00 0.00 0.00 0.00 1.00 filter: bottom margin: 37 (0x0025) range: (0,100) right margin: 46 (0x002e) range: (0,100) top margin: 36 (0x0024) range: (0,100) left margin: 54 (0x0036)range: (0,100) mode: NTSC-M supported: NTSC-M NTSC-443 NTSC-J PAL-M PAL-NPAL 480p 576p 720p@60Hz720p@50Hz1080i@50Hz 1080i@60Hz ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] 3.10.0+ laptop resolution problem
On 07/11/2013 09:41 PM, Daniel Vetter wrote: On Thu, Jul 11, 2013 at 09:05:45PM +0200, Hans de Bruin wrote: On 07/11/2013 08:22 PM, Daniel Vetter wrote: On Thu, Jul 11, 2013 at 8:04 PM, Hans de Bruin jmdebr...@xmsnet.nl wrote: somewhere before commit 496322b (yesterday's kernel) resolution switching on my laptop broke. The screen switches to the right resolution but the screen is not horizontally centered. The screen is aligned left and the last vertical line is repeated until the right side of the screen. Normally there would be black bars on left and right side. Can you please boot with drm.debug=0xe added to your kernel cmdline and then reply with your complete dmesg? I have also started a bisect. Is it useful to continue that? Let's first see whether my bug-spotting skills are still in working order. Please test the below diff, thanks. Apparently the are. The diff fixes my problem. -- Hans ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] commit drm/i915: disable shared panel fitter for pipe breaks resolution switching
On 04/11/2013 04:34 PM, Daniel Vetter wrote: On Tue, Apr 9, 2013 at 7:59 PM, Daniel Vetter dan...@ffwll.ch wrote: ... Ok, I guess that was just a comment to say that the current bug isn't quite a match with the old bug. Anyway, I think I've tracked down this regression here, but since I couldn't reproduce it, can you please test the patch at: https://patchwork.kernel.org/patch/2428981/ Your patch works. I have gone though all possible resolutions. Thanks for the effort. -- Hans ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] commit drm/i915: disable shared panel fitter for pipe breaks resolution switching
On 04/09/2013 06:40 PM, Daniel Vetter wrote: Can you please quickly test whether the below patch changes anything in the behaviour? diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 8809813..974ae32 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -4715,7 +4715,7 @@ static int i9xx_crtc_mode_set(struct drm_crtc *crtc, i9xx_set_pipeconf(intel_crtc); - intel_enable_pipe(dev_priv, pipe, false); + //intel_enable_pipe(dev_priv, pipe, false); intel_wait_for_vblank(dev, pipe); for some reason the diff did not work. Here a snippet of my modified intel_display.c: ... /* pipesrc and dspsize control the size that is scaled from, * which should always be the user's requested size. */ I915_WRITE(DSPSIZE(plane), ((mode-vdisplay - 1) 16) | (mode-hdisplay - 1)); I915_WRITE(DSPPOS(plane), 0); I915_WRITE(PIPECONF(pipe), pipeconf); POSTING_READ(PIPECONF(pipe)); //intel_enable_pipe(dev_priv, pipe, false); intel_wait_for_vblank(dev, pipe); I915_WRITE(DSPCNTR(plane), dspcntr); POSTING_READ(DSPCNTR(plane)); ... The screen still does not scale. By the way, I have had this problem before: https://bugzilla.kernel.org/show_bug.cgi?id=43071 -- Hans On Mon, Apr 8, 2013 at 7:38 PM, Hans de Bruin jmdebr...@xmsnet.nl wrote: On 04/07/2013 08:56 PM, Daniel Vetter wrote: On Sun, Mar 10, 2013 at 06:02:32PM +0100, Hans de Bruin wrote: On 03/06/2013 11:37 PM, Daniel Vetter wrote: On Wed, Mar 6, 2013 at 7:39 PM, Hans de Bruin jmdebr...@xmsnet.nl wrote: On 03/06/2013 03:00 PM, Daniel Vetter wrote: Hi Hans, Can you please test with 3.9-rc1? That contains an additional patch which might prevent the regression. Specifically commit 9d6d9f19e8146fa24903cb561e204a22232740e3 Author: Mika Kuoppala mika.kuopp...@linux.intel.com Date: Fri Feb 8 16:35:38 2013 +0200 drm/i915: clean up panel fitter handling in lvds Today's kernel still contains the bug. Hm, I've just retested latest drm-intel-nightly which should have the same set of relevant patches, and I couldn't reproduce your issue. Low-res modes on the lvds panel seem to correctly scale up here on my 945gm. Can you pls retest with latest -nightly from http://cgit.freedesktop.org/~danvet/drm-intel ? Also please attach the output of xrandr --verbose when running with a reduced mode. tested: http://cgit.freedesktop.org/~danvet/drm-intel commit d08a6eb2690b1ac6f0582feb41c2ccbea945285f Date: Thu Mar 7 22:54:25 2013 +0100 The problem is still there my previous post contained the xrandr output whiteout the verbose. Doe you want my to repost with the verbose option? Sorry for the long delay in taking again a look at this. I've tried to reproduce this on my various machines similar to yours, but totally failed. Also, a bunch of people with matching machines to yours actually claim that the 2 commits which regress for you actually fix up lvds panel fiting for them. So I'm a bit lost as to what's going on here. Can you please try the below debug patch on top of latest 3.9-rc kernels? Please boot that kernel with drm.debug=0xe added to your kernel cmdline, reproduce the issue (preferrably with xrandr --output LVDS --mode ...) and then attach the complete dmesg. This will enable lots of debugging, so please make sure you grab everything starting from when i915.ko loads. ok, here is de dmesg. -- Hans -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] commit drm/i915: disable shared panel fitter for pipe breaks resolution switching
On 04/09/2013 07:42 PM, Hans de Bruin wrote: On 04/09/2013 06:40 PM, Daniel Vetter wrote: Can you please quickly test whether the below patch changes anything in the behaviour? diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 8809813..974ae32 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -4715,7 +4715,7 @@ static int i9xx_crtc_mode_set(struct drm_crtc *crtc, i9xx_set_pipeconf(intel_crtc); - intel_enable_pipe(dev_priv, pipe, false); + //intel_enable_pipe(dev_priv, pipe, false); intel_wait_for_vblank(dev, pipe); for some reason the diff did not work. Here a snippet of my modified intel_display.c: ... /* pipesrc and dspsize control the size that is scaled from, * which should always be the user's requested size. */ I915_WRITE(DSPSIZE(plane), ((mode-vdisplay - 1) 16) | (mode-hdisplay - 1)); I915_WRITE(DSPPOS(plane), 0); I915_WRITE(PIPECONF(pipe), pipeconf); POSTING_READ(PIPECONF(pipe)); //intel_enable_pipe(dev_priv, pipe, false); intel_wait_for_vblank(dev, pipe); I915_WRITE(DSPCNTR(plane), dspcntr); POSTING_READ(DSPCNTR(plane)); ... The screen still does not scale. By the way, I have had this problem before: https://bugzilla.kernel.org/show_bug.cgi?id=43071 sorry my mistake that one did scale, but just was not alligned properly. -- Hans ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] regression: grass turns red
On 03/26/2013 10:15 PM, Alexander van Heukelum wrote: Hi Hans, Could you check if the attached patch solves your problem? Yep, the grass is green again. -- Hans ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] regression: grass turns red
commit 49cb25e9290 x86: 'get rid of pt_regs argument in vm86/vm86old' somehow breaks the colors when I play 'civilization I' under xdosemu. During the intro of the game something the colors get messed up. When the game begins the grass of the earth is red. Reverting the commit fixes the problem. -- Hans ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] commit drm/i915: disable shared panel fitter for pipe breaks resolution switching
On 03/06/2013 11:37 PM, Daniel Vetter wrote: On Wed, Mar 6, 2013 at 7:39 PM, Hans de Bruin jmdebr...@xmsnet.nl wrote: On 03/06/2013 03:00 PM, Daniel Vetter wrote: Hi Hans, Can you please test with 3.9-rc1? That contains an additional patch which might prevent the regression. Specifically commit 9d6d9f19e8146fa24903cb561e204a22232740e3 Author: Mika Kuoppala mika.kuopp...@linux.intel.com Date: Fri Feb 8 16:35:38 2013 +0200 drm/i915: clean up panel fitter handling in lvds Today's kernel still contains the bug. Hm, I've just retested latest drm-intel-nightly which should have the same set of relevant patches, and I couldn't reproduce your issue. Low-res modes on the lvds panel seem to correctly scale up here on my 945gm. Can you pls retest with latest -nightly from http://cgit.freedesktop.org/~danvet/drm-intel ? Also please attach the output of xrandr --verbose when running with a reduced mode. tested: http://cgit.freedesktop.org/~danvet/drm-intel commit d08a6eb2690b1ac6f0582feb41c2ccbea945285f Date: Thu Mar 7 22:54:25 2013 +0100 The problem is still there my previous post contained the xrandr output whiteout the verbose. Doe you want my to repost with the verbose option? -- Hans PGETBL_CTL: 0x7ffc0001 PGTBL_ER: 0x EXCC: 0x HWS_PGA: 0x361c7000 IPEIR: 0x IPEHR: 0x0100 INST_DONE: 0x7fc0 NOPID: 0x HWSTAM: 0xfffceffe SCPD0: 0x0200 IER: 0x00028053 IIR: 0x IMR: 0xfffd73ae ISR: 0x EIR: 0x EMR: 0xffed ESR: 0x0001 INST_PM: 0x0800 ECOSKPD: 0x0306 DCC: 0x000f0400 (single channel, XOR randomization: disabled, XOR bit: 11) CHDECMISC: 0x22b97420 (XOR bank/rank, ch2 enh disabled, ch1 enh disabled, ch0 enh disabled, flex disabled, ep not present) C0DRB0: 0x000f0400 (0x0400) C0DRB1: 0x000f (0x000f) C0DRB2: 0x (0x) C0DRB3: 0x0108 (0x) C1DRB0: 0x0e0d0d0c (0x0d0c) C1DRB1: 0x0f0e0e0d (0x0e0d) C1DRB2: 0x100f0f0e (0x0f0e) C1DRB3: 0x0e0d100f (0x100f) C0DRA01: 0x04020108 (0x0108) C0DRA23: 0x0402 (0x0402) C1DRA01: 0x100f0e0d (0x0e0d) C1DRA23: 0x1211100f (0x100f) PGETBL_CTL: 0x7ffc0001 VCLK_DIVISOR_VGA0: 0x00031108 (n = 3, m1 = 17, m2 = 8) VCLK_DIVISOR_VGA1: 0x00031406 (n = 3, m1 = 20, m2 = 6) VCLK_POST_DIV: 0x00020002 (vga0 p1 = 4, p2 = 2, vga1 p1 = 2, p2 = 2) DPLL_TEST: 0x00010001 () CACHE_MODE_0: 0x6820 D_STATE: 0x000b DSPCLK_GATE_D: 0x1000 (clock gates disabled: DPLUNIT) RENCLK_GATE_D1: 0x RENCLK_GATE_D2: 0x SDVOB: 0x00480004 (disabled, pipe A, stall disabled, detected) SDVOC: 0x0048 (disabled, pipe A, stall disabled, not detected) SDVOUDI: 0x DSPARB: 0x1d9c DSPFW1: 0x DSPFW2: 0x DSPFW3: 0x ADPA: 0x40008c18 (disabled, pipe B, +hsync, +vsync) LVDS: 0xc0308300 (enabled, pipe B, 18 bit, 1 channel) DVOA: 0x (disabled, pipe A, no stall, -hsync, -vsync) DVOB: 0x00480004 (disabled, pipe A, no stall, -hsync, -vsync) DVOC: 0x0048 (disabled, pipe A, no stall, -hsync, -vsync) DVOA_SRCDIM: 0x DVOB_SRCDIM: 0x DVOC_SRCDIM: 0x PP_CONTROL: 0xabcd0001 (power target: on) PP_STATUS: 0xc008 (on, ready, sequencing idle) PP_ON_DELAYS: 0x012c07d0 PP_OFF_DELAYS: 0x00fa07d0 PP_DIVISOR: 0x00270f05 PFIT_CONTROL: 0x PFIT_PGM_RATIOS: 0x99909990 PORT_HOTPLUG_EN: 0x0220 PORT_HOTPLUG_STAT: 0x0400 DSPACNTR: 0xd900 (enabled, pipe B) DSPASTRIDE: 0x1000 (4096 bytes) DSPAPOS: 0x (0, 0) DSPASIZE: 0x01df027f (640, 480) DSPABASE: 0x0720 DSPASURF: 0x DSPATILEOFF: 0x PIPEACONF: 0x (disabled, single-wide) PIPEASRC: 0x04ff03ff (1280, 1024) PIPEASTAT: 0x (status:) PIPEA_GMCH_DATA_M: 0x PIPEA_GMCH_DATA_N: 0x PIPEA_DP_LINK_M: 0x PIPEA_DP_LINK_N: 0x CURSOR_A_BASE: 0x CURSOR_A_CONTROL
Re: [Intel-gfx] commit drm/i915: disable shared panel fitter for pipe breaks resolution switching
On 03/06/2013 03:00 PM, Daniel Vetter wrote: Hi Hans, Can you please test with 3.9-rc1? That contains an additional patch which might prevent the regression. Specifically commit 9d6d9f19e8146fa24903cb561e204a22232740e3 Author: Mika Kuoppala mika.kuopp...@linux.intel.com Date: Fri Feb 8 16:35:38 2013 +0200 drm/i915: clean up panel fitter handling in lvds Today's kernel still contains the bug. -- Hans ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] commit drm/i915: disable shared panel fitter for pipe breaks resolution switching
On 03/06/2013 04:32 PM, Mika Kuoppala wrote: Hello Hans, Daniel Vetter daniel.vet...@ffwll.ch writes: Hi Hans, Can you please test with 3.9-rc1? That contains an additional patch which might prevent the regression. Specifically commit 9d6d9f19e8146fa24903cb561e204a22232740e3 Author: Mika Kuoppala mika.kuopp...@linux.intel.com Date: Fri Feb 8 16:35:38 2013 +0200 drm/i915: clean up panel fitter handling in lvds Thanks, Daniel Further, could you also test: https://github.com/mkuoppal/linux/tree/pfit_test pfit_test functions normally. -- Hans ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] commit drm/i915: disable shared panel fitter for pipe breaks resolution switching
On 03/06/2013 11:37 PM, Daniel Vetter wrote: On Wed, Mar 6, 2013 at 7:39 PM, Hans de Bruin jmdebr...@xmsnet.nl wrote: On 03/06/2013 03:00 PM, Daniel Vetter wrote: Hi Hans, Can you please test with 3.9-rc1? That contains an additional patch which might prevent the regression. Specifically commit 9d6d9f19e8146fa24903cb561e204a22232740e3 Author: Mika Kuoppala mika.kuopp...@linux.intel.com Date: Fri Feb 8 16:35:38 2013 +0200 drm/i915: clean up panel fitter handling in lvds Today's kernel still contains the bug. Hm, I've just retested latest drm-intel-nightly which should have the same set of relevant patches, and I couldn't reproduce your issue. Low-res modes on the lvds panel seem to correctly scale up here on my 945gm. dell latitudes d430's are quite special. Can you pls retest with latest -nightly from http://cgit.freedesktop.org/~danvet/drm-intel ? pending Also please attach the output of xrandr --verbose when running with a reduced mode. I have attached the output of xrandr and intel_reg_dumper good and bad. People have asked for intel_reg_dumper output before. I do not know whether color things show up in the dump but I also have a color problem. That problem is not caused by this commit. -- Hans PGETBL_CTL: 0x7ffc0001 PGTBL_ER: 0x EXCC: 0x HWS_PGA: 0x3620 IPEIR: 0x IPEHR: 0x0100 INST_DONE: 0x7fc0 NOPID: 0x HWSTAM: 0xfffceffe SCPD0: 0x0200 IER: 0x00028053 IIR: 0x IMR: 0xfffd73ae ISR: 0x EIR: 0x EMR: 0xffed ESR: 0x0001 INST_PM: 0x0800 ECOSKPD: 0x0306 DCC: 0x000f0400 (single channel, XOR randomization: disabled, XOR bit: 11) CHDECMISC: 0x22b97420 (XOR bank/rank, ch2 enh disabled, ch1 enh disabled, ch0 enh disabled, flex disabled, ep not present) C0DRB0: 0x000f0400 (0x0400) C0DRB1: 0x000f (0x000f) C0DRB2: 0x (0x) C0DRB3: 0x0108 (0x) C1DRB0: 0x0e0d0d0c (0x0d0c) C1DRB1: 0x0f0e0e0d (0x0e0d) C1DRB2: 0x100f0f0e (0x0f0e) C1DRB3: 0x0e0d100f (0x100f) C0DRA01: 0x04020108 (0x0108) C0DRA23: 0x0402 (0x0402) C1DRA01: 0x100f0e0d (0x0e0d) C1DRA23: 0x1211100f (0x100f) PGETBL_CTL: 0x7ffc0001 VCLK_DIVISOR_VGA0: 0x00031108 (n = 3, m1 = 17, m2 = 8) VCLK_DIVISOR_VGA1: 0x00031406 (n = 3, m1 = 20, m2 = 6) VCLK_POST_DIV: 0x00020002 (vga0 p1 = 4, p2 = 2, vga1 p1 = 2, p2 = 2) DPLL_TEST: 0x00010001 () CACHE_MODE_0: 0x6820 D_STATE: 0x000b DSPCLK_GATE_D: 0x1000 (clock gates disabled: DPLUNIT) RENCLK_GATE_D1: 0x RENCLK_GATE_D2: 0x SDVOB: 0x00480004 (disabled, pipe A, stall disabled, detected) SDVOC: 0x0048 (disabled, pipe A, stall disabled, not detected) SDVOUDI: 0x DSPARB: 0x1d9c DSPFW1: 0x DSPFW2: 0x DSPFW3: 0x ADPA: 0x40008c18 (disabled, pipe B, +hsync, +vsync) LVDS: 0xc0308300 (enabled, pipe B, 18 bit, 1 channel) DVOA: 0x (disabled, pipe A, no stall, -hsync, -vsync) DVOB: 0x00480004 (disabled, pipe A, no stall, -hsync, -vsync) DVOC: 0x0048 (disabled, pipe A, no stall, -hsync, -vsync) DVOA_SRCDIM: 0x DVOB_SRCDIM: 0x DVOC_SRCDIM: 0x PP_CONTROL: 0xabcd0001 (power target: on) PP_STATUS: 0xc008 (on, ready, sequencing idle) PP_ON_DELAYS: 0x012c07d0 PP_OFF_DELAYS: 0x00fa07d0 PP_DIVISOR: 0x00270f05 PFIT_CONTROL: 0x PFIT_PGM_RATIOS: 0x99909990 PORT_HOTPLUG_EN: 0x0220 PORT_HOTPLUG_STAT: 0x0400 DSPACNTR: 0xd900 (enabled, pipe B) DSPASTRIDE: 0x2000 (8192 bytes) DSPAPOS: 0x (0, 0) DSPASIZE: 0x01df027f (640, 480) DSPABASE: 0x0480 DSPASURF: 0x DSPATILEOFF: 0x PIPEACONF: 0x (disabled, single-wide) PIPEASRC: 0x04ff03ff (1280, 1024) PIPEASTAT: 0x (status:) PIPEA_GMCH_DATA_M: 0x PIPEA_GMCH_DATA_N: 0x PIPEA_DP_LINK_M: 0x PIPEA_DP_LINK_N: 0x CURSOR_A_BASE
