Re: [Intel-gfx] [PATCH v3] drm/i915: Honor SSC quirk table over the default, unless set by user
Hi Keith, That patch is still not in 3.2-rc2, drm-intel-fixes or drm-intel-next. I've been using it successfully on i915 (both SSC-blacklisted and not) and non-i915 machines; feel free to set the Tested-by and Reviewed-by tags. Thanks, -- Michel On 11/09/2011 07:07 PM, Keith Packard wrote: > On Wed, 09 Nov 2011 17:30:29 +0100, Michel Alexandre Salim > wrote: >> Additional note: while I've not touched the line since it does not >> affect me, it seems that i915_panel_use_ssc *cannot* be less than 0 >> since that variable is declared as unsigned. > > Oops. That's the bug here -- we're supposed to make it so that the > command line can override the quirks, but there's no way to use a quirk > given the mis-declared parameter. > > This is untested... > > From e64ecadef40e3c2035cd4e9b967ffd83489bdea0 Mon Sep 17 00:00:00 2001 > From: Keith Packard > Date: Wed, 9 Nov 2011 09:57:50 -0800 > Subject: [PATCH] drm/i915: Module parameters using '-1' as default must be > signed type > > Testing i915_panel_use_ssc for the default value was broken, so the > driver would never autodetect the correct value. > > Signed-off-by: Keith Packard > --- > drivers/gpu/drm/i915/i915_drv.c |4 ++-- > drivers/gpu/drm/i915/i915_drv.h |4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index 548e04b..13488be 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -67,7 +67,7 @@ module_param_named(i915_enable_rc6, i915_enable_rc6, int, > 0600); > MODULE_PARM_DESC(i915_enable_rc6, > "Enable power-saving render C-state 6 (default: true)"); > > -unsigned int i915_enable_fbc __read_mostly = -1; > +int i915_enable_fbc __read_mostly = -1; > module_param_named(i915_enable_fbc, i915_enable_fbc, int, 0600); > MODULE_PARM_DESC(i915_enable_fbc, > "Enable frame buffer compression for power savings " > @@ -79,7 +79,7 @@ MODULE_PARM_DESC(lvds_downclock, > "Use panel (LVDS/eDP) downclocking for power savings " > "(default: false)"); > > -unsigned int i915_panel_use_ssc __read_mostly = -1; > +int i915_panel_use_ssc __read_mostly = -1; > module_param_named(lvds_use_ssc, i915_panel_use_ssc, int, 0600); > MODULE_PARM_DESC(lvds_use_ssc, > "Use Spread Spectrum Clock with panels [LVDS/eDP] " > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index d2da91f..4a9c1b9 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -1000,10 +1000,10 @@ extern int i915_panel_ignore_lid __read_mostly; > extern unsigned int i915_powersave __read_mostly; > extern unsigned int i915_semaphores __read_mostly; > extern unsigned int i915_lvds_downclock __read_mostly; > -extern unsigned int i915_panel_use_ssc __read_mostly; > +extern int i915_panel_use_ssc __read_mostly; > extern int i915_vbt_sdvo_panel_type __read_mostly; > extern unsigned int i915_enable_rc6 __read_mostly; > -extern unsigned int i915_enable_fbc __read_mostly; > +extern int i915_enable_fbc __read_mostly; > extern bool i915_enable_hangcheck __read_mostly; > > extern int i915_suspend(struct drm_device *dev, pm_message_t state); > > > > ___ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Michel Alexandre Salim µblog: http://identi.ca/hircus http://twitter.com/hircus GPG key ID: 78884778 () ascii ribbon campaign - against html e-mail /\ www.asciiribbon.org - against proprietary attachments ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v3] drm/i915: Honor SSC quirk table over the default, unless set by user
On Wed, 2011-11-09 at 10:07 -0800, Keith Packard wrote: > On Wed, 09 Nov 2011 17:30:29 +0100, Michel Alexandre Salim > wrote: > > Additional note: while I've not touched the line since it does not > > affect me, it seems that i915_panel_use_ssc *cannot* be less than 0 > > since that variable is declared as unsigned. > > Oops. That's the bug here -- we're supposed to make it so that the > command line can override the quirks, but there's no way to use a quirk > given the mis-declared parameter. Ah, now everything makes sense. > > This is untested... > Tested and it works fine: - without extra parameter, the blacklist is used - with i915.lvds_use_ssc=1, SSC use is enforced and the display turns black on my unsupported hardware - with i915.lvds_use_ssc=0, SSC is disabled (ps the PGP/MIME signature made it hard to just extract the git-formatted email; I ended up just editing the message by hand before 'git am') > From e64ecadef40e3c2035cd4e9b967ffd83489bdea0 Mon Sep 17 00:00:00 2001 > From: Keith Packard > Date: Wed, 9 Nov 2011 09:57:50 -0800 > Subject: [PATCH] drm/i915: Module parameters using '-1' as default must be > signed type > > Testing i915_panel_use_ssc for the default value was broken, so the > driver would never autodetect the correct value. > > Signed-off-by: Keith Packard Reviewed-by: Michel Alexandre Salim Tested-by: Michel Alexandre Salim Should I send the patch that I applied with those added lines? Probably not necessary. Thanks, -- Michel ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH v3] drm/i915: Honor SSC quirk table over the default, unless set by user
Additional note: while I've not touched the line since it does not
affect me, it seems that i915_panel_use_ssc *cannot* be less than 0
since that variable is declared as unsigned.
So the last line (the value in dev_priv) will never be used to determine
whether SSC is used anyway. Keith probably knows more since he
introduces that check in the commit that my patch referred to.
On 11/09/2011 05:12 PM, Michel Alexandre Salim wrote:
> static inline bool intel_panel_use_ssc(struct drm_i915_private *dev_priv)
> {
> + if (i915_panel_use_ssc == 1)
> + return true;
> + if (dev_priv->quirks & QUIRK_LVDS_SSC_DISABLE)
> + return false;
> if (i915_panel_use_ssc >= 0)
> return i915_panel_use_ssc != 0;
> - return dev_priv->lvds_use_ssc
> - && !(dev_priv->quirks & QUIRK_LVDS_SSC_DISABLE);
> + return dev_priv->lvds_use_ssc;
> }
>
> /**
--
Michel Alexandre Salim
µblog: http://identi.ca/hircus
http://twitter.com/hircus
GPG key ID: 78884778
() ascii ribbon campaign - against html e-mail
/\ www.asciiribbon.org - against proprietary attachments
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm/i915: Prioritize SSC quirk table when determining SSC settings
On Wed, 2011-11-09 at 14:20 +, Chris Wilson wrote: > On Wed, 09 Nov 2011 15:11:40 +0100, Michel Alexandre Salim > wrote: > > From ab11cf4b1b28d0abb1db8bc992d016b257489ab5 Mon Sep 17 00:00:00 2001 > > From: Michel Alexandre Salim > > Date: Wed, 9 Nov 2011 14:18:45 +0100 > > Subject: [PATCH] drm/i915: Prioritize SSC quirk table when determining SSC > > settings > > > > Commit 72bbe58cd9568c7766cc219a779ea68a02132797 makes the check against > > the quirk table unreachable if i915_panel_use_ssc is set. This patch > > reorders the tests so that the quirk table is checked first, the > > i915_panel_use_ssc next and the original per-device setting last. > > The whole point of having a module parameter is to override the defaults > for the hardware, be it quirked or not. You are complaining that we are > honoring a parameter explicitly set by the user, are you not? > -Chris > Fixed in v3: - if i915_panel_use_ssc is set to exactly 1 (so the user is explicitly setting this value) then quirk is ignored - else if the hardware is in the quirk table, SSC is always disabled - else consider the inherited value of i915_panel_use_ssc per Keith's 72bbe58cd commit - lastly, use the original device SSC setting (no longer checking against the quirk table here, since that's already checked before). I've tested it by booting: - without any kernel parameter override -- SSC is off and my panel works - with i915.lvds_use_ssc=1 -- SSC is forced on, panel turns black as soon as KMS is enabled - with i915.lvds_use_ssc=0 -- SSC is off Let me know if there's any problem with the v3 patch. Thanks, -- Michel Alexandre Salim ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH v3] drm/i915: Honor SSC quirk table over the default, unless set by user
>From a90bf9ac2a40869242a79c88958c99dacc3da2a9 Mon Sep 17 00:00:00 2001
From: Michel Alexandre Salim
Date: Wed, 9 Nov 2011 14:18:45 +0100
Subject: [PATCH v3] drm/i915: Honor SSC quirk table over the default, unless
set by user
Commit 72bbe58cd9568c7766cc219a779ea68a02132797 makes the check against
the quirk table unreachable if i915_panel_use_ssc is automatically set
to a non-zero value. This patch changes the tests so that unless
i915_panel_use_ssc is set to exactly 1, the quirk table is checked.
This ensures that on known quirky hardware, SSC is disabled unless
specifically enabled by the user.
Signed-off-by: Michel Alexandre Salim
---
drivers/gpu/drm/i915/intel_display.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 981b1f1..aa7b0c8 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -4660,10 +4660,13 @@ static void intel_update_watermarks(struct drm_device
*dev)
static inline bool intel_panel_use_ssc(struct drm_i915_private *dev_priv)
{
+ if (i915_panel_use_ssc == 1)
+ return true;
+ if (dev_priv->quirks & QUIRK_LVDS_SSC_DISABLE)
+ return false;
if (i915_panel_use_ssc >= 0)
return i915_panel_use_ssc != 0;
- return dev_priv->lvds_use_ssc
- && !(dev_priv->quirks & QUIRK_LVDS_SSC_DISABLE);
+ return dev_priv->lvds_use_ssc;
}
/**
--
1.7.7
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH v2] drm/i915: Prioritize SSC quirk table when determining SSC settings
>From ab11cf4b1b28d0abb1db8bc992d016b257489ab5 Mon Sep 17 00:00:00 2001
From: Michel Alexandre Salim
Date: Wed, 9 Nov 2011 14:18:45 +0100
Subject: [PATCH] drm/i915: Prioritize SSC quirk table when determining SSC
settings
Commit 72bbe58cd9568c7766cc219a779ea68a02132797 makes the check against
the quirk table unreachable if i915_panel_use_ssc is set. This patch
reorders the tests so that the quirk table is checked first, the
i915_panel_use_ssc next and the original per-device setting last.
Signed-off-by: Michel Alexandre Salim
---
drivers/gpu/drm/i915/intel_display.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 981b1f1..23a05bb 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -4660,10 +4660,11 @@ static void intel_update_watermarks(struct drm_device
*dev)
static inline bool intel_panel_use_ssc(struct drm_i915_private *dev_priv)
{
+ if (dev_priv->quirks & QUIRK_LVDS_SSC_DISABLE)
+ return false;
if (i915_panel_use_ssc >= 0)
return i915_panel_use_ssc != 0;
- return dev_priv->lvds_use_ssc
- && !(dev_priv->quirks & QUIRK_LVDS_SSC_DISABLE);
+ return dev_priv->lvds_use_ssc;
}
/**
--
1.7.6.4
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm/i915: Prioritize SSC quirk table when determining SSC settings
On Wed, 2011-11-09 at 15:11 +0100, Michel Alexandre Salim wrote: > From ab11cf4b1b28d0abb1db8bc992d016b257489ab5 Mon Sep 17 00:00:00 2001 > From: Michel Alexandre Salim > Date: Wed, 9 Nov 2011 14:18:45 +0100 > Subject: [PATCH] drm/i915: Prioritize SSC quirk table when determining SSC > settings > Apologies; subject line gets line-wrapped. Sending the fixed version next. -- Michel Alexandre Salim ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH] drm/i915: Prioritize SSC quirk table when determining SSC settings
>From ab11cf4b1b28d0abb1db8bc992d016b257489ab5 Mon Sep 17 00:00:00 2001
From: Michel Alexandre Salim
Date: Wed, 9 Nov 2011 14:18:45 +0100
Subject: [PATCH] drm/i915: Prioritize SSC quirk table when determining SSC
settings
Commit 72bbe58cd9568c7766cc219a779ea68a02132797 makes the check against
the quirk table unreachable if i915_panel_use_ssc is set. This patch
reorders the tests so that the quirk table is checked first, the
i915_panel_use_ssc next and the original per-device setting last.
Signed-off-by: Michel Alexandre Salim
---
drivers/gpu/drm/i915/intel_display.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 981b1f1..23a05bb 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -4660,10 +4660,11 @@ static void intel_update_watermarks(struct drm_device
*dev)
static inline bool intel_panel_use_ssc(struct drm_i915_private *dev_priv)
{
+ if (dev_priv->quirks & QUIRK_LVDS_SSC_DISABLE)
+ return false;
if (i915_panel_use_ssc >= 0)
return i915_panel_use_ssc != 0;
- return dev_priv->lvds_use_ssc
- && !(dev_priv->quirks & QUIRK_LVDS_SSC_DISABLE);
+ return dev_priv->lvds_use_ssc;
}
/**
--
1.7.6.4
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] i915 native backlight never got merged
Keith, On Fri, 2011-08-12 at 09:34 -0700, Kamal Mostafa wrote: > On Fri, 2011-08-12 at 06:52 -0700, Keith Packard wrote: > > On Fri, 12 Aug 2011 12:11:33 +0200, Michel Alexandre Salim > > wrote: > > > > > Matthew's last patch from July 16th applies without modification on top > > > of Linux 3.0 and 3.1-rc1 [...] > >> From fa7419eee713b989e2c268c7b06ec9a544a2b647 Mon Sep 17 00:00:00 2001 > > > > I'll merge this version, with the change to make > > intel_panel_init_backlight static (it's not declared in a header, and > > isn't used outside of intel_panel.c). > > That version works also works fine for me. > any update on the merge? I've not seen it anywhere on git://git.kernel.org/pub/scm/linux/kernel/git/keithp/linux-2.6 Thanks, -- Michel ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] i915 native backlight never got merged
Hi Keith & all,
On Thu, 2011-08-11 at 15:28 -0700, Keith Packard wrote:
> On Thu, 11 Aug 2011 21:36:38 +0200, Michel Alexandre Salim
> wrote:
>
> > Since there's no known regression introduced by Matthew's patch, could
> > it be merged? Feel free to add a
>
> I've had to amend the patch a bit to get it to apply on top of
> drm-intel-fixes; anyone care to take a look and see if it still looks
> reasonable (and/or actually works?)
>
Matthew's last patch from July 16th applies without modification on top
of Linux 3.0 and 3.1-rc1, and applies with some offsets on top of
drm-intel-fixes.
I've eyeballed the code and they look identical apart from some lines
struct changes being transposed a bit, and intel_panel_init_backlight is
no longer static; please find the patch attached below (with my
Tested-by: added)
>From fa7419eee713b989e2c268c7b06ec9a544a2b647 Mon Sep 17 00:00:00 2001
From: Matthew Garrett
Date: Sat, 16 Jul 2011 23:31:01 +1000
Subject: [PATCH] Not all systems expose a firmware or platform mechanism for
changing the backlight intensity on i915, so add native
driver support.
Signed-off-by: Matthew Garrett
Cc: Richard Purdie
Cc: Chris Wilson
Cc: David Airlie
Cc: Alex Deucher
Cc: Ben Skeggs
Cc: Zhang Rui
Cc: Len Brown
Cc: Jesse Barnes
Tested-by: Sedat Dilek
Tested-by: Michel Alexandre Salim
Signed-off-by: Andrew Morton
---
drivers/gpu/drm/i915/i915_drv.h |4 ++
drivers/gpu/drm/i915/intel_dp.c |7 +++
drivers/gpu/drm/i915/intel_drv.h |3 +-
drivers/gpu/drm/i915/intel_lvds.c |5 ++
drivers/gpu/drm/i915/intel_opregion.c |1 -
drivers/gpu/drm/i915/intel_panel.c| 72 -
6 files changed, 89 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 6867e19..886bd29 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -36,6 +36,7 @@
#include
#include
#include
+#include
/* General customization:
*/
@@ -689,6 +690,7 @@ typedef struct drm_i915_private {
int child_dev_num;
struct child_device_config *child_dev;
struct drm_connector *int_lvds_connector;
+ struct drm_connector *int_edp_connector;
bool mchbar_need_disable;
@@ -722,6 +724,8 @@ typedef struct drm_i915_private {
/* list of fbdev register on this device */
struct intel_fbdev *fbdev;
+ struct backlight_device *backlight;
+
struct drm_property *broadcast_rgb_property;
struct drm_property *force_audio_property;
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index f797fb5..2cde606 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -1811,6 +1811,11 @@ done:
static void
intel_dp_destroy (struct drm_connector *connector)
{
+ struct drm_device *dev = connector->dev;
+
+ if (intel_dpd_is_edp(dev))
+ intel_panel_destroy_backlight(dev);
+
drm_sysfs_connector_remove(connector);
drm_connector_cleanup(connector);
kfree(connector);
@@ -2043,6 +2048,8 @@ intel_dp_init(struct drm_device *dev, int output_reg)
DRM_MODE_TYPE_PREFERRED;
}
}
+ dev_priv->int_edp_connector = connector;
+ intel_panel_setup_backlight(dev);
}
intel_dp_add_properties(intel_dp, connector);
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index 6e990f9..057e2bc 100644
--- a/drivers/gpu/drm/i915/intel_drv.h
+++ b/drivers/gpu/drm/i915/intel_drv.h
@@ -274,9 +274,10 @@ extern void intel_pch_panel_fitting(struct drm_device *dev,
extern u32 intel_panel_get_max_backlight(struct drm_device *dev);
extern u32 intel_panel_get_backlight(struct drm_device *dev);
extern void intel_panel_set_backlight(struct drm_device *dev, u32 level);
-extern void intel_panel_setup_backlight(struct drm_device *dev);
+extern int intel_panel_setup_backlight(struct drm_device *dev);
extern void intel_panel_enable_backlight(struct drm_device *dev);
extern void intel_panel_disable_backlight(struct drm_device *dev);
+extern void intel_panel_destroy_backlight(struct drm_device *dev);
extern enum drm_connector_status intel_panel_detect(struct drm_device *dev);
extern void intel_crtc_load_lut(struct drm_crtc *crtc);
diff --git a/drivers/gpu/drm/i915/intel_lvds.c
b/drivers/gpu/drm/i915/intel_lvds.c
index b28f7bd..9104496 100644
--- a/drivers/gpu/drm/i915/intel_lvds.c
+++ b/drivers/gpu/drm/i915/intel_lvds.c
@@ -582,6 +582,8 @@ static void intel_lvds_destroy(struct drm_connector
*connector)
struct drm_device *dev = connector->dev;
struct drm_i915_private *dev_priv = dev->dev_private;
+ intel_panel_destroy_backlight(dev);
+
if (dev_priv->lid_notifier.
Re: [Intel-gfx] i915 native backlight never got merged
On Sun, Aug 21, 2011 at 6:00 AM, Ali Gholami Rudi wrote: > Andrew Morton wrote: >> >> On Wed, 10 Aug 2011 07:53:18 -0700 Keith Packard wrote: >> > Matthew -- shall I just merge the old patch? Or did you want to make >> > some changes? >> >> I have a note here that Ali Gholami Rudi had issues with >> the version I merged into -mm. > > Actually the patch helped me cope with another annoying problem. > The problem is in some kernels the ACPI brightness control > disappears. Matthew's patches made it possible to access the > native backlight control via sysfs, without which I couldn't > change the brightness of my screen. So my problem has nothing > to do with Matthew's patches. > Since there's no known regression introduced by Matthew's patch, could it be merged? Feel free to add a 'Tested-by: Michel Alexandre Salim ' line to it. I've had to run my own kernels since I got my Sony Vaio Y2 last December, and from reports on notebookreview.com's forum, it's affecting other Linux users of this laptop (most of them using Kamal Mostafa's PPA) Thanks, -- Michel Alexandre Salim Fedora Project Contributor: http://fedoraproject.org/ Email: sali...@fedoraproject.org | GPG key ID: 78884778 Jabber: hir...@jabber.ccc.de | IRC: hir...@irc.freenode.net () ascii ribbon campaign - against html e-mail /\ www.asciiribbon.org - against proprietary attachments ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] i915 native backlight never got merged
On 08/09/2011 12:43 AM, Keith Packard wrote: > On Mon, 8 Aug 2011 22:31:40 +0100, Matthew Garrett > wrote: > >> Yup. There's a small set of systems that appear to provide no firmware >> control mechanism. > > There were a few comments in that old thread about the patch as > submitted; is there an updated version? > The last patch I could find is in linux-next's next-20110726 tag; looks like it disappeared from Matthew's git tree afterwards, and thus not in any subsequent linux-next tags. commit fa7419eee713b989e2c268c7b06ec9a544a2b647 Author: Matthew Garrett Date: Sat Jul 16 23:31:01 2011 +1000 FYI, I'm using that on top of Linux 3.0 and 3.1-rc1 and it still works fine. -- Michel Alexandre Salim µblog: http://identi.ca/hircus http://twitter.com/hircus GPG key ID: 78884778 () ascii ribbon campaign - against html e-mail /\ www.asciiribbon.org - against proprietary attachments ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH] drm/i915: Add quirk to disable SSC on Sony Vaio Y2
Using the new quirk added to support disabling SSC on Lenovo U160
(#36656, commit 435793dfb8aec7b2e19f72d5bce8a22fd0b57839), also register
the Vaio as a special case and disable SSC for it.
This patch fixes #34437 on fdo bugzilla:
https://bugs.freedesktop.org/show_bug.cgi?id=34437
Signed-off-by: Michel Alexandre Salim
---
drivers/gpu/drm/i915/intel_display.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 0f1c799..11eb831 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -7851,6 +7851,9 @@ struct intel_quirk intel_quirks[] = {
/* Lenovo U160 cannot use SSC on LVDS */
{ 0x0046, 0x17aa, 0x3920, quirk_ssc_force_disable },
+
+ /* Sony Vaio Y cannot use SSC on LVDS */
+ { 0x0046, 0x104d, 0x9076, quirk_ssc_force_disable },
};
static void intel_init_quirks(struct drm_device *dev)
--
1.7.6
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm/i915: Add quirk to disable SSC on Sony Vaio Y2
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 07/27/2011 02:03 PM, Michel Alexandre Salim wrote:
> Using the new quirk added to support disabling SSC on Lenovo U160
> (#36656, commit 435793dfb8aec7b2e19f72d5bce8a22fd0b57839), also
> register the Vaio as a special case and disable SSC for it.
>
Apologies; Thunderbird mangled the patch. I'm attaching it to make sure
it arrives intact.
- --
Michel Alexandre Salim
µblog: http://identi.ca/hircus
http://twitter.com/hircus
GPG key ID: 78884778
() ascii ribbon campaign - against html e-mail
/\ www.asciiribbon.org - against proprietary attachments
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk4wAJ4ACgkQNd069XiIR3gN3QCfehYUPl1e46D/0fahZkwwMOyp
i7AAnRhqEZOVfigArWU00dS+tr4HMOvC
=Y243
-END PGP SIGNATURE-
>From dc5ed070efda5e4d3c8aed79f9b3e2c97c489fcb Mon Sep 17 00:00:00 2001
From: Michel Alexandre Salim
Date: Wed, 27 Jul 2011 10:08:25 +0200
Subject: [PATCH] drm/i915: Add quirk to disable SSC on Sony Vaio Y2
Using the new quirk added to support disabling SSC on Lenovo U160
(#36656, commit 435793dfb8aec7b2e19f72d5bce8a22fd0b57839), also register
the Vaio as a special case and disable SSC for it.
This patch fixes #34437 on fdo bugzilla:
https://bugs.freedesktop.org/show_bug.cgi?id=34437
---
drivers/gpu/drm/i915/intel_display.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 0f1c799..11eb831 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -7851,6 +7851,9 @@ struct intel_quirk intel_quirks[] = {
/* Lenovo U160 cannot use SSC on LVDS */
{ 0x0046, 0x17aa, 0x3920, quirk_ssc_force_disable },
+
+ /* Sony Vaio Y cannot use SSC on LVDS */
+ { 0x0046, 0x104d, 0x9076, quirk_ssc_force_disable },
};
static void intel_init_quirks(struct drm_device *dev)
--
1.7.6
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH] drm/i915: Add quirk to disable SSC on Sony Vaio Y2
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Using the new quirk added to support disabling SSC on Lenovo U160
(#36656, commit 435793dfb8aec7b2e19f72d5bce8a22fd0b57839), also register
the Vaio as a special case and disable SSC for it.
This patch fixes #34437 on fdo bugzilla:
https://bugs.freedesktop.org/show_bug.cgi?id=34437
- ---
drivers/gpu/drm/i915/intel_display.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 0f1c799..11eb831 100644
- --- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -7851,6 +7851,9 @@ struct intel_quirk intel_quirks[] = {
/* Lenovo U160 cannot use SSC on LVDS */
{ 0x0046, 0x17aa, 0x3920, quirk_ssc_force_disable },
+
+ /* Sony Vaio Y cannot use SSC on LVDS */
+ { 0x0046, 0x104d, 0x9076, quirk_ssc_force_disable },
};
static void intel_init_quirks(struct drm_device *dev)
- --
1.7.6
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk4v/oUACgkQNd069XiIR3gZFgCfTcZBgVMmPfo5l2/Xxstl82fj
05QAn3lbi1rNHjhbfgwdURV8oLgfQrZK
=ghae
-END PGP SIGNATURE-
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] Status of native backlight patchset?
Hi, Is there an updated version of the native backlight patchset that Matthew posted in November? http://thread.gmane.org/gmane.linux.acpi.devel/48145 On my Sony Vaio Y, Intel Ironlake/Arrandale integrated graphics, I'm having problems setting my backlight level through /sys/class/backlight/acpi_video0 -- all inputs seem to be ignored: https://bugs.freedesktop.org/show_bug.cgi?id=34417 and it looks like the same issue that is being tracked by Ubuntu's Kamal Mostafa, based on Matthew's patchset: https://launchpad.net/~kamalmostafa/+archive/linux-kamal-mjgbacklight I've not been able to find a patchset newer than the one from November, and if I apply patches 1 & 2 (skipping 3 & 4 because they don't apply to i915), I get a kernel with broken KMS. Should I apply #5 as well? I'll wait to see if there's a newer patchset before trying that, though. Matthew, do you have a public kernel git tree I can clone from? Thanks, -- Michel Alexandre Salim () ascii ribbon campaign - against html e-mail /\ www.asciiribbon.org - against proprietary attachments ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] Intel HD (Ironlake) problem on Sony Vaio Y
Apologies for cluttering the list, but I'm wondering if anyone else (on the same or different Ironlake hardware) is affected by these two bugs: [Ironlake LVDS Vaio-Y] Ineffectual backlight brightness controls https://bugs.freedesktop.org/show_bug.cgi?id=34417 [Ironlake LVDS Vaio-Y] blank screen (with backlight) after resuming from suspend or hibernate https://bugs.freedesktop.org/show_bug.cgi?id=34437 They are marked as being closed by one of the recent commits; however, having tested that commit and still experiencing the exact same problem, I reopened them. I've tried both the last drm-intel-fixes commit (from March 7th) as well as the latest 2.6.38 kernel (as shipped by Fedora in its Fedora 15 branch) and, again, with all kernels tested, the same two problems occur. If there's any more debugging information I need to provide, or any patch I can test, please let me know. And anyone else affected by the same problems, feel free to chime in on those two bug reports. Thanks, -- Michel Alexandre Salim () ascii ribbon campaign - against html e-mail /\ www.asciiribbon.org - against proprietary attachments ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
