Re: [Intel-gfx] [CI 1/3] drm/i915/gem: Remove incorrect early dbg print

2020-11-20 Thread Chris Wilson 
Quoting Tvrtko Ursulin (2020-11-20 14:49:16)
> 
> On 20/11/2020 14:03, Chris Wilson wrote:
> > We print out the "logical" context support before we discover whether or
> > not the engines have logical contexts. No one seems to have noticed the
> > error, so the debug message must not be useful to anyone.
> 
> I have, many months ago! :)

No one, except Tvrtko, seems to have noticed...
-Chris
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [CI 1/3] drm/i915/gem: Remove incorrect early dbg print

2020-11-20 Thread Tvrtko Ursulin 



On 20/11/2020 14:03, Chris Wilson wrote:

We print out the "logical" context support before we discover whether or
not the engines have logical contexts. No one seems to have noticed the
error, so the debug message must not be useful to anyone.


I have, many months ago! :)

Regards,

Tvrtko


Signed-off-by: Chris Wilson 
Reviewed-by: Mika Kuoppala 
---
  drivers/gpu/drm/i915/gem/i915_gem_context.c | 3 ---
  1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c 
b/drivers/gpu/drm/i915/gem/i915_gem_context.c
index 4fd38101bb56..a6299da64de4 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
@@ -904,9 +904,6 @@ static void init_contexts(struct i915_gem_contexts *gc)
  void i915_gem_init__contexts(struct drm_i915_private *i915)
  {
init_contexts(&i915->gem.contexts);
-   drm_dbg(&i915->drm, "%s context support initialized\n",
-   DRIVER_CAPS(i915)->has_logical_contexts ?
-   "logical" : "fake");
  }
  
  void i915_gem_driver_release__contexts(struct drm_i915_private *i915)



___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [CI 1/3] drm/i915/gem: Remove incorrect early dbg print

2020-11-20 Thread Chris Wilson 
We print out the "logical" context support before we discover whether or
not the engines have logical contexts. No one seems to have noticed the
error, so the debug message must not be useful to anyone.

Signed-off-by: Chris Wilson 
Reviewed-by: Mika Kuoppala 
---
 drivers/gpu/drm/i915/gem/i915_gem_context.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c 
b/drivers/gpu/drm/i915/gem/i915_gem_context.c
index 4fd38101bb56..a6299da64de4 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
@@ -904,9 +904,6 @@ static void init_contexts(struct i915_gem_contexts *gc)
 void i915_gem_init__contexts(struct drm_i915_private *i915)
 {
init_contexts(&i915->gem.contexts);
-   drm_dbg(&i915->drm, "%s context support initialized\n",
-   DRIVER_CAPS(i915)->has_logical_contexts ?
-   "logical" : "fake");
 }
 
 void i915_gem_driver_release__contexts(struct drm_i915_private *i915)
-- 
2.20.1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx