Re: [Intel-gfx] [PACTH i-g-t v1] lib/drmtest: Change DRIVER_INTEL check to avoid running GEM on non-Intel

[Robert Foss]

Thanks Chris!

On 2016-06-28 05:06 AM, Chris Wilson wrote:

On Mon, Jun 27, 2016 at 01:53:13PM -0400, robert.f...@collabora.com wrote:

From: Robert Foss 

Avoid running gem_quiescent_gpu() on non-Intel hardware.

Signed-off-by: Robert Foss 
---
  lib/drmtest.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/drmtest.c b/lib/drmtest.c
index 632fec4..6427657 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -338,7 +338,7 @@ int drm_open_driver(int chipset)
if (__sync_fetch_and_add(_count, 1))
return fd;

-   if(chipset & DRIVER_INTEL){
+   if(chipset == DRIVER_INTEL){


That doesn't work. You need an is_i915_device()
Took the liberty of making that change and pushing with your credit.
-Chris


___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PACTH i-g-t v1] lib/drmtest: Change DRIVER_INTEL check to avoid running GEM on non-Intel

[Chris Wilson]

On Mon, Jun 27, 2016 at 01:53:13PM -0400, robert.f...@collabora.com wrote:
> From: Robert Foss 
> 
> Avoid running gem_quiescent_gpu() on non-Intel hardware.
> 
> Signed-off-by: Robert Foss 
> ---
>  lib/drmtest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/drmtest.c b/lib/drmtest.c
> index 632fec4..6427657 100644
> --- a/lib/drmtest.c
> +++ b/lib/drmtest.c
> @@ -338,7 +338,7 @@ int drm_open_driver(int chipset)
>   if (__sync_fetch_and_add(_count, 1))
>   return fd;
>  
> - if(chipset & DRIVER_INTEL){
> + if(chipset == DRIVER_INTEL){

That doesn't work. You need an is_i915_device()
Took the liberty of making that change and pushing with your credit.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PACTH i-g-t v1] lib/drmtest: Change DRIVER_INTEL check to avoid running GEM on non-Intel

[robert . foss]

From: Robert Foss 

Avoid running gem_quiescent_gpu() on non-Intel hardware.

Signed-off-by: Robert Foss 
---
 lib/drmtest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/drmtest.c b/lib/drmtest.c
index 632fec4..6427657 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -338,7 +338,7 @@ int drm_open_driver(int chipset)
if (__sync_fetch_and_add(_count, 1))
return fd;
 
-   if(chipset & DRIVER_INTEL){
+   if(chipset == DRIVER_INTEL){
gem_quiescent_gpu(fd);
igt_install_exit_handler(quiescent_gpu_at_exit);
}
-- 
2.7.4

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx