Re: [Intel-gfx] [PATCH] dma-fence: remove fill_driver_data callback

[Eric Anholt]

Daniel Vetter  writes:

> Noticed while I was typing docs. Entirely unused.
>
> v2: Remove reference in @timeline_value_str too. While at it clarify
> why timeline_value_str has a fence parameter - we don't have an
> explicit timeline structure unfortunately.
>
> Cc: Eric Anholt 

Reviewed-by: Eric Anholt 


signature.asc
Description: PGP signature
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] dma-fence: remove fill_driver_data callback

[Daniel Vetter]

Noticed while I was typing docs. Entirely unused.

v2: Remove reference in @timeline_value_str too. While at it clarify
why timeline_value_str has a fence parameter - we don't have an
explicit timeline structure unfortunately.

Cc: Eric Anholt 
Reviewed-by: Christian König  (v1)
Cc: Christian König  (v1)
Signed-off-by: Daniel Vetter 
---
 include/linux/dma-fence.h | 16 +++-
 1 file changed, 3 insertions(+), 13 deletions(-)

diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h
index eb9b05aa5aea..111aefe1c956 100644
--- a/include/linux/dma-fence.h
+++ b/include/linux/dma-fence.h
@@ -217,17 +217,6 @@ struct dma_fence_ops {
 */
void (*release)(struct dma_fence *fence);
 
-   /**
-* @fill_driver_data:
-*
-* Callback to fill in free-form debug info.
-*
-* Returns amount of bytes filled, or negative error on failure.
-*
-* This callback is optional.
-*/
-   int (*fill_driver_data)(struct dma_fence *fence, void *data, int size);
-
/**
 * @fence_value_str:
 *
@@ -242,8 +231,9 @@ struct dma_fence_ops {
 * @timeline_value_str:
 *
 * Fills in the current value of the timeline as a string, like the
-* sequence number. This should match what @fill_driver_data prints for
-* the most recently signalled fence (assuming no delayed signalling).
+* sequence number. Note that the specific fence passed to this function
+* should not matter, drivers should only use it to look up the
+* corresponding timeline structures.
 */
void (*timeline_value_str)(struct dma_fence *fence,
   char *str, int size);
-- 
2.17.0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx