Re: [Intel-gfx] [PATCH] drm/i915/aml: Allow SPT PCH for all AML devices

2019-10-17 Thread Lyude Paul
Hey! work brought this issue to my attention, so I figured I'd help speed
things up and review this :)

Anyway-looks fine to me
Reviewed-by: Lyude Paul 

On Thu, 2019-10-17 at 12:42 -0700, James Ausmus wrote:
> Even the AML devices that behave like CFLs can be paired with an SPT
> PCH. Allow this to happen without blowing up dmesg.
> 
> BSpec: 33665
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112013
> Cc: Quanxian Wang 
> Cc: Rodrigo Vivi 
> Signed-off-by: James Ausmus 
> ---
>  drivers/gpu/drm/i915/intel_pch.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pch.c
> b/drivers/gpu/drm/i915/intel_pch.c
> index 1035d3d46fd8..bb1cb6f12a50 100644
> --- a/drivers/gpu/drm/i915/intel_pch.c
> +++ b/drivers/gpu/drm/i915/intel_pch.c
> @@ -52,7 +52,8 @@ intel_pch_type(const struct drm_i915_private *dev_priv,
> unsigned short id)
>   return PCH_SPT;
>   case INTEL_PCH_SPT_LP_DEVICE_ID_TYPE:
>   DRM_DEBUG_KMS("Found SunrisePoint LP PCH\n");
> - WARN_ON(!IS_SKYLAKE(dev_priv) && !IS_KABYLAKE(dev_priv));
> + WARN_ON(!IS_SKYLAKE(dev_priv) && !IS_KABYLAKE(dev_priv) &&
> + !IS_COFFEELAKE(dev_priv));
>   return PCH_SPT;
>   case INTEL_PCH_KBP_DEVICE_ID_TYPE:
>   DRM_DEBUG_KMS("Found Kaby Lake PCH (KBP)\n");
-- 
Cheers,
Lyude Paul

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915/aml: Allow SPT PCH for all AML devices

2019-10-17 Thread James Ausmus
Even the AML devices that behave like CFLs can be paired with an SPT
PCH. Allow this to happen without blowing up dmesg.

BSpec: 33665

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112013
Cc: Quanxian Wang 
Cc: Rodrigo Vivi 
Signed-off-by: James Ausmus 
---
 drivers/gpu/drm/i915/intel_pch.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_pch.c b/drivers/gpu/drm/i915/intel_pch.c
index 1035d3d46fd8..bb1cb6f12a50 100644
--- a/drivers/gpu/drm/i915/intel_pch.c
+++ b/drivers/gpu/drm/i915/intel_pch.c
@@ -52,7 +52,8 @@ intel_pch_type(const struct drm_i915_private *dev_priv, 
unsigned short id)
return PCH_SPT;
case INTEL_PCH_SPT_LP_DEVICE_ID_TYPE:
DRM_DEBUG_KMS("Found SunrisePoint LP PCH\n");
-   WARN_ON(!IS_SKYLAKE(dev_priv) && !IS_KABYLAKE(dev_priv));
+   WARN_ON(!IS_SKYLAKE(dev_priv) && !IS_KABYLAKE(dev_priv) &&
+   !IS_COFFEELAKE(dev_priv));
return PCH_SPT;
case INTEL_PCH_KBP_DEVICE_ID_TYPE:
DRM_DEBUG_KMS("Found Kaby Lake PCH (KBP)\n");
-- 
2.23.0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx