Re: [Intel-gfx] [PATCH] drm/i915/display: do not use cursor size reduction on MTL
On Mon, Dec 11, 2023 at 02:42:30PM +0100, Andrzej Hajda wrote: > On 24.11.2023 08:53, Andrzej Hajda wrote: > > Cursor size reduction is not supported since MTL. > > > > Signed-off-by: Andrzej Hajda > > --- > > drivers/gpu/drm/i915/display/intel_display_device.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Gently ping. > > CC: maintainers pushed to drm-intel-next. There was probably an hesitation due to CI complains, but from what I could check there's nothing to worry. Thanks, Rodrigo. > > Regards > Andrzej > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h > > b/drivers/gpu/drm/i915/display/intel_display_device.h > > index 4299cc452e0504..6610d73f55e6c4 100644 > > --- a/drivers/gpu/drm/i915/display/intel_display_device.h > > +++ b/drivers/gpu/drm/i915/display/intel_display_device.h > > @@ -36,7 +36,7 @@ struct drm_printer; > > #define HAS_ASYNC_FLIPS(i915) (DISPLAY_VER(i915) >= 5) > > #define HAS_CDCLK_CRAWL(i915) > > (DISPLAY_INFO(i915)->has_cdclk_crawl) > > #define HAS_CDCLK_SQUASH(i915) > > (DISPLAY_INFO(i915)->has_cdclk_squash) > > -#define HAS_CUR_FBC(i915) (!HAS_GMCH(i915) && DISPLAY_VER(i915) > > >= 7) > > +#define HAS_CUR_FBC(i915) (!HAS_GMCH(i915) && > > IS_DISPLAY_VER(i915, 7, 13)) > > #define HAS_D12_PLANE_MINIMIZATION(i915) (IS_ROCKETLAKE(i915) || > > IS_ALDERLAKE_S(i915)) > > #define HAS_DDI(i915) (DISPLAY_INFO(i915)->has_ddi) > > #define HAS_DISPLAY(i915) (DISPLAY_RUNTIME_INFO(i915)->pipe_mask > > != 0) > > > > --- > > base-commit: 94f973d8238e0d8fd1b0234f220783a1e346f60b > > change-id: 20231124-cur_size_reduction-813979149f83 > > > > Best regards, >
Re: [Intel-gfx] [PATCH] drm/i915/display: do not use cursor size reduction on MTL
On 24.11.2023 08:53, Andrzej Hajda wrote: Cursor size reduction is not supported since MTL. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/display/intel_display_device.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Gently ping. CC: maintainers Regards Andrzej diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h index 4299cc452e0504..6610d73f55e6c4 100644 --- a/drivers/gpu/drm/i915/display/intel_display_device.h +++ b/drivers/gpu/drm/i915/display/intel_display_device.h @@ -36,7 +36,7 @@ struct drm_printer; #define HAS_ASYNC_FLIPS(i915) (DISPLAY_VER(i915) >= 5) #define HAS_CDCLK_CRAWL(i915) (DISPLAY_INFO(i915)->has_cdclk_crawl) #define HAS_CDCLK_SQUASH(i915) (DISPLAY_INFO(i915)->has_cdclk_squash) -#define HAS_CUR_FBC(i915) (!HAS_GMCH(i915) && DISPLAY_VER(i915) >= 7) +#define HAS_CUR_FBC(i915) (!HAS_GMCH(i915) && IS_DISPLAY_VER(i915, 7, 13)) #define HAS_D12_PLANE_MINIMIZATION(i915) (IS_ROCKETLAKE(i915) || IS_ALDERLAKE_S(i915)) #define HAS_DDI(i915) (DISPLAY_INFO(i915)->has_ddi) #define HAS_DISPLAY(i915) (DISPLAY_RUNTIME_INFO(i915)->pipe_mask != 0) --- base-commit: 94f973d8238e0d8fd1b0234f220783a1e346f60b change-id: 20231124-cur_size_reduction-813979149f83 Best regards,
Re: [Intel-gfx] [PATCH] drm/i915/display: do not use cursor size reduction on MTL
Hi Andrzej, On Fri, Nov 24, 2023 at 08:53:04AM +0100, Andrzej Hajda wrote: > Cursor size reduction is not supported since MTL. > > Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti Thanks, Andi
[Intel-gfx] [PATCH] drm/i915/display: do not use cursor size reduction on MTL
Cursor size reduction is not supported since MTL. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/display/intel_display_device.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h index 4299cc452e0504..6610d73f55e6c4 100644 --- a/drivers/gpu/drm/i915/display/intel_display_device.h +++ b/drivers/gpu/drm/i915/display/intel_display_device.h @@ -36,7 +36,7 @@ struct drm_printer; #define HAS_ASYNC_FLIPS(i915) (DISPLAY_VER(i915) >= 5) #define HAS_CDCLK_CRAWL(i915) (DISPLAY_INFO(i915)->has_cdclk_crawl) #define HAS_CDCLK_SQUASH(i915) (DISPLAY_INFO(i915)->has_cdclk_squash) -#define HAS_CUR_FBC(i915) (!HAS_GMCH(i915) && DISPLAY_VER(i915) >= 7) +#define HAS_CUR_FBC(i915) (!HAS_GMCH(i915) && IS_DISPLAY_VER(i915, 7, 13)) #define HAS_D12_PLANE_MINIMIZATION(i915) (IS_ROCKETLAKE(i915) || IS_ALDERLAKE_S(i915)) #define HAS_DDI(i915) (DISPLAY_INFO(i915)->has_ddi) #define HAS_DISPLAY(i915) (DISPLAY_RUNTIME_INFO(i915)->pipe_mask != 0) --- base-commit: 94f973d8238e0d8fd1b0234f220783a1e346f60b change-id: 20231124-cur_size_reduction-813979149f83 Best regards, -- Andrzej Hajda
