Re: [Intel-gfx] [PATCH] drm/i915/selftests: Filter out both physical address swizzles

2018-07-10 Thread Chris Wilson 
Quoting Matthew Auld (2018-07-10 09:46:13)
> On 9 July 2018 at 20:49, Chris Wilson  wrote:
> > In our swizzling selftests, we cannot predict the physical address of
> > the target page (at least not simply!) and so skip bit17 swizzles.
> > However, there are two bit17 swizzle modes and we only skipped on, with
> 
> we only skipped one
> 
> > the second being observed on the lab gdg causing the test to fail,
> > as soon as we hit a page with bit17 set it its address.
> 
> "set it its address"?

set in its address

> 
> >
> > Testcase: igt/drv_selftest/live_objects #gdg
> > Signed-off-by: Chris Wilson 
> Reviewed-by: Matthew Auld 

Thanks for the proofreading /o\
-Chris
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Filter out both physical address swizzles

2018-07-10 Thread Matthew Auld 
On 9 July 2018 at 20:49, Chris Wilson  wrote:
> In our swizzling selftests, we cannot predict the physical address of
> the target page (at least not simply!) and so skip bit17 swizzles.
> However, there are two bit17 swizzle modes and we only skipped on, with

we only skipped one

> the second being observed on the lab gdg causing the test to fail,
> as soon as we hit a page with bit17 set it its address.

"set it its address"?

>
> Testcase: igt/drv_selftest/live_objects #gdg
> Signed-off-by: Chris Wilson 
Reviewed-by: Matthew Auld 
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915/selftests: Filter out both physical address swizzles

2018-07-09 Thread Chris Wilson 
In our swizzling selftests, we cannot predict the physical address of
the target page (at least not simply!) and so skip bit17 swizzles.
However, there are two bit17 swizzle modes and we only skipped on, with
the second being observed on the lab gdg causing the test to fail,
as soon as we hit a page with bit17 set it its address.

Testcase: igt/drv_selftest/live_objects #gdg
Signed-off-by: Chris Wilson 
---
 drivers/gpu/drm/i915/selftests/i915_gem_object.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_object.c 
b/drivers/gpu/drm/i915/selftests/i915_gem_object.c
index d77acf4cc439..c69cbd5aed52 100644
--- a/drivers/gpu/drm/i915/selftests/i915_gem_object.c
+++ b/drivers/gpu/drm/i915/selftests/i915_gem_object.c
@@ -375,7 +375,8 @@ static int igt_partial_tiling(void *arg)
}
 
GEM_BUG_ON(tile.swizzle == I915_BIT_6_SWIZZLE_UNKNOWN);
-   if (tile.swizzle == I915_BIT_6_SWIZZLE_9_10_17)
+   if (tile.swizzle == I915_BIT_6_SWIZZLE_9_17 ||
+   tile.swizzle == I915_BIT_6_SWIZZLE_9_10_17)
continue;
 
if (INTEL_GEN(i915) <= 2) {
-- 
2.18.0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx