Re: [Intel-gfx] [PATCH] drm/i915/selftests: Flush any i915_active callback work as well

2019-10-24 Thread Mika Kuoppala
Chris Wilson  writes:

> Make trebly sure that all possible callbacks and their delayed brethren
> are complete before asserting that the i915_active should be idle after
> flushing all barriers.
>
> Signed-off-by: Chris Wilson 

Reviewed-by: Mika Kuoppala 

> ---
>  drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c 
> b/drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c
> index 9fb5d30c43bb..768f032e6578 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c
> @@ -55,6 +55,7 @@ static void pulse_unlock_wait(struct pulse *p)
>  {
>   mutex_lock(&p->active.mutex);
>   mutex_unlock(&p->active.mutex);
> + flush_work(&p->active.work);
>  }
>  
>  static int __live_idle_pulse(struct intel_engine_cs *engine,
> -- 
> 2.24.0.rc0
>
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915/selftests: Flush any i915_active callback work as well

2019-10-23 Thread Chris Wilson
Make trebly sure that all possible callbacks and their delayed brethren
are complete before asserting that the i915_active should be idle after
flushing all barriers.

Signed-off-by: Chris Wilson 
---
 drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c 
b/drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c
index 9fb5d30c43bb..768f032e6578 100644
--- a/drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c
+++ b/drivers/gpu/drm/i915/gt/selftest_engine_heartbeat.c
@@ -55,6 +55,7 @@ static void pulse_unlock_wait(struct pulse *p)
 {
mutex_lock(&p->active.mutex);
mutex_unlock(&p->active.mutex);
+   flush_work(&p->active.work);
 }
 
 static int __live_idle_pulse(struct intel_engine_cs *engine,
-- 
2.24.0.rc0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx