Re: [Intel-gfx] [PATCH] drm/i915/tgl: Add second TGL PCH ID

2019-11-06 Thread James Ausmus 
On Wed, Nov 06, 2019 at 04:25:27PM -0800, Lucas De Marchi wrote:
> On Tue, Nov 05, 2019 at 05:13:29PM -0800, Jose Souza wrote:
> >On Tue, 2019-11-05 at 16:55 -0800, James Ausmus wrote:
> >> Another TGP ID has shown up, so let's add it to avoid South Display
> >> breakage on systems that have this ID.
> >>
> >
> >Reviewed-by: José Roberto de Souza 
> 
> and pushed, thanks

Thanks Lucas!

-James

> 
> Lucas De Marchi
> 
> >
> >> Cc: Lucas De Marchi 
> >> Cc: José Roberto de Souza 
> >> Signed-off-by: James Ausmus 
> >> ---
> >>  drivers/gpu/drm/i915/intel_pch.c | 1 +
> >>  drivers/gpu/drm/i915/intel_pch.h | 1 +
> >>  2 files changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/i915/intel_pch.c
> >> b/drivers/gpu/drm/i915/intel_pch.c
> >> index 000ba43e2c02..fd22355b9a96 100644
> >> --- a/drivers/gpu/drm/i915/intel_pch.c
> >> +++ b/drivers/gpu/drm/i915/intel_pch.c
> >> @@ -85,6 +85,7 @@ intel_pch_type(const struct drm_i915_private
> >> *dev_priv, unsigned short id)
> >>WARN_ON(!IS_ELKHARTLAKE(dev_priv));
> >>return PCH_MCC;
> >>case INTEL_PCH_TGP_DEVICE_ID_TYPE:
> >> +  case INTEL_PCH_TGP2_DEVICE_ID_TYPE:
> >>DRM_DEBUG_KMS("Found Tiger Lake LP PCH\n");
> >>WARN_ON(!IS_TIGERLAKE(dev_priv));
> >>return PCH_TGP;
> >> diff --git a/drivers/gpu/drm/i915/intel_pch.h
> >> b/drivers/gpu/drm/i915/intel_pch.h
> >> index 1115c6a0522c..52d145dcdb15 100644
> >> --- a/drivers/gpu/drm/i915/intel_pch.h
> >> +++ b/drivers/gpu/drm/i915/intel_pch.h
> >> @@ -47,6 +47,7 @@ enum intel_pch {
> >>  #define INTEL_PCH_ICP_DEVICE_ID_TYPE  0x3480
> >>  #define INTEL_PCH_MCC_DEVICE_ID_TYPE  0x4B00
> >>  #define INTEL_PCH_TGP_DEVICE_ID_TYPE  0xA080
> >> +#define INTEL_PCH_TGP2_DEVICE_ID_TYPE 0x4380
> >>  #define INTEL_PCH_JSP_DEVICE_ID_TYPE  0x4D80
> >>  #define INTEL_PCH_JSP2_DEVICE_ID_TYPE 0x3880
> >>  #define INTEL_PCH_P2X_DEVICE_ID_TYPE  0x7100
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Add second TGL PCH ID

2019-11-06 Thread Lucas De Marchi 

On Tue, Nov 05, 2019 at 05:13:29PM -0800, Jose Souza wrote:

On Tue, 2019-11-05 at 16:55 -0800, James Ausmus wrote:

Another TGP ID has shown up, so let's add it to avoid South Display
breakage on systems that have this ID.



Reviewed-by: José Roberto de Souza 


and pushed, thanks

Lucas De Marchi




Cc: Lucas De Marchi 
Cc: José Roberto de Souza 
Signed-off-by: James Ausmus 
---
 drivers/gpu/drm/i915/intel_pch.c | 1 +
 drivers/gpu/drm/i915/intel_pch.h | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_pch.c
b/drivers/gpu/drm/i915/intel_pch.c
index 000ba43e2c02..fd22355b9a96 100644
--- a/drivers/gpu/drm/i915/intel_pch.c
+++ b/drivers/gpu/drm/i915/intel_pch.c
@@ -85,6 +85,7 @@ intel_pch_type(const struct drm_i915_private
*dev_priv, unsigned short id)
WARN_ON(!IS_ELKHARTLAKE(dev_priv));
return PCH_MCC;
case INTEL_PCH_TGP_DEVICE_ID_TYPE:
+   case INTEL_PCH_TGP2_DEVICE_ID_TYPE:
DRM_DEBUG_KMS("Found Tiger Lake LP PCH\n");
WARN_ON(!IS_TIGERLAKE(dev_priv));
return PCH_TGP;
diff --git a/drivers/gpu/drm/i915/intel_pch.h
b/drivers/gpu/drm/i915/intel_pch.h
index 1115c6a0522c..52d145dcdb15 100644
--- a/drivers/gpu/drm/i915/intel_pch.h
+++ b/drivers/gpu/drm/i915/intel_pch.h
@@ -47,6 +47,7 @@ enum intel_pch {
 #define INTEL_PCH_ICP_DEVICE_ID_TYPE   0x3480
 #define INTEL_PCH_MCC_DEVICE_ID_TYPE   0x4B00
 #define INTEL_PCH_TGP_DEVICE_ID_TYPE   0xA080
+#define INTEL_PCH_TGP2_DEVICE_ID_TYPE  0x4380
 #define INTEL_PCH_JSP_DEVICE_ID_TYPE   0x4D80
 #define INTEL_PCH_JSP2_DEVICE_ID_TYPE  0x3880
 #define INTEL_PCH_P2X_DEVICE_ID_TYPE   0x7100

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915/tgl: Add second TGL PCH ID

2019-11-05 Thread Souza, Jose 
On Tue, 2019-11-05 at 16:55 -0800, James Ausmus wrote:
> Another TGP ID has shown up, so let's add it to avoid South Display
> breakage on systems that have this ID.
> 

Reviewed-by: José Roberto de Souza 

> Cc: Lucas De Marchi 
> Cc: José Roberto de Souza 
> Signed-off-by: James Ausmus 
> ---
>  drivers/gpu/drm/i915/intel_pch.c | 1 +
>  drivers/gpu/drm/i915/intel_pch.h | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pch.c
> b/drivers/gpu/drm/i915/intel_pch.c
> index 000ba43e2c02..fd22355b9a96 100644
> --- a/drivers/gpu/drm/i915/intel_pch.c
> +++ b/drivers/gpu/drm/i915/intel_pch.c
> @@ -85,6 +85,7 @@ intel_pch_type(const struct drm_i915_private
> *dev_priv, unsigned short id)
>   WARN_ON(!IS_ELKHARTLAKE(dev_priv));
>   return PCH_MCC;
>   case INTEL_PCH_TGP_DEVICE_ID_TYPE:
> + case INTEL_PCH_TGP2_DEVICE_ID_TYPE:
>   DRM_DEBUG_KMS("Found Tiger Lake LP PCH\n");
>   WARN_ON(!IS_TIGERLAKE(dev_priv));
>   return PCH_TGP;
> diff --git a/drivers/gpu/drm/i915/intel_pch.h
> b/drivers/gpu/drm/i915/intel_pch.h
> index 1115c6a0522c..52d145dcdb15 100644
> --- a/drivers/gpu/drm/i915/intel_pch.h
> +++ b/drivers/gpu/drm/i915/intel_pch.h
> @@ -47,6 +47,7 @@ enum intel_pch {
>  #define INTEL_PCH_ICP_DEVICE_ID_TYPE 0x3480
>  #define INTEL_PCH_MCC_DEVICE_ID_TYPE 0x4B00
>  #define INTEL_PCH_TGP_DEVICE_ID_TYPE 0xA080
> +#define INTEL_PCH_TGP2_DEVICE_ID_TYPE0x4380
>  #define INTEL_PCH_JSP_DEVICE_ID_TYPE 0x4D80
>  #define INTEL_PCH_JSP2_DEVICE_ID_TYPE0x3880
>  #define INTEL_PCH_P2X_DEVICE_ID_TYPE 0x7100
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915/tgl: Add second TGL PCH ID

2019-11-05 Thread James Ausmus 
Another TGP ID has shown up, so let's add it to avoid South Display
breakage on systems that have this ID.

Cc: Lucas De Marchi 
Cc: José Roberto de Souza 
Signed-off-by: James Ausmus 
---
 drivers/gpu/drm/i915/intel_pch.c | 1 +
 drivers/gpu/drm/i915/intel_pch.h | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_pch.c b/drivers/gpu/drm/i915/intel_pch.c
index 000ba43e2c02..fd22355b9a96 100644
--- a/drivers/gpu/drm/i915/intel_pch.c
+++ b/drivers/gpu/drm/i915/intel_pch.c
@@ -85,6 +85,7 @@ intel_pch_type(const struct drm_i915_private *dev_priv, 
unsigned short id)
WARN_ON(!IS_ELKHARTLAKE(dev_priv));
return PCH_MCC;
case INTEL_PCH_TGP_DEVICE_ID_TYPE:
+   case INTEL_PCH_TGP2_DEVICE_ID_TYPE:
DRM_DEBUG_KMS("Found Tiger Lake LP PCH\n");
WARN_ON(!IS_TIGERLAKE(dev_priv));
return PCH_TGP;
diff --git a/drivers/gpu/drm/i915/intel_pch.h b/drivers/gpu/drm/i915/intel_pch.h
index 1115c6a0522c..52d145dcdb15 100644
--- a/drivers/gpu/drm/i915/intel_pch.h
+++ b/drivers/gpu/drm/i915/intel_pch.h
@@ -47,6 +47,7 @@ enum intel_pch {
 #define INTEL_PCH_ICP_DEVICE_ID_TYPE   0x3480
 #define INTEL_PCH_MCC_DEVICE_ID_TYPE   0x4B00
 #define INTEL_PCH_TGP_DEVICE_ID_TYPE   0xA080
+#define INTEL_PCH_TGP2_DEVICE_ID_TYPE  0x4380
 #define INTEL_PCH_JSP_DEVICE_ID_TYPE   0x4D80
 #define INTEL_PCH_JSP2_DEVICE_ID_TYPE  0x3880
 #define INTEL_PCH_P2X_DEVICE_ID_TYPE   0x7100
-- 
2.23.0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx