Re: [Intel-gfx] [PATCH] drm/i915: Fix build failure with debug and extra logging enabled

[Tvrtko Ursulin]

On 15/11/2022 14:39, Janusz Krzysztofik wrote:

A comma is missing, fix it.

Signed-off-by: Janusz Krzysztofik 
---
  drivers/gpu/drm/i915/i915_vma.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
index 3b969d679c1e2..947fde68e5f53 100644
--- a/drivers/gpu/drm/i915/i915_vma.c
+++ b/drivers/gpu/drm/i915/i915_vma.c
@@ -73,7 +73,7 @@ static void vma_print_allocator(struct i915_vma *vma, const 
char *reason)
char buf[512];
  
  	if (!vma->node.stack) {

-   drm_dbg(_i915(vma->obj->base.dev)->drm
+   drm_dbg(_i915(vma->obj->base.dev)->drm,
"vma.node [%08llx + %08llx] %s: unknown owner\n",
vma->node.start, vma->node.size, reason);
return;


Yep, thanks, however already sent this morning: 
https://patchwork.freedesktop.org/series/110906/. Just waiting for CI to 
give it a green light, which is a bit pointless, nevertheless it's the 
process.


Regards,

Tvrtko

[Intel-gfx] [PATCH] drm/i915: Fix build failure with debug and extra logging enabled

[Janusz Krzysztofik]

A comma is missing, fix it.

Signed-off-by: Janusz Krzysztofik 
---
 drivers/gpu/drm/i915/i915_vma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
index 3b969d679c1e2..947fde68e5f53 100644
--- a/drivers/gpu/drm/i915/i915_vma.c
+++ b/drivers/gpu/drm/i915/i915_vma.c
@@ -73,7 +73,7 @@ static void vma_print_allocator(struct i915_vma *vma, const 
char *reason)
char buf[512];
 
if (!vma->node.stack) {
-   drm_dbg(_i915(vma->obj->base.dev)->drm
+   drm_dbg(_i915(vma->obj->base.dev)->drm,
"vma.node [%08llx + %08llx] %s: unknown owner\n",
vma->node.start, vma->node.size, reason);
return;
-- 
2.25.1

[Intel-gfx] [PATCH] drm/i915: Fix build failure

[Lauri Kasanen]

ERROR: __build_bug_on_failed [drivers/gpu/drm/i915/i915.ko] undefined!

Originally reported at 
http://www.gossamer-threads.com/lists/linux/kernel/1631803
FDO bug #62775

This needs to be backported to both 3.7 and 3.8 stable trees. Doesn't apply 
straight,
but it's a quick change.

Signed-off-by: Lauri Kasanen c...@gmx.com
---
 drivers/gpu/drm/i915/i915_gem_execbuffer.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c 
b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
index 3b11ab0..9a48e1a 100644
--- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
@@ -57,7 +57,7 @@ eb_create(struct drm_i915_gem_execbuffer2 *args)
if (eb == NULL) {
int size = args-buffer_count;
int count = PAGE_SIZE / sizeof(struct hlist_head) / 2;
-   BUILD_BUG_ON(!is_power_of_2(PAGE_SIZE / sizeof(struct 
hlist_head)));
+   BUILD_BUG_ON_NOT_POWER_OF_2(PAGE_SIZE / sizeof(struct 
hlist_head));
while (count  2*size)
count = 1;
eb = kzalloc(count*sizeof(struct hlist_head) +
-- 
1.7.2.1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx