Re: [Intel-gfx] [PATCH] drm/i915: Fix cxsr_latency_table reorg

2016-10-17 Thread Joonas Lahtinen 
On pe, 2016-10-14 at 14:55 +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin 
> 
> I have re-ordered some struct members in patch:
> 
>   commit 44a655cae3043453f9dd8076538712d52e2e0ce4
> >   Author: Tvrtko Ursulin 
>   Date:   Thu Oct 13 11:09:23 2016 +0100
> 
>   drm/i915: Shrink cxsr_latency_table
> 
> but that particular one is not initialized with named
> initializers which broke it.
> 

Wrong commit message above this line?

Patch itself is;

Reviewed-by: Joonas Lahtinen 

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915: Fix cxsr_latency_table reorg

2016-10-14 Thread Tvrtko Ursulin 
From: Tvrtko Ursulin 

I have re-ordered some struct members in patch:

  commit 44a655cae3043453f9dd8076538712d52e2e0ce4
  Author: Tvrtko Ursulin 
  Date:   Thu Oct 13 11:09:23 2016 +0100

  drm/i915: Shrink cxsr_latency_table

but that particular one is not initialized with named
initializers which broke it.

Move the bitfields back at the beginning. Space saving
is still there.

Signed-off-by: Tvrtko Ursulin 
Fixes: 44a655cae304 ("drm/i915: Shrink cxsr_latency_table")
Cc: Joonas Lahtinen 
Cc: Jani Nikula 
---
 drivers/gpu/drm/i915/intel_drv.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index a885b2ac9618..5bc115496355 100644
--- a/drivers/gpu/drm/i915/intel_drv.h
+++ b/drivers/gpu/drm/i915/intel_drv.h
@@ -807,14 +807,14 @@ struct intel_watermark_params {
 };
 
 struct cxsr_latency {
+   bool is_desktop : 1;
+   bool is_ddr3 : 1;
u16 fsb_freq;
u16 mem_freq;
u16 display_sr;
u16 display_hpll_disable;
u16 cursor_sr;
u16 cursor_hpll_disable;
-   bool is_desktop : 1;
-   bool is_ddr3 : 1;
 };
 
 #define to_intel_atomic_state(x) container_of(x, struct intel_atomic_state, 
base)
-- 
2.7.4

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx