Re: [Intel-gfx] [PATCH] drm/i915: Return the correct score in i915_ppat_get()

2017-09-21 Thread Wang, Zhi A 
Please drop this one.

-Original Message-
From: Wang, Zhi A 
Sent: Thursday, September 21, 2017 8:27 PM
To: intel-gfx@lists.freedesktop.org; intel-gvt-...@lists.freedesktop.org
Cc: joonas.lahti...@linux.intel.com; ch...@chris-wilson.co.uk; 
zhen...@linux.intel.com; Wang, Zhi A ; Widawsky, Benjamin 
; Vivi, Rodrigo 
Subject: [PATCH] drm/i915: Return the correct score in i915_ppat_get()

The cache attribute of the required entry has to be the same with the existing 
value. After this requirement is met, the futher comparison should be 
performed. After this fix, the refined test case can pass.

v2:

- Refine the tittle and comments. (Rodrigo)

Fixes: 4395890a4855 ("drm/i915: Introduce private PAT management")
Cc: Chris Wilson 
Cc: Ben Widawsky 
Cc: Rodrigo Vivi 
Cc: Joonas Lahtinen 
Signed-off-by: Zhi Wang 
Reviewed-by: Joonas Lahtinen 
---
 drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c 
b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 5923b51..636ad7d 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -2965,7 +2965,7 @@ static unsigned int bdw_private_pat_match(u8 src, u8 dst)
};
 
/* Cache attribute has to be matched. */
-   if (GEN8_PPAT_GET_CA(src) == GEN8_PPAT_GET_CA(dst))
+   if (GEN8_PPAT_GET_CA(src) != GEN8_PPAT_GET_CA(dst))
return 0;
 
score |= CA_MATCH;
--
2.7.4

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915: Return the correct score in i915_ppat_get()

2017-09-21 Thread Zhi Wang 
The cache attribute of the required entry has to be the same with the
existing value. After this requirement is met, the futher comparison
should be performed. After this fix, the refined test case can pass.

v2:

- Refine the tittle and comments. (Rodrigo)

Fixes: 4395890a4855 ("drm/i915: Introduce private PAT management")
Cc: Chris Wilson 
Cc: Ben Widawsky 
Cc: Rodrigo Vivi 
Cc: Joonas Lahtinen 
Signed-off-by: Zhi Wang 
Reviewed-by: Joonas Lahtinen 
---
 drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c 
b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 5923b51..636ad7d 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -2965,7 +2965,7 @@ static unsigned int bdw_private_pat_match(u8 src, u8 dst)
};
 
/* Cache attribute has to be matched. */
-   if (GEN8_PPAT_GET_CA(src) == GEN8_PPAT_GET_CA(dst))
+   if (GEN8_PPAT_GET_CA(src) != GEN8_PPAT_GET_CA(dst))
return 0;
 
score |= CA_MATCH;
-- 
2.7.4

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Return the correct score in i915_ppat_get()

2017-09-18 Thread Wang, Zhi A 
Sorry for the trouble. :(

-Original Message-
From: intel-gvt-dev [mailto:intel-gvt-dev-boun...@lists.freedesktop.org] On 
Behalf Of Chris Wilson
Sent: Monday, September 18, 2017 6:03 PM
To: Wang, Zhi A ; intel-gfx@lists.freedesktop.org; 
intel-gvt-...@lists.freedesktop.org
Cc: Vivi, Rodrigo ; joonas.lahti...@linux.intel.com; 
Wang, Zhi A ; zhen...@linux.intel.com; Widawsky, Benjamin 

Subject: Re: [PATCH] drm/i915: Return the correct score in i915_ppat_get()

Quoting Zhi Wang (2017-09-18 14:36:34)
> The cache attribute of the required entry has to be the same with the 
> existing value. After this requirement is met, the futher comparison 
> should be performed. After this fix, the refined test case can pass.
> 
> v2:
> 
> - Refine the tittle and comments. (Rodrigo)
> 
> Fixes: 4395890a4855 ("drm/i915: Introduce private PAT management")
> Cc: Chris Wilson 
> Cc: Ben Widawsky 
> Cc: Rodrigo Vivi 
> Cc: Joonas Lahtinen 
> Signed-off-by: Zhi Wang 
> Reviewed-by: Joonas Lahtinen 

And pushed, thanks for the followup.
-Chris
___
intel-gvt-dev mailing list
intel-gvt-...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Return the correct score in i915_ppat_get()

2017-09-18 Thread Chris Wilson 
Quoting Zhi Wang (2017-09-18 14:36:34)
> The cache attribute of the required entry has to be the same with the
> existing value. After this requirement is met, the futher comparison
> should be performed. After this fix, the refined test case can pass.
> 
> v2:
> 
> - Refine the tittle and comments. (Rodrigo)
> 
> Fixes: 4395890a4855 ("drm/i915: Introduce private PAT management")
> Cc: Chris Wilson 
> Cc: Ben Widawsky 
> Cc: Rodrigo Vivi 
> Cc: Joonas Lahtinen 
> Signed-off-by: Zhi Wang 
> Reviewed-by: Joonas Lahtinen 

And pushed, thanks for the followup.
-Chris
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915: Return the correct score in i915_ppat_get()

2017-09-18 Thread Zhi Wang 
The cache attribute of the required entry has to be the same with the
existing value. After this requirement is met, the futher comparison
should be performed. After this fix, the refined test case can pass.

v2:

- Refine the tittle and comments. (Rodrigo)

Fixes: 4395890a4855 ("drm/i915: Introduce private PAT management")
Cc: Chris Wilson 
Cc: Ben Widawsky 
Cc: Rodrigo Vivi 
Cc: Joonas Lahtinen 
Signed-off-by: Zhi Wang 
Reviewed-by: Joonas Lahtinen 
---
 drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c 
b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 5923b51..636ad7d 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -2965,7 +2965,7 @@ static unsigned int bdw_private_pat_match(u8 src, u8 dst)
};
 
/* Cache attribute has to be matched. */
-   if (GEN8_PPAT_GET_CA(src) == GEN8_PPAT_GET_CA(dst))
+   if (GEN8_PPAT_GET_CA(src) != GEN8_PPAT_GET_CA(dst))
return 0;
 
score |= CA_MATCH;
-- 
2.7.4

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx