Re: [Intel-gfx] [PATCH] drm/i915: Use user, not driver, DRM_DEBUG for 2 context ioctls

[Joonas Lahtinen]

On ma, 2016-11-21 at 11:31 +, Chris Wilson wrote:
> For the context ioctls, we record a debug, but we use the
> DRM_DEBUG_DRIVER for what is clearly a user, not driver, action. Use
> DRM_DEBUG instead.
> 
> Signed-off-by: Chris Wilson 

You could phrase the commit message to be more clear; "For user
actions, we should use DRM_DEBUG. So ..."

Reviewed-by: Joonas Lahtinen 

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915: Use user, not driver, DRM_DEBUG for 2 context ioctls

[Chris Wilson]

For the context ioctls, we record a debug, but we use the
DRM_DEBUG_DRIVER for what is clearly a user, not driver, action. Use
DRM_DEBUG instead.

Signed-off-by: Chris Wilson 
---
 drivers/gpu/drm/i915/i915_gem_context.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gem_context.c 
b/drivers/gpu/drm/i915/i915_gem_context.c
index 1f74ab266f6b..f93fd94a04ec 100644
--- a/drivers/gpu/drm/i915/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/i915_gem_context.c
@@ -1027,7 +1027,7 @@ int i915_gem_context_create_ioctl(struct drm_device *dev, 
void *data,
return PTR_ERR(ctx);
 
args->ctx_id = ctx->user_handle;
-   DRM_DEBUG_DRIVER("HW context %d created\n", args->ctx_id);
+   DRM_DEBUG("HW context %d created\n", args->ctx_id);
 
return 0;
 }
@@ -1060,7 +1060,7 @@ int i915_gem_context_destroy_ioctl(struct drm_device 
*dev, void *data,
context_close(ctx);
mutex_unlock(>struct_mutex);
 
-   DRM_DEBUG_DRIVER("HW context %d destroyed\n", args->ctx_id);
+   DRM_DEBUG("HW context %d destroyed\n", args->ctx_id);
return 0;
 }
 
-- 
2.10.2

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx