[Intel-gfx] [PATCH] drm/i915: dvo_ch7xxx: fix vsync polarity setting
This fixes a typo which set the wrong vsync and possibly also hsync polarity for any modes with positive vsync polarity. Signed-off-by: Imre Deak imre.d...@intel.com --- drivers/gpu/drm/i915/dvo_ch7xxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/dvo_ch7xxx.c b/drivers/gpu/drm/i915/dvo_ch7xxx.c index 757e0fa..af42e94 100644 --- a/drivers/gpu/drm/i915/dvo_ch7xxx.c +++ b/drivers/gpu/drm/i915/dvo_ch7xxx.c @@ -307,7 +307,7 @@ static void ch7xxx_mode_set(struct intel_dvo_device *dvo, idf |= CH7xxx_IDF_HSP; if (mode-flags DRM_MODE_FLAG_PVSYNC) - idf |= CH7xxx_IDF_HSP; + idf |= CH7xxx_IDF_VSP; ch7xxx_writeb(dvo, CH7xxx_IDF, idf); } -- 1.8.3.2 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm/i915: dvo_ch7xxx: fix vsync polarity setting
On Thu, Jul 25, 2013 at 04:22:31PM +0300, Imre Deak wrote: This fixes a typo which set the wrong vsync and possibly also hsync polarity for any modes with positive vsync polarity. Note that this typo exists in the very first import of KMS: commit 79e539453b34e35f39299a899d263b0a1f1670bd Author: Jesse Barnes jbar...@virtuousgeek.org Date: Fri Nov 7 14:24:08 2008 -0800 DRM: i915: add mode setting support Signed-off-by: Imre Deak imre.d...@intel.com Cc: Jesse Barnes jbar...@virtuousgeek.org Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm/i915: dvo_ch7xxx: fix vsync polarity setting
On Thu, Jul 25, 2013 at 02:45:05PM +0100, Chris Wilson wrote: On Thu, Jul 25, 2013 at 04:22:31PM +0300, Imre Deak wrote: This fixes a typo which set the wrong vsync and possibly also hsync polarity for any modes with positive vsync polarity. Note that this typo exists in the very first import of KMS: commit 79e539453b34e35f39299a899d263b0a1f1670bd Author: Jesse Barnes jbar...@virtuousgeek.org Date: Fri Nov 7 14:24:08 2008 -0800 DRM: i915: add mode setting support Signed-off-by: Imre Deak imre.d...@intel.com Cc: Jesse Barnes jbar...@virtuousgeek.org Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
