Re: [Intel-gfx] [PATCH] drm/i915: fix broadwell EU computation

2019-08-29 Thread Sasha Levin 

On Thu, Aug 29, 2019 at 12:22:27AM +0300, Lionel Landwerlin wrote:

On 29/08/2019 00:02, Rodrigo Vivi wrote:

From: Lionel Landwerlin 

commit 6a67a20366f894c172734f28c5646bdbe48a46e3 upstream.

subslice_mask is an array indexed by slice, not subslice.

Signed-off-by: Lionel Landwerlin 
Fixes: 8cc7669355136f ("drm/i915: store all subslice masks")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108712
Reviewed-by: Chris Wilson 
Reviewed-by: Tvrtko Ursulin 
Link: 
https://patchwork.freedesktop.org/patch/msgid/20181112123931.2815-1-lionel.g.landwer...@intel.com
(cherry picked from commit 63ac3328f0d1d37f286e397b14d9596ed09d7ca5)
Signed-off-by: Joonas Lahtinen 
Cc:  # 4.17



Rodrigo pointed out I forgot the Cc: tag which is why this didn't make 
it to stable.


The same bug showed up on a CentOS kernel : 
https://github.com/intel/compute-runtime/issues/200


I just queued the upstream patch for 4.19, thanks!

--
Thanks,
Sasha
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: fix broadwell EU computation

2019-08-28 Thread Lionel Landwerlin 

On 29/08/2019 00:02, Rodrigo Vivi wrote:

From: Lionel Landwerlin 

commit 6a67a20366f894c172734f28c5646bdbe48a46e3 upstream.

subslice_mask is an array indexed by slice, not subslice.

Signed-off-by: Lionel Landwerlin 
Fixes: 8cc7669355136f ("drm/i915: store all subslice masks")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108712
Reviewed-by: Chris Wilson 
Reviewed-by: Tvrtko Ursulin 
Link: 
https://patchwork.freedesktop.org/patch/msgid/20181112123931.2815-1-lionel.g.landwer...@intel.com
(cherry picked from commit 63ac3328f0d1d37f286e397b14d9596ed09d7ca5)
Signed-off-by: Joonas Lahtinen 
Cc:  # 4.17



Rodrigo pointed out I forgot the Cc: tag which is why this didn't make 
it to stable.


The same bug showed up on a CentOS kernel : 
https://github.com/intel/compute-runtime/issues/200


My bad... :(


Thanks for resending!


-Lionel



Signed-off-by: Rodrigo Vivi 
---
  drivers/gpu/drm/i915/intel_device_info.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_device_info.c 
b/drivers/gpu/drm/i915/intel_device_info.c
index 0ef0c6448d53..01fa98299bae 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -474,7 +474,7 @@ static void broadwell_sseu_info_init(struct 
drm_i915_private *dev_priv)
u8 eu_disabled_mask;
u32 n_disabled;
  
-			if (!(sseu->subslice_mask[ss] & BIT(ss)))

+   if (!(sseu->subslice_mask[s] & BIT(ss)))
/* skip disabled subslice */
continue;
  



___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915: fix broadwell EU computation

2019-08-28 Thread Rodrigo Vivi 
From: Lionel Landwerlin 

commit 6a67a20366f894c172734f28c5646bdbe48a46e3 upstream.

subslice_mask is an array indexed by slice, not subslice.

Signed-off-by: Lionel Landwerlin 
Fixes: 8cc7669355136f ("drm/i915: store all subslice masks")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108712
Reviewed-by: Chris Wilson 
Reviewed-by: Tvrtko Ursulin 
Link: 
https://patchwork.freedesktop.org/patch/msgid/20181112123931.2815-1-lionel.g.landwer...@intel.com
(cherry picked from commit 63ac3328f0d1d37f286e397b14d9596ed09d7ca5)
Signed-off-by: Joonas Lahtinen 
Cc:  # 4.17
Signed-off-by: Rodrigo Vivi 
---
 drivers/gpu/drm/i915/intel_device_info.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_device_info.c 
b/drivers/gpu/drm/i915/intel_device_info.c
index 0ef0c6448d53..01fa98299bae 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -474,7 +474,7 @@ static void broadwell_sseu_info_init(struct 
drm_i915_private *dev_priv)
u8 eu_disabled_mask;
u32 n_disabled;
 
-   if (!(sseu->subslice_mask[ss] & BIT(ss)))
+   if (!(sseu->subslice_mask[s] & BIT(ss)))
/* skip disabled subslice */
continue;
 
-- 
2.20.1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: fix broadwell EU computation

2018-11-12 Thread Lionel Landwerlin 

On 12/11/2018 15:57, Tvrtko Ursulin wrote:


On 12/11/2018 12:39, Lionel Landwerlin wrote:

subslice_mask is an array indexed by slice, not subslice.

Signed-off-by: Lionel Landwerlin 
Fixes: 8cc7669355136f ("drm/i915: store all subslice masks")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108712
---
  drivers/gpu/drm/i915/intel_device_info.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_device_info.c 
b/drivers/gpu/drm/i915/intel_device_info.c

index 89ed3a84a4fa..ceecb5bd5226 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -474,7 +474,7 @@ static void broadwell_sseu_info_init(struct 
drm_i915_private *dev_priv)

  u8 eu_disabled_mask;
  u32 n_disabled;
  -    if (!(sseu->subslice_mask[ss] & BIT(ss)))
+    if (!(sseu->subslice_mask[s] & BIT(ss)))
  /* skip disabled subslice */
  continue;


Reviewed-by: Tvrtko Ursulin 

Regards,

Tvrtko


Thanks all, pushed.


-

Lionel

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: fix broadwell EU computation

2018-11-12 Thread Tvrtko Ursulin 


On 12/11/2018 12:39, Lionel Landwerlin wrote:

subslice_mask is an array indexed by slice, not subslice.

Signed-off-by: Lionel Landwerlin 
Fixes: 8cc7669355136f ("drm/i915: store all subslice masks")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108712
---
  drivers/gpu/drm/i915/intel_device_info.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_device_info.c 
b/drivers/gpu/drm/i915/intel_device_info.c
index 89ed3a84a4fa..ceecb5bd5226 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -474,7 +474,7 @@ static void broadwell_sseu_info_init(struct 
drm_i915_private *dev_priv)
u8 eu_disabled_mask;
u32 n_disabled;
  
-			if (!(sseu->subslice_mask[ss] & BIT(ss)))

+   if (!(sseu->subslice_mask[s] & BIT(ss)))
/* skip disabled subslice */
continue;
  


Reviewed-by: Tvrtko Ursulin 

Regards,

Tvrtko
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: fix broadwell EU computation

2018-11-12 Thread Chris Wilson 
Quoting Lionel Landwerlin (2018-11-12 12:39:31)
> subslice_mask is an array indexed by slice, not subslice.
> 
> Signed-off-by: Lionel Landwerlin 
> Fixes: 8cc7669355136f ("drm/i915: store all subslice masks")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108712
> ---
>  drivers/gpu/drm/i915/intel_device_info.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_device_info.c 
> b/drivers/gpu/drm/i915/intel_device_info.c
> index 89ed3a84a4fa..ceecb5bd5226 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.c
> +++ b/drivers/gpu/drm/i915/intel_device_info.c
> @@ -474,7 +474,7 @@ static void broadwell_sseu_info_init(struct 
> drm_i915_private *dev_priv)
> u8 eu_disabled_mask;
> u32 n_disabled;
>  
> -   if (!(sseu->subslice_mask[ss] & BIT(ss)))
> +   if (!(sseu->subslice_mask[s] & BIT(ss)))

Tallies up with the other users.
Reviewed-by: Chris Wilson 
-Chris
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915: fix broadwell EU computation

2018-11-12 Thread Lionel Landwerlin 
subslice_mask is an array indexed by slice, not subslice.

Signed-off-by: Lionel Landwerlin 
Fixes: 8cc7669355136f ("drm/i915: store all subslice masks")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108712
---
 drivers/gpu/drm/i915/intel_device_info.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_device_info.c 
b/drivers/gpu/drm/i915/intel_device_info.c
index 89ed3a84a4fa..ceecb5bd5226 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -474,7 +474,7 @@ static void broadwell_sseu_info_init(struct 
drm_i915_private *dev_priv)
u8 eu_disabled_mask;
u32 n_disabled;
 
-   if (!(sseu->subslice_mask[ss] & BIT(ss)))
+   if (!(sseu->subslice_mask[s] & BIT(ss)))
/* skip disabled subslice */
continue;
 
-- 
2.19.1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx