Re: [Intel-gfx] [PATCH] drm/i915: make dbuf configurations const
On Wed, 19 Feb 2020, Matt Roper wrote: > On Wed, Feb 19, 2020 at 05:45:42PM +0200, Jani Nikula wrote: >> Ensure const data goes to rodata. >> >> Fixes: ff2cd8635e41 ("drm/i915: Correctly map DBUF slices to pipes") >> Cc: Matt Roper >> Cc: Stanislav Lisovskiy >> Cc: Ville Syrjälä >> Signed-off-by: Jani Nikula > > Reviewed-by: Matt Roper Thanks for the review, pushed to dinq. BR, Jani. > >> --- >> drivers/gpu/drm/i915/intel_pm.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/intel_pm.c >> b/drivers/gpu/drm/i915/intel_pm.c >> index ffac0b862ca5..9b74c37e4fa4 100644 >> --- a/drivers/gpu/drm/i915/intel_pm.c >> +++ b/drivers/gpu/drm/i915/intel_pm.c >> @@ -4178,7 +4178,7 @@ struct dbuf_slice_conf_entry { >> * as is from BSpec itself - that way it is at least easier >> * to compare, change and check. >> */ >> -static struct dbuf_slice_conf_entry icl_allowed_dbufs[] = >> +static const struct dbuf_slice_conf_entry icl_allowed_dbufs[] = >> /* Autogenerated with igt/tools/intel_dbuf_map tool: */ >> { >> { >> @@ -4240,7 +4240,7 @@ static struct dbuf_slice_conf_entry >> icl_allowed_dbufs[] = >> * as is from BSpec itself - that way it is at least easier >> * to compare, change and check. >> */ >> -static struct dbuf_slice_conf_entry tgl_allowed_dbufs[] = >> +static const struct dbuf_slice_conf_entry tgl_allowed_dbufs[] = >> /* Autogenerated with igt/tools/intel_dbuf_map tool: */ >> { >> { >> -- >> 2.20.1 >> -- Jani Nikula, Intel Open Source Graphics Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm/i915: make dbuf configurations const
On Wed, Feb 19, 2020 at 05:45:42PM +0200, Jani Nikula wrote: > Ensure const data goes to rodata. > > Fixes: ff2cd8635e41 ("drm/i915: Correctly map DBUF slices to pipes") > Cc: Matt Roper > Cc: Stanislav Lisovskiy > Cc: Ville Syrjälä > Signed-off-by: Jani Nikula Reviewed-by: Matt Roper > --- > drivers/gpu/drm/i915/intel_pm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > index ffac0b862ca5..9b74c37e4fa4 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -4178,7 +4178,7 @@ struct dbuf_slice_conf_entry { > * as is from BSpec itself - that way it is at least easier > * to compare, change and check. > */ > -static struct dbuf_slice_conf_entry icl_allowed_dbufs[] = > +static const struct dbuf_slice_conf_entry icl_allowed_dbufs[] = > /* Autogenerated with igt/tools/intel_dbuf_map tool: */ > { > { > @@ -4240,7 +4240,7 @@ static struct dbuf_slice_conf_entry icl_allowed_dbufs[] > = > * as is from BSpec itself - that way it is at least easier > * to compare, change and check. > */ > -static struct dbuf_slice_conf_entry tgl_allowed_dbufs[] = > +static const struct dbuf_slice_conf_entry tgl_allowed_dbufs[] = > /* Autogenerated with igt/tools/intel_dbuf_map tool: */ > { > { > -- > 2.20.1 > -- Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation (916) 356-2795 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH] drm/i915: make dbuf configurations const
Ensure const data goes to rodata. Fixes: ff2cd8635e41 ("drm/i915: Correctly map DBUF slices to pipes") Cc: Matt Roper Cc: Stanislav Lisovskiy Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_pm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index ffac0b862ca5..9b74c37e4fa4 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/gpu/drm/i915/intel_pm.c @@ -4178,7 +4178,7 @@ struct dbuf_slice_conf_entry { * as is from BSpec itself - that way it is at least easier * to compare, change and check. */ -static struct dbuf_slice_conf_entry icl_allowed_dbufs[] = +static const struct dbuf_slice_conf_entry icl_allowed_dbufs[] = /* Autogenerated with igt/tools/intel_dbuf_map tool: */ { { @@ -4240,7 +4240,7 @@ static struct dbuf_slice_conf_entry icl_allowed_dbufs[] = * as is from BSpec itself - that way it is at least easier * to compare, change and check. */ -static struct dbuf_slice_conf_entry tgl_allowed_dbufs[] = +static const struct dbuf_slice_conf_entry tgl_allowed_dbufs[] = /* Autogenerated with igt/tools/intel_dbuf_map tool: */ { { -- 2.20.1 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx