Re: [Intel-gfx] [PATCH] drm: Print device information again in debugfs
On Thu, 13 Oct 2016, Daniel Vetterwrote: > I was a bit over-eager in my cleanup in > > commit 95c081c17f284de50eaca60d4d55643a64d39019 > Author: Daniel Vetter > Date: Tue Jun 21 10:54:12 2016 +0200 > > drm: Move master pointer from drm_minor to drm_device > > Noticed by Chris Wilson. > > Fixes: 95c081c17f28 ("drm: Move master pointer from drm_minor to drm_device") Cc: # v4.8+ > Cc: Chris Wilson > Cc: Chris Wilson > Cc: Daniel Vetter > Cc: Emil Velikov > Cc: Julia Lawall > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_info.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/drm_info.c b/drivers/gpu/drm/drm_info.c > index 1df2d33d0b40..ffb2ab389d1d 100644 > --- a/drivers/gpu/drm/drm_info.c > +++ b/drivers/gpu/drm/drm_info.c > @@ -54,9 +54,6 @@ int drm_name_info(struct seq_file *m, void *data) > > mutex_lock(>master_mutex); > master = dev->master; > - if (!master) > - goto out_unlock; > - > seq_printf(m, "%s", dev->driver->name); > if (dev->dev) > seq_printf(m, " dev=%s", dev_name(dev->dev)); > @@ -65,7 +62,6 @@ int drm_name_info(struct seq_file *m, void *data) > if (dev->unique) > seq_printf(m, " unique=%s", dev->unique); > seq_printf(m, "\n"); > -out_unlock: > mutex_unlock(>master_mutex); > > return 0; -- Jani Nikula, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm: Print device information again in debugfs
On 13 October 2016 at 15:13, Daniel Vetterwrote: > I was a bit over-eager in my cleanup in > > commit 95c081c17f284de50eaca60d4d55643a64d39019 > Author: Daniel Vetter > Date: Tue Jun 21 10:54:12 2016 +0200 > > drm: Move master pointer from drm_minor to drm_device > > Noticed by Chris Wilson. > > Fixes: 95c081c17f28 ("drm: Move master pointer from drm_minor to drm_device") > Cc: Chris Wilson > Cc: Chris Wilson > Cc: Daniel Vetter > Cc: Emil Velikov > Cc: Julia Lawall > Signed-off-by: Daniel Vetter Oops ;-) Worth updating/dropping the "Called when ..." comment above the function ? How about the rest of the file ? Either way, Reviewed-by: Emil Velikov -Emil ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm: Print device information again in debugfs
On Thu, Oct 13, 2016 at 04:13:44PM +0200, Daniel Vetter wrote: > I was a bit over-eager in my cleanup in > > commit 95c081c17f284de50eaca60d4d55643a64d39019 > Author: Daniel Vetter> Date: Tue Jun 21 10:54:12 2016 +0200 > > drm: Move master pointer from drm_minor to drm_device > > Noticed by Chris Wilson. > > Fixes: 95c081c17f28 ("drm: Move master pointer from drm_minor to drm_device") > Cc: Chris Wilson > Cc: Chris Wilson > Cc: Daniel Vetter > Cc: Emil Velikov > Cc: Julia Lawall > Signed-off-by: Daniel Vetter Tested-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm: Print device information again in debugfs
On Thu, Oct 13, 2016 at 10:13 AM, Daniel Vetterwrote: > I was a bit over-eager in my cleanup in > > commit 95c081c17f284de50eaca60d4d55643a64d39019 > Author: Daniel Vetter > Date: Tue Jun 21 10:54:12 2016 +0200 > > drm: Move master pointer from drm_minor to drm_device > > Noticed by Chris Wilson. > > Fixes: 95c081c17f28 ("drm: Move master pointer from drm_minor to drm_device") > Cc: Chris Wilson > Cc: Chris Wilson > Cc: Daniel Vetter > Cc: Emil Velikov > Cc: Julia Lawall > Signed-off-by: Daniel Vetter Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/drm_info.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/drm_info.c b/drivers/gpu/drm/drm_info.c > index 1df2d33d0b40..ffb2ab389d1d 100644 > --- a/drivers/gpu/drm/drm_info.c > +++ b/drivers/gpu/drm/drm_info.c > @@ -54,9 +54,6 @@ int drm_name_info(struct seq_file *m, void *data) > > mutex_lock(>master_mutex); > master = dev->master; > - if (!master) > - goto out_unlock; > - > seq_printf(m, "%s", dev->driver->name); > if (dev->dev) > seq_printf(m, " dev=%s", dev_name(dev->dev)); > @@ -65,7 +62,6 @@ int drm_name_info(struct seq_file *m, void *data) > if (dev->unique) > seq_printf(m, " unique=%s", dev->unique); > seq_printf(m, "\n"); > -out_unlock: > mutex_unlock(>master_mutex); > > return 0; > -- > 2.9.3 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH] drm: Print device information again in debugfs
I was a bit over-eager in my cleanup in commit 95c081c17f284de50eaca60d4d55643a64d39019 Author: Daniel VetterDate: Tue Jun 21 10:54:12 2016 +0200 drm: Move master pointer from drm_minor to drm_device Noticed by Chris Wilson. Fixes: 95c081c17f28 ("drm: Move master pointer from drm_minor to drm_device") Cc: Chris Wilson Cc: Chris Wilson Cc: Daniel Vetter Cc: Emil Velikov Cc: Julia Lawall Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_info.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/drm_info.c b/drivers/gpu/drm/drm_info.c index 1df2d33d0b40..ffb2ab389d1d 100644 --- a/drivers/gpu/drm/drm_info.c +++ b/drivers/gpu/drm/drm_info.c @@ -54,9 +54,6 @@ int drm_name_info(struct seq_file *m, void *data) mutex_lock(>master_mutex); master = dev->master; - if (!master) - goto out_unlock; - seq_printf(m, "%s", dev->driver->name); if (dev->dev) seq_printf(m, " dev=%s", dev_name(dev->dev)); @@ -65,7 +62,6 @@ int drm_name_info(struct seq_file *m, void *data) if (dev->unique) seq_printf(m, " unique=%s", dev->unique); seq_printf(m, "\n"); -out_unlock: mutex_unlock(>master_mutex); return 0; -- 2.9.3 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx