Re: [Intel-gfx] [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly

2016-05-09 Thread Lee Jones 
On Fri, 22 Apr 2016, ville.syrj...@linux.intel.com wrote:

> From: Ville Syrjälä 
> 
> GPIO lookup tables are supposed to be zero terminated. Let's do that
> and avoid accidentally walking off the end.
> 
> Cc: Shobhit Kumar 
> Cc: Samuel Ortiz 
> Cc: Linus Walleij 
> Cc: Alexandre Courbot 
> Cc: Thierry Reding 
> Cc: Lee Jones 
> Cc: sta...@vger.kernel.org
> Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel 
> Control as GPIO signal")
> Signed-off-by: Ville Syrjälä 
> ---
>  drivers/mfd/intel_soc_pmic_core.c | 1 +
>  1 file changed, 1 insertion(+)

Applied with Linus' and Daniel's Ack.

> diff --git a/drivers/mfd/intel_soc_pmic_core.c 
> b/drivers/mfd/intel_soc_pmic_core.c
> index d9e15cf7c6c8..12d6ebb4ae5d 100644
> --- a/drivers/mfd/intel_soc_pmic_core.c
> +++ b/drivers/mfd/intel_soc_pmic_core.c
> @@ -35,6 +35,7 @@ static struct gpiod_lookup_table panel_gpio_table = {
>   .table = {
>   /* Panel EN/DISABLE */
>   GPIO_LOOKUP("gpio_crystalcove", 94, "panel", GPIO_ACTIVE_HIGH),
> + { },
>   },
>  };
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly

2016-05-09 Thread Lee Jones 
On Mon, 09 May 2016, Daniel Vetter wrote:

> On Wed, May 04, 2016 at 08:32:17AM +0100, Lee Jones wrote:
> > On Mon, 02 May 2016, Daniel Vetter wrote:
> > 
> > > On Fri, Apr 29, 2016 at 11:31:44AM +0200, Linus Walleij wrote:
> > > > On Fri, Apr 22, 2016 at 9:38 PM,   wrote:
> > > > 
> > > > > From: Ville Syrjälä 
> > > > >
> > > > > GPIO lookup tables are supposed to be zero terminated. Let's do that
> > > > > and avoid accidentally walking off the end.
> > > > >
> > > > > Cc: Shobhit Kumar 
> > > > > Cc: Samuel Ortiz 
> > > > > Cc: Linus Walleij 
> > > > > Cc: Alexandre Courbot 
> > > > > Cc: Thierry Reding 
> > > > > Cc: Lee Jones 
> > > > > Cc: sta...@vger.kernel.org
> > > > > Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for 
> > > > > Panel Control as GPIO signal")
> > > > > Signed-off-by: Ville Syrjälä 
> > > > 
> > > > Acked-by: Linus Walleij 
> > > 
> > > Applied to drm-intel trees, thanks for patch, reviews
> > 
> > Do what now?  How can you apply a patch for a subsystem you don't have
> > responsibility for?  This is bound to cause merge conflicts.
> 
> Oh crap, I thought Linus' ack was for the mfd stuff and didn't bother
> double-checking with MAINTAINTERS. Should I throw it out again and you'll
> pick it up, or ok as such?

Yes please.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly

2016-05-09 Thread Daniel Vetter 
On Wed, May 04, 2016 at 08:32:17AM +0100, Lee Jones wrote:
> On Mon, 02 May 2016, Daniel Vetter wrote:
> 
> > On Fri, Apr 29, 2016 at 11:31:44AM +0200, Linus Walleij wrote:
> > > On Fri, Apr 22, 2016 at 9:38 PM,   wrote:
> > > 
> > > > From: Ville Syrjälä 
> > > >
> > > > GPIO lookup tables are supposed to be zero terminated. Let's do that
> > > > and avoid accidentally walking off the end.
> > > >
> > > > Cc: Shobhit Kumar 
> > > > Cc: Samuel Ortiz 
> > > > Cc: Linus Walleij 
> > > > Cc: Alexandre Courbot 
> > > > Cc: Thierry Reding 
> > > > Cc: Lee Jones 
> > > > Cc: sta...@vger.kernel.org
> > > > Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for 
> > > > Panel Control as GPIO signal")
> > > > Signed-off-by: Ville Syrjälä 
> > > 
> > > Acked-by: Linus Walleij 
> > 
> > Applied to drm-intel trees, thanks for patch, reviews
> 
> Do what now?  How can you apply a patch for a subsystem you don't have
> responsibility for?  This is bound to cause merge conflicts.

Oh crap, I thought Linus' ack was for the mfd stuff and didn't bother
double-checking with MAINTAINTERS. Should I throw it out again and you'll
pick it up, or ok as such?

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly

2016-05-04 Thread Lee Jones 
On Mon, 02 May 2016, Daniel Vetter wrote:

> On Fri, Apr 29, 2016 at 11:31:44AM +0200, Linus Walleij wrote:
> > On Fri, Apr 22, 2016 at 9:38 PM,   wrote:
> > 
> > > From: Ville Syrjälä 
> > >
> > > GPIO lookup tables are supposed to be zero terminated. Let's do that
> > > and avoid accidentally walking off the end.
> > >
> > > Cc: Shobhit Kumar 
> > > Cc: Samuel Ortiz 
> > > Cc: Linus Walleij 
> > > Cc: Alexandre Courbot 
> > > Cc: Thierry Reding 
> > > Cc: Lee Jones 
> > > Cc: sta...@vger.kernel.org
> > > Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for 
> > > Panel Control as GPIO signal")
> > > Signed-off-by: Ville Syrjälä 
> > 
> > Acked-by: Linus Walleij 
> 
> Applied to drm-intel trees, thanks for patch, reviews

Do what now?  How can you apply a patch for a subsystem you don't have
responsibility for?  This is bound to cause merge conflicts.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly

2016-05-02 Thread Daniel Vetter 
On Fri, Apr 29, 2016 at 11:31:44AM +0200, Linus Walleij wrote:
> On Fri, Apr 22, 2016 at 9:38 PM,   wrote:
> 
> > From: Ville Syrjälä 
> >
> > GPIO lookup tables are supposed to be zero terminated. Let's do that
> > and avoid accidentally walking off the end.
> >
> > Cc: Shobhit Kumar 
> > Cc: Samuel Ortiz 
> > Cc: Linus Walleij 
> > Cc: Alexandre Courbot 
> > Cc: Thierry Reding 
> > Cc: Lee Jones 
> > Cc: sta...@vger.kernel.org
> > Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel 
> > Control as GPIO signal")
> > Signed-off-by: Ville Syrjälä 
> 
> Acked-by: Linus Walleij 

Applied to drm-intel trees, thanks for patch, reviews
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly

2016-04-29 Thread Linus Walleij 
On Fri, Apr 22, 2016 at 9:38 PM,   wrote:

> From: Ville Syrjälä 
>
> GPIO lookup tables are supposed to be zero terminated. Let's do that
> and avoid accidentally walking off the end.
>
> Cc: Shobhit Kumar 
> Cc: Samuel Ortiz 
> Cc: Linus Walleij 
> Cc: Alexandre Courbot 
> Cc: Thierry Reding 
> Cc: Lee Jones 
> Cc: sta...@vger.kernel.org
> Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel 
> Control as GPIO signal")
> Signed-off-by: Ville Syrjälä 

Acked-by: Linus Walleij 

Yours,
Linus Walleij
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly

2016-04-25 Thread Thierry Reding 
On Fri, Apr 22, 2016 at 10:38:55PM +0300, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä 
> 
> GPIO lookup tables are supposed to be zero terminated. Let's do that
> and avoid accidentally walking off the end.
> 
> Cc: Shobhit Kumar 
> Cc: Samuel Ortiz 
> Cc: Linus Walleij 
> Cc: Alexandre Courbot 
> Cc: Thierry Reding 
> Cc: Lee Jones 
> Cc: sta...@vger.kernel.org
> Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel 
> Control as GPIO signal")
> Signed-off-by: Ville Syrjälä 
> ---
>  drivers/mfd/intel_soc_pmic_core.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Thierry Reding 


signature.asc
Description: PGP signature
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly

2016-04-25 Thread Jani Nikula 
On Fri, 22 Apr 2016, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä 
>
> GPIO lookup tables are supposed to be zero terminated. Let's do that
> and avoid accidentally walking off the end.
>
> Cc: Shobhit Kumar 
> Cc: Samuel Ortiz 
> Cc: Linus Walleij 
> Cc: Alexandre Courbot 
> Cc: Thierry Reding 
> Cc: Lee Jones 
> Cc: sta...@vger.kernel.org
> Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel 
> Control as GPIO signal")
> Signed-off-by: Ville Syrjälä 

Reviewed-by: Jani Nikula 

> ---
>  drivers/mfd/intel_soc_pmic_core.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/intel_soc_pmic_core.c 
> b/drivers/mfd/intel_soc_pmic_core.c
> index d9e15cf7c6c8..12d6ebb4ae5d 100644
> --- a/drivers/mfd/intel_soc_pmic_core.c
> +++ b/drivers/mfd/intel_soc_pmic_core.c
> @@ -35,6 +35,7 @@ static struct gpiod_lookup_table panel_gpio_table = {
>   .table = {
>   /* Panel EN/DISABLE */
>   GPIO_LOOKUP("gpio_crystalcove", 94, "panel", GPIO_ACTIVE_HIGH),
> + { },
>   },
>  };

-- 
Jani Nikula, Intel Open Source Technology Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly

2016-04-22 Thread ville . syrjala 
From: Ville Syrjälä 

GPIO lookup tables are supposed to be zero terminated. Let's do that
and avoid accidentally walking off the end.

Cc: Shobhit Kumar 
Cc: Samuel Ortiz 
Cc: Linus Walleij 
Cc: Alexandre Courbot 
Cc: Thierry Reding 
Cc: Lee Jones 
Cc: sta...@vger.kernel.org
Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel 
Control as GPIO signal")
Signed-off-by: Ville Syrjälä 
---
 drivers/mfd/intel_soc_pmic_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/intel_soc_pmic_core.c 
b/drivers/mfd/intel_soc_pmic_core.c
index d9e15cf7c6c8..12d6ebb4ae5d 100644
--- a/drivers/mfd/intel_soc_pmic_core.c
+++ b/drivers/mfd/intel_soc_pmic_core.c
@@ -35,6 +35,7 @@ static struct gpiod_lookup_table panel_gpio_table = {
.table = {
/* Panel EN/DISABLE */
GPIO_LOOKUP("gpio_crystalcove", 94, "panel", GPIO_ACTIVE_HIGH),
+   { },
},
 };
 
-- 
2.7.4

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx