Re: [Intel-gfx] [PATCH 0/2] Introduce Glamor to UXA framework.

2011-11-17 Thread Chris Wilson
On Thu, 17 Nov 2011 10:55:39 +0800, Zhigang Gong 
zhigang.g...@linux.intel.com wrote:
 Now glamor was extracted from the xorg and be a separate library. Please
 checkout glamor at : git://people.freedesktop.org/~gongzg/glamor.
 This library implements two modules glamor and glamor_egl which are
 required for intel video driver to enable glamor.

Hmm, I did install the glamor library. A
/usr/lib/xorg/modules/libglamor.so is installed but the ddx is looking
for a glamor_egl module.

Ah, looks to be due to the
  checking for EGL... no
  checking for EGL... yes
in glamor.  How very confusing. ;-)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [PATCH 0/2] Introduce Glamor to UXA framework.

2011-11-17 Thread Zhigang Gong
 -Original Message-
 From: Chris Wilson [mailto:ch...@chris-wilson.co.uk]
 Sent: Thursday, November 17, 2011 5:20 PM
 To: Zhigang Gong; intel-gfx@lists.freedesktop.org
 Subject: RE: [PATCH 0/2] Introduce Glamor to UXA framework.
 
 On Thu, 17 Nov 2011 10:55:39 +0800, Zhigang Gong
 zhigang.g...@linux.intel.com wrote:
  Now glamor was extracted from the xorg and be a separate library.
  Please checkout glamor at :
 git://people.freedesktop.org/~gongzg/glamor.
  This library implements two modules glamor and glamor_egl which are
  required for intel video driver to enable glamor.
 
 Hmm, I did install the glamor library. A
/usr/lib/xorg/modules/libglamor.so
 is installed but the ddx is looking for a glamor_egl module.
 
 Ah, looks to be due to the
   checking for EGL... no
   checking for EGL... yes
 in glamor.  How very confusing. ;-)
I think I know the reason, there is a typo error in glamor's configure.ac
which doesn't
Check the required packages correctly. Please pull the latest glamor master.
One of the 
two above checks should be checking for GBM. I guess your mesa hasn't been
built with
gbm enabled. Then glamor will not build glamor_egl which depends on that.

Another thing need to pay attention is that when you build xserver, you need
to disable
glx.

Sorry for the confusing.

 -Chris
 
 --
 Chris Wilson, Intel Open Source Technology Centre

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [PATCH 0/2] Introduce Glamor to UXA framework.

2011-11-17 Thread Chris Wilson
On Thu, 17 Nov 2011 18:49:49 +0800, Zhigang Gong 
zhigang.g...@linux.intel.com wrote:
  -Original Message-
  From: Chris Wilson [mailto:ch...@chris-wilson.co.uk]
  Sent: Thursday, November 17, 2011 5:20 PM
  To: Zhigang Gong; intel-gfx@lists.freedesktop.org
  Subject: RE: [PATCH 0/2] Introduce Glamor to UXA framework.
  
  On Thu, 17 Nov 2011 10:55:39 +0800, Zhigang Gong
  zhigang.g...@linux.intel.com wrote:
   Now glamor was extracted from the xorg and be a separate library.
   Please checkout glamor at :
  git://people.freedesktop.org/~gongzg/glamor.
   This library implements two modules glamor and glamor_egl which are
   required for intel video driver to enable glamor.
  
  Hmm, I did install the glamor library. A
 /usr/lib/xorg/modules/libglamor.so
  is installed but the ddx is looking for a glamor_egl module.
  
  Ah, looks to be due to the
checking for EGL... no
checking for EGL... yes
  in glamor.  How very confusing. ;-)
 I think I know the reason, there is a typo error in glamor's configure.ac
 which doesn't
 Check the required packages correctly. Please pull the latest glamor master.
 One of the 
 two above checks should be checking for GBM. I guess your mesa hasn't been
 built with
 gbm enabled. Then glamor will not build glamor_egl which depends on that.

It was actually mesa insisting on only building egl_platform=drm and the
pre-requisite egl_dri2 if and only if libxcb-dri2 was installed. Seems a
bit strange for something that is supposed to be used on an X-less
system.
 
 Another thing need to pay attention is that when you build xserver, you need
 to disable
 glx.

Rebuild the xserver... Oh well, that rules out testing by simply replacing
distro drivers. I'm having a lot of fun with building glamor as it is
missing or including headers in the wrong order and deciding that XID is
8 bytes when the server was compiled with a 4 byte XID. Fun. And the
usual problems with incomplete framebuffers, but hopefully that is just
the glx confusion.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [PATCH 0/2] Introduce Glamor to UXA framework.

2011-11-17 Thread Zhigang Gong


 -Original Message-
 From: Chris Wilson [mailto:ch...@chris-wilson.co.uk]
 Sent: Thursday, November 17, 2011 6:57 PM
 To: Zhigang Gong; intel-gfx@lists.freedesktop.org
 Subject: RE: [PATCH 0/2] Introduce Glamor to UXA framework.
 
 On Thu, 17 Nov 2011 18:49:49 +0800, Zhigang Gong
 zhigang.g...@linux.intel.com wrote:
   -Original Message-
   From: Chris Wilson [mailto:ch...@chris-wilson.co.uk]
   Sent: Thursday, November 17, 2011 5:20 PM
   To: Zhigang Gong; intel-gfx@lists.freedesktop.org
   Subject: RE: [PATCH 0/2] Introduce Glamor to UXA framework.
  
   On Thu, 17 Nov 2011 10:55:39 +0800, Zhigang Gong
   zhigang.g...@linux.intel.com wrote:
Now glamor was extracted from the xorg and be a separate library.
Please checkout glamor at :
   git://people.freedesktop.org/~gongzg/glamor.
This library implements two modules glamor and glamor_egl which
are required for intel video driver to enable glamor.
  
   Hmm, I did install the glamor library. A
  /usr/lib/xorg/modules/libglamor.so
   is installed but the ddx is looking for a glamor_egl module.
  
   Ah, looks to be due to the
 checking for EGL... no
 checking for EGL... yes
   in glamor.  How very confusing. ;-)
  I think I know the reason, there is a typo error in glamor's
  configure.ac which doesn't Check the required packages correctly.
  Please pull the latest glamor master.
  One of the
  two above checks should be checking for GBM. I guess your mesa hasn't
  been built with gbm enabled. Then glamor will not build glamor_egl
  which depends on that.
 
 It was actually mesa insisting on only building egl_platform=drm and the
 pre-requisite egl_dri2 if and only if libxcb-dri2 was installed. Seems a
bit
 strange for something that is supposed to be used on an X-less system.
 
  Another thing need to pay attention is that when you build xserver,
  you need to disable glx.
 
 Rebuild the xserver... Oh well, that rules out testing by simply replacing
 distro drivers.

One of the todo items is to fully support glx including direct and indirect
. 
The major problem is that Xserver's glx code has the same glapi symbols 
which conflicts with standard mesa's glapi's implementations. It's easy to
rename the xserver side glapi's symbol to other names to avoid this
conflicts, 
but that will break indirect GLX in xserver side. I still don't have a
perfect 
solution to solve this problem. Do you or anyone in this list have any
suggestion
 to solve this confliction?

 I'm having a lot of fun with building glamor as it is missing or
 including headers in the wrong order and deciding that XID is
 8 bytes when the server was compiled with a 4 byte XID. Fun. 
Will discuss these problem with you through IRC. 
 And the
 usual problems with incomplete framebuffers, but hopefully that is just
the
 glx confusion.
That must be caused by glapi symbol confliction.

Thanks.

- Zhigang

 -Chris
 
 --
 Chris Wilson, Intel Open Source Technology Centre

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [PATCH 0/2] Introduce Glamor to UXA framework.

2011-11-16 Thread Chris Wilson
On Wed, 16 Nov 2011 15:04:35 +0800, Zhigang Gong zhigang.g...@linux.intel.com 
wrote:
 This patchset initially enable glamor with UXA. And two functions
 ,fill_spans and poly_fill_rects, go to the glamor path. I tested it
 with render check, and it works fine.

I split your patches slightly differently and pushed them. I could
only verify that it didn't impact UXA without the glamor_egl module
available. Do you have a patch for testing?
-Chrid

-- 
Chris Wilson, Intel Open Source Technology Centre
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


Re: [Intel-gfx] [PATCH 0/2] Introduce Glamor to UXA framework.

2011-11-16 Thread Zhigang Gong
 -Original Message-
 From: Chris Wilson [mailto:ch...@chris-wilson.co.uk]
 Sent: Thursday, November 17, 2011 9:14 AM
 To: Zhigang Gong; intel-gfx@lists.freedesktop.org
 Cc: zhigang.g...@linux.intel.com
 Subject: Re: [PATCH 0/2] Introduce Glamor to UXA framework.
 
 On Wed, 16 Nov 2011 15:04:35 +0800, Zhigang Gong
 zhigang.g...@linux.intel.com wrote:
  This patchset initially enable glamor with UXA. And two functions
  ,fill_spans and poly_fill_rects, go to the glamor path. I tested it
  with render check, and it works fine.
 
 I split your patches slightly differently and pushed them.

I just checked out the master branch, and have a simple test, everything
seems
ok. Thanks.

 I could only verify
 that it didn't impact UXA without the glamor_egl module available. Do you
 have a patch for testing?

Now glamor was extracted from the xorg and be a separate library. Please
checkout glamor at : git://people.freedesktop.org/~gongzg/glamor.
This library implements two modules glamor and glamor_egl which are
required for intel video driver to enable glamor.

 -Chris
 
 --
 Chris Wilson, Intel Open Source Technology Centre

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] [PATCH 0/2] Introduce Glamor to UXA framework.

2011-11-15 Thread Zhigang Gong
After discussion with Chris yesterday, I reworked the previous
glamor branch and concentrate the patchset to two patches. The 
first patch is the same as the previous. The second patch merges 
all the others into one, and made some slightly change. One major 
change is that I decide to extent the finish_access to handle the 
flushing operations by check the access type. And also add some
missed glamor flushing operations.

This patchset initially enable glamor with UXA. And two functions
,fill_spans and poly_fill_rects, go to the glamor path. I tested it
with render check, and it works fine.

One of the remaining issues is the vsync'ed copy. I discussed with
Chris, and already got a solution. Will do that when I enable
the copy_area to glamor path.
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx