Re: [Intel-gfx] [PATCH 0/2] drm/i915/gvt: clean up makefile
On Wed, Apr 13, 2022 at 07:04:54PM +0300, Jani Nikula wrote: > > v6: > > - Remove the reference of intel_gvt_device_info.(Christoph) > > - Refine the save_mmio() function. (Christoph) > > > > which don't belong in the commit log. It might be worth to fix that > > before sending a pull request. > > I'll just note, without any value judgement, that it is customary in the > drm land to do so. They are fine here even if they're not accepted in > other subsystems. I'm not going to insist one way or the other. Ok. Seems very odd to me, but I guess I don't spend enough time in drm land to know this particular quirk.
Re: [Intel-gfx] [PATCH 0/2] drm/i915/gvt: clean up makefile
On Wed, 13 Apr 2022, Christoph Hellwig wrote: > On Wed, Apr 13, 2022 at 03:25:37PM +0300, Jani Nikula wrote: >> This is [1] rebased on gvt-next. (Which means it won't build on CI.) > > Btw, now that I found that gvt-next branch: > > Zhi, your commits still have per-commit changelog like: > > v6: > - Remove the reference of intel_gvt_device_info.(Christoph) > - Refine the save_mmio() function. (Christoph) > > which don't belong in the commit log. It might be worth to fix that > before sending a pull request. I'll just note, without any value judgement, that it is customary in the drm land to do so. They are fine here even if they're not accepted in other subsystems. I'm not going to insist one way or the other. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center
Re: [Intel-gfx] [PATCH 0/2] drm/i915/gvt: clean up makefile
On Wed, Apr 13, 2022 at 03:25:37PM +0300, Jani Nikula wrote: > This is [1] rebased on gvt-next. (Which means it won't build on CI.) Btw, now that I found that gvt-next branch: Zhi, your commits still have per-commit changelog like: v6: - Remove the reference of intel_gvt_device_info.(Christoph) - Refine the save_mmio() function. (Christoph) which don't belong in the commit log. It might be worth to fix that before sending a pull request.
Re: [Intel-gfx] [PATCH 0/2] drm/i915/gvt: clean up makefile
On 4/13/22 12:25 PM, Jani Nikula wrote: > This is [1] rebased on gvt-next. (Which means it won't build on CI.) > > BR, > Jani. > > > [1] https://patchwork.freedesktop.org/series/102003/ > > > Cc: Zhi Wang > Cc: Christoph Hellwig > > > Jani Nikula (2): > drm/i915/gvt: fix trace TRACE_INCLUDE_PATH > drm/i915/gvt: better align the Makefile with i915 Makefile > > drivers/gpu/drm/i915/Makefile | 6 +++--- > drivers/gpu/drm/i915/gvt/Makefile | 30 +++--- > drivers/gpu/drm/i915/gvt/trace.h | 2 +- > 3 files changed, 27 insertions(+), 11 deletions(-) > Thanks so much for the patch. Reviewed-by: Zhi Wang
[Intel-gfx] [PATCH 0/2] drm/i915/gvt: clean up makefile
This is [1] rebased on gvt-next. (Which means it won't build on CI.) BR, Jani. [1] https://patchwork.freedesktop.org/series/102003/ Cc: Zhi Wang Cc: Christoph Hellwig Jani Nikula (2): drm/i915/gvt: fix trace TRACE_INCLUDE_PATH drm/i915/gvt: better align the Makefile with i915 Makefile drivers/gpu/drm/i915/Makefile | 6 +++--- drivers/gpu/drm/i915/gvt/Makefile | 30 +++--- drivers/gpu/drm/i915/gvt/trace.h | 2 +- 3 files changed, 27 insertions(+), 11 deletions(-) -- 2.30.2
