Re: [Intel-gfx] [PATCH 01/12] drm/i915: Unify VBT version number comments
On Tue, Jul 19, 2022 at 06:25:20AM -0400, Rodrigo Vivi wrote:
> On Fri, Jul 15, 2022 at 11:20:33PM +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > Use a more standard form for the VT version number comments.
> >
> > Signed-off-by: Ville Syrjälä
> > ---
> > drivers/gpu/drm/i915/display/intel_vbt_defs.h | 206 ++
> > 1 file changed, 110 insertions(+), 96 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> > b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> > index 509b0a419c20..ba328d130991 100644
> > --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> > +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> > @@ -75,6 +75,20 @@ struct bdb_header {
> > u16 bdb_size;
> > } __packed;
> >
> > +/*
> > + * BDB version number dependencies are documented as:
> > + *
> > + * +
> > + *indicates the field was introduced in version
> > + *and is still valid
> > + *
> > + * -
> > + *indicates the field was introduced in version
> > + *and obsoleted in version +1.
> > + *
> > + * ??? indicates the specific version number is unknown
> > + */
> > +
> > /*
> > * There are several types of BIOS data blocks (BDBs), each block has
> > * an ID and size in the first 3 bytes (ID in first, size in next 2).
> > @@ -144,12 +158,12 @@ struct bdb_general_features {
> > /* bits 3 */
> > u8 disable_smooth_vision:1;
> > u8 single_dvi:1;
> > - u8 rotate_180:1;/* 181 */
> > + u8 rotate_180:1;/* 181+ */
> > u8 fdi_rx_polarity_inverted:1;
> > - u8 vbios_extended_mode:1; /* 160 */
> > - u8 copy_ilfp_dtd_to_sdvo_lvds_dtd:1;/* 160 */
> > - u8 panel_best_fit_timing:1; /* 160 */
> > - u8 ignore_strap_state:1;/* 160 */
> > + u8 vbios_extended_mode:1; /* 160+ */
> > + u8 copy_ilfp_dtd_to_sdvo_lvds_dtd:1;/* 160+ */
> > + u8 panel_best_fit_timing:1; /* 160+ */
> > + u8 ignore_strap_state:1;/* 160+ */
> >
> > /* bits 4 */
> > u8 legacy_monitor_detect;
> > @@ -164,11 +178,11 @@ struct bdb_general_features {
> > u8 rsvd11:2; /* finish byte */
> >
> > /* bits 6 */
> > - u8 tc_hpd_retry_timeout:7; /* 242 */
> > + u8 tc_hpd_retry_timeout:7; /* 242+ */
> > u8 rsvd12:1;
> >
> > /* bits 7 */
> > - u8 afc_startup_config:2;/* 249 */
> > + u8 afc_startup_config:2;/* 249+ */
> > u8 rsvd13:6;
> > } __packed;
> >
> > @@ -275,27 +289,27 @@ struct bdb_general_features {
> > #define DVO_PORT_DPC 8
> > #define DVO_PORT_DPD 9
> > #define DVO_PORT_DPA 10
> > -#define DVO_PORT_DPE 11 /* 193
> > */
> > -#define DVO_PORT_HDMIE 12 /* 193
> > */
> > +#define DVO_PORT_DPE 11 /* 193+
> > */
> > +#define DVO_PORT_HDMIE 12 /* 193+
> > */
> > #define DVO_PORT_DPF 13 /* N/A
> > */
> > #define DVO_PORT_HDMIF 14 /* N/A
> > */
> > -#define DVO_PORT_DPG 15 /* 217
> > */
> > -#define DVO_PORT_HDMIG 16 /* 217
> > */
> > -#define DVO_PORT_DPH 17 /* 217
> > */
> > -#define DVO_PORT_HDMIH 18 /* 217
> > */
> > -#define DVO_PORT_DPI 19 /* 217
> > */
> > -#define DVO_PORT_HDMII 20 /* 217
> > */
> > -#define DVO_PORT_MIPIA 21 /* 171
> > */
> > -#define DVO_PORT_MIPIB 22 /* 171
> > */
> > -#define DVO_PORT_MIPIC 23 /* 171
> > */
> > -#define DVO_PORT_MIPID 24 /* 171
> > */
> > +#define DVO_PORT_DPG 15 /* 217+
> > */
> > +#define DVO_PORT_HDMIG 16 /* 217+
> > */
> > +#define DVO_PORT_DPH 17 /* 217+
> > */
> > +#define DVO_PORT_HDMIH 18 /* 217+
> > */
> > +#define DVO_PORT_DPI 19 /* 217+
> > */
> > +#define DVO_PORT_HDMII 20 /* 217+
> > */
> > +#define DVO_PORT_MIPIA 21 /* 171+
> > */
> > +#define DVO_PORT_MIPIB 22
Re: [Intel-gfx] [PATCH 01/12] drm/i915: Unify VBT version number comments
On Fri, Jul 15, 2022 at 11:20:33PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Use a more standard form for the VT version number comments.
>
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/display/intel_vbt_defs.h | 206 ++
> 1 file changed, 110 insertions(+), 96 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> index 509b0a419c20..ba328d130991 100644
> --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> @@ -75,6 +75,20 @@ struct bdb_header {
> u16 bdb_size;
> } __packed;
>
> +/*
> + * BDB version number dependencies are documented as:
> + *
> + * +
> + *indicates the field was introduced in version
> + *and is still valid
> + *
> + * -
> + *indicates the field was introduced in version
> + *and obsoleted in version +1.
> + *
> + * ??? indicates the specific version number is unknown
> + */
> +
> /*
> * There are several types of BIOS data blocks (BDBs), each block has
> * an ID and size in the first 3 bytes (ID in first, size in next 2).
> @@ -144,12 +158,12 @@ struct bdb_general_features {
> /* bits 3 */
> u8 disable_smooth_vision:1;
> u8 single_dvi:1;
> - u8 rotate_180:1;/* 181 */
> + u8 rotate_180:1;/* 181+ */
> u8 fdi_rx_polarity_inverted:1;
> - u8 vbios_extended_mode:1; /* 160 */
> - u8 copy_ilfp_dtd_to_sdvo_lvds_dtd:1;/* 160 */
> - u8 panel_best_fit_timing:1; /* 160 */
> - u8 ignore_strap_state:1;/* 160 */
> + u8 vbios_extended_mode:1; /* 160+ */
> + u8 copy_ilfp_dtd_to_sdvo_lvds_dtd:1;/* 160+ */
> + u8 panel_best_fit_timing:1; /* 160+ */
> + u8 ignore_strap_state:1;/* 160+ */
>
> /* bits 4 */
> u8 legacy_monitor_detect;
> @@ -164,11 +178,11 @@ struct bdb_general_features {
> u8 rsvd11:2; /* finish byte */
>
> /* bits 6 */
> - u8 tc_hpd_retry_timeout:7; /* 242 */
> + u8 tc_hpd_retry_timeout:7; /* 242+ */
> u8 rsvd12:1;
>
> /* bits 7 */
> - u8 afc_startup_config:2;/* 249 */
> + u8 afc_startup_config:2;/* 249+ */
> u8 rsvd13:6;
> } __packed;
>
> @@ -275,27 +289,27 @@ struct bdb_general_features {
> #define DVO_PORT_DPC 8
> #define DVO_PORT_DPD 9
> #define DVO_PORT_DPA 10
> -#define DVO_PORT_DPE 11 /* 193 */
> -#define DVO_PORT_HDMIE 12 /* 193
> */
> +#define DVO_PORT_DPE 11 /* 193+ */
> +#define DVO_PORT_HDMIE 12 /* 193+
> */
> #define DVO_PORT_DPF 13 /* N/A */
> #define DVO_PORT_HDMIF 14 /* N/A
> */
> -#define DVO_PORT_DPG 15 /* 217 */
> -#define DVO_PORT_HDMIG 16 /* 217
> */
> -#define DVO_PORT_DPH 17 /* 217 */
> -#define DVO_PORT_HDMIH 18 /* 217
> */
> -#define DVO_PORT_DPI 19 /* 217 */
> -#define DVO_PORT_HDMII 20 /* 217
> */
> -#define DVO_PORT_MIPIA 21 /* 171
> */
> -#define DVO_PORT_MIPIB 22 /* 171
> */
> -#define DVO_PORT_MIPIC 23 /* 171
> */
> -#define DVO_PORT_MIPID 24 /* 171
> */
> +#define DVO_PORT_DPG 15 /* 217+ */
> +#define DVO_PORT_HDMIG 16 /* 217+
> */
> +#define DVO_PORT_DPH 17 /* 217+ */
> +#define DVO_PORT_HDMIH 18 /* 217+
> */
> +#define DVO_PORT_DPI 19 /* 217+ */
> +#define DVO_PORT_HDMII 20 /* 217+
> */
> +#define DVO_PORT_MIPIA 21 /* 171+
> */
> +#define DVO_PORT_MIPIB 22 /* 171+
> */
> +#define DVO_PORT_MIPIC 23 /* 171+
> */
> +#define DVO_PORT_MIPID 24 /* 171+
> */
>
> -#define HDMI_MAX_DATA_RATE_PLATFORM 0 /* 204 */
> -#define HDMI_MAX_DATA_RATE_297 1
[Intel-gfx] [PATCH 01/12] drm/i915: Unify VBT version number comments
From: Ville Syrjälä
Use a more standard form for the VT version number comments.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_vbt_defs.h | 206 ++
1 file changed, 110 insertions(+), 96 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
index 509b0a419c20..ba328d130991 100644
--- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
+++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
@@ -75,6 +75,20 @@ struct bdb_header {
u16 bdb_size;
} __packed;
+/*
+ * BDB version number dependencies are documented as:
+ *
+ * +
+ *indicates the field was introduced in version
+ *and is still valid
+ *
+ * -
+ *indicates the field was introduced in version
+ *and obsoleted in version +1.
+ *
+ * ??? indicates the specific version number is unknown
+ */
+
/*
* There are several types of BIOS data blocks (BDBs), each block has
* an ID and size in the first 3 bytes (ID in first, size in next 2).
@@ -144,12 +158,12 @@ struct bdb_general_features {
/* bits 3 */
u8 disable_smooth_vision:1;
u8 single_dvi:1;
- u8 rotate_180:1;/* 181 */
+ u8 rotate_180:1;/* 181+ */
u8 fdi_rx_polarity_inverted:1;
- u8 vbios_extended_mode:1; /* 160 */
- u8 copy_ilfp_dtd_to_sdvo_lvds_dtd:1;/* 160 */
- u8 panel_best_fit_timing:1; /* 160 */
- u8 ignore_strap_state:1;/* 160 */
+ u8 vbios_extended_mode:1; /* 160+ */
+ u8 copy_ilfp_dtd_to_sdvo_lvds_dtd:1;/* 160+ */
+ u8 panel_best_fit_timing:1; /* 160+ */
+ u8 ignore_strap_state:1;/* 160+ */
/* bits 4 */
u8 legacy_monitor_detect;
@@ -164,11 +178,11 @@ struct bdb_general_features {
u8 rsvd11:2; /* finish byte */
/* bits 6 */
- u8 tc_hpd_retry_timeout:7; /* 242 */
+ u8 tc_hpd_retry_timeout:7; /* 242+ */
u8 rsvd12:1;
/* bits 7 */
- u8 afc_startup_config:2;/* 249 */
+ u8 afc_startup_config:2;/* 249+ */
u8 rsvd13:6;
} __packed;
@@ -275,27 +289,27 @@ struct bdb_general_features {
#define DVO_PORT_DPC 8
#define DVO_PORT_DPD 9
#define DVO_PORT_DPA 10
-#define DVO_PORT_DPE 11 /* 193 */
-#define DVO_PORT_HDMIE 12 /* 193 */
+#define DVO_PORT_DPE 11 /* 193+ */
+#define DVO_PORT_HDMIE 12 /* 193+ */
#define DVO_PORT_DPF 13 /* N/A */
#define DVO_PORT_HDMIF 14 /* N/A */
-#define DVO_PORT_DPG 15 /* 217 */
-#define DVO_PORT_HDMIG 16 /* 217 */
-#define DVO_PORT_DPH 17 /* 217 */
-#define DVO_PORT_HDMIH 18 /* 217 */
-#define DVO_PORT_DPI 19 /* 217 */
-#define DVO_PORT_HDMII 20 /* 217 */
-#define DVO_PORT_MIPIA 21 /* 171 */
-#define DVO_PORT_MIPIB 22 /* 171 */
-#define DVO_PORT_MIPIC 23 /* 171 */
-#define DVO_PORT_MIPID 24 /* 171 */
+#define DVO_PORT_DPG 15 /* 217+ */
+#define DVO_PORT_HDMIG 16 /* 217+ */
+#define DVO_PORT_DPH 17 /* 217+ */
+#define DVO_PORT_HDMIH 18 /* 217+ */
+#define DVO_PORT_DPI 19 /* 217+ */
+#define DVO_PORT_HDMII 20 /* 217+ */
+#define DVO_PORT_MIPIA 21 /* 171+ */
+#define DVO_PORT_MIPIB 22 /* 171+ */
+#define DVO_PORT_MIPIC 23 /* 171+ */
+#define DVO_PORT_MIPID 24 /* 171+ */
-#define HDMI_MAX_DATA_RATE_PLATFORM0 /* 204 */
-#define HDMI_MAX_DATA_RATE_297 1 /* 204 */
-#define HDMI_MAX_DATA_RATE_165 2 /* 204 */
-#define HDMI_MAX_DATA_RATE_594 3 /* 249 */
-#define HDMI_MAX_DATA_RATE_340 4 /* 249 */
-#define HDMI_MAX_DATA_RATE_300 5 /* 249 */
+#define
