Re: [Intel-gfx] [PATCH 02/17] dma-fence: remove fill_driver_data callback

2018-04-30 Thread Eric Anholt
Daniel Vetter  writes:

> Noticed while I was typing docs. Entirely unused.
>
> Signed-off-by: Daniel Vetter 
> ---
>  include/linux/dma-fence.h | 10 --
>  1 file changed, 10 deletions(-)
>
> diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h
> index 9d6f39bf2111..f9a6848f8558 100644
> --- a/include/linux/dma-fence.h
> +++ b/include/linux/dma-fence.h
> @@ -217,16 +217,6 @@ struct dma_fence_ops {
>*/
>   void (*release)(struct dma_fence *fence);
>  
> - /**
> -  * @fill_driver_data:
> -  *
> -  * Callback to fill in free-form debug info Returns amount of bytes
> -  * filled, or negative error on failure.
> -  *
> -  * This callback is optional.
> -  */
> - int (*fill_driver_data)(struct dma_fence *fence, void *data, int size);
> -

There's a reference to this one from timeline_value_str() as well.
Could you fix that up?


signature.asc
Description: PGP signature
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] [PATCH 02/17] dma-fence: remove fill_driver_data callback

2018-04-27 Thread Daniel Vetter
Noticed while I was typing docs. Entirely unused.

Signed-off-by: Daniel Vetter 
---
 include/linux/dma-fence.h | 10 --
 1 file changed, 10 deletions(-)

diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h
index 9d6f39bf2111..f9a6848f8558 100644
--- a/include/linux/dma-fence.h
+++ b/include/linux/dma-fence.h
@@ -217,16 +217,6 @@ struct dma_fence_ops {
 */
void (*release)(struct dma_fence *fence);
 
-   /**
-* @fill_driver_data:
-*
-* Callback to fill in free-form debug info Returns amount of bytes
-* filled, or negative error on failure.
-*
-* This callback is optional.
-*/
-   int (*fill_driver_data)(struct dma_fence *fence, void *data, int size);
-
/**
 * @fence_value_str:
 *
-- 
2.17.0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx