Re: [Intel-gfx] [PATCH 03/12] drm/i915: Properly define the DP redriver VBT bits

[Jani Nikula]

On Fri, 15 Jul 2022, Ville Syrjala  wrote:
> From: Ville Syrjälä 
>
> Split the DP redriver bytes into bitfields.
>
> Signed-off-by: Ville Syrjälä 

Reviewed-by: Jani Nikula 

> ---
>  drivers/gpu/drm/i915/display/intel_vbt_defs.h | 16 +++-
>  1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h 
> b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> index e997b8bcc6b8..a88c5ef51cd8 100644
> --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> @@ -393,8 +393,14 @@ struct child_device_config {
>   u8  device_id[10]; /* ascii string */
>   struct {
>   u8 i2c_speed;
> - u8 dp_onboard_redriver; /* 158+ */
> - u8 dp_ondock_redriver;  /* 158+ */
> + u8 dp_onboard_redriver_preemph:3;   /* 158+ */
> + u8 dp_onboard_redriver_vswing:3;/* 158+ */
> + u8 dp_onboard_redriver_present:1;   /* 158+ */
> + u8 reserved0:1;
> + u8 dp_ondock_redriver_preemph:3;/* 158+ */
> + u8 dp_ondock_redriver_vswing:3; /* 158+ */
> + u8 dp_ondock_redriver_present:1;/* 158+ */
> + u8 reserved1:1;
>   u8 hdmi_level_shifter_value:5;  /* 158+ */
>   u8 hdmi_max_data_rate:3;/* 204+ */
>   u16 dtd_buf_ptr;/* 161+ */
> @@ -402,11 +408,11 @@ struct child_device_config {
>   u8 compression_enable:1;/* 198+ */
>   u8 compression_method_cps:1;/* 198+ */
>   u8 ganged_edp:1;/* 202+ */
> - u8 reserved0:4;
> + u8 reserved2:4;
>   u8 compression_structure_index:4;   /* 198+ */
> - u8 reserved1:4;
> + u8 reserved3:4;
>   u8 slave_port;  /* 202+ */
> - u8 reserved2;
> + u8 reserved4;
>   } __packed;
>   } __packed;

-- 
Jani Nikula, Intel Open Source Graphics Center

[Intel-gfx] [PATCH 03/12] drm/i915: Properly define the DP redriver VBT bits

[Ville Syrjala]

From: Ville Syrjälä 

Split the DP redriver bytes into bitfields.

Signed-off-by: Ville Syrjälä 
---
 drivers/gpu/drm/i915/display/intel_vbt_defs.h | 16 +++-
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h 
b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
index e997b8bcc6b8..a88c5ef51cd8 100644
--- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
+++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
@@ -393,8 +393,14 @@ struct child_device_config {
u8  device_id[10]; /* ascii string */
struct {
u8 i2c_speed;
-   u8 dp_onboard_redriver; /* 158+ */
-   u8 dp_ondock_redriver;  /* 158+ */
+   u8 dp_onboard_redriver_preemph:3;   /* 158+ */
+   u8 dp_onboard_redriver_vswing:3;/* 158+ */
+   u8 dp_onboard_redriver_present:1;   /* 158+ */
+   u8 reserved0:1;
+   u8 dp_ondock_redriver_preemph:3;/* 158+ */
+   u8 dp_ondock_redriver_vswing:3; /* 158+ */
+   u8 dp_ondock_redriver_present:1;/* 158+ */
+   u8 reserved1:1;
u8 hdmi_level_shifter_value:5;  /* 158+ */
u8 hdmi_max_data_rate:3;/* 204+ */
u16 dtd_buf_ptr;/* 161+ */
@@ -402,11 +408,11 @@ struct child_device_config {
u8 compression_enable:1;/* 198+ */
u8 compression_method_cps:1;/* 198+ */
u8 ganged_edp:1;/* 202+ */
-   u8 reserved0:4;
+   u8 reserved2:4;
u8 compression_structure_index:4;   /* 198+ */
-   u8 reserved1:4;
+   u8 reserved3:4;
u8 slave_port;  /* 202+ */
-   u8 reserved2;
+   u8 reserved4;
} __packed;
} __packed;
 
-- 
2.35.1