Re: [Intel-gfx] [PATCH 03/13] drm/i915: Remove pointless dpll_funcs checks

[Jani Nikula]

On Fri, 25 Mar 2022, Ville Syrjala  wrote:
> From: Ville Syrjälä 
>
> All platforms have dpll_funcs. Remove the pointless NULL checks.
>
> Signed-off-by: Ville Syrjälä 

Reviewed-by: Jani Nikula 

> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 4 
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c 
> b/drivers/gpu/drm/i915/display/intel_display.c
> index 986e2e67ef91..57d9b065622f 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -7053,14 +7053,10 @@ intel_crtc_update_active_timings(const struct 
> intel_crtc_state *crtc_state)
>  
>  static void intel_modeset_clear_plls(struct intel_atomic_state *state)
>  {
> - struct drm_i915_private *dev_priv = to_i915(state->base.dev);
>   struct intel_crtc_state *new_crtc_state;
>   struct intel_crtc *crtc;
>   int i;
>  
> - if (!dev_priv->dpll_funcs)
> - return;
> -
>   for_each_new_intel_crtc_in_state(state, crtc, new_crtc_state, i) {
>   if (!intel_crtc_needs_modeset(new_crtc_state))
>   continue;

-- 
Jani Nikula, Intel Open Source Graphics Center

[Intel-gfx] [PATCH 03/13] drm/i915: Remove pointless dpll_funcs checks

[Ville Syrjala]

From: Ville Syrjälä 

All platforms have dpll_funcs. Remove the pointless NULL checks.

Signed-off-by: Ville Syrjälä 
---
 drivers/gpu/drm/i915/display/intel_display.c | 4 
 1 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c 
b/drivers/gpu/drm/i915/display/intel_display.c
index 986e2e67ef91..57d9b065622f 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -7053,14 +7053,10 @@ intel_crtc_update_active_timings(const struct 
intel_crtc_state *crtc_state)
 
 static void intel_modeset_clear_plls(struct intel_atomic_state *state)
 {
-   struct drm_i915_private *dev_priv = to_i915(state->base.dev);
struct intel_crtc_state *new_crtc_state;
struct intel_crtc *crtc;
int i;
 
-   if (!dev_priv->dpll_funcs)
-   return;
-
for_each_new_intel_crtc_in_state(state, crtc, new_crtc_state, i) {
if (!intel_crtc_needs_modeset(new_crtc_state))
continue;
-- 
2.34.1