Re: [Intel-gfx] [PATCH 06/31] drm/i915: Name i915_runtime_pm structure in dev_priv as "rpm"

2017-09-20 Thread Szwichtenberg, Radoslaw
On Tue, 2017-09-19 at 23:11 +0530, Sagar Arun Kamble wrote:
> Will be using pm for state containing RPS/RC6 state in the next patch.
> 
> Cc: Imre Deak 
> Cc: Chris Wilson 
> Signed-off-by: Sagar Arun Kamble 
Reviewed-by: Radoslaw Szwichtenberg 
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] [PATCH 06/31] drm/i915: Name i915_runtime_pm structure in dev_priv as "rpm"

2017-09-19 Thread Sagar Arun Kamble
Will be using pm for state containing RPS/RC6 state in the next patch.

Cc: Imre Deak 
Cc: Chris Wilson 
Signed-off-by: Sagar Arun Kamble 
---
 drivers/gpu/drm/i915/i915_drv.c |  8 
 drivers/gpu/drm/i915/i915_drv.h |  2 +-
 drivers/gpu/drm/i915/i915_gpu_error.c   |  4 ++--
 drivers/gpu/drm/i915/i915_irq.c |  8 
 drivers/gpu/drm/i915/intel_drv.h| 10 +-
 drivers/gpu/drm/i915/intel_pm.c |  4 ++--
 drivers/gpu/drm/i915/intel_runtime_pm.c | 10 +-
 7 files changed, 23 insertions(+), 23 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index ec0e770..d155316 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -2533,12 +2533,12 @@ static int intel_runtime_suspend(struct device *kdev)
intel_uncore_suspend(dev_priv);
 
enable_rpm_wakeref_asserts(dev_priv);
-   WARN_ON_ONCE(atomic_read(&dev_priv->pm.wakeref_count));
+   WARN_ON_ONCE(atomic_read(&dev_priv->rpm.wakeref_count));
 
if (intel_uncore_arm_unclaimed_mmio_detection(dev_priv))
DRM_ERROR("Unclaimed access detected prior to suspending\n");
 
-   dev_priv->pm.suspended = true;
+   dev_priv->rpm.suspended = true;
 
/*
 * FIXME: We really should find a document that references the arguments
@@ -2584,11 +2584,11 @@ static int intel_runtime_resume(struct device *kdev)
 
DRM_DEBUG_KMS("Resuming device\n");
 
-   WARN_ON_ONCE(atomic_read(&dev_priv->pm.wakeref_count));
+   WARN_ON_ONCE(atomic_read(&dev_priv->rpm.wakeref_count));
disable_rpm_wakeref_asserts(dev_priv);
 
intel_opregion_notify_adapter(dev_priv, PCI_D0);
-   dev_priv->pm.suspended = false;
+   dev_priv->rpm.suspended = false;
if (intel_uncore_unclaimed_mmio(dev_priv))
DRM_DEBUG_DRIVER("Unclaimed access during suspend, bios?\n");
 
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 4d5ffde..49dfc3d 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -2512,7 +2512,7 @@ struct drm_i915_private {
bool distrust_bios_wm;
} wm;
 
-   struct i915_runtime_pm pm;
+   struct i915_runtime_pm rpm;
 
struct {
bool initialized;
diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c 
b/drivers/gpu/drm/i915/i915_gpu_error.c
index 0c77967..23e9abf 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -1665,8 +1665,8 @@ static void i915_capture_gen_state(struct 
drm_i915_private *dev_priv,
   struct i915_gpu_state *error)
 {
error->awake = dev_priv->gt.awake;
-   error->wakelock = atomic_read(&dev_priv->pm.wakeref_count);
-   error->suspended = dev_priv->pm.suspended;
+   error->wakelock = atomic_read(&dev_priv->rpm.wakeref_count);
+   error->suspended = dev_priv->rpm.suspended;
 
error->iommu = -1;
 #ifdef CONFIG_INTEL_IOMMU
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 4d0e8f7..e44d894 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -4118,7 +4118,7 @@ int intel_irq_install(struct drm_i915_private *dev_priv)
 * interrupts as enabled _before_ actually enabling them to avoid
 * special cases in our ordering checks.
 */
-   dev_priv->pm.irqs_enabled = true;
+   dev_priv->rpm.irqs_enabled = true;
 
return drm_irq_install(&dev_priv->drm, dev_priv->drm.pdev->irq);
 }
@@ -4134,7 +4134,7 @@ void intel_irq_uninstall(struct drm_i915_private 
*dev_priv)
 {
drm_irq_uninstall(&dev_priv->drm);
intel_hpd_cancel_work(dev_priv);
-   dev_priv->pm.irqs_enabled = false;
+   dev_priv->rpm.irqs_enabled = false;
 }
 
 /**
@@ -4147,7 +4147,7 @@ void intel_irq_uninstall(struct drm_i915_private 
*dev_priv)
 void intel_runtime_pm_disable_interrupts(struct drm_i915_private *dev_priv)
 {
dev_priv->drm.driver->irq_uninstall(&dev_priv->drm);
-   dev_priv->pm.irqs_enabled = false;
+   dev_priv->rpm.irqs_enabled = false;
synchronize_irq(dev_priv->drm.irq);
 }
 
@@ -4160,7 +4160,7 @@ void intel_runtime_pm_disable_interrupts(struct 
drm_i915_private *dev_priv)
  */
 void intel_runtime_pm_enable_interrupts(struct drm_i915_private *dev_priv)
 {
-   dev_priv->pm.irqs_enabled = true;
+   dev_priv->rpm.irqs_enabled = true;
dev_priv->drm.driver->irq_preinstall(&dev_priv->drm);
dev_priv->drm.driver->irq_postinstall(&dev_priv->drm);
 }
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index 3078076..76ef34b 100644
--- a/drivers/gpu/drm/i915/intel_drv.h
+++ b/drivers/gpu/drm/i915/intel_drv.h
@@ -1252,7 +1252,7 @@ static inline bool intel_irqs_enabled(struct 
drm_i915_private *dev_priv)
 * We only use drm_irq_uninstall() at unload and VT swit