Re: [Intel-gfx] [PATCH 08/11] drm/i915/perf: add more debug message on open perf open & configs

[Matthew Auld]

On 26 March 2018 at 10:08, Lionel Landwerlin
 wrote:
> This will make it easier to spot issues related to config
> creation/usage.
>
> Signed-off-by: Lionel Landwerlin 

s/open perf open/perf open/ ?

Reviewed-by: Matthew Auld 
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 08/11] drm/i915/perf: add more debug message on open perf open & configs

[Lionel Landwerlin]

This will make it easier to spot issues related to config
creation/usage.

Signed-off-by: Lionel Landwerlin 
---
 drivers/gpu/drm/i915/i915_perf.c | 17 ++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
index 2bad0bf66d89..c91ad447207e 100644
--- a/drivers/gpu/drm/i915/i915_perf.c
+++ b/drivers/gpu/drm/i915/i915_perf.c
@@ -2102,13 +2102,17 @@ static int i915_oa_stream_init(struct i915_perf_stream 
*stream,
 
if (stream->ctx) {
ret = oa_get_render_ctx_id(stream);
-   if (ret)
+   if (ret) {
+   DRM_DEBUG("Invalid context id to filter with\n");
return ret;
+   }
}
 
ret = get_oa_config(dev_priv, props->metrics_set, >oa_config);
-   if (ret)
+   if (ret) {
+   DRM_DEBUG("Invalid OA config id=%i\n", props->metrics_set);
goto err_config;
+   }
 
/* PRM - observability performance counters:
 *
@@ -2134,8 +2138,10 @@ static int i915_oa_stream_init(struct i915_perf_stream 
*stream,
goto err_lock;
 
ret = dev_priv->perf.oa.ops.enable_metric_set(dev_priv, stream);
-   if (ret)
+   if (ret) {
+   DRM_DEBUG("Unable to enable metric set\n");
goto err_enable;
+   }
 
stream->ops = _oa_stream_ops;
 
@@ -3295,6 +3301,8 @@ int i915_perf_add_config_ioctl(struct drm_device *dev, 
void *data,
 
mutex_unlock(_priv->perf.metrics_lock);
 
+   DRM_DEBUG("Added config %s id=%i\n", oa_config->uuid, oa_config->id);
+
return oa_config->id;
 
 sysfs_err:
@@ -3351,6 +3359,9 @@ int i915_perf_remove_config_ioctl(struct drm_device *dev, 
void *data,
   _config->sysfs_metric);
 
idr_remove(_priv->perf.metrics_idr, *arg);
+
+   DRM_DEBUG("Removed config %s id=%i\n", oa_config->uuid, oa_config->id);
+
put_oa_config(dev_priv, oa_config);
 
 config_err:
-- 
2.16.3

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx